Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Remove unused function xlate_out_copy().

Acked-by: Alex Wang On Thu, Jul 23, 2015 at 4:18 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c | 17 - > ofproto/ofproto-dpif-xlate.h | 1 - > 2 files changed, 18 deletions(-) > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofpro

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Indentation fix.

On 23 July 2015 at 16:19, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Fix typo in comment.

On 23 July 2015 at 16:19, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] netdev-linux: Make netdev_linux_get_in6() conform to API definition.

The get_in6() API defined in netdev-provider.h requires the return of error values when the 'netdev' has no assigned IPv6 address or the 'netdev' does not support IPv6. However, the netdev_linux_get_in6() implementation does not follow this (always return 0). And this causes the a bug in deleting

Re: [ovs-dev] [PATCH] netdev-linux: Refine function comments of netdev_linux_get_in6().

On Thu, Jul 23, 2015 at 4:31 PM, Ben Pfaff wrote: > On Thu, Jul 23, 2015 at 04:30:12PM -0700, Alex Wang wrote: > > This commit refines the comments of function netdev_linux_get_in6() > > to correctly describe its behavior. > > > > Signed-off-by: Alex Wang > > It always returns 0, not 'true'. > >

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Restore txq/rxq number if initialization fails.

Summary of issue: I ran the following commands: 276 ovs-vswitchd --dpdk -c 0x1 -n 4 -- unix:$DB_SOCK --pidfile --detach --log-file 277 ovs-vsctl add-br br0 -- set bridge br0 datapath_type=netdev 278 ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk This is what the log file

[ovs-dev] (no subject)

Haben Sie geschäftliche oder persönliche Darlehen benötigen? Brauchen Sie Darlehen, um Ihr Unternehmen zu refinanzieren? Wir geben Darlehen an jeden einzelnen und Unternehmen bei 4% Zinsen jährlich. Für weitere Informationen, kontaktieren Sie uns per E-Mail: perfectcredit...@gmail.com

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Restore txq/rxq number if initialization fails.

Will do. Luis E. P. Sent from my iPhone > On Jul 23, 2015, at 16:31, Ethan Jackson wrote: > > Would you please summarize the errors on list? Daniele should > probably have a look at it since he wrote the patch originally. > > Ethan > >> On Thu, Jul 23, 2015 at 4:27 PM, Luis E Pena wrote:

Re: [ovs-dev] [PATCH] netdev-linux: Refine function comments of netdev_linux_get_in6().

On Thu, Jul 23, 2015 at 04:30:12PM -0700, Alex Wang wrote: > This commit refines the comments of function netdev_linux_get_in6() > to correctly describe its behavior. > > Signed-off-by: Alex Wang It always returns 0, not 'true'. But should it return EADDRNOTAVAIL if none is found? And EOPNOTSU

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Restore txq/rxq number if initialization fails.

Would you please summarize the errors on list? Daniele should probably have a look at it since he wrote the patch originally. Ethan On Thu, Jul 23, 2015 at 4:27 PM, Luis E Pena wrote: > I ran into errors when using master when adding a dpdk port. I worked with > Pravin yesterday and we think t

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Restore txq/rxq number if initialization fails.

I ran into errors when using master when adding a dpdk port. I worked with Pravin yesterday and we think that the cause is this patch. When we tried branch-2.4, we ran into no errors. Today I am working on confirming that this is the patch. Luis E. P. Sent from my iPhone > On Jul 23, 2015, at

[ovs-dev] [PATCH] netdev-linux: Refine function comments of netdev_linux_get_in6().

This commit refines the comments of function netdev_linux_get_in6() to correctly describe its behavior. Signed-off-by: Alex Wang --- lib/netdev-linux.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 18a1399..913a532 10064

[ovs-dev] [PATCH] tunnel: Drop 'base_flow' parameter from tnl_xlate_init().

At the point when tnl_xlate_init() is called, all of the members that tnl_xlate_init() examines in 'base_flow' have the same values in 'flow', so there's no point in passing both. CC: Jesse Gross Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-xlate.c | 2 +- ofproto/tunnel.c | 1

[ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Indentation fix.

Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-upcall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index b65ead6..8a27059 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c @@ -69

[ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Fix typo in comment.

Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-upcall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 8a27059..440f9e9 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c @@ -17

[ovs-dev] [PATCH] ofproto-dpif-xlate: Remove unused function xlate_out_copy().

Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-xlate.c | 17 - ofproto/ofproto-dpif-xlate.h | 1 - 2 files changed, 18 deletions(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index ed5c824..a9d98ee 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/

Re: [ovs-dev] [PATCH] netflow: Mark some function parameters 'const'.

Thanks, applied to master. On Wed, Jul 22, 2015 at 12:55:51PM -0700, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > > On Jul 22, 2015, at 12:17 PM, Ben Pfaff wrote: > > > > Signed-off-by: Ben Pfaff > > --- > > ofproto/netflow.c | 7 --- > > ofproto/netflow.h | 6 +++--- > > 2 files

[ovs-dev] [PATCH] ofproto-dpif-xlate: Fix handling of write_actions(group(5), output(10)).

Without the fix added by this commit, the test case as updated by this commit fails. Found by inspection. Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-xlate.c | 1 + tests/ofproto-dpif.at| 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif-

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Restore txq/rxq number if initialization fails.

Ben, Justin, should this be backported? I'm not up on the policy at the moment. Etha On Thu, Jul 23, 2015 at 3:42 AM, Traynor, Kevin wrote: > >> -Original Message- >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di >> Proietto >> Sent: Thursday, July 16, 2015 7:48

Re: [ovs-dev] recirculation in_port in ofproto-dpif-xlate

> On Jul 23, 2015, at 2:39 PM, Ben Pfaff wrote: > > On Thu, Jul 23, 2015 at 02:36:56PM -0700, Jarno Rajahalme wrote: >> Something bugged me about this, so I looked again. >> >>> On Jul 23, 2015, at 1:23 PM, Ben Pfaff wrote: >>> >>> Since commit e672ff9b4d2 (ofproto-dpif: Restore metadata and

Re: [ovs-dev] recirculation in_port in ofproto-dpif-xlate

On Thu, Jul 23, 2015 at 02:36:56PM -0700, Jarno Rajahalme wrote: > Something bugged me about this, so I looked again. > > > On Jul 23, 2015, at 1:23 PM, Ben Pfaff wrote: > > > > Since commit e672ff9b4d2 (ofproto-dpif: Restore metadata and registers > > on recirculation.), xlate_actions() has fir

Re: [ovs-dev] recirculation in_port in ofproto-dpif-xlate

Something bugged me about this, so I looked again. > On Jul 23, 2015, at 1:23 PM, Ben Pfaff wrote: > > Since commit e672ff9b4d2 (ofproto-dpif: Restore metadata and registers > on recirculation.), xlate_actions() has first obtained the input port: > >/* The in_port of the original packet bef

Re: [ovs-dev] [PATCH net-next] openvswitch: Retrieve tunnel metadata when receiving from vport-netdev

On Thu, Jul 23, 2015 at 4:04 AM, Thomas Graf wrote: > Retrieve the tunnel metadata for packets received by a net_device and > provide it to ovs_vport_receive() for flow key extraction. > > [This hunk was in the GRE patch in the initial series and missed the > cut for the initial submission for me

Re: [ovs-dev] recirculation in_port in ofproto-dpif-xlate

> On Jul 23, 2015, at 1:23 PM, Ben Pfaff wrote: > > Since commit e672ff9b4d2 (ofproto-dpif: Restore metadata and registers > on recirculation.), xlate_actions() has first obtained the input port: > >/* The in_port of the original packet before recirculation. */ >struct xport *in_port =

Re: [ovs-dev] [PATCH 1/2] db-ctl-base: remove the recurse member from struct cmd_show_table

On Tue, Jul 21, 2015 at 11:41 AM, Ben Pfaff wrote: > On Fri, Jul 17, 2015 at 05:12:44PM -0700, Andy Zhou wrote: >> The 'recurse' is used during run time to suppress duplicated prints. >> It is not essential to describe how show command should work. >> >> This patch remove the 'recurse' member. Dup

Re: [ovs-dev] [PATCH 2/2] db-ctl-base: make cmd_show_table private

On Tue, Jul 21, 2015 at 11:43 AM, Ben Pfaff wrote: > On Fri, Jul 17, 2015 at 05:12:45PM -0700, Andy Zhou wrote: >> Instead of requiring user to declare a global variable, pass the value >> via ctl_init(). >> >> Signed-off-by: Andy Zhou > > I think that cmd_show_tables should be 'static'. Absolute

[ovs-dev] recirculation in_port in ofproto-dpif-xlate

Since commit e672ff9b4d2 (ofproto-dpif: Restore metadata and registers on recirculation.), xlate_actions() has first obtained the input port: /* The in_port of the original packet before recirculation. */ struct xport *in_port = get_ofp_port(xbridge, flow->in_port.ofp_port); then updated

Re: [ovs-dev] [PATCH V3 1/1] Fix detection of vhost_cuse in dpdk rte_config.h

> -Original Message- > From: Ben Pfaff [mailto:b...@nicira.com] > Sent: Thursday, July 23, 2015 14:36 > To: Mussar, Gary > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH V3 1/1] Fix detection of vhost_cuse in dpdk > rte_config.h > > On Thu, Jul 23, 2015 at 01:48:53PM -0400, Gary

Re: [ovs-dev] [PATCH V3 1/1] Fix detection of vhost_cuse in dpdk rte_config.h

On Thu, Jul 23, 2015 at 01:48:53PM -0400, Gary Mussar wrote: > Dpdk allows users to create a config that includes other config files and > then override values. > > Eg. > defconfig_x86_64-native_vhost_cuse-linuxapp-gcc: > > CONFIG_RTE_BUILD_COMBINE_LIBS=y > CONFIG_RTE_BUILD_SHARED_LIB=n > CONFIG_

[ovs-dev] [PATCH V3 1/1] Fix detection of vhost_cuse in dpdk rte_config.h

Dpdk allows users to create a config that includes other config files and then override values. Eg. defconfig_x86_64-native_vhost_cuse-linuxapp-gcc: CONFIG_RTE_BUILD_COMBINE_LIBS=y CONFIG_RTE_BUILD_SHARED_LIB=n CONFIG_RTE_LIBRTE_VHOST=y CONFIG_RTE_LIBRTE_VHOST_USER=n This allows you to have both

[ovs-dev] [PATCH V3 0/1] Fix detection of vhost_cuse in dpdk rte_config.h

Changes from V2: 1) Use AC_COMPILE_IFELSE rather than the less conventional AC_EGREP_CPP Gary Mussar (1): Fix detection of vhost_cuse in dpdk rte_config.h acinclude.m4 | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) -- 1.9.1 ___ dev mai

Re: [ovs-dev] FW: [PATCH V2 1/1] Fix detection of vhost_cuse in dpdk rte_config.h

On Thu, Jul 23, 2015 at 12:15:29PM -0400, Mussar, Gary wrote: > > > > -Original Message- > > From: Ben Pfaff [mailto:b...@nicira.com] > > Sent: Thursday, July 23, 2015 11:47 > > To: Mussar, Gary > > Cc: dev@openvswitch.org > > Subject: Re: [ovs-dev] FW: [PATCH V2 1/1] Fix detection of vho

Re: [ovs-dev] FW: [PATCH V2 1/1] Fix detection of vhost_cuse in dpdk rte_config.h

> -Original Message- > From: Ben Pfaff [mailto:b...@nicira.com] > Sent: Thursday, July 23, 2015 11:47 > To: Mussar, Gary > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] FW: [PATCH V2 1/1] Fix detection of vhost_cuse in > dpdk rte_config.h > > On Thu, Jul 23, 2015 at 11:09:32AM -0400,

Re: [ovs-dev] FW: [PATCH V2 1/1] Fix detection of vhost_cuse in dpdk rte_config.h

On Thu, Jul 23, 2015 at 11:09:32AM -0400, Mussar, Gary wrote: > Dpdk allows users to create a config that includes other config files and > then override values. > > Eg. > defconfig_x86_64-native_vhost_cuse-linuxapp-gcc: > > CONFIG_RTE_BUILD_COMBINE_LIBS=y > CONFIG_RTE_BUILD_SHARED_LIB=n > CONFIG

[ovs-dev] FW: [PATCH V2 1/1] Fix detection of vhost_cuse in dpdk rte_config.h

Dpdk allows users to create a config that includes other config files and then override values. Eg. defconfig_x86_64-native_vhost_cuse-linuxapp-gcc: CONFIG_RTE_BUILD_COMBINE_LIBS=y CONFIG_RTE_BUILD_SHARED_LIB=n CONFIG_RTE_LIBRTE_VHOST=y CONFIG_RTE_LIBRTE_VHOST_USER=n This allows you to have both

[ovs-dev] FW: [PATCH V2 0/1] Fix detection of vhost_cuse in dpdk rte_config.h

Differences from the V1 patch: 1) Remove the AC_LANG_PUSH/AC_LAN_POP calls. 2) Rebase to master and include the conditional -lfuse changes. Gary Mussar (1): Fix detection of vhost_cuse in dpdk rte_config.h acinclude.m4 | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) -- 1.9.1 _

[ovs-dev] [PATCH V2 1/1] Fix detection of vhost_cuse in dpdk rte_config.h

Dpdk allows users to create a config that includes other config files and then override values. Eg. defconfig_x86_64-native_vhost_cuse-linuxapp-gcc: CONFIG_RTE_BUILD_COMBINE_LIBS=y CONFIG_RTE_BUILD_SHARED_LIB=n CONFIG_RTE_LIBRTE_VHOST=y CONFIG_RTE_LIBRTE_VHOST_USER=n This allows you to have both

[ovs-dev] [PATCH V2 0/1] Fix detection of vhost_cuse in dpdk rte_config.h

Differences from the V1 patch: 1) Remove the AC_LANG_PUSH/AC_LAN_POP calls. 2) Rebase to master and include the conditional -lfuse changes. Gary Mussar (1): Fix detection of vhost_cuse in dpdk rte_config.h acinclude.m4 | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) -- 1.9.1 _

Re: [ovs-dev] intra VM communication

> > Yea you are right , it is during the vswitch init it is reaching there , that > time > there was no VM running . But once I start the VMs I don't see ovs trying to > de queue at all . (Ovs just stops to dequeue after few attempts of failure) > > Is it expected behavior ? If you have the same

Re: [ovs-dev] intra VM communication

Yea you are right , it is during the vswitch init it is reaching there , that time there was no VM running . But once I start the VMs I don't see ovs trying to de queue at all . (Ovs just stops to dequeue after few attempts of failure) Is it expected behavior ? /srikanth On Thursday, July 23, 2

[ovs-dev] [PATCH v1 2/2] ofproto: Implement OF1.4 Group & Meter change notification messages

From: Niti Rohilla This patch adds support for Openflow1.4 Group & meter change notification messages. In a multi controller environment, when a controller modifies the state of group and meter table, the request that successfully modifies this state is forwarded to other controllers. Other contr

[ovs-dev] [PATCH v4 1/2] ofproto: Implement OF1.4 Set/Get asynchronous configuration messages.

From: Niti Rohilla This patch adds support for Openflow1.4 set/get asynchronous configuration messages. OpenVSwitch already supports set/get asynchronous configuration messages for Openflow1.3. In this patch OFPT_SET_ASYNC_CONFIG message allows the controllers to set the configuration for OFPT_RO

[ovs-dev] [PATCH v1 0/2] OF1.4 Group and Meter change notification (EXT-235)

Hi Ben, This series of patches contains implementation of OF1.4 Group and Meter change notification (EXT-235). 1. [PATCH v4 1/2] : ofproto: Implement OF1.4 Set/Get asynchronous configuration messages. v3 of this patch has already been sent on July 16,2015. v3->v4 Rebased with the lat

[ovs-dev] [PATCH v1 0/3] OF1.4 Group and Meter change notification (EXT-235)

Hi Ben, This series of patches contains implementation of OF1.4 Group and Meter change notification (EXT-235). 1. [PATCH v4 1/2] : ofproto: Implement OF1.4 Set/Get asynchronous configuration messages. v3 of this patch has already been sent on July 16,2015. v3->v4 Rebased with the lat

[ovs-dev] [PATCH net-next] openvswitch: Retrieve tunnel metadata when receiving from vport-netdev

Retrieve the tunnel metadata for packets received by a net_device and provide it to ovs_vport_receive() for flow key extraction. [This hunk was in the GRE patch in the initial series and missed the cut for the initial submission for merging.] Fixes: 614732eaa12d ("openvswitch: Use regular VXLAN

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Restore txq/rxq number if initialization fails.

> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di > Proietto > Sent: Thursday, July 16, 2015 7:48 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 1/2] netdev-dpdk: Restore txq/rxq number if > initialization fails. > > netdev_dpdk_set_mu

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup until we don't get any failure.

> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di > Proietto > Sent: Thursday, July 16, 2015 7:48 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup until we > don't get any failure. > > It has bee

Re: [ovs-dev] [PATCH net-next] openvswitch: fix compilation when vxlan is a module

On 07/23/15 at 11:29am, Nicolas Dichtel wrote: > With CONFIG_VXLAN=m and CONFIG_OPENVSWITCH=y, there was the following > compilation error: > LD init/built-in.o > net/built-in.o: In function `vxlan_tnl_create': > .../net/openvswitch/vport-netdev.c:322: undefined reference to > `vxlan_de

[ovs-dev] [PATCH net-next] openvswitch: fix compilation when vxlan is a module

With CONFIG_VXLAN=m and CONFIG_OPENVSWITCH=y, there was the following compilation error: LD init/built-in.o net/built-in.o: In function `vxlan_tnl_create': .../net/openvswitch/vport-netdev.c:322: undefined reference to `vxlan_dev_create' make: *** [vmlinux] Error 1 CC: Thomas Graf F

Re: [ovs-dev] intra VM communication

> > Hi Ciara , > When i further try to debug the issue , i could see that > >     if (OVS_UNLIKELY(!is_vhost_running(virtio_dev))) { >     return EAGAIN; > <<< it always returns from here >     } > >> I believe that dequeue has to be called to get the packets from > Guest