[ovs-dev] Can we trivially enable group chaining?

2015-06-02 Thread Ben Pfaff
We have the following comment in ofproto-dpif-xlate.c: /* Prevent nested translation of OpenFlow groups. * * OpenFlow allows this restriction. We enforce this restriction only * because, with the current architecture, we would otherwise have to * take a

Re: [ovs-dev] [PATCH] Update my email address

2015-06-02 Thread Takashi Yamamoto
Justin, Miguel, thank you! applied to master, branch-2.3, 2.2, and 2.1. On Tue, Jun 2, 2015 at 5:12 PM, Miguel Ángel Ajo wrote: > Congratulations :) > > Midokura did something very smart ;) > > Miguel Ángel Ajo > > On Tuesday, 2 de June de 2015 at 8:03, Justin Pettit wrote: > > Congratulations o

Re: [ovs-dev] [PATCH] lib/util.c: style fixes

2015-06-02 Thread Andy Zhou
On Mon, Jun 1, 2015 at 8:13 PM, Jesse Gross wrote: > On Mon, Jun 1, 2015 at 7:08 PM, Andy Zhou wrote: >> Covert tabs into spaces. Found by inspection. >> >> Signed-off-by: Andy Zhou > > Acked-by: Jesse Gross Thanks, pushed. ___ dev mailing list dev@o

Re: [ovs-dev] [PATCH v2 15/19] ofproto: Add support for reverting flow mods, and bundle commit.

2015-06-02 Thread Jarno Rajahalme
> On Jun 2, 2015, at 10:59 AM, Ben Pfaff wrote: > > On Mon, Jun 01, 2015 at 06:17:48PM -0700, Jarno Rajahalme wrote: >> Applied to master with the following incremental based on the above, > > Great, I'm happy to see this. I’ll work on a v3 for the rest of the series, no need to review v2 furt

Re: [ovs-dev] [RFC V2 1/4] ovs_list: Extend list functions.

2015-06-02 Thread Alex Wang
Thanks for the review, really good points, adopt both, On Tue, Jun 2, 2015 at 12:57 PM, Andy Zhou wrote: > On Mon, Jun 1, 2015 at 11:24 AM, Alex Wang wrote: > > This commit adds function that allows the appending of one list > > content to the other. Also, it adds functions which allows list >

Re: [ovs-dev] [RFC V2 1/4] ovs_list: Extend list functions.

2015-06-02 Thread Andy Zhou
On Mon, Jun 1, 2015 at 11:24 AM, Alex Wang wrote: > This commit adds function that allows the appending of one list > content to the other. Also, it adds functions which allows list > to be sorted. > > Signed-off-by: Alex Wang > --- > RFC->RFC V2: > - Adopt Ben's suggestions. > > --- > lib/list

Re: [ovs-dev] [net-next RFC 00/14] Convert OVS tunnel vports to use regular net_devices

2015-06-02 Thread Eric W. Biederman
Thomas Graf writes: > This is the first series in a greater effort to bring the scalability > and programmability advantages of OVS to the rest of the network > stack and to get rid of as much OVS specific code as possible. > > This first series focuses on getting rid of OVS tunnel vports and use

Re: [ovs-dev] Adding a LuaJIT binding for openvswitch

2015-06-02 Thread William Adams
>> Perhaps other people working on things like Rust or Go might be >> interested in adding links there as well. The more the merrier I >> think. > > Sure, I'd be happy to have links to all the bindings that are available > (I didn't know about Rust bindings!). I don't know of a Rust binding eith

Re: [ovs-dev] Adding a LuaJIT binding for openvswitch

2015-06-02 Thread Ben Pfaff
On Tue, Jun 02, 2015 at 06:11:45PM +, William Adams wrote: > Thanks a lot!  that was pretty darned fast. When people make it easy by submitting pull requests to the webpage, I have no excuse to be slow ;-) > Perhaps other people working on things like Rust or Go might be > interested in addin

Re: [ovs-dev] Adding a LuaJIT binding for openvswitch

2015-06-02 Thread William Adams
Thanks a lot!  that was pretty darned fast. Perhaps other people working on things like Rust or Go might be interested in adding links there as well.  The more the merrier I think. -- William === - Shaping clay is easier than digging it out of the ground. ---

Re: [ovs-dev] [PATCH v2 15/19] ofproto: Add support for reverting flow mods, and bundle commit.

2015-06-02 Thread Ben Pfaff
On Mon, Jun 01, 2015 at 06:17:48PM -0700, Jarno Rajahalme wrote: > Applied to master with the following incremental based on the above, Great, I'm happy to see this. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH V10 4/5] 802.1AD: Describe 802.1ad changes

2015-06-02 Thread Thomas F Herbert
From: "Thomas F. Herbert" Signed-off-by: Thomas F Herbert --- NEWS | 2 ++ utilities/ovs-ofctl.8.in | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index a480607..cbdde3a 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,7 @@ Post-v2.3.0 -

[ovs-dev] [PATCH V10 5/5] Test push and popp of vlan with both 802.1AD and 802.1Q

2015-06-02 Thread Thomas F Herbert
From: "Thomas F. Herbert" This test tests the user space actions for 802.1q and 802.1ad. This test was originally contributed by Dave Benson. Signed-off-by: Thomas F Herbert --- tests/ofproto-dpif.at | 40 1 file changed, 40 insertions(+) diff --git a/

[ovs-dev] [PATCH V10 3/5] Flow key and netlink parsing changes for 8021.AD

2015-06-02 Thread Thomas F Herbert
From: "Thomas F. Herbert" Netlink parsing and flow key conversion. Netlink attribute encoding is done with double encap attributes. Netlink attributes for 802.1ad look like the following: eth_type(0x88a8),vlan(vid=100),encap(eth_type(0x8100), vlan(vid=200), encap(eth_type(0x0800)

[ovs-dev] [PATCH V10 1/5] Support functions for 8021.ad push and pop vlan

2015-06-02 Thread Thomas F Herbert
From: "Thomas F. Herbert" Changes to allow the tpid to be specified and all vlan tpid checking to be generalized. Signed-off-by: Thomas F Herbert --- lib/odp-execute.c | 2 +- lib/packets.c | 8 lib/packets.h | 7 +++ 3 files changed, 12 insertions(+), 5 deletions(-) diff

[ovs-dev] [PATCH V10 2/5] 802.1AD: Flow and action changes

2015-06-02 Thread Thomas F Herbert
From: "Thomas F. Herbert" The flow structure is updated to hold the customer tci. Flow key extraction is changed to add support for ctci and both TPIDs. Parsing to support pushing and popping with both single and double tagged vlans. In response to reviewers comments on V6, all changes affected b

[ovs-dev] [PATCH V10 0/5] Add 802.1ad (qinq) support

2015-06-02 Thread Thomas F Herbert
From: "Thomas F. Herbert" Version 10: Use doubly nested encap attributes to encode 802.1ad. Rebase to master. V8 and V9 were skipped and this version was called V10 to accompany V10 kernel module patch simultaneously to net-next. This patch will is incopatible with old versions of the kernel mod

Re: [ovs-dev] [PATCH v2 06/19] bundles: Validate bundled messages.

2015-06-02 Thread Ben Pfaff
On Mon, Jun 01, 2015 at 06:06:14PM -0700, Jarno Rajahalme wrote: > > > On Jun 1, 2015, at 2:48 PM, Ben Pfaff wrote: > > > > On Mon, Jun 01, 2015 at 01:58:41PM -0700, Jarno Rajahalme wrote: > >> > >>> On Jun 1, 2015, at 1:47 PM, Jarno Rajahalme wrote: > >>> > >>> > On May 29, 2015, at 5:

Re: [ovs-dev] [net-next RFC 00/14] Convert OVS tunnel vports to use regular net_devices

2015-06-02 Thread Flavio Leitner
It seems patch 01 didn't make it to ovs dev mailing list, but it is available on netdev mailing list. fbl ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH net-next V10 4/4] 8021AD: Flow key parsing and netlink attributes.

2015-06-02 Thread Thomas F Herbert
Add support for 802.1ad to netlink parsing and flow conversation. Uses double nested encap attributes to represent double tagged vlan. Signed-off-by: Thomas F Herbert --- net/openvswitch/flow_netlink.c | 186 ++--- 1 file changed, 157 insertions(+), 29 deletio

[ovs-dev] [PATCH net-next V10 3/4] 802.1AD: Flow handling, actions and vlan parsing

2015-06-02 Thread Thomas F Herbert
Add support for 802.1ad including the ability to push and pop double tagged vlans. Signed-off-by: Thomas F Herbert --- net/openvswitch/flow.c | 82 ++ net/openvswitch/flow.h | 3 ++ 2 files changed, 73 insertions(+), 12 deletions(-) diff --git a/

[ovs-dev] [PATCH net-next V10 2/4] General check for vlan ethernet types

2015-06-02 Thread Thomas F Herbert
This patch adds a function to check for vlan ethernet types. There is a use case in openvswitch and it should be useful elsewhere. Signed-off-by: Thomas F Herbert --- include/linux/if_vlan.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_v

[ovs-dev] [PATCH net-next V10 1/4] openvswitch: 802.1ad uapi changes.

2015-06-02 Thread Thomas F Herbert
openvswitch: Add support for 8021.AD Change the description of the VLAN tpid field. Signed-off-by: Thomas F Herbert --- include/uapi/linux/openvswitch.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/op

[ovs-dev] [PATCH net-next V10 0/4] openvswitch: Add support for 802.1AD

2015-06-02 Thread Thomas F Herbert
Add support for 802.1AD to the openvswitch kernel module. V10: Implement reviewer comments: Consolidate vlan parsing functions. Splits netlink parsing and flow conversion into a separate patch. Uses double encap attribute encapsulation for 802.1ad. Netlink attributes now look like this: eth_

Re: [ovs-dev] Adding a LuaJIT binding for openvswitch

2015-06-02 Thread Ben Pfaff
Works for me! I merged it. On Tue, Jun 02, 2015 at 05:25:24PM +, William Adams wrote: > OK.  I have made the change in the 'development' area.  I hope you find that > acceptable. > > -- William > > > > === > - Shaping clay is easier than digging it out of the

Re: [ovs-dev] [PATCH v2] dpif-netdev: Fix non-pmd thread queue id.

2015-06-02 Thread Flavio Leitner
On Fri, May 29, 2015 at 12:42:00PM +0100, Mark D. Gray wrote: > From: Daniele Di Proietto > > Non pmd threads have a core_id == UINT32_MAX, while queue ids used by > netdevs range from 0 to the number of CPUs. Therefore core ids cannot > be used directly to select a queue. > > This commit intro

Re: [ovs-dev] Adding a LuaJIT binding for openvswitch

2015-06-02 Thread William Adams
OK.  I have made the change in the 'development' area.  I hope you find that acceptable. -- William === - Shaping clay is easier than digging it out of the ground. > Date: Tue, 2 Jun 2015 08:02:00 -0700 > From: b...@nicira.

Re: [ovs-dev] [PATCH 1/3] odp-util: Refactor ovs_u128 handling functions.

2015-06-02 Thread Joe Stringer
For UFID, I sent a patch to reuse UUID for UFID: http://openvswitch.org/pipermail/dev/2015-June/055890.html I'm currently thinking that for 128-bit maskable bitfields like conn_label, I'll have something similar to this original patch, which will represent the value as "conn_label=0xf00bar/0xc

Re: [ovs-dev] [PATCH ovn 2/2] fedora.spec: Create openvswitch-ovn package.

2015-06-02 Thread Flavio Leitner
On Tue, Jun 02, 2015 at 11:17:29AM -0400, Russell Bryant wrote: > On 06/02/2015 09:24 AM, Flavio Leitner wrote: > > On Fri, May 29, 2015 at 02:51:26PM -0700, Ben Pfaff wrote: > >> On Fri, May 29, 2015 at 05:07:19PM -0400, Russell Bryant wrote: > >>> On 05/29/2015 04:50 PM, Ben Pfaff wrote: > O

Re: [ovs-dev] [RFC PATCH kernel 09/10] vxlan: export vxlan6_xmit_skb

2015-06-02 Thread Jiri Benc
On Mon, 1 Jun 2015 15:11:03 -0700, Jesse Gross wrote: > On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > > diff --git a/include/net/vxlan.h b/include/net/vxlan.h > > index 0082b5d33d7d..a4ed7241c56a 100644 > > --- a/include/net/vxlan.h > > +++ b/include/net/vxlan.h > > +int vxlan6_xmit_skb(str

Re: [ovs-dev] [PATCH] datapath: do not add vlan_hwaccel_push_inside() for kernel >= 3.18.13

2015-06-02 Thread Flavio Leitner
On Wed, May 27, 2015 at 02:11:32PM -0700, Jesse Gross wrote: > On Wed, May 27, 2015 at 2:07 PM, Hauke Mehrtens wrote: > > On 05/27/2015 10:14 PM, Jesse Gross wrote: > >> On Tue, May 26, 2015 at 4:59 PM, Ben Pfaff wrote: > >>> diff --git a/datapath/linux/compat/include/linux/if_vlan.h > >>> b/dat

Re: [ovs-dev] [RFC PATCH kernel 08/10] ip6_tunnel: do not update stats if no netdev given

2015-06-02 Thread Jiri Benc
On Mon, 1 Jun 2015 15:09:54 -0700, Jesse Gross wrote: > On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > > Other users of IPv6 tunneling (e.g. openvswitch) may not have a net_device > > that represents the tunnel. > > > > Signed-off-by: Jiri Benc > > I think this will probably not make peopl

Re: [ovs-dev] [RFC PATCH kernel 07/10] openvswitch: IPv6 support for ovs_tunnel_get_egress_info

2015-06-02 Thread Jiri Benc
On Mon, 1 Jun 2015 15:07:11 -0700, Jesse Gross wrote: > On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > > diff --git a/net/openvswitch/vport.h b/net/openvswitch/vport.h > > index b22d45775eb5..ca9ebb9eb0f7 100644 > > --- a/net/openvswitch/vport.h > > +++ b/net/openvswitch/vport.h > > +static

Re: [ovs-dev] [RFC PATCH kernel 04/10] openvswitch: IPv6 type of tunnel vports

2015-06-02 Thread Jiri Benc
On Mon, 1 Jun 2015 14:40:41 -0700, Jesse Gross wrote: > On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > > diff --git a/include/uapi/linux/openvswitch.h > > b/include/uapi/linux/openvswitch.h > > index 4d26da40b01f..ba7ae3b05308 100644 > > --- a/include/uapi/linux/openvswitch.h > > +++ b/incl

Re: [ovs-dev] [RFC PATCH kernel 03/10] openvswitch: IPv6 tunnel flows

2015-06-02 Thread Jiri Benc
On Mon, 1 Jun 2015 14:22:48 -0700, Jesse Gross wrote: > On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > > diff --git a/net/openvswitch/flow.h b/net/openvswitch/flow.h > > index 2af6ffbf2f2e..78e96a120120 100644 > > --- a/net/openvswitch/flow.h > > +++ b/net/openvswitch/flow.h > > -struct ovs_

Re: [ovs-dev] [PATCH v2] ofp-util: Convert flow_metadata to match structure.

2015-06-02 Thread Ben Pfaff
On Tue, Jun 02, 2015 at 08:25:14AM -0700, Jesse Gross wrote: > On Tue, Jun 2, 2015 at 8:03 AM, Ben Pfaff wrote: > > On Tue, Jun 02, 2015 at 07:58:48AM -0700, Ben Pfaff wrote: > >> On Mon, Jun 01, 2015 at 03:35:23PM -0700, Jesse Gross wrote: > >> > On Mon, Jun 1, 2015 at 2:55 PM, Ben Pfaff wrote:

Re: [ovs-dev] [PATCH v2] ofp-util: Convert flow_metadata to match structure.

2015-06-02 Thread Jesse Gross
On Tue, Jun 2, 2015 at 8:03 AM, Ben Pfaff wrote: > On Tue, Jun 02, 2015 at 07:58:48AM -0700, Ben Pfaff wrote: >> On Mon, Jun 01, 2015 at 03:35:23PM -0700, Jesse Gross wrote: >> > On Mon, Jun 1, 2015 at 2:55 PM, Ben Pfaff wrote: >> > > On Mon, Jun 01, 2015 at 01:49:30PM -0700, Jesse Gross wrote: >

Re: [ovs-dev] [PATCH ovn 2/2] fedora.spec: Create openvswitch-ovn package.

2015-06-02 Thread Russell Bryant
On 06/02/2015 09:24 AM, Flavio Leitner wrote: > On Fri, May 29, 2015 at 02:51:26PM -0700, Ben Pfaff wrote: >> On Fri, May 29, 2015 at 05:07:19PM -0400, Russell Bryant wrote: >>> On 05/29/2015 04:50 PM, Ben Pfaff wrote: On Fri, Apr 24, 2015 at 01:06:06PM -0400, Russell Bryant wrote: > This

Re: [ovs-dev] [PATCH v2] ofp-util: Convert flow_metadata to match structure.

2015-06-02 Thread Ben Pfaff
On Tue, Jun 02, 2015 at 07:58:48AM -0700, Ben Pfaff wrote: > On Mon, Jun 01, 2015 at 03:35:23PM -0700, Jesse Gross wrote: > > On Mon, Jun 1, 2015 at 2:55 PM, Ben Pfaff wrote: > > > On Mon, Jun 01, 2015 at 01:49:30PM -0700, Jesse Gross wrote: > > >> We have a special flow_metadata structure to repr

Re: [ovs-dev] Adding a LuaJIT binding for openvswitch

2015-06-02 Thread Ben Pfaff
On Tue, Jun 02, 2015 at 05:18:09AM +, William Adams wrote: > I have been working on some luajit bindings/code for openvswitch. > First of all, is there knowledge of an existing lua based binding > already? If not, what's the best way of contributing this work? > Should I just point to my own g

Re: [ovs-dev] [PATCH v2] ofp-util: Convert flow_metadata to match structure.

2015-06-02 Thread Ben Pfaff
On Mon, Jun 01, 2015 at 03:35:23PM -0700, Jesse Gross wrote: > On Mon, Jun 1, 2015 at 2:55 PM, Ben Pfaff wrote: > > On Mon, Jun 01, 2015 at 01:49:30PM -0700, Jesse Gross wrote: > >> We have a special flow_metadata structure to represent the parts > >> of a packet that aren't carried in the payload

Re: [ovs-dev] [RFC PATCH kernel 03/10] openvswitch: IPv6 tunnel flows

2015-06-02 Thread Flavio Leitner
On Mon, Jun 01, 2015 at 02:22:48PM -0700, Jesse Gross wrote: > On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > > diff --git a/net/openvswitch/flow.h b/net/openvswitch/flow.h > > index 2af6ffbf2f2e..78e96a120120 100644 > > --- a/net/openvswitch/flow.h > > +++ b/net/openvswitch/flow.h > > -stru

Re: [ovs-dev] [RFC PATCH kernel 02/10] openvswitch: remove custom alignment

2015-06-02 Thread Flavio Leitner
On Thu, May 14, 2015 at 08:10:44PM +0200, Jiri Benc wrote: > The custom alignment of struct ovs_key_ipv4_tunnel was originally introduced > by commit 1139e241ec436 ("openvswitch: Compact sw_flow_key."). At that time, > the size of the structure was not a multiply of 64bit. This is not the case > an

Re: [ovs-dev] [RFC PATCH kernel 01/10] openvswitch: fix CHECKSUM_PARTIAL with tunnels

2015-06-02 Thread Flavio Leitner
On Thu, May 28, 2015 at 02:51:55PM +0200, Jiri Benc wrote: > On Wed, 27 May 2015 14:27:59 -0700, Jesse Gross wrote: > > Isn't this really a bug in the decapsulation code? It seems like this > > should trigger in other cases as well - what happens on normal > > forwarding where we compute the checks

Re: [ovs-dev] [PATCH ovn 2/2] fedora.spec: Create openvswitch-ovn package.

2015-06-02 Thread Flavio Leitner
On Fri, May 29, 2015 at 02:51:26PM -0700, Ben Pfaff wrote: > On Fri, May 29, 2015 at 05:07:19PM -0400, Russell Bryant wrote: > > On 05/29/2015 04:50 PM, Ben Pfaff wrote: > > > On Fri, Apr 24, 2015 at 01:06:06PM -0400, Russell Bryant wrote: > > >> This patch creates a new subpackage for OVN, openvsw

Re: [ovs-dev] submariner blue face model for cheap

2015-06-02 Thread Malcolm Godwin
Wow the crowd with our captivating array of fine Duplicate watches. http://ibhsedu.com/0ct48i/64phy.html";>More Details ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] Update my email address

2015-06-02 Thread Miguel Ángel Ajo
Congratulations :) Midokura did something very smart ;) Miguel Ángel Ajo On Tuesday, 2 de June de 2015 at 8:03, Justin Pettit wrote: > Congratulations on the new job! > > Acked-by: Justin Pettit mailto:jpet...@nicira.com)> > > --Justin > > > > On Jun 1, 2015, at 10:35 PM, YAMAMOTO Ta

[ovs-dev] error

2015-06-02 Thread email
5…ê Ͳ ¦ÆG¶>9yï's1ò ¢Gïórª•D^ž<‚¤ÐvšúprÎ^5á`/ïjh̓˚èZ[äu"ZB;/ü,¿}¸K*m5 l:“-Rš„Øé>'CÆëPQ¯uNõÔô/áñxODÊbZ{G¢²n”$óT?“T(W_]û)îÀ’gjÝX3,*?´èÔî3ÔÔfáÎҙðqv"6‘gÐAu¾åýÓä»é«þ6!¥\A.ßÛ ÐÐ*¢dJ.ßüþ¨0Ÿûʹf¦µ7ó­ŒëŒ „W»œ†¹ÉUj,´ì?½Í‘%ù¥\ésô~ ¦•#ΛM‰›±Þp’¡7snªæ¯r%ÏòVÎtÔÌ_ÐÁ9Ip«ø?*ûÐ.Òd§~¹Œ^ñ…m†m4Ž‡ ÈLsÆþ

Re: [ovs-dev] [PATCH INFO 2/2] geneve: Zero header before parsing userspace tunneling action.

2015-06-02 Thread Andy Zhou
On Wed, Apr 8, 2015 at 8:31 AM, Jesse Gross wrote: > When we parse the text representation of the Geneve action the > header is not fully initialized. Besides the obvious potential > to generate an action that the user did not actually specify, this > also causes intermittent unit test failures wh

Re: [ovs-dev] [PATCH INFO 1/2] packet: Avoid array of struct with zero length member.

2015-06-02 Thread Andy Zhou
On Wed, Apr 8, 2015 at 8:31 AM, Jesse Gross wrote: > Windows doesn't like that the Geneve header has an array of > options with each have a zero length member (the variable data). > Nothing is accessing the data now, so just replace the member with > a comment - we can use pointer arithmetic when