Re: [ovs-dev] [PATCH] Update my email address

2015-06-01 Thread Justin Pettit
Congratulations on the new job! Acked-by: Justin Pettit --Justin > On Jun 1, 2015, at 10:35 PM, YAMAMOTO Takashi wrote: > > Signed-off-by: YAMAMOTO Takashi > --- > AUTHORS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/AUTHORS b/AUTHORS > index a2b40a7..f155105 100

[ovs-dev] [PATCH] Update my email address

2015-06-01 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- AUTHORS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS b/AUTHORS index a2b40a7..f155105 100644 --- a/AUTHORS +++ b/AUTHORS @@ -179,7 +179,7 @@ Vivien Bernet-Rollande v...@soprive.net Wang Sheng-Hui shh...@gmail.com Wei Y

[ovs-dev] Adding a LuaJIT binding for openvswitch

2015-06-01 Thread William Adams
Hi List, I have been working on some luajit bindings/code for openvswitch. First of all, is there knowledge of an existing lua based binding already? If not, what's the best way of contributing this work? Should I just point to my own github repo, or is there someplace in openvswitch where li

Re: [ovs-dev] [PATCH] metaflow: Convert hex parsing to use new utility functions.

2015-06-01 Thread Jesse Gross
On Mon, Jun 1, 2015 at 6:54 PM, Andy Zhou wrote: [...] >> -return xasprintf("%s: bad syntax for %s", s, mf->name); >> +if (err == ERANGE) { >> +return xasprintf("%s: value too large for %u-byte field %s", >> + s, mf->n_bytes, mf->name); > This error message

Re: [ovs-dev] [PATCH] lib/util.c: style fixes

2015-06-01 Thread Jesse Gross
On Mon, Jun 1, 2015 at 7:08 PM, Andy Zhou wrote: > Covert tabs into spaces. Found by inspection. > > Signed-off-by: Andy Zhou Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] lib/util.c: style fixes

2015-06-01 Thread Andy Zhou
Covert tabs into spaces. Found by inspection. Signed-off-by: Andy Zhou --- lib/util.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/util.c b/lib/util.c index c7e2b77..9473985 100644 --- a/lib/util.c +++ b/lib/util.c @@ -651,11 +651,11 @@ str_to_uint(const cha

Re: [ovs-dev] [PATCH] metaflow: Convert hex parsing to use new utility functions.

2015-06-01 Thread Andy Zhou
I have a minor comments in line. Overall, looks good. Acked-by: Andy Zhou On Mon, Jun 1, 2015 at 11:34 AM, Jesse Gross wrote: > We now have functions that can do parsing and printing of long hex > strings, so we should use them for meta flow fields to ensure > consistent behavior. > > Since the

[ovs-dev] [PATCH 2/2] types: Rename and move ovs_u128_equal().

2015-06-01 Thread Joe Stringer
This function doesn't need to be exported in the public OVS headers, and it had an inconsistent name compared to uuid_equals(). Rename and move. Signed-off-by: Joe Stringer --- include/openvswitch/types.h | 7 --- lib/dpif-netdev.c | 2 +- lib/dpif.c| 3 ++-

[ovs-dev] [PATCH 1/2] odp-util: Reuse UUID marshalling for UFID.

2015-06-01 Thread Joe Stringer
Unique flow identifiers are really a UUID of sorts, so it makes sense to reuse the UUID string representations for UFID. Suggested-by: Ben Pfaff Signed-off-by: Joe Stringer --- lib/odp-util.c | 36 ++-- tests/dpif-netdev.at| 2 +- tests/ofproto-dpif

Re: [ovs-dev] [PATCH v2 15/19] ofproto: Add support for reverting flow mods, and bundle commit.

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 6:40 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:24PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > You know, we could make evictions reversible, since after all we have a > way to mark rules as to-be-deleted and then not delete them. I d

Re: [ovs-dev] [PATCH v2 14/19] ofproto: Split delete_flow*().

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 6:18 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:23PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > Acked-by: Ben Pfaff Merged, Jarno ___ dev mailing list dev@openvswitch.org http://openvsw

Re: [ovs-dev] [PATCH v2 13/19] ofproto: Split modify_flows().

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 6:16 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:22PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > Acked-by: Ben Pfaff Thanks for review! Merged to master, Jarno ___ dev mailing list dev@o

Re: [ovs-dev] [PATCH v2 12/19] ofproto: Split add_flow().

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 6:08 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:21PM -0700, Jarno Rajahalme wrote: >> Split add_flow() to add_flow_begin() which does all the error >> checking, and add_flow_finish() which can not fail. >> >> Since we still want to send an error response for an

Re: [ovs-dev] [PATCH v2 11/19] ofproto: Refactor modify_flows__().

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 6:01 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:20PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > I see some opportunity for simplification in modify_flows_check__(): > > diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c > index 5c8b1a

Re: [ovs-dev] [PATCH v2 10/19] ofproto: Use enum ofperr for 'error'.

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 5:54 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:19PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > Hmm, ofproto_rule_create() returns ENOMEM instead of an ofperr on error, > we should fix that. > > I see a few references to OFPROTO_POSTP

Re: [ovs-dev] [PATCH v2 09/19] ofproto: Factor out ofproto_rule_create().

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 5:47 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:18PM -0700, Jarno Rajahalme wrote: >> Makes add_flow() easier to read and understand. >> >> Signed-off-by: Jarno Rajahalme > > Acked-by: Ben Pfaff Pushed, thanks! Jarno _

Re: [ovs-dev] [PATCH v2 08/19] ofproto: Factor out ofproto_rule_insert__().

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 5:44 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:17PM -0700, Jarno Rajahalme wrote: >> Pairs well with ofproto_rule_remove__(). > > I prefer a mid-priced Gewürztraminer with my ofproto_rule_remove__(). > > Acked-by: Ben Pfaff Thanks! Pushed to master, Jarn

Re: [ovs-dev] [PATCH v2 07/19] bundles: Manage bundles in connmgr.

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 5:42 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:16PM -0700, Jarno Rajahalme wrote: >> This will make implementing commit in ofproto.c easier. >> >> Signed-off-by: Jarno Rajahalme > > Acked-by: Ben Pfaff Thanks for the review! Pushed to master, Jarno __

Re: [ovs-dev] [PATCH v2 06/19] bundles: Validate bundled messages.

2015-06-01 Thread Jarno Rajahalme
Pushed to master, Jarno > On Jun 1, 2015, at 6:06 PM, Jarno Rajahalme wrote: > > >> On Jun 1, 2015, at 2:48 PM, Ben Pfaff > > wrote: >> >> On Mon, Jun 01, 2015 at 01:58:41PM -0700, Jarno Rajahalme wrote: >>> On Jun 1, 2015, at 1:47 PM, Jarno Rajahalme >>>

Re: [ovs-dev] [PATCH v2 06/19] bundles: Validate bundled messages.

2015-06-01 Thread Jarno Rajahalme
> On Jun 1, 2015, at 2:48 PM, Ben Pfaff wrote: > > On Mon, Jun 01, 2015 at 01:58:41PM -0700, Jarno Rajahalme wrote: >> >>> On Jun 1, 2015, at 1:47 PM, Jarno Rajahalme wrote: >>> >>> On May 29, 2015, at 5:38 PM, Ben Pfaff wrote: On Mon, May 18, 2015 at 04:10:15PM -0700, Jarno

Re: [ovs-dev] [net-next RFC 05/14] route: Per route tunnel metadata with RTA_TUNNEL

2015-06-01 Thread Thomas Graf
On 06/01/15 at 05:51pm, Robert Shearman wrote: > On 01/06/15 15:27, Thomas Graf wrote: > >Introduces a new Netlink attribute RTA_TUNNEL which allows routes > >to set tunnel transmit metadata and specify the tunnel endpoint or > >tunnel id on a per route basis. The route must point to a tunnel > >de

[ovs-dev] vswitchd segfaults at dpdk_queue_flush__() on receiving the first packet

2015-06-01 Thread Prem Anand Haridoss
Hi Folks I am trying to use ovs (master) with dpdk (2.0.0). I had followed the guide https://github.com/openvswitch/ovs/blob/master/INSTALL.DPDK.md and built everything successfully I then created a ovs bridge and added a SR-IOV VF as a dpdk interface. The bridge gets created as expected, howeve

Re: [ovs-dev] [PATCH v2] ofp-util: Convert flow_metadata to match structure.

2015-06-01 Thread Jesse Gross
On Mon, Jun 1, 2015 at 2:55 PM, Ben Pfaff wrote: > On Mon, Jun 01, 2015 at 01:49:30PM -0700, Jesse Gross wrote: >> We have a special flow_metadata structure to represent the parts >> of a packet that aren't carried in the payload itself. This is >> used in the case where we need to send the packet

[ovs-dev] [PATCH 1/2] perf-counter: simplify the performance macro

2015-06-01 Thread Andy Zhou
Replace the original PERF_FUNCTION_BEGIN and PERF_FUNCTION_END pair with a single PERF macro. This design is also more flexible, removing the restriction of have only one measurement per function. The next patch will make use of this macro. Signed-off-by: Andy Zhou --- lib/perf-counter.c | 13 +

[ovs-dev] [PATCH 2/2] ovsdb: Add per transaction commit instruction counter

2015-06-01 Thread Andy Zhou
Measure user space only instruction counters for commit each transaction. This measurement is mainly useful for tuning OVSDB internal implementation, such as how OVSDB scales over number of client connections. A simple usage example: ovs-appctl -t ovsdb-server ovsdb-server/perf-counters-clear ovs

Re: [ovs-dev] [PATCH] ovsdb: add user space instruction counters

2015-06-01 Thread Andy Zhou
On Fri, May 29, 2015 at 1:32 PM, Ben Pfaff wrote: > On Wed, Apr 15, 2015 at 09:01:14AM -0700, Andy Zhou wrote: >> Add a set of user space instruction counters to help break down >> where instructions are spent. >> >> Here is an example of screen capture of adding a port to database >> without any

Re: [ovs-dev] [RFC PATCH kernel 10/10] openvswitch: add IPv6 support for vxlan

2015-06-01 Thread Jesse Gross
On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > Signed-off-by: Jiri Benc > --- > net/openvswitch/vport-vxlan.c | 133 > +++--- > 1 file changed, 99 insertions(+), 34 deletions(-) No particular objection to this although it's obviously going to need to l

Re: [ovs-dev] [RFC PATCH kernel 09/10] vxlan: export vxlan6_xmit_skb

2015-06-01 Thread Jesse Gross
On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > diff --git a/include/net/vxlan.h b/include/net/vxlan.h > index 0082b5d33d7d..a4ed7241c56a 100644 > --- a/include/net/vxlan.h > +++ b/include/net/vxlan.h > +int vxlan6_xmit_skb(struct dst_entry *dst, struct sock *sk, > + struct

Re: [ovs-dev] [RFC PATCH kernel 08/10] ip6_tunnel: do not update stats if no netdev given

2015-06-01 Thread Jesse Gross
On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > Other users of IPv6 tunneling (e.g. openvswitch) may not have a net_device > that represents the tunnel. > > Signed-off-by: Jiri Benc I think this will probably not make people happy upstream, so we'll need to wait for the netdevice tunnel pat

Re: [ovs-dev] [RFC PATCH kernel 07/10] openvswitch: IPv6 support for ovs_tunnel_get_egress_info

2015-06-01 Thread Jesse Gross
On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > diff --git a/net/openvswitch/vport.h b/net/openvswitch/vport.h > index b22d45775eb5..ca9ebb9eb0f7 100644 > --- a/net/openvswitch/vport.h > +++ b/net/openvswitch/vport.h > +static inline struct dst_entry *ovs_tunnel6_route_lookup(struct sock *sk,

Re: [ovs-dev] [PATCH v2] ofp-util: Convert flow_metadata to match structure.

2015-06-01 Thread Ben Pfaff
On Mon, Jun 01, 2015 at 01:49:30PM -0700, Jesse Gross wrote: > We have a special flow_metadata structure to represent the parts > of a packet that aren't carried in the payload itself. This is > used in the case where we need to send the packet as a Packet In > to an OpenFlow controller. This is a

Re: [ovs-dev] [PATCH v2 06/19] bundles: Validate bundled messages.

2015-06-01 Thread Ben Pfaff
On Mon, Jun 01, 2015 at 01:58:41PM -0700, Jarno Rajahalme wrote: > > > On Jun 1, 2015, at 1:47 PM, Jarno Rajahalme wrote: > > > > > >> On May 29, 2015, at 5:38 PM, Ben Pfaff wrote: > >> > >> On Mon, May 18, 2015 at 04:10:15PM -0700, Jarno Rajahalme wrote: > >>> OpenFlow bundle messages should

Re: [ovs-dev] [RFC PATCH kernel 04/10] openvswitch: IPv6 type of tunnel vports

2015-06-01 Thread Jesse Gross
On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > diff --git a/include/uapi/linux/openvswitch.h > b/include/uapi/linux/openvswitch.h > index 4d26da40b01f..ba7ae3b05308 100644 > --- a/include/uapi/linux/openvswitch.h > +++ b/include/uapi/linux/openvswitch.h > @@ -267,6 +267,7 @@ enum { >

Re: [ovs-dev] [RFC PATCH kernel 03/10] openvswitch: IPv6 tunnel flows

2015-06-01 Thread Jesse Gross
On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > diff --git a/net/openvswitch/flow.h b/net/openvswitch/flow.h > index 2af6ffbf2f2e..78e96a120120 100644 > --- a/net/openvswitch/flow.h > +++ b/net/openvswitch/flow.h > -struct ovs_key_ipv4_tunnel { > +struct ovs_key_ip_tunnel { > __be64 t

Re: [ovs-dev] [PATCH v2 06/19] bundles: Validate bundled messages.

2015-06-01 Thread Jarno Rajahalme
> On Jun 1, 2015, at 1:47 PM, Jarno Rajahalme wrote: > > >> On May 29, 2015, at 5:38 PM, Ben Pfaff wrote: >> >> On Mon, May 18, 2015 at 04:10:15PM -0700, Jarno Rajahalme wrote: >>> OpenFlow bundle messages should be decoded and validated at the time >>> they are added to the bundle. This com

[ovs-dev] [PATCH v2] ofp-util: Convert flow_metadata to match structure.

2015-06-01 Thread Jesse Gross
We have a special flow_metadata structure to represent the parts of a packet that aren't carried in the payload itself. This is used in the case where we need to send the packet as a Packet In to an OpenFlow controller. This is a subset of the more general struct flow. In practice, almost all oper

Re: [ovs-dev] [PATCH v2 06/19] bundles: Validate bundled messages.

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 5:38 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:15PM -0700, Jarno Rajahalme wrote: >> OpenFlow bundle messages should be decoded and validated at the time >> they are added to the bundle. This commit does this for flow mod and >> port mod messages. >> >> Signe

Re: [ovs-dev] [PATCH v2 05/19] classifier: Support duplicate rules.

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 5:23 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:14PM -0700, Jarno Rajahalme wrote: >> OpenFlow 1.4 bundles are easier to implement when it is possible to >> mark a rule as 'to_be_removed' and then insert a new, identical rule >> with the same priority. >> >> Al

Re: [ovs-dev] [PATCH v2 05/19] classifier: Support duplicate rules.

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 5:23 PM, Ben Pfaff wrote: > > + * Tentative Modifications > + * === > + * > + * When a new rule is added to a classifier, it can optionally be > "invisible". > + * That means that lookups won't find the rule, although iterations through > + * the classi

Re: [ovs-dev] [PATCH v2 04/19] classifier: Add support for invisible flows.

2015-06-01 Thread Jarno Rajahalme
> On Jun 1, 2015, at 1:11 PM, Ben Pfaff wrote: > > On Mon, Jun 01, 2015 at 01:00:26PM -0700, Jarno Rajahalme wrote: >> Do you want to see a v2 for these changes? > > Not necessary. OK, pushed to master, Jarno ___ dev mailing list dev@openvswitch.

Re: [ovs-dev] [PATCH v2 03/19] ofp-util: Fix xid in ofputil_encode_bundle_add().

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 3:58 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:12PM -0700, Jarno Rajahalme wrote: >> Bundle add must use the same xid as the embedded message. >> >> Signed-off-by: Jarno Rajahalme > > Good catch, thanks. > > Acked-by: Ben Pfaff Thanks for the review, pus

Re: [ovs-dev] [PATCH v2 02/19] ofp-parse: Remove unused F_OUT_PORT field flag.

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 3:52 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:11PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > I think the correct fix is more like this: > > diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c > index 856044d..0e265a7 100644 > --- a/lib/

Re: [ovs-dev] [PATCH v2 01/19] ofproto: Eliminate use of unset error code.

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 3:47 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:10PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > Looks good, will you backport to 2.3 (if applicable)? > > Thanks, > > Ben. Pushed to master and branch-2.3, Jarno __

Re: [ovs-dev] [PATCH v2 04/19] classifier: Add support for invisible flows.

2015-06-01 Thread Ben Pfaff
On Mon, Jun 01, 2015 at 01:00:26PM -0700, Jarno Rajahalme wrote: > Do you want to see a v2 for these changes? Not necessary. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 04/19] classifier: Add support for invisible flows.

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 4:28 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:13PM -0700, Jarno Rajahalme wrote: >> This makes it possible to tentatively add flows to the classifier >> without the datapath seeing them. >> >> Signed-off-by: Jarno Rajahalme > > This is nifty. > > Here are

[ovs-dev] Report

2015-06-01 Thread The Post Office
Your message could not be delivered ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 01/19] ofproto: Eliminate use of unset error code.

2015-06-01 Thread Jarno Rajahalme
> On Jun 1, 2015, at 11:33 AM, Ben Pfaff wrote: > > On Mon, Jun 01, 2015 at 11:28:48AM -0700, Jarno Rajahalme wrote: >> >>> On May 29, 2015, at 3:47 PM, Ben Pfaff wrote: >>> >>> On Mon, May 18, 2015 at 04:10:10PM -0700, Jarno Rajahalme wrote: Signed-off-by: Jarno Rajahalme >>> >>> Look

[ovs-dev] [PATCH] ofp-util: Convert flow_metadata to match structure.

2015-06-01 Thread Jesse Gross
We have a special flow_metadata structure to represent the parts of a packet that aren't carried in the payload itself. This is used in the case where we need to send the packet as a Packet In to an OpenFlow controller. This is a subset of the more general struct flow. In practice, almost all oper

[ovs-dev] [PATCH] metaflow: Convert hex parsing to use new utility functions.

2015-06-01 Thread Jesse Gross
We now have functions that can do parsing and printing of long hex strings, so we should use them for meta flow fields to ensure consistent behavior. Since these functions can handle infinitely long strings, we can also increase the maximum field size for MFS_HEXADECIMAL types to the limit allowed

Re: [ovs-dev] [PATCH v2 01/19] ofproto: Eliminate use of unset error code.

2015-06-01 Thread Ben Pfaff
On Mon, Jun 01, 2015 at 11:28:48AM -0700, Jarno Rajahalme wrote: > > > On May 29, 2015, at 3:47 PM, Ben Pfaff wrote: > > > > On Mon, May 18, 2015 at 04:10:10PM -0700, Jarno Rajahalme wrote: > >> Signed-off-by: Jarno Rajahalme > > > > Looks good, will you backport to 2.3 (if applicable)? > > I

Re: [ovs-dev] [PATCH v2 01/19] ofproto: Eliminate use of unset error code.

2015-06-01 Thread Jarno Rajahalme
> On May 29, 2015, at 3:47 PM, Ben Pfaff wrote: > > On Mon, May 18, 2015 at 04:10:10PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > Looks good, will you backport to 2.3 (if applicable)? Is this an Acked-by in disguise? Jarno > > Thanks, > > Ben. _

[ovs-dev] [RFC V2 4/4] ofprot-dpif-hsa: Implement HSA prototype.

2015-06-01 Thread Alex Wang
This commit implements a prototype of Header Space Analysis of the OVS OpenFlow table. What It Does 1. Dump all OpenFlow rules from a specified bridge. 2. Generate all-unmasked header space with specified input port number and start looking up from default starting table. 3.

[ovs-dev] [RFC V2 3/4] flow: Add supporting functions for HSA.

2015-06-01 Thread Alex Wang
This commit adds functions that check if the 'struct flow_wildcards' member is fully masked (exact-match) or fully unmasked (don't care the entire field at all). Also, this commit adds a function to change a more wildcarded flow to a more specific one. Signed-off-by: Alex Wang Acked-by: Ben Pfaf

[ovs-dev] [RFC V2 2/4] hsa-match: Sparse representation of a byte array derived from "struct match".

2015-06-01 Thread Alex Wang
For conducting Header Space Analysis (HSA), we convert the wildcarded OpenFlow flow represented by 'struct match' into an encoded byte array. To further save memory, we use a sparse array to represent such byte array in the same way as 'struct miniflow'. So, this commit implements the structs and

[ovs-dev] [RFC V2 1/4] ovs_list: Extend list functions.

2015-06-01 Thread Alex Wang
This commit adds function that allows the appending of one list content to the other. Also, it adds functions which allows list to be sorted. Signed-off-by: Alex Wang --- RFC->RFC V2: - Adopt Ben's suggestions. --- lib/list.h| 48 tests/library.at |2 +-

[ovs-dev] [RFC V2 0/4] HSA for OVS prototype.

2015-06-01 Thread Alex Wang
The second version of RFC. This version contains mainly the refinement over previous one based on the reviews from Ben. As Ben asked in the review, if we want to utilize HSA in OVN, I start to think that it may be good to remodel this work so that it could parse the Southbound db and conduct HSA

Re: [ovs-dev] [RFC HSA 0/4] HSA for OVS prototype.

2015-06-01 Thread Alex Wang
I start to think that, if we want to utilize HSA in OVN, it may be good to remodel this work so that it could parse the Southbound db and conduct HSA with simpler logical flows and broader view of the logical networks. I will post V2 of the series. Again, hope to hear any feedback~ Thanks, Alex

Re: [ovs-dev] [net-next RFC 05/14] route: Per route tunnel metadata with RTA_TUNNEL

2015-06-01 Thread Robert Shearman
On 01/06/15 15:27, Thomas Graf wrote: Introduces a new Netlink attribute RTA_TUNNEL which allows routes to set tunnel transmit metadata and specify the tunnel endpoint or tunnel id on a per route basis. The route must point to a tunnel device which understands per skb tunnel metadata and has been

[ovs-dev] [net-next RFC 09/14] openvswitch: Move dev pointer into vport itself

2015-06-01 Thread Thomas Graf
This is the first step in representing all OVS vports as regular struct net_devices. Move the net_device pointer into the vport structure itself to get rid of struct vport_netdev. Signed-off-by: Thomas Graf Signed-off-by: Pravin B Shelar --- net/openvswitch/datapath.c | 7 +-- net/op

[ovs-dev] [net-next RFC 13/14] openvswitch: Use regular GRE net_device instead of vport

2015-06-01 Thread Thomas Graf
From: Pravin Shelar Removes all of the OVS specific GRE code and makes OVS use a GRE net_device . Signed-off-by: Pravin B Shelar --- net/core/dev.c | 5 +- net/ipv4/ip_gre.c | 161 - net/openvswitch/Makefile | 1 - net/openvswitch/vpor

[ovs-dev] [net-next RFC 08/14] openvswitch: Allocate & attach ip_tunnel_info for tunnel set action

2015-06-01 Thread Thomas Graf
Make use of the new skb tunnel metadata field by allocating a ip_tunnel_info per OVS tunnel set action and then attaching that metadata to each skb that passes the set action. The old egress_tun_info via the OVS_CB() is left in place until all tunnel vports have been converted to the new method.

[ovs-dev] [net-next RFC 11/14] openvswitch: Use regular VXLAN net_device device

2015-06-01 Thread Thomas Graf
This gets rid of all OVS specific VXLAN code in the receive and transmit path by using a VXLAN net_device to represent the vport. Only a small shim layer remains which takes care of handling the VXLAN specific OVS Netlink configuration. Unexports vxlan_sock_add(), vxlan_sock_release(), vxlan_xmit_

[ovs-dev] [net-next RFC 00/14] Convert OVS tunnel vports to use regular net_devices

2015-06-01 Thread Thomas Graf
This is the first series in a greater effort to bring the scalability and programmability advantages of OVS to the rest of the network stack and to get rid of as much OVS specific code as possible. This first series focuses on getting rid of OVS tunnel vports and use regular tunnel net_devices ins

[ovs-dev] [net-next RFC 14/14] arp: Associate ARP requests with tunnel info

2015-06-01 Thread Thomas Graf
Since ARP performs its own route lookup call, eventually returned tunnel metadata must be attached manually. Signed-off-by: Thomas Graf --- net/ipv4/arp.c | 8 1 file changed, 8 insertions(+) diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c index 933a928..6cf0502 100644 --- a/net/ipv4/arp.

[ovs-dev] [net-next RFC 07/14] vxlan: Factor out device configuration

2015-06-01 Thread Thomas Graf
This factors out the device configuration out of the RTNL newlink API which allows for in-kernel creation of VXLAN net_devices. Signed-off-by: Thomas Graf --- drivers/net/vxlan.c | 332 include/net/vxlan.h | 59 ++ 2 files changed, 23

[ovs-dev] [net-next RFC 03/14] vxlan: Flow based tunneling

2015-06-01 Thread Thomas Graf
Allows putting a VXLAN device into a new flow-based mode in which it will populate a tunnel info structure for each packet received. The metadata structure will contain the outer header and tunnel header fields which have been stripped off. Layers further up in the stack such as routing, tc or netf

[ovs-dev] [net-next RFC 06/14] fib: Add fib rule match on tunnel id

2015-06-01 Thread Thomas Graf
This add the ability to select a routing table based on the tunnel id which allows to maintain separate routing tables for each virtual tunnel network. ip rule add from all tunnel-id 100 lookup 100 ip rule add from all tunnel-id 200 lookup 200 Signed-off-by: Thomas Graf --- include/net/fib_rule

[ovs-dev] [net-next RFC 12/14] vxlan: remove indirect call to vxlan_rcv() and vni member

2015-06-01 Thread Thomas Graf
With the removal of the special treating of OVS VXLAN vports, the indirect call to vxlan_rcv() can be avoided and the VNI member in vxlan_metadata can be removed. Signed-off-by: Thomas Graf --- drivers/net/vxlan.c | 225 +--- include/net/vxlan.h |

[ovs-dev] [net-next RFC 05/14] route: Per route tunnel metadata with RTA_TUNNEL

2015-06-01 Thread Thomas Graf
Introduces a new Netlink attribute RTA_TUNNEL which allows routes to set tunnel transmit metadata and specify the tunnel endpoint or tunnel id on a per route basis. The route must point to a tunnel device which understands per skb tunnel metadata and has been put into the respective mode. Signed-o

[ovs-dev] [net-next RFC 02/14] ip_tunnel: support per packet tunnel metadata

2015-06-01 Thread Thomas Graf
This allows to attach an ip_tunnel_info metadata structure to skbs via skb_shared_info to represent receive side tunnel information as well as transmit side encapsulation instructions. The new field is added to skb_shared_info as the field is typically immutable after it has been attached. A new f

[ovs-dev] [net-next RFC 04/14] route: Extend flow representation with tunnel key

2015-06-01 Thread Thomas Graf
Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to allow routes to match on tunnel metadata. For now, the tunnel id is added to flowi_tunnel which allows for routes to be bound to specific virtual tunnels. Signed-off-by: Thomas Graf --- include/net/flow.h | 7 +++

[ovs-dev] [net-next RFC 10/14] openvswitch: Abstract vport name through ovs_vport_name()

2015-06-01 Thread Thomas Graf
This allows to get rid of the get_name() vport ops later on. Signed-off-by: Thomas Graf --- net/openvswitch/datapath.c | 4 ++-- net/openvswitch/vport-internal_dev.c | 1 - net/openvswitch/vport-netdev.c | 6 -- net/openvswitch/vport-netdev.h | 1 - net/openvswitch/vpor

[ovs-dev] up your business

2015-06-01 Thread Sam
Need new customers? We can help your business by our email services. Please reply for pricing and proposal. Looking forward to your soonest reply. Best regards Sam Email: jamm...@sina.com ___ dev mailing list dev@openvswitch.org http://openvswitch.org/

[ovs-dev] [ovsdb speedup v4 3/3] ovsdb-monitor: add json cache

2015-06-01 Thread Andy Zhou
Although multiple jsonrpc monitors can share the same ovsdb monitor, each change still needs to translated into json object from scratch. This can be wasteful if multiple jsonrpc monitors are interested in the same changes. Json cache improves this by keeping an copy of json object generated for t

[ovs-dev] [ovsdb speedup v4 2/3] ovsdb-monitor: allow multiple jsonrpc monitors to share a single ovsdb monitor

2015-06-01 Thread Andy Zhou
Store ovsdb monitor in a global hmap. If a newly created ovsdb monitor object monitors the same tables and columns as an existing one, the existing monitor will be reused. With this patch, jsonrpc monitor and ovsdb monitor now have N:1 mapping. The goals are to: 1) Reduce the cost of maintaining d

[ovs-dev] [ovsdb speedup v4 1/3] ovsdb-monitor: refactor ovsdb_monitor_create()

2015-06-01 Thread Andy Zhou
Add ovsdb_monitor_add_jsonrpc_monitor(). This change will allow ovsdb_monitor to be reference counted. Signed-off-by: Andy Zhou Acked-by: Ben Pfaff --- v1->v2: style fixes v2->v3: no change v3->v4: Fix a bug that introduced memory leak. With this fix, this patch becomes trival, and could be mer

Re: [ovs-dev] [ovsdb speedup v3 19/19] ovsdb-monitor: add json cache

2015-06-01 Thread Andy Zhou
On Fri, May 29, 2015 at 1:05 PM, Ben Pfaff wrote: > On Thu, Apr 09, 2015 at 06:40:28PM -0700, Andy Zhou wrote: >> Although multiple jsonrpc monitor can share the same ovsdb monitor, each >> change still needs to transalted into json object from scratch. This >> can be wastful is mutiple jsonrpc mo

[ovs-dev] [ovsdb speedup v4 0/3] improve ovsdb connection scaling

2015-06-01 Thread Andy Zhou
From last 19 part patch series, patches 1-16 has been acked and committed. The patches in this set are rework of original patch 17-19, based on review comments. Andy Zhou (3): ovsdb-monitor: refactor ovsdb_monitor_create() ovsdb-monitor: allow multiple jsonrpc monitors to share a single ovsd

Re: [ovs-dev] [ovsdb speedup v3 17/19] ovsdb-monitor: refactor ovsdb_monitor_create()

2015-06-01 Thread Andy Zhou
On Fri, May 29, 2015 at 12:15 PM, Ben Pfaff wrote: > On Thu, Apr 09, 2015 at 06:40:26PM -0700, Andy Zhou wrote: >> Add ovsdb_monitor_add_jsonrpc_monitor(). This change will allow >> ovsdb_monitor to be reference counted. >> >> Signed-off-by: Andy Zhou >> Acked-by: Ben Pfaff >> >> --- >> v1->v2:

[ovs-dev] Fwd: Payment Advice

2015-06-01 Thread HSBC Advising Service
Dear Customer, The attached payment advice is issued at the request of our customer. The advice is for your reference only. Yours faithfully, Global Payments and Cash Management HSBC *** This is an auto-generated ema