Re: [ovs-dev] [PATCH 2/5] datapath-windows: Correctly link newly allocated NBL

2015-05-06 Thread Sorin Vinturis
Hi Nithin, Thanks for your review on my two patches. Please ignore the fourth patch in series, ' [PATCH 4/5] datapath-windows: Multiple NBLs support for userspace forwarded packets', because it considers that OvsTcpSegmentNBL function returns a NET_BUFFET_LIST with multiple NBLs, which is incor

Re: [ovs-dev] [PATCH 2/5] datapath-windows: Correctly link newly allocated NBL

2015-05-06 Thread Nithin Raju
> On Apr 23, 2015, at 2:05 PM, Sorin Vinturis > wrote: > > OvsPartialCopyToMultipleNBLs function failed to correctly link the newly > created NBL with single NB to the multiple NBLs list. > > Signed-off-by: Sorin Vinturis > Co-authored-by: Alin Gabriel Serdean Acked-by: Nithin Raju ___

Re: [ovs-dev] [ovn] match: Fix compile of match initializer on GCC 4.6.1.

2015-05-06 Thread Justin Pettit
> On May 6, 2015, at 6:09 PM, Russell Bryant wrote: > > On 05/06/2015 06:29 PM, Justin Pettit wrote: >> GCC 4.6.1 complained about the match structure not being properly >> initialzed when using MATCH_CATCHALL_INITIALIZER macro. >> >> Signed-off-by: Justin Pettit > > I didn't get any complain

Re: [ovs-dev] [PATCH 1/5] datapath-windows: Added new function for native forwarded traffic

2015-05-06 Thread Nithin Raju
> On Apr 23, 2015, at 2:05 PM, Sorin Vinturis > wrote: > > Signed-off-by: Sorin Vinturis hi Sorin, Thanks for these patches. They are super important. This one looks good, but for a couple of minor comments. I’ll review the rest of them too. Acked-by: Nithin Raju > @@ -255,10 +235,30 @@

Re: [ovs-dev] [ovn] match: Fix compile of match initializer on GCC 4.6.1.

2015-05-06 Thread Russell Bryant
On 05/06/2015 06:29 PM, Justin Pettit wrote: > GCC 4.6.1 complained about the match structure not being properly > initialzed when using MATCH_CATCHALL_INITIALIZER macro. > > Signed-off-by: Justin Pettit I didn't get any complaints with gcc 4.9.2, but it still builds fine with the change, so: A

Re: [ovs-dev] [PATCH ovn v2] controller: Set chassis for container port.

2015-05-06 Thread Justin Pettit
Thanks! I pushed it to "ovn". --Justin > On May 5, 2015, at 7:30 PM, Russell Bryant wrote: > > ovn-controller updates the chassis column of the Bindings table in > OVN_Southbound when a logical port appears on the local switch. A > logical port that has a parent will never appear on a switch

[ovs-dev] [ovn] match: Fix compile of match initializer on GCC 4.6.1.

2015-05-06 Thread Justin Pettit
GCC 4.6.1 complained about the match structure not being properly initialzed when using MATCH_CATCHALL_INITIALIZER macro. Signed-off-by: Justin Pettit --- lib/match.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/match.h b/lib/match.h index 638c49d..10aa0af 100644

Re: [ovs-dev] [PATCH] lldp: Fix clang warning.

2015-05-06 Thread Joe Stringer
On 6 May 2015 at 14:41, Joe Stringer wrote: > Clang-3.7 generates warnings such as the following: > ../lib/ovs-lldp.c:394:19: error: address of array 'hardware->h_ifname' > will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] > > This value is fetched from a netdev, which as far as I

[ovs-dev] [PATCH] lldp: Fix clang warning.

2015-05-06 Thread Joe Stringer
Clang-3.7 generates warnings such as the following: ../lib/ovs-lldp.c:394:19: error: address of array 'hardware->h_ifname' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] This value is fetched from a netdev, which as far as I can tell must always have a non-NULL name. Simplify t

Re: [ovs-dev] [PATCH net-next V8 2/2] openvswitch: 802.1ad: Flow handling, actions, and parsing

2015-05-06 Thread Pravin Shelar
On Tue, May 5, 2015 at 8:51 AM, Thomas F Herbert wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. > > Signed-off-by: Thomas F Herbert > --- > net/openvswitch/actions.c | 6 ++- > net/openvswitch/flow.c | 83 ++

[ovs-dev] [PATCH 1/3] dpctl: Add OVS_PRINTF_FORMAT annotation to dpctl_* functions.

2015-05-06 Thread Daniele Di Proietto
Signed-off-by: Daniele Di Proietto --- lib/dpctl.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/dpctl.c b/lib/dpctl.c index a9a56ff..0f21a51 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -60,6 +60,11 @@ struct dpctl_command { dpctl_command_handler *handler

[ovs-dev] [PATCH 3/3] dpctl: Ignore enumeration errors if there is at least one datapath.

2015-05-06 Thread Daniele Di Proietto
When dpctl commands are used to inspect a userspace datapath, but OVS has also built-in support for the kernel datapath, an error message is reported if the kernel module is not loaded. This commit suppresses the message. Suggested-by: Ethan Jackson Signed-off-by: Daniele Di Proietto --- lib/d

[ovs-dev] [PATCH 2/3] dpctl: Factor out common code to iterate through all dpifs.

2015-05-06 Thread Daniele Di Proietto
This commit introduces dps_for_each() which calls a callback for each datapath of each registered type. Signed-off-by: Daniele Di Proietto --- lib/dpctl.c | 109 +++- 1 file changed, 49 insertions(+), 60 deletions(-) diff --git a/lib/dpctl

[ovs-dev] Natural aphrodisiacs have helped hundreds of people solve their problems!

2015-05-06 Thread Jo
Once again you’ll be sporting massive boners in your pants You won’t believe how big your boner gets now Everything you need is on our site! Free pills right now! http://zzb.bz/lwaLN Buy discount medications ___ dev mailing list dev@openvswitch.o