Re: [ovs-dev] [PATCH v7] datapath: Add Stateless TCP Tunneling protocol.

2015-04-20 Thread Jesse Gross
On Mon, Apr 20, 2015 at 7:33 PM, Pravin Shelar wrote: > On Mon, Apr 20, 2015 at 5:56 PM, Jesse Gross wrote: >> On Mon, Apr 20, 2015 at 3:54 PM, Pravin Shelar wrote: >>> On Mon, Apr 20, 2015 at 3:36 PM, Jesse Gross wrote: On Mon, Apr 20, 2015 at 1:29 PM, Pravin B Shelar wrote: >

Re: [ovs-dev] [PATCH] datapath: Provide alternate name for setup_udp_tunnel_sock()

2015-04-20 Thread Alex Wang
On Mon, Apr 20, 2015 at 8:41 PM, Tuan Nguyen wrote: > Hi Alex Wang, > > I tried two patches in your link, but the bug "export duplicate symbol" > still happened. > > Does I still need a patch for > "/datapath/linux/compat/include/net/udp_tunnel.h": > > +#define setup_udp_tunnel_sock rpl_setup_udp

Re: [ovs-dev] [PATCH] datapath: Provide alternate name for setup_udp_tunnel_sock()

2015-04-20 Thread Tuan Nguyen
Hi Alex Wang, I tried two patches in your link, but the bug "export duplicate symbol" still happened. Does I still need a patch for "/datapath/linux/compat/include/net/udp_tunnel.h": +#define setup_udp_tunnel_sock rpl_setup_udp_tunnel_sock ... +#define udp_tunnel_xmit_skb rpl_udp_tunnel_xmit_skb

Re: [ovs-dev] [PATCH v7] datapath: Add Stateless TCP Tunneling protocol.

2015-04-20 Thread Pravin Shelar
On Mon, Apr 20, 2015 at 5:56 PM, Jesse Gross wrote: > On Mon, Apr 20, 2015 at 3:54 PM, Pravin Shelar wrote: >> On Mon, Apr 20, 2015 at 3:36 PM, Jesse Gross wrote: >>> On Mon, Apr 20, 2015 at 1:29 PM, Pravin B Shelar wrote: diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/st

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-20 Thread Kevin Lo
On Fri, Apr 17, 2015 at 08:02:28AM -0700, Gurucharan Shetty wrote: > > > > > I know some of you are concerned about it will break build on Windows. > > The diff below fixes pthread linking on FreeBSD. > > Tested on Linux, NetBSD, and FreeBSD. > You can also check whether it builds successfully on

Re: [ovs-dev] [PATCH 2/2] bridge: Remove redundant call to discover_types().

2015-04-20 Thread Ben Pfaff
On Tue, Apr 14, 2015 at 11:46:48AM -0400, Russell Bryant wrote: > On 04/14/2015 11:16 AM, Ben Pfaff wrote: > > On Wed, Mar 25, 2015 at 10:25:51PM -0700, Ben Pfaff wrote: > >> Signed-off-by: Ben Pfaff > > > > This still needs a review, thanks! > > Looks good. The call removed from bridge_reconfi

Re: [ovs-dev] [PATCH] FAQ: Refine discussion of how to get a kernel module.

2015-04-20 Thread Ben Pfaff
On Mon, Apr 20, 2015 at 08:45:41PM -0400, Russell Bryant wrote: > On 04/16/2015 01:49 PM, Ben Pfaff wrote: > > This has come up a couple of times lately. > > > > Signed-off-by: Ben Pfaff > > --- > > FAQ.md | 25 + > > 1 file changed, 17 insertions(+), 8 deletions(-) > >

Re: [ovs-dev] [PATCH] bridge: Remove unused macro OFP_PORT_ACTION_WINDOW.

2015-04-20 Thread Ben Pfaff
On Mon, Apr 20, 2015 at 08:44:11PM -0400, Russell Bryant wrote: > On 04/16/2015 12:01 PM, Ben Pfaff wrote: > > I guess that this was missed when the corresponding feature was removed. > > > > Reported-by: David Evans > > Signed-off-by: Ben Pfaff > > --- > > AUTHORS | 1 + > > vswitch

Re: [ovs-dev] [PATCH v7] datapath: Add Stateless TCP Tunneling protocol.

2015-04-20 Thread Jesse Gross
On Mon, Apr 20, 2015 at 3:54 PM, Pravin Shelar wrote: > On Mon, Apr 20, 2015 at 3:36 PM, Jesse Gross wrote: >> On Mon, Apr 20, 2015 at 1:29 PM, Pravin B Shelar wrote: >>> diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c >>> new file mode 100644 >>> index 000..209bf1a >>

Re: [ovs-dev] [PATCH] FAQ: Refine discussion of how to get a kernel module.

2015-04-20 Thread Russell Bryant
On 04/16/2015 01:49 PM, Ben Pfaff wrote: > This has come up a couple of times lately. > > Signed-off-by: Ben Pfaff > --- > FAQ.md | 25 + > 1 file changed, 17 insertions(+), 8 deletions(-) Makes sense to me. Acked-by: Russell Bryant -- Russell Bryant

[ovs-dev] header files in the connection-tracking branch

2015-04-20 Thread pclin
Dear all, We are reading the source code in the private branch https://github.com/justinpettit/ovs/tree/conntrack, and find that some of the header files, such as net/netfilter/nf_conntrack_helper.h in conntrack.c, seem to be outdated (my apology if there is any misunderstanding). For

Re: [ovs-dev] [PATCH 2/2] in-band: Mention ofproto name in the VLOG.

2015-04-20 Thread Alex Wang
Thx, applied with suggested change,~ On Mon, Apr 20, 2015 at 3:55 PM, Ben Pfaff wrote: > On Mon, Apr 20, 2015 at 03:36:36PM -0700, Alex Wang wrote: > > This will help the debugging of in-band module. > > > > Signed-off-by: Alex Wang > > Acked-by: Ben Pfaff > > I think a colon would be more nat

Re: [ovs-dev] [PATCH] ovn-sb.xml: Make output to ingress port a no-op.

2015-04-20 Thread Russell Bryant
On 04/20/2015 06:11 PM, Ben Pfaff wrote: > This provides better alignment with OpenFlow semantics. > > Reported-by: Russell Bryant > Signed-off-by: Ben Pfaff > --- > ovn/ovn-sb.xml |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml > i

Re: [ovs-dev] [PATCH ovn pipeline 4/6] ovn: Add logical_datapath concept to schema.

2015-04-20 Thread Russell Bryant
On 04/20/2015 05:57 PM, Justin Pettit wrote: > Looks good. Thanks. Same here. The updates help a lot. Thanks! -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-04-20 Thread Nithin Raju
hi Sorin, I looked at your replies, and responded to the ones that required a response. I’ll await the next version of the patch. In general, we want to make sure the add/deletion workflow follows the pattern: a. During OVS_VPORT_CMD_NEW, tunnel vport does not “exist” until OvsTunnelVportPendin

Re: [ovs-dev] [PATCH 1/2] in-band: Do not use manager with loopback address for in-band control.

2015-04-20 Thread Ben Pfaff
On Mon, Apr 20, 2015 at 03:36:35PM -0700, Alex Wang wrote: > If the manager resides on the same host as ovs, the manager target will > be the loopback address. Then, if in-band is enabled on a bridge, the > in-band module will constantly checks the connection to the manager to > make sure the mana

Re: [ovs-dev] [PATCH 2/2] in-band: Mention ofproto name in the VLOG.

2015-04-20 Thread Ben Pfaff
On Mon, Apr 20, 2015 at 03:36:36PM -0700, Alex Wang wrote: > This will help the debugging of in-band module. > > Signed-off-by: Alex Wang Acked-by: Ben Pfaff I think a colon would be more natural than a comma as a delimiter, though. ___ dev mailing l

Re: [ovs-dev] [PATCH v7] datapath: Add Stateless TCP Tunneling protocol.

2015-04-20 Thread Pravin Shelar
On Mon, Apr 20, 2015 at 3:36 PM, Jesse Gross wrote: > On Mon, Apr 20, 2015 at 1:29 PM, Pravin B Shelar wrote: >> diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c >> new file mode 100644 >> index 000..209bf1a >> --- /dev/null >> +++ b/datapath/linux/compat/stt.c >> +stati

Re: [ovs-dev] [PATCH v3 2/2] datapath-windows: Removed assert from FilterNetPnPEvent handler

2015-04-20 Thread Ben Pfaff
Applied to master, thanks. On Wed, Apr 15, 2015 at 05:30:26PM +, Sorin Vinturis wrote: > I have removed an inappropriate assert from the FilterNetPnPEvent > routine, OvsExtNetPnPEvent. When NDIS calls the FilterNetPnPEvent > routine, the extension is in paused state and, obviously, the > switc

Re: [ovs-dev] [PATCH v3 1/2] datapath-windows: Enable extension after rrestart

2015-04-20 Thread Ben Pfaff
On Wed, Apr 15, 2015 at 05:30:26PM +, Sorin Vinturis wrote: > The extension failed to be activated during booting due to the > failure to initialize tunnel filter. This happened because the Base > Filtering Engine (BFE) is not started and no session to the engine > could be acquired. > > The s

Re: [ovs-dev] [PATCH] datapath: Provide alternate name for setup_udp_tunnel_sock()

2015-04-20 Thread Alex Wang
Thx Thomas, Tuan, Please refer to this thread for the converstaion about renaming and exporting all symbols. http://openvswitch.org/pipermail/dev/2015-April/054259.html I'll credit Tuan's work, Thanks, Alex Wang, On Mon, Apr 20, 2015 at 2:25 PM, Thomas Graf wrote: > On 04/20/15 at 06:33pm, T

Re: [ovs-dev] [PATCH v7] datapath: Add Stateless TCP Tunneling protocol.

2015-04-20 Thread Jesse Gross
On Mon, Apr 20, 2015 at 1:29 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c > new file mode 100644 > index 000..209bf1a > --- /dev/null > +++ b/datapath/linux/compat/stt.c > +static void update_headers(struct sk_buff *skb, bool head, > +

Re: [ovs-dev] [RFC 1/2] datapath: Fix unexported public functions in linux/compat/linux/.

2015-04-20 Thread Alex Wang
On Mon, Apr 20, 2015 at 2:21 PM, Thomas Graf wrote: > On 04/20/15 at 12:28pm, Alex Wang wrote: > > Thx a lot for the comments~ > > > > I think here are my todos: > > 1. prefix all public functions in the compat/include with rpl_ + and add > > checks > > to make sure. > > 2. export all rpl_* s

[ovs-dev] [PATCH 2/2] in-band: Mention ofproto name in the VLOG.

2015-04-20 Thread Alex Wang
This will help the debugging of in-band module. Signed-off-by: Alex Wang --- ofproto/in-band.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/ofproto/in-band.c b/ofproto/in-band.c index 902a86c..57af6d1 100644 --- a/ofproto/in-band.c +++ b/ofproto/in

[ovs-dev] [PATCH 1/2] in-band: Do not use manager with loopback address for in-band control.

2015-04-20 Thread Alex Wang
If the manager resides on the same host as ovs, the manager target will be the loopback address. Then, if in-band is enabled on a bridge, the in-band module will constantly checks the connection to the manager to make sure the manager is reachable. However, the connection checking implementation

Re: [ovs-dev] [PATCH] ovn-sb.xml: Make output to ingress port a no-op.

2015-04-20 Thread Ben Pfaff
Applied, thanks. On Mon, Apr 20, 2015 at 03:16:09PM -0700, Justin Pettit wrote: > Acked-by: Justin Pettit > > --Justin > > > > On Apr 20, 2015, at 3:11 PM, Ben Pfaff wrote: > > > > This provides better alignment with OpenFlow semantics. > > > > Reported-by: Russell Bryant > > Signed-off-by

Re: [ovs-dev] [PATCH] ovn-nb.xml: "true" match is actually expressed "1".

2015-04-20 Thread Ben Pfaff
Applied, thanks. On Mon, Apr 20, 2015 at 03:13:52PM -0700, Justin Pettit wrote: > Acked-by: Justin Pettit > > --Justin > > > > On Apr 20, 2015, at 2:51 PM, Ben Pfaff wrote: > > > > The original draft for the OVN expression language included "true" and > > 'false" keywords but later I changed

Re: [ovs-dev] [PATCH ovn pipeline 0/6] Generate basic Pipeline table.

2015-04-20 Thread Ben Pfaff
On Sat, Apr 18, 2015 at 10:04:32AM -0700, Ben Pfaff wrote: > This adds some basic support to ovn-northd for generating the contents of > the OVN_SB Pipeline table. > > Ben Pfaff (6): > json: New function json_string_escape(). > lex: Make token parameter of lex_token_format() const. > lex: Ne

[ovs-dev] [PATCH ovn pipeline v2] ovn-northd: Implement basic Pipeline generation.

2015-04-20 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- v1->v2: Dropped remainder of series because it was committed. ovn/northd/automake.mk |6 +- ovn/northd/ovn-northd.c | 345 +++ ovn/ovn-nb.xml | 14 +- 3 files changed, 358 insertions(+), 7 deletions(-) dif

Re: [ovs-dev] [PATCH] ovn-sb.xml: Make output to ingress port a no-op.

2015-04-20 Thread Justin Pettit
Acked-by: Justin Pettit --Justin > On Apr 20, 2015, at 3:11 PM, Ben Pfaff wrote: > > This provides better alignment with OpenFlow semantics. > > Reported-by: Russell Bryant > Signed-off-by: Ben Pfaff > --- > ovn/ovn-sb.xml |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > di

Re: [ovs-dev] [PATCH] ovn-nb.xml: "true" match is actually expressed "1".

2015-04-20 Thread Justin Pettit
Acked-by: Justin Pettit --Justin > On Apr 20, 2015, at 2:51 PM, Ben Pfaff wrote: > > The original draft for the OVN expression language included "true" and > 'false" keywords but later I changed them to "1" and "0" and forgot to > update this text. > > Signed-off-by: Ben Pfaff > --- > ovn/o

[ovs-dev] [PATCH] ovn-sb.xml: Make output to ingress port a no-op.

2015-04-20 Thread Ben Pfaff
This provides better alignment with OpenFlow semantics. Reported-by: Russell Bryant Signed-off-by: Ben Pfaff --- ovn/ovn-sb.xml |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml index c623cff..4238c5b 100644 --- a/ovn/ovn-sb.xml +++ b/ovn/o

Re: [ovs-dev] [PATCH ovn pipeline 6/6] ovn-northd: Implement basic Pipeline generation.

2015-04-20 Thread Ben Pfaff
On Mon, Apr 20, 2015 at 05:07:32PM -0400, Russell Bryant wrote: > In table 1, if "eth.dst[40]" matches, the output is all ports. Is that > intentional? Or should it be output to all ports except the source port? In OpenFlow, an output to the input port is implicitly dropped. This is commonly he

[ovs-dev] [PATCH] ovn-nb.xml: "true" match is actually expressed "1".

2015-04-20 Thread Ben Pfaff
The original draft for the OVN expression language included "true" and 'false" keywords but later I changed them to "1" and "0" and forgot to update this text. Signed-off-by: Ben Pfaff --- ovn/ovn-nb.xml |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/ovn-nb.xml b/ovn/

Re: [ovs-dev] [PATCH ovn pipeline 4/6] ovn: Add logical_datapath concept to schema.

2015-04-20 Thread Justin Pettit
Looks good. Thanks. Acked-by: Justin Pettit --Justin > On Apr 20, 2015, at 2:47 PM, Ben Pfaff wrote: > > On Mon, Apr 20, 2015 at 02:33:00PM -0700, Justin Pettit wrote: >> >>> On Apr 18, 2015, at 10:04 AM, Ben Pfaff wrote: >>> >>> + >>> + The logical datapath to which the logical

Re: [ovs-dev] [PATCH 0/3] Improve vport module handling

2015-04-20 Thread Thomas Graf
On 04/20/15 at 01:13pm, Ben Pfaff wrote: > On Tue, Apr 07, 2015 at 12:43:40PM +0200, Thomas Graf wrote: > > Thomas Graf (3): > > ovs-ctl: Unload & reload vport modules on force-reload-kmod > > ovs-dev: Hint that vport modules may need to be loaded manually > > NEWS: Leave a comment that vport

Re: [ovs-dev] [PATCH ovn pipeline 5/6] ovn-nb: Disallow priority 0 ACLs.

2015-04-20 Thread Ben Pfaff
On Mon, Apr 20, 2015 at 02:16:14PM -0700, Justin Pettit wrote: > > > On Apr 18, 2015, at 10:04 AM, Ben Pfaff wrote: > > > > diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml > > index 2d0632e..6985f5e 100644 > > --- a/ovn/ovn-nb.xml > > +++ b/ovn/ovn-nb.xml > > @@ -167,7 +167,7 @@ > > the highe

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-20 Thread Pravin Shelar
On Wed, Apr 15, 2015 at 12:03 AM, Panu Matilainen wrote: > On 04/14/2015 11:31 PM, Pravin Shelar wrote: >> >> On Thu, Mar 19, 2015 at 11:48 AM, Ciara Loftus >> wrote: >>> >>> This patch adds support for a new port type to the userspace datapath >>> called dpdkvhostuser. It adds to the existing in

Re: [ovs-dev] [PATCH ovn pipeline 6/6] ovn-northd: Implement basic Pipeline generation.

2015-04-20 Thread Russell Bryant
On 04/18/2015 01:04 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > ovn/northd/automake.mk | 6 +- > ovn/northd/ovn-northd.c | 345 > > ovn/ovn-nb.xml | 14 +- > 3 files changed, 358 insertions(+), 7 deletions(-) I haven't fi

Re: [ovs-dev] [PATCH ovn pipeline 4/6] ovn: Add logical_datapath concept to schema.

2015-04-20 Thread Ben Pfaff
On Mon, Apr 20, 2015 at 03:45:09PM -0400, Russell Bryant wrote: > On 04/18/2015 01:04 PM, Ben Pfaff wrote: > > It's possible that we could implement all of the OVN concepts as a single > > collection of flow tables, but it makes more sense to me if we instead > > represent each logical switch and l

Re: [ovs-dev] [PATCH ovn pipeline 4/6] ovn: Add logical_datapath concept to schema.

2015-04-20 Thread Ben Pfaff
On Mon, Apr 20, 2015 at 02:33:00PM -0700, Justin Pettit wrote: > > > On Apr 18, 2015, at 10:04 AM, Ben Pfaff wrote: > > > > + > > + The logical datapath to which the logical port belongs. A logical > > + datapath implements a logical pipeline among the ports in the > + table

Re: [ovs-dev] [PATCH ovn pipeline 4/6] ovn: Add logical_datapath concept to schema.

2015-04-20 Thread Justin Pettit
> On Apr 18, 2015, at 10:04 AM, Ben Pfaff wrote: > > + > + The logical datapath to which the logical port belongs. A logical > + datapath implements a logical pipeline among the ports in the + table="Bindings"/> table associated with it. (No table represents a > + logi

Re: [ovs-dev] [PATCH] datapath: Provide alternate name for setup_udp_tunnel_sock()

2015-04-20 Thread Thomas Graf
On 04/20/15 at 06:33pm, Tuan Nguyen wrote: > Hi Thomas Graf, > > Thanks for your help, I tried this patch and got a same bug with functions: > udp_tunnel_xmit_skb, udp_tunnel_sock_release > . > I tried to fix like your patch and all work well now. Thanks for testing! It looks like Alex is going t

Re: [ovs-dev] [RFC 1/2] datapath: Fix unexported public functions in linux/compat/linux/.

2015-04-20 Thread Thomas Graf
On 04/20/15 at 12:28pm, Alex Wang wrote: > Thx a lot for the comments~ > > I think here are my todos: > 1. prefix all public functions in the compat/include with rpl_ + and add > checks > to make sure. > 2. export all rpl_* symbols + add check to make sure all rpl_* are exported. My concerns

Re: [ovs-dev] [PATCH ovn pipeline 5/6] ovn-nb: Disallow priority 0 ACLs.

2015-04-20 Thread Justin Pettit
> On Apr 18, 2015, at 10:04 AM, Ben Pfaff wrote: > > diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml > index 2d0632e..6985f5e 100644 > --- a/ovn/ovn-nb.xml > +++ b/ovn/ovn-nb.xml > @@ -167,7 +167,7 @@ > the highest- matching row in this table > determines a packet's treatment. If no ro

Re: [ovs-dev] [PATCH ovn pipeline 4/6] ovn: Add logical_datapath concept to schema.

2015-04-20 Thread Russell Bryant
On 04/18/2015 01:04 PM, Ben Pfaff wrote: > It's possible that we could implement all of the OVN concepts as a single > collection of flow tables, but it makes more sense to me if we instead > represent each logical switch and logical router separately. This also > fits the model described in T. Ko

[ovs-dev] [PATCH v7] datapath: Add Stateless TCP Tunneling protocol.

2015-04-20 Thread Pravin B Shelar
The Stateless TCP Tunnel (STT) protocol encapsulates traffic in IPv4/TCP packets. STT uses TCP segmentation offload available in most of NIC. On packet xmit STT driver appends STT header along with TCP header to the packet. For GSO packet GSO parameters are set according to tunnel configuration and

[ovs-dev] [PATCH ovn] ovn*.xml: Convert tabs to spaces.

2015-04-20 Thread Russell Bryant
These files used both tabs and spaces for indentation. Convert all of the tabs to spaces for consistency. Signed-off-by: Russell Bryant --- ovn/ovn-architecture.7.xml | 68 - ovn/ovn-nb.xml | 34 ++--- ovn/ovn-sb.xml | 340 ++

Re: [ovs-dev] [PATCH ovn] ovn-sb.xml: Remove duplicate "physical".

2015-04-20 Thread Ben Pfaff
On Mon, Apr 20, 2015 at 04:16:28PM -0400, Russell Bryant wrote: > I noticed this case where a description referred to "physical physical > flows." Remove the duplicate instance of "physical". > > Signed-off-by: Russell Bryant I applied this, thanks. _

[ovs-dev] [PATCH ovn] ovn-sb.xml: Remove duplicate "physical".

2015-04-20 Thread Russell Bryant
I noticed this case where a description referred to "physical physical flows." Remove the duplicate instance of "physical". Signed-off-by: Russell Bryant --- ovn/ovn-sb.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml index e4159db..e30

Re: [ovs-dev] [PATCH 0/3] Improve vport module handling

2015-04-20 Thread Ben Pfaff
On Tue, Apr 07, 2015 at 12:43:40PM +0200, Thomas Graf wrote: > Thomas Graf (3): > ovs-ctl: Unload & reload vport modules on force-reload-kmod > ovs-dev: Hint that vport modules may need to be loaded manually > NEWS: Leave a comment that vports are now separate kernel modules I'm not sure of

Re: [ovs-dev] [PATCH 5/5] dpif-netdev: Reset RSS hash when recirculating.

2015-04-20 Thread Ethan Jackson
I don't really like this. For one thing, Suppose in a particular stage no changes to the packet are made. There's a good chance you'll recompute the same hash and still collide. What if instead, in the emc code if the depth > 0, you folded it into the hash for the lookup? Very simple change tha

Re: [ovs-dev] [PATCH 1/1] docs: Clarify bonding of DPDK enabled interfaces.

2015-04-20 Thread Ben Pfaff
On Tue, Apr 14, 2015 at 11:10:43AM +0100, Billy O'Mahony wrote: > Unlike system interfaces, DPDK enabled interfaces must have their interface > type explicitly set when used to create bonded ports. Mention this at the > relevant points in the documentation. > > Signed-off-by: Billy O'Mahony I s

Re: [ovs-dev] [PATCH 4/5] dpif-netdev: Batch packets when recirculating.

2015-04-20 Thread Ethan Jackson
Looks like a big win. Acked-by: Ethan Jackson On Wed, Apr 15, 2015 at 11:11 AM, Daniele Di Proietto wrote: > Now that we have per packet metadata, there's no need to split packet > batches when recirculating. > > Signed-off-by: Daniele Di Proietto > --- > lib/dpif-netdev.c | 29 +

Re: [ovs-dev] [PATCH 3/5] dp-packet: Rename 'dp_hash' in 'rss_hash'.

2015-04-20 Thread Ethan Jackson
Acked-by: Ethan Jackson On Wed, Apr 15, 2015 at 11:11 AM, Daniele Di Proietto wrote: > We already have the 'dp_hash' embedded in the metadata. This caused > confusion in the code. With this commit it should be clear that > 'rss_hash' is the packet hash used for internal purposes, while > 'md.

Re: [ovs-dev] [PATCH v4] netlink-socket: Exit NL transaction loop when EINVAL is returned

2015-04-20 Thread Ben Pfaff
On Wed, Apr 15, 2015 at 08:22:01PM +, Sorin Vinturis wrote: > The nl_sock_transact_multiple function enters in an infinite loop, > when invalid error, EINVAL, is returned by nl_sock_transact_multiple__. > EINVAL is the error returned by the latter function when a driver > request fails. > > v2

Re: [ovs-dev] [PATCH ovn pipeline 5/6] ovn-nb: Disallow priority 0 ACLs.

2015-04-20 Thread Russell Bryant
On 04/18/2015 01:04 PM, Ben Pfaff wrote: > We need to have a priority-0 logical datapath flow to act as a catch-all. > The easiest way to make sure that it doesn't overlap with NB-provided ACLs > is to prohibit them from using priority 0. > > Maybe we should restrict ACLs to some smaller range of

Re: [ovs-dev] [PATCH 2/5] dpif-netdev: Cache time_msec() calls for each received batch.

2015-04-20 Thread Ethan Jackson
Acked-by: Ethan Jackson On Wed, Apr 15, 2015 at 11:11 AM, Daniele Di Proietto wrote: > Calling time_msec() (which calls clock_gettime()) too often might be > expensive. With this commit OVS makes only one call per received > batch and caches the result. > > Suggested-by: Ethan Jackson > Signe

[ovs-dev] [PATCHv3] DPDK: add support for v2.0.0

2015-04-20 Thread Mark Kavanagh
Update relevant artifacts to add support for DPDK v2.0.0 - INSTALL.DPDK.md - travis build script - acinclude.m4: add 'mssse3' flag to OVS_CFLAGS - netdev-dpdk: fix build with unified offload types in DPDK v2.0.0 Note that this breaks compatibility with DPDK v1.8.0 v1: - update DPDK version &

Re: [ovs-dev] [PATCH] vlog.c: Avoid duplicating log message in rsyslog if enabling syslog-target

2015-04-20 Thread Ben Pfaff
After speaking to the author of the current code, it works as it does because of a concern that the connection to the remote syslog might be unreliable, that the remote data is harder to get at, and that it's harder to see it in the context of other messages logged on the local system, so that the

Re: [ovs-dev] [PATCH 1/5] dpif-netdev: Store actions data and size contiguously.

2015-04-20 Thread Ethan Jackson
I'll merge this shortly. Acked-by: Ethan Jackson On Wed, Apr 15, 2015 at 11:11 AM, Daniele Di Proietto wrote: > As stated by the comment above the structure, the 'action' pointer does not > change during the 'dp_netdev_actions' lifetime: we might as well embed > the pointed memory into the stru

Re: [ovs-dev] [PATCH ovn pipeline 3/6] lex: New function lex_format_to_string().

2015-04-20 Thread Russell Bryant
On 04/18/2015 01:04 PM, Ben Pfaff wrote: > First used in an upcoming commit. > > Signed-off-by: Ben Pfaff Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH ovn pipeline 2/6] lex: Make token parameter of lex_token_format() const.

2015-04-20 Thread Russell Bryant
On 04/18/2015 01:04 PM, Ben Pfaff wrote: > It wasn't ever modified, this was just overlooked. > > Signed-off-by: Ben Pfaff Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/de

Re: [ovs-dev] [PATCH 1/1] auto-attach: Implement interface lldp disable and re-enable

2015-04-20 Thread Ben Pfaff
On Wed, Apr 15, 2015 at 11:53:56AM -0400, drfl...@avaya.com wrote: > From: Dennis Flynn > > This commit completes the implementation of the lldp enable > option. Specifically after enabling lldp on a particular interface, lldp can > now be disabled and subsequently re-enabled. OVS will not transm

Re: [ovs-dev] [RFC 1/2] datapath: Fix unexported public functions in linux/compat/linux/.

2015-04-20 Thread Alex Wang
Thx a lot for the comments~ I think here are my todos: 1. prefix all public functions in the compat/include with rpl_ + and add checks to make sure. 2. export all rpl_* symbols + add check to make sure all rpl_* are exported. Thanks, Alex Wang, On Mon, Apr 20, 2015 at 10:54 AM, Ben Pfaff wr

Re: [ovs-dev] [PATCH ovn pipeline 1/6] json: New function json_string_escape().

2015-04-20 Thread Russell Bryant
On 04/18/2015 01:04 PM, Ben Pfaff wrote: > This saves some cut-and-paste duplicated code elsewhere and will have > additional users in upcoming commits. > > Signed-off-by: Ben Pfaff Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev

Re: [ovs-dev] [PATCH] dpctl.at: Fix failures on BSDs

2015-04-20 Thread Ben Pfaff
Hmm, not sure how this corrupted second copy of my email came about, please ignore this copy. On Mon, Apr 20, 2015 at 12:11:49PM -0700, Ben Pfaff wrote: > ct: Re: [ovs-dev] [PATCH] dpctl.at: Fix failures on BSDs > Message-ID: <20150420191149.gh15...@nicira.com> > References: <1429241888-8013-1-git

Re: [ovs-dev] [PATCH ovn 1/2 v7] ovn-nbctl: Updates for container integration.

2015-04-20 Thread Russell Bryant
On 04/20/2015 01:32 PM, Justin Pettit wrote: > >> On Apr 20, 2015, at 9:56 AM, Russell Bryant wrote: >> >> @@ -58,8 +59,13 @@ Logical switch commands:\n\ >> \n\ >> Logical port commands:\n\ >> lport-add LSWITCH LPORT add logical port LPORT on LSWITCH\n\ >> + lport-add LSWITCH LPORT PARENT TA

Re: [ovs-dev] [PATCH] dpctl.at: Fix failures on BSDs

2015-04-20 Thread Ben Pfaff
On Fri, Apr 17, 2015 at 12:38:08PM +0900, YAMAMOTO Takashi wrote: > Unfortunately ENODEV has different string representations > among platforms. > > References: > > > http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/sys/errno.h?rev=1.40&content-type=text/x-cvsweb-markup&only_with_tag=MAIN >

[ovs-dev] [PATCH 3/3] Sample to automate build installer

2015-04-20 Thread Alin Serdean
This commit is a POC on how to build the installer from the command line. One could issue the following commands to build the binaries, driver and installer. ./boot.sh;./configure CC=./build-aux/cccl LD="`which link`" LIBS="-lws2_32" \ --prefix="C:/openvswitch/usr" --localstatedir="C:/openvswit

[ovs-dev] [PATCH 2/3] Add file to .gitignore

2015-04-20 Thread Alin Serdean
Add testsuite.tmp.orig to .gitignore Signed-off-by: Alin Gabriel Serdean --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index e37a690..8f0d41f 100644 --- a/.gitignore +++ b/.gitignore @@ -66,3 +66,4 @@ _debian odp-netlink.h OvsDpInterface.h /.vagran

[ovs-dev] Come and F$ck Me!

2015-04-20 Thread Foster
All cool girls call you a shmuck? A blow job from any chick you want http://zzb.bz/FY5Ld ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH V2] configure.ac: fix pthread linking on FreeBSD

2015-04-20 Thread Ben Pfaff
On Sun, Apr 19, 2015 at 01:48:06AM +0800, Kevin Lo wrote: > The configure script checks for the existence of pthread_sigmask. > However, on FreeBSD, libc contains no-op stubs for many of the > pthread_* functions. As a result, the AC_SEARCH_LIBS macro returns > "none required". > > As an alte

Re: [ovs-dev] [RFC 1/2] datapath: Fix unexported public functions in linux/compat/linux/.

2015-04-20 Thread Ben Pfaff
On Mon, Apr 20, 2015 at 10:53:44AM -0700, Jesse Gross wrote: > On Mon, Apr 20, 2015 at 10:47 AM, Ben Pfaff wrote: > > On Mon, Apr 20, 2015 at 10:07:54AM -0700, Alex Wang wrote: > >> On Mon, Apr 20, 2015 at 1:17 AM, Thomas Graf > >> wrote: > >> > >> > On 04/19/15 at 10:15pm, Alex Wang wrote: > >>

Re: [ovs-dev] [RFC 1/2] datapath: Fix unexported public functions in linux/compat/linux/.

2015-04-20 Thread Jesse Gross
On Mon, Apr 20, 2015 at 10:47 AM, Ben Pfaff wrote: > On Mon, Apr 20, 2015 at 10:07:54AM -0700, Alex Wang wrote: >> On Mon, Apr 20, 2015 at 1:17 AM, Thomas Graf >> wrote: >> >> > On 04/19/15 at 10:15pm, Alex Wang wrote: >> > > With the latest change of separating vports into their own modules, >>

Re: [ovs-dev] [RFC 1/2] datapath: Fix unexported public functions in linux/compat/linux/.

2015-04-20 Thread Ben Pfaff
On Mon, Apr 20, 2015 at 10:07:54AM -0700, Alex Wang wrote: > On Mon, Apr 20, 2015 at 1:17 AM, Thomas Graf > wrote: > > > On 04/19/15 at 10:15pm, Alex Wang wrote: > > > With the latest change of separating vports into their own modules, > > > it is necessary to export all public functions in linux

Re: [ovs-dev] [PATCH] ovs-ofctl: Fix documentation of burst_size.

2015-04-20 Thread Ben Pfaff
Thanks, applied to master. On Mon, Apr 20, 2015 at 10:36:42AM -0700, Justin Pettit wrote: > This is an improvement over just the argument being wrong. Thanks! > > Acked-by: Justin Pettit > > --Justin > > > > On Apr 20, 2015, at 8:45 AM, Ben Pfaff wrote: > > > > Reported-by: Kentaro Ebisawa

Re: [ovs-dev] [PATCH] ovs-ofctl: Fix documentation of burst_size.

2015-04-20 Thread Justin Pettit
This is an improvement over just the argument being wrong. Thanks! Acked-by: Justin Pettit --Justin > On Apr 20, 2015, at 8:45 AM, Ben Pfaff wrote: > > Reported-by: Kentaro Ebisawa > Signed-off-by: Ben Pfaff > --- > utilities/ovs-ofctl.8.in | 8 +--- > 1 file changed, 5 insertions(+),

Re: [ovs-dev] [PATCH ovn 1/2 v7] ovn-nbctl: Updates for container integration.

2015-04-20 Thread Justin Pettit
> On Apr 20, 2015, at 9:56 AM, Russell Bryant wrote: > > @@ -58,8 +59,13 @@ Logical switch commands:\n\ > \n\ > Logical port commands:\n\ > lport-add LSWITCH LPORT add logical port LPORT on LSWITCH\n\ > + lport-add LSWITCH LPORT PARENT TAG\n\ > +add logical port

Re: [ovs-dev] [RFC 1/2] datapath: Fix unexported public functions in linux/compat/linux/.

2015-04-20 Thread Alex Wang
On Mon, Apr 20, 2015 at 1:17 AM, Thomas Graf wrote: > On 04/19/15 at 10:15pm, Alex Wang wrote: > > With the latest change of separating vports into their own modules, > > it is necessary to export all public functions in linux/compat/linux/. > > This will prevent the linker error when vport modul

[ovs-dev] [PATCH ovn 0/2 v7] Updates for container integration.

2015-04-20 Thread Russell Bryant
v1->v2: - Tweaks to ovn-nbctl as suggested by Justin - Update ovn-nbd to handle changes to parent and tag on a logical port after it is first created v2->v3: - After more discussion, change lport-list back to not including the parent_name and tag in its output. - Rebase on top of commit t

[ovs-dev] [PATCH ovn 1/2 v7] ovn-nbctl: Updates for container integration.

2015-04-20 Thread Russell Bryant
Add support for specifying a parent port name and tag when creating logical ports. Also add commands for getting the parent_name or tag set on a logical port. These are necessary for dealing with container interfaces that sit behind normal interfaces. Signed-off-by: Russell Bryant --- ovn/ovn-

[ovs-dev] [PATCH ovn 2/2 v7] ovn-northd: Update Bindings for container integration.

2015-04-20 Thread Russell Bryant
ovn-northd updates the Bindings table of the OVN database when there are updates to the OVN_Northbound database. This update makes ovn-northd copy over the container integration related fields from OVN_Northbound into the Bindings table. Signed-off-by: Russell Bryant Acked-by: Justin Pettit ---

Re: [ovs-dev] [PATCH ovn 1/2 v6] ovn-nbctl: Updates for container integration.

2015-04-20 Thread Russell Bryant
On 04/17/2015 05:55 PM, Justin Pettit wrote: > >> On Apr 17, 2015, at 1:17 PM, Russell Bryant wrote: > > Looks good, just some minor things. > >> Logical Port Commands >> >> - lport-add lswitch lport >> + lport-add lswitch lport >> [parent] [tag] >> >> Creates

[ovs-dev] It is difficult to admit but when you face erectile dysfunction every single second matters!

2015-04-20 Thread Michele
Erectile dysfunction is not the problem to worry about in the 21st century! All our regular customers get a 20% discount for all men's health medications on sale this month! On our site all the necessary for you pharmaceuticals! http://zzb.bz/5LGeu Buy World pfizer viagra cheap _

[ovs-dev] [PATCHv2] DPDK: add support for v2.0.0

2015-04-20 Thread Mark Kavanagh
Update relevant artifacts to add support for DPDK v2.0.0 - INSTALL.DPDK.md - travis build script - acinclude.m4: add 'mssse3' flag to OVS_CFLAGS - netdev-dpdk: fix build with unified offload types in DPDK v2.0.0 Note that this breaks compatibility with DPDK v1.8.0 v1: - update DPDK version &

Re: [ovs-dev] [PATCH] DPDK: add support for v2.0.0

2015-04-20 Thread Kavanagh, Mark B
>-Original Message- >From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Kavanagh, Mark B >Sent: Wednesday, April 8, 2015 10:26 PM >To: Daniele Di Proietto >Cc: dev@openvswitch.org; Butler, Siobhan A >Subject: Re: [ovs-dev] [PATCH] DPDK: add support for v2.0.0 > >>Thanks for the p

Re: [ovs-dev] [PATCH] DPDK: add support for v2.0.0

2015-04-20 Thread Kavanagh, Mark B
>-Original Message- >From: Panu Matilainen [mailto:pmati...@redhat.com] >Sent: Thursday, April 9, 2015 8:23 AM >To: Kavanagh, Mark B; dev@openvswitch.org >Subject: Re: [PATCH] DPDK: add support for v2.0.0 > >On 04/08/2015 06:34 PM, Mark Kavanagh wrote: >> Update relevant artifacts to add

[ovs-dev] [PATCH] ovs-ofctl: Fix documentation of burst_size.

2015-04-20 Thread Ben Pfaff
Reported-by: Kentaro Ebisawa Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.8.in | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index ea3337b..c667aa4 100644 --- a/utilities/ovs-ofctl.8.in +++ b/utilities/ovs-ofct

[ovs-dev] Many studies are held to show evidence that smoking may be a major cause of erectile dysfunction.

2015-04-20 Thread Donovan
Boost your husband's sexual energy and enjoy him as never before! Buy our men's drug! Boost your power! Have sex whenever you want! Just check out our stock! http://zzb.bz/xMwch Only World licensed remedies ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] kernel oops while doing OVN testing

2015-04-20 Thread Russell Bryant
On 04/20/2015 04:35 AM, Thomas Graf wrote: > On 04/17/15 at 01:56pm, Russell Bryant wrote: >> This is the openvswitch module that came with the following Fedora >> kernel: 3.19.1-201.fc21.x86_64 >> >> I can easily reproduce this. It happens when running devstack multiple >> times to stand up OpenS

Re: [ovs-dev] [PATCH] datapath: Provide alternate name for setup_udp_tunnel_sock()

2015-04-20 Thread Tuan Nguyen
Hi Thomas Graf, Thanks for your help, I tried this patch and got a same bug with functions: udp_tunnel_xmit_skb, udp_tunnel_sock_release . I tried to fix like your patch and all work well now. --- a/datapath/linux/compat/include/net/udp_tunnel.h +++ b/datapath/linux/compat/include/net/udp_tunnel.

Re: [ovs-dev] kernel oops while doing OVN testing

2015-04-20 Thread Thomas Graf
On 04/17/15 at 01:56pm, Russell Bryant wrote: > This is the openvswitch module that came with the following Fedora > kernel: 3.19.1-201.fc21.x86_64 > > I can easily reproduce this. It happens when running devstack multiple > times to stand up OpenStack + OVS + OVN + OpenStack Neutron OVN > integr

[ovs-dev] [PATCH] datapath: Provide alternate name for setup_udp_tunnel_sock()

2015-04-20 Thread Thomas Graf
On 04/20/15 at 10:16am, Thomas Graf wrote: > On 04/20/15 at 11:25am, Tuan Nguyen wrote: > > Hi Ben, > > > > I tried with newest openvswitch in github ( > > https://github.com/openvswitch/ovs) with OpenWrt version in trunk. > > When kernel booting, it shows: > > openvswitch: exports duplic

Re: [ovs-dev] [RFC 1/2] datapath: Fix unexported public functions in linux/compat/linux/.

2015-04-20 Thread Thomas Graf
On 04/19/15 at 10:15pm, Alex Wang wrote: > With the latest change of separating vports into their own modules, > it is necessary to export all public functions in linux/compat/linux/. > This will prevent the linker error when vport modules use those > functions in the future. e.g., the to be merged

Re: [ovs-dev] OpenvSwitch on kernel 3.18.x

2015-04-20 Thread Thomas Graf
On 04/20/15 at 11:25am, Tuan Nguyen wrote: > Hi Ben, > > I tried with newest openvswitch in github ( > https://github.com/openvswitch/ovs) with OpenWrt version in trunk. > When kernel booting, it shows: > openvswitch: exports duplicate symbol setup_udp_tunnel_sock (owned > by udp_tunnel)