[ovs-dev] test

2015-02-13 Thread Mail Administrator
The original message was received at Sat, 14 Feb 2015 09:45:58 +0800 from 116.186.176.207 - The following addresses had permanent fatal errors - ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH/RFC v2 2/8] Add types for NMX selection method

2015-02-13 Thread Ben Pfaff
On Fri, Feb 13, 2015 at 06:20:40PM -0500, Simon Horman wrote: > On Fri, Feb 13, 2015 at 01:51:54PM -0800, Ben Pfaff wrote: > > On Fri, Jan 30, 2015 at 11:41:50AM +0900, Simon Horman wrote: > > > NMX selection method > > > Signed-off-by: Simon Horman > > > > > > --- > > > * v2 > > > Use array of T

Re: [ovs-dev] [PATCH/RFC v2 2/8] Add types for NMX selection method

2015-02-13 Thread Simon Horman
On Fri, Feb 13, 2015 at 01:51:54PM -0800, Ben Pfaff wrote: > On Fri, Jan 30, 2015 at 11:41:50AM +0900, Simon Horman wrote: > > NMX selection method > > Signed-off-by: Simon Horman > > > > --- > > * v2 > > Use array of TLVs rather than OF1.1 match for fields field of > > NMX selection method prope

Re: [ovs-dev] [PATCH/RFC v2 3/8] Support decoding of NMX selection method

2015-02-13 Thread Simon Horman
On Fri, Feb 13, 2015 at 02:55:58PM -0800, Ben Pfaff wrote: > On Fri, Jan 30, 2015 at 11:41:51AM +0900, Simon Horman wrote: > > This is in preparation for supporting group mod and desc reply > > messages with an NMX selection method group experimenter property. > > > > NMX selection method > > Sign

Re: [ovs-dev] [PATCH/RFC v2 3/8] Support decoding of NMX selection method

2015-02-13 Thread Ben Pfaff
On Fri, Jan 30, 2015 at 11:41:51AM +0900, Simon Horman wrote: > This is in preparation for supporting group mod and desc reply > messages with an NMX selection method group experimenter property. > > NMX selection method > Signed-off-by: Simon Horman > > --- > v2 Use list of struct field_array o

Re: [ovs-dev] [PATCH] ofp-parse: Correctly update bucket lists if they are empty

2015-02-13 Thread Ben Pfaff
On Thu, Jan 29, 2015 at 07:48:38AM +0900, Simon Horman wrote: > On Wed, Jan 28, 2015 at 11:33:05PM +0100, Thomas Graf wrote: > > On 01/28/15 at 01:22pm, Ben Pfaff wrote: > > > Are you sure? What *gms points to, that is, **gms, is freed, but *gms > > > should still point to the same location. list

[ovs-dev] [PATCH] ofp-parse: Correctly update bucket lists if they are empty.

2015-02-13 Thread Ben Pfaff
Previously, list_moved() only worked with non-empty lists, but this was a caveat that was really easy to miss. parse_ofp_group_mod_file() had a bug because it didn't honor that restriction. This commit fixes the problem, by modifying the list_moved() interface to be harder to use incorrectly and

Re: [ovs-dev] Failed to install openvswitch

2015-02-13 Thread Salvatore Mazzarino
modinfo openvswitch.ko filename: openvswitch.ko version:2.3.1 license:GPL description:Open vSwitch switching datapath srcversion: 9D3DB83C0348C936CAD217F depends:libcrc32c,gre vermagic: 3.10.68-11.el6.centos.alt.x86_64 SMP mod_unload modversions > On 13

Re: [ovs-dev] [PATCH/RFC v2 2/8] Add types for NMX selection method

2015-02-13 Thread Ben Pfaff
On Fri, Jan 30, 2015 at 11:41:50AM +0900, Simon Horman wrote: > NMX selection method > Signed-off-by: Simon Horman > > --- > * v2 > Use array of TLVs rather than OF1.1 match for fields field of > NMX selection method property I'm a little surprised that no selection method names are defined in t

Re: [ovs-dev] [PATCH 6/6] ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS

2015-02-13 Thread Ben Pfaff
On Wed, Feb 04, 2015 at 04:45:11PM +0100, Thomas Graf wrote: > From: Madhu Challa > > Introduces two new NXMs to represent VXLAN-GBP [0] fields. > > actions=load:0x10->NXM_NX_TUN_GBP_ID[],NORMAL > tun_gbp_id=0x10,actions=drop > > This enables existing VXLAN tunnels to carry security label >

Re: [ovs-dev] [PATCH] datapath-windows: Support for custom VXLAN tunnel port

2015-02-13 Thread Ben Pfaff
Great, thanks. On Fri, Feb 13, 2015 at 09:18:38PM +, Eitan Eliahu wrote: > Hi Ben, > Sorin plans to address some issues once he is back. > Thanks, > Eitan > > > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Eitan Eliahu > Sent: Wednesday, January 07

Re: [ovs-dev] [PATCH] datapath-windows: Support for custom VXLAN tunnel port

2015-02-13 Thread Eitan Eliahu
Hi Ben, Sorin plans to address some issues once he is back. Thanks, Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Eitan Eliahu Sent: Wednesday, January 07, 2015 1:16 PM To: Sorin Vinturis; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-w

Re: [ovs-dev] [PATCH] datapath-windows: Support for multiple VXLAN tunnels

2015-02-13 Thread Ben Pfaff
On Wed, Jan 21, 2015 at 10:23:18PM +, Sorin Vinturis wrote: > At the moment the OVS extension supports only one VXLAN tunnel that > is cached in the extension switch context. Replaced the latter > cached pointer with an array list that contains all VXLAN tunnel > vports. > > Signed-off-by: Sor

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: set_miimon should return EOPNOTSUPP

2015-02-13 Thread Ben Pfaff
On Fri, Feb 13, 2015 at 10:00:58AM +, Mark D. Gray wrote: > From: "Mark D. Gray" > > According to netdev-provider, this function should return > EOPNOTSUPP if not supported. > > Signed-off-by: Mark D. Gray Applied, thanks! ___ dev mailing list de

Re: [ovs-dev] [PATCH 2/3] netdev-dpdk: Fix typo

2015-02-13 Thread Ben Pfaff
On Fri, Feb 13, 2015 at 10:00:57AM +, Mark D. Gray wrote: > From: "Mark D. Gray" > > Signed-off-by: Mark D. Gray Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/3] ofproto-dpif: Fix whitespace and typo

2015-02-13 Thread Ben Pfaff
On Fri, Feb 13, 2015 at 10:00:56AM +, Mark D. Gray wrote: > From: "Mark D. Gray" > > Signed-off-by: Mark D. Gray Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Failed to install openvswitch

2015-02-13 Thread Pravin Shelar
On Fri, Feb 13, 2015 at 11:11 AM, Salvatore Mazzarino wrote: > The rpm I use (kmod-openvswitch) is generated by me through this command > > rpmbuild -bb \ > -D "kversion 3.10.68-11.el6.centos.alt.x86_64" \ > > -D "kflavors default" \ > rhel/openvswitch-kmod-rhel6.spec > ok, Can you pos

Re: [ovs-dev] Failed to install openvswitch

2015-02-13 Thread Salvatore Mazzarino
The rpm I use (kmod-openvswitch) is generated by me through this command rpmbuild -bb \ -D "kversion 3.10.68-11.el6.centos.alt.x86_64" \ -D "kflavors default" \ rhel/openvswitch-kmod-rhel6.spec > On 13 Feb 2015, at 20:05, Pravin Shelar wrote: > > On Fri, Feb 13, 2015 at 9:05 AM, S

Re: [ovs-dev] Failed to install openvswitch

2015-02-13 Thread Pravin Shelar
On Fri, Feb 13, 2015 at 9:05 AM, Salvatore Mazzarino wrote: > Maybe could be useful. > > All this commands have been executed on Centos6.5 with kernel > > 3.10.68-11.el6.centos.alt.x86_64 > to host xen hypervistor > > The repository where it has been downloaded is Xen4CentOS > I think you are usin

Re: [ovs-dev] [PATCH v2] tests: Enable running parallel unit tests for Windows.

2015-02-13 Thread Gurucharan Shetty
Thank you Eitan and Ben. I pushed this to master. On Fri, Feb 13, 2015 at 9:35 AM, Ben Pfaff wrote: > On Wed, Feb 11, 2015 at 06:00:23PM -0800, Gurucharan Shetty wrote: >> testsuite uses mkfifo in its job dispatcher that manages >> parallel unit tests. MinGW does not have a mkfifo. This >> result

Re: [ovs-dev] [PATCH v2] tests: Enable running parallel unit tests for Windows.

2015-02-13 Thread Ben Pfaff
On Wed, Feb 11, 2015 at 06:00:23PM -0800, Gurucharan Shetty wrote: > testsuite uses mkfifo in its job dispatcher that manages > parallel unit tests. MinGW does not have a mkfifo. This > results in unit tests running serially on Windows. Right > now it takes up to approximately 40 minutes to run all

Re: [ovs-dev] Markdown coding standard

2015-02-13 Thread Ben Pfaff
On Fri, Feb 13, 2015 at 05:28:34PM +, Finucane, Stephen wrote: > > On Thu, Feb 12, 2015 at 09:21:35PM +0100, Thomas Graf wrote: > > > On 02/12/15 at 05:37pm, Finucane, Stephen wrote: > > > > * Line limit? It's not necessary to wrap Markdown if you don't want > > to, but files seem to alternat

Re: [ovs-dev] [PATCH] docs: fix overlapping 'weak' edges in ovs-vswitchd.conf.db.5

2015-02-13 Thread Ben Pfaff
On Tue, Feb 10, 2015 at 09:20:12PM -0800, Shu Shen wrote: > Multiple weak edges between nodes at the same rank overlaps with each other in > a dot/graphviz diagram. The vswitchd.pic used in ovs-vswitchd.conf.db.5 > suffers > this problem. > > Removing "constraint=false" allows graphviz to rank th

Re: [ovs-dev] Markdown coding standard

2015-02-13 Thread Finucane, Stephen
> On Thu, Feb 12, 2015 at 09:21:35PM +0100, Thomas Graf wrote: > > On 02/12/15 at 05:37pm, Finucane, Stephen wrote: > > > * Line limit? It's not necessary to wrap Markdown if you don't want > to, but files seem to alternate between 72, 79 and 80+ quite a bit > > > > I basically did the minimum re

Re: [ovs-dev] Fwd: [ovs-discuss] OVS segfault in recirculation

2015-02-13 Thread Andy Zhou
Great! looking forward to the test results. On Fri, Feb 13, 2015 at 3:56 AM, Salvatore Cambria wrote: > Hi Andy, > > Yes, it makes a lot of sense! > > I applied the patch and I'm running my script again in order to test it. It > looks good so far! > I will leave the script running all across the

Re: [ovs-dev] [PATCH] meta-flow: Fix wrong parentheses.

2015-02-13 Thread Ben Pfaff
On Thu, Feb 12, 2015 at 09:47:32PM +0800, Kmindg wrote: > Bitwise not operator has higher precedence than Bitwise right shift > operator, so the MFF_IP_DSCP_SHIFTED case always returns true currently. > > Signed-off-by: Kmindg Thanks for the report. I don't see the problem yet. Can you help? H

Re: [ovs-dev] Markdown coding standard

2015-02-13 Thread Finucane, Stephen
> On 02/12/15 at 05:37pm, Finucane, Stephen wrote: > > I note that there are no coding standard for Markdown documents. Given > this, I have some questions: > > > > * What's the expected format for code blocks (multi-line and single- > line)? > > We haven't standardized on anything yet. Is there

Re: [ovs-dev] Failed to install openvswitch

2015-02-13 Thread Salvatore Mazzarino
Maybe could be useful. All this commands have been executed on Centos6.5 with kernel 3.10.68-11.el6.centos.alt.x86_64 to host xen hypervistor The repository where it has been downloaded is Xen4CentOS > On 13 Feb 2015, at 17:15, Gurucharan Shetty wrote: > > Pravin, > Does the kernel missing dep

Re: [ovs-dev] [PATCH] mac-learning: Implement per-port MAC learning fairness.

2015-02-13 Thread Ben Pfaff
Thanks Ethan and Alex (and Ronny). I applied this to master and backported it to branch-2.3, branch-2.1, and branch-2.0. On Thu, Feb 12, 2015 at 12:33:10PM -0800, Ethan Jackson wrote: > Solution seems clean, I'm happy with this as well. > > Acked-by: Ethan Jackson > > > On Thu, Feb 12, 2015 a

Re: [ovs-dev] [PATCH] mac-learning: Implement per-port MAC learning fairness.

2015-02-13 Thread Alex Wang
Thx a lot for the explanation, it is clear now! On Fri, Feb 13, 2015 at 8:44 AM, Ben Pfaff wrote: > On Thu, Feb 12, 2015 at 11:02:06AM -0800, Alex Wang wrote: > > > +struct mac_learning_port *mlport; > > > > > > Simple C question, why don't we need to forward declare the struct > > 'mac_lear

Re: [ovs-dev] [PATCH RFC v6 1/1] netdev-dpdk: add dpdk vhost ports

2015-02-13 Thread Traynor, Kevin
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Thursday, February 12, 2015 2:09 PM > To: Traynor, Kevin > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH RFC v6 1/1] netdev-dpdk: add dpdk vhost ports > Michael, thanks for the feedback - will look

Re: [ovs-dev] [PATCH] mac-learning: Implement per-port MAC learning fairness.

2015-02-13 Thread Ben Pfaff
On Thu, Feb 12, 2015 at 11:02:06AM -0800, Alex Wang wrote: > > +struct mac_learning_port *mlport; > > > Simple C question, why don't we need to forward declare the struct > 'mac_learning_port'? Forward declarations are only necessary in one weird C corner case: when the first use of the stru

Re: [ovs-dev] Error

2015-02-13 Thread Ben Pfaff
On Fri, Feb 13, 2015 at 11:27:48AM +0300, Amer wrote: > I am trying to change the size of VLAN tag, I have changed the size > parameters in pox and the size of VLAN-tci in > openveswitch/datapath/vlan.h and vlan.c > > However, I am still receiving the down error, my question is what > parameters s

Re: [ovs-dev] Markdown coding standard

2015-02-13 Thread Ben Pfaff
On Thu, Feb 12, 2015 at 09:21:35PM +0100, Thomas Graf wrote: > On 02/12/15 at 05:37pm, Finucane, Stephen wrote: > > * Line limit? It's not necessary to wrap Markdown if you don't want to, > > but files seem to alternate between 72, 79 and 80+ quite a bit > > I basically did the minimum required

Re: [ovs-dev] Failed to install openvswitch

2015-02-13 Thread Gurucharan Shetty
Pravin, Does the kernel missing dependencies make sense here? http://pastebin.com/M0kpGhqY On Fri, Feb 13, 2015 at 7:21 AM, Salvatore Mazzarino wrote: > hi > I have an issue during the installing of openvswitch on centos 6.5 > I have follewed the following guide > https://github.com/openvswitch/

[ovs-dev] Failed to install openvswitch

2015-02-13 Thread Salvatore Mazzarino
hi I have an issue during the installing of openvswitch on centos 6.5 I have follewed the following guide https://github.com/openvswitch/ovs/blob/master/INSTALL.RHEL.md here is what I get when I execute the last step of the above guide http://pastebin.com/bzLrnYsd the kmod-openvswitch-2.3.1-1.el

Re: [ovs-dev] Fwd: [ovs-discuss] OVS segfault in recirculation

2015-02-13 Thread Salvatore Cambria
Hi Andy, Yes, it makes a lot of sense! I applied the patch and I'm running my script again in order to test it. It looks good so far! I will leave the script running all across the weekend and I'll come back to you with my results on Monday. Thank you for your very fast response and for your

[ovs-dev] [PATCH 2/3] netdev-dpdk: Fix typo

2015-02-13 Thread Mark D. Gray
From: "Mark D. Gray" Signed-off-by: Mark D. Gray --- lib/netdev-provider.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-provider.h b/lib/netdev-provider.h index 3fdc732..e0b76fc 100644 --- a/lib/netdev-provider.h +++ b/lib/netdev-provider.h @@ -384,7 +384,7 @@

[ovs-dev] [PATCH 3/3] netdev-dpdk: set_miimon should return EOPNOTSUPP

2015-02-13 Thread Mark D. Gray
From: "Mark D. Gray" According to netdev-provider, this function should return EOPNOTSUPP if not supported. Signed-off-by: Mark D. Gray --- lib/netdev-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 391695f..aea2016 100644

[ovs-dev] [PATCH 1/3] ofproto-dpif: Fix whitespace and typo

2015-02-13 Thread Mark D. Gray
From: "Mark D. Gray" Signed-off-by: Mark D. Gray --- ofproto/ofproto-dpif.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 069f087..a18a67d 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -172

[ovs-dev] Error

2015-02-13 Thread Amer
Hello, I am trying to change the size of VLAN tag, I have changed the size parameters in pox and the size of VLAN-tci in openveswitch/datapath/vlan.h and vlan.c However, I am still receiving the down error, my question is what parameters should I modify in openveswitch code files to extend the