[ovs-dev] Fwd: [ovs-discuss] OVS segfault in recirculation

2015-02-12 Thread Andy Zhou
Does not mean to drop the list. -- Forwarded message -- From: Andy Zhou Date: Thu, Feb 12, 2015 at 3:42 PM Subject: Re: [ovs-discuss] OVS segfault in recirculation To: Salvatore Cambria Hi, Salvatore, I think I found a bug: hmap_remove needs to be protected by a lock. As you

Re: [ovs-dev] [PATCH 11/13] datapath: Allow building against 3.19.x

2015-02-12 Thread Thomas Graf
On 02/12/15 at 01:08pm, Andy Zhou wrote: > I agree. we now have the initial infrastructure to add more tests. > > In the meantime, the infrastructure can also use some improvements. > For example, it does not deal with kernel crash > very well. Any suggestions or past experiences in setting up k

Re: [ovs-dev] [PATCH 11/13] datapath: Allow building against 3.19.x

2015-02-12 Thread Andy Zhou
I agree. we now have the initial infrastructure to add more tests. In the meantime, the infrastructure can also use some improvements. For example, it does not deal with kernel crash very well. Any suggestions or past experiences in setting up kernel testing framework are welcome. On Wed, Feb

Re: [ovs-dev] [PATCH] mac-learning: Implement per-port MAC learning fairness.

2015-02-12 Thread Ethan Jackson
Solution seems clean, I'm happy with this as well. Acked-by: Ethan Jackson On Thu, Feb 12, 2015 at 11:02 AM, Alex Wang wrote: > Looks good to me, > > /* A MAC learning table entry. >> - * Guarded by owning 'mac_learning''s rwlock */ >> + * Guarded by owning 'mac_learning''s rwlock. */ >> str

Re: [ovs-dev] [PATCH] datapath: vxlan: Only set has-GBP bit in header if any other bits would be set

2015-02-12 Thread Thomas Graf
On 02/11/15 at 03:58pm, Pravin Shelar wrote: > On Mon, Feb 9, 2015 at 7:54 AM, Thomas Graf wrote: > > vxlan: Only set has-GBP bit in header if any other bits would be set > > > > This allows for a VXLAN-GBP socket to talk to a Linux VXLAN socket by > > not setting any of the bits. > >

Re: [ovs-dev] Markdown coding standard

2015-02-12 Thread Thomas Graf
On 02/12/15 at 05:37pm, Finucane, Stephen wrote: > I note that there are no coding standard for Markdown documents. Given this, > I have some questions: > > * What's the expected format for code blocks (multi-line and single-line)? We haven't standardized on anything yet. Is there an exciting

Re: [ovs-dev] [PATCH v2] lib/util.h: use types compatible with DWORD

2015-02-12 Thread Gurucharan Shetty
On Thu, Feb 12, 2015 at 10:53 AM, Nithin Raju wrote: > _BitScanForward() and friends are part of the Windows API and > take DWORD as parameter type. DWORD is defined to be 'unsigned long' > in Windows' header files. > > We call into these functions from within lib/util.h. Currently, we > pass argu

Re: [ovs-dev] [PATCH] mac-learning: Implement per-port MAC learning fairness.

2015-02-12 Thread Alex Wang
Looks good to me, /* A MAC learning table entry. > - * Guarded by owning 'mac_learning''s rwlock */ > + * Guarded by owning 'mac_learning''s rwlock. */ > struct mac_entry { > struct hmap_node hmap_node; /* Node in a mac_learning hmap. */ > time_t expires; /* Expiration time

[ovs-dev] [PATCH v2] lib/util.h: use types compatible with DWORD

2015-02-12 Thread Nithin Raju
_BitScanForward() and friends are part of the Windows API and take DWORD as parameter type. DWORD is defined to be 'unsigned long' in Windows' header files. We call into these functions from within lib/util.h. Currently, we pass arguments of type uint32_t which is type defined to 'unsigned int'. T

Re: [ovs-dev] [PATCH v2] tests: Enable running parallel unit tests for Windows.

2015-02-12 Thread Eitan Eliahu
Thanks! Acked-by: Eitan Eliahu -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Gurucharan Shetty Sent: Wednesday, February 11, 2015 6:00 PM To: dev@openvswitch.org Cc: Gurucharan Shetty Subject: [ovs-dev] [PATCH v2] tests: Enable running parallel unit tes

[ovs-dev] Markdown coding standard

2015-02-12 Thread Finucane, Stephen
I note that there are no coding standard for Markdown documents. Given this, I have some questions: * What's the expected format for code blocks (multi-line and single-line)? * Can we use GHFM-extensions (i.e. syntax-highlighted code fences) * Line limit? It's not necessary to wrap Markdown

Re: [ovs-dev] [PATCH RFC v6 1/1] netdev-dpdk: add dpdk vhost ports

2015-02-12 Thread Michael S. Tsirkin
On Thu, Feb 12, 2015 at 12:59:17PM +, Traynor, Kevin wrote: > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Wednesday, January 21, 2015 11:19 AM > > To: Traynor, Kevin > > Cc: dev@openvswitch.org > > Subject: Re: [ovs-dev] [PATCH RFC v6 1/1] netdev

[ovs-dev] [PATCH] meta-flow: Fix wrong parentheses.

2015-02-12 Thread Kmindg
Bitwise not operator has higher precedence than Bitwise right shift operator, so the MFF_IP_DSCP_SHIFTED case always returns true currently. Signed-off-by: Kmindg --- lib/meta-flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/meta-flow.c b/lib/meta-flow.c index 9ce4c

Re: [ovs-dev] [PATCH RFC v6 1/1] netdev-dpdk: add dpdk vhost ports

2015-02-12 Thread Traynor, Kevin
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Wednesday, January 21, 2015 11:19 AM > To: Traynor, Kevin > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH RFC v6 1/1] netdev-dpdk: add dpdk vhost ports > > On Thu, Jan 08, 2015 at 11:05:02PM +, K