Re: [ovs-dev] layer 3 ports and OVS_KEY_ATTR_PACKET_ETHERTYPE (was Re: [PATCH v8 5/5] datapath: add layer 3 support to ovs_packet_cmd_execute())

2015-02-02 Thread Lori Jakab
Sorry to insist, but can you guys (Jesse/Pravin/Jarno) please look at this and give your opinion so Thomas and I know how to proceed? -Lori On 01/23/2015 02:45 PM, Lori Jakab wrote: > On 1/20/15 12:52 PM, Thomas Morin wrote: >> Hi Jarno, Lori, >> >> On 12/10/2014 02:45 AM, Jarno Rajahalme wrote:

Re: [ovs-dev] [PATCH] vlog: Fix "/dev/log" test

2015-02-02 Thread YAMAMOTO Takashi
> On Sun, Feb 1, 2015 at 9:18 PM, YAMAMOTO Takashi > wrote: >> commit 7905aae3fc1633c2c44c8fdb9e9d3a3d6e63439b >> ("vlog: Don't fail syslog initialization in chroot.") >> uses os.path.isfile("/dev/log"), which tests if the given path >> is a regular file, to see if syslog can be usable. >> >> How

[ovs-dev] [ovs-discuss] Open vSwitch STT support

2015-02-02 Thread John Xiao
Thanks Pravin for sharing the patch. One question on STT IP, is it free to use STT in commercial products? I believe Nicira has patents on this. Thanks, John On Tue, Feb 3, 2015 at 5:34 AM, Pravin Shelar wrote: > On Mon, Feb 2, 2015 at 11:20 AM, John W. Linville > wrote: >> On Mon, Feb 02, 20

[ovs-dev] OFP14 set async config - dev query

2015-02-02 Thread Shashaankar Reddy
Hi Folks, I'm working on implementing OFP1.4 specific feature to set/get async configuration on a switch. From the code I understand that OFPTYPE_SET_ASYNC_CONFIG being referred to both nicira-xt and OFP13 messages: /* OFPRAW_NXT_SET_ASYNC_CONFIG. * OFPRAW_OFPT13_SET_ASYNC. */ The set async confi

Re: [ovs-dev] [PATCH] miniflow: Fix miniflow push of L4 port numbers.

2015-02-02 Thread Jarno Rajahalme
Thanks for the fix! Applied to the master with appropriate additions to the AUTHORS file, Jarno On Feb 2, 2015, at 3:11 PM, Traynor, Kevin wrote: > This patch is for the issue reported here > http://openvswitch.org/pipermail/dev/2015-January/050368.html. It's tested > for TCP and UDP. It w

Re: [ovs-dev] [PATCH] vlog: Fix "/dev/log" test

2015-02-02 Thread Gurucharan Shetty
On Sun, Feb 1, 2015 at 9:18 PM, YAMAMOTO Takashi wrote: > commit 7905aae3fc1633c2c44c8fdb9e9d3a3d6e63439b > ("vlog: Don't fail syslog initialization in chroot.") > uses os.path.isfile("/dev/log"), which tests if the given path > is a regular file, to see if syslog can be usable. > > However, /dev/

[ovs-dev] [PATCH] ofproto: add support of OFPR_ACTION_SET as packet-in reason for OF1.4+

2015-02-02 Thread Shu Shen
This patch adds support for OFPR_ACTION_SET as the packet-in reason when a Packet-In message is triggered by an output action within an action-set. By default reason code OFPR_ACTION_SET is enabled for async messages when Openflow 1.4+ is used. A test case is included. Signed-off-by: Shu Shen ---

Re: [ovs-dev] [PATCH] miniflow: Fix miniflow push of L4 port numbers.

2015-02-02 Thread Traynor, Kevin
This patch is for the issue reported here http://openvswitch.org/pipermail/dev/2015-January/050368.html. It's tested for TCP and UDP. It would have been slightly more efficient to replace the miniflow_push_words() with miniflow_push_words_32() and remove the explicit igmp_group_ipv4 padding, bu

[ovs-dev] [PATCH] ovs-dpctl: Do not report pmd info for 'dpif-netlink' datapath.

2015-02-02 Thread Alex Wang
In 'ovs-dpctl dump-flows' output, we should only report the pmd related info for 'dpif-netdev' datapath. However, current implementation also reports uninitialized pmd info for 'dpif-netlink' datapath, which is very confusing to users. This commit fixes it. Signed-off-by: Alex Wang --- lib/dpc

[ovs-dev] [PATCH] miniflow: Fix miniflow push of L4 port numbers.

2015-02-02 Thread Kevin Traynor
Replace a 64 bit copy of L4 src/dst ports that was also including additional packet params (e.g. TCP Seq Num). This was later resulting in all packets from the flow missing in the EMC. Signed-off-by: Kevin Traynor Reported-by: Ciara Loftus --- lib/flow.c |9 ++--- 1 files changed, 6 ins

Re: [ovs-dev] [ovs-discuss] Open vSwitch STT support

2015-02-02 Thread Pravin Shelar
On Mon, Feb 2, 2015 at 11:20 AM, John W. Linville wrote: > On Mon, Feb 02, 2015 at 10:55:25AM -0800, Pravin Shelar wrote: >> STT patches were posted on netdev mailing list, But it was rejected. >> As policy datapath patches must be accepted first in upstream kernel >> before ported to OVS repo. Bu

[ovs-dev] [PATCH] ovs-command-completion: Complete on file path by default.

2015-02-02 Thread Alex Wang
This commit makes the bash completion script complete on file path when there is no completion available. The unit tests are also adjusted accordingly. Signed-off-by: Alex Wang --- tests/completion.at| 25 --- utilities/ovs-command-compgen.bash | 62 +

Re: [ovs-dev] [PATCH] ofproto-dpif: Revalidate when sFlow probability changes.

2015-02-02 Thread Jarno Rajahalme
LGTM, Acked-by: Jarno Rajahalme On Jan 30, 2015, at 1:36 PM, Ben Pfaff wrote: > Until now, when the sFlow selection probability changed, OVS failed to > immediately revalidate the flow table, delaying the new probability taking > effect. This commit fixes the problem. > > Reported-by: K 華 >

[ovs-dev] Returned mail: see transcript for details

2015-02-02 Thread The Post Office
ݶÜ\ò¦7M%Ȑ,®(Z¨S(¦©fm…¡ššôñ0­`ꋺtýÁ ›3Þ\o·$7´¾g‹‘‘K\b¶‹^œ¤c2Ó4®¯´[ËN ™ÎŒ•Æô_ÊÁŠfšHQ‘ÊëžCÁͦIª„¯!™•.šq½ccžÂö×ÀREÍK%Z-Ðו¤%8Ý<üéRIË?÷ŽV>ÓBŽWÞ/—ψ6H?3ȯ‹ B•w¬aÓ$t&!çÆjß°,zÔ/–BLì¯S,.6˜ù‘è¥CôÂð0ú(rì&^d›AŚêRê-':˘Š 9„æmƒë•?(Ôh˜Žo –Ûdm}?I¹1¢m„NûŠˆ~§äP`Éۊžs–H-˜lډm¼~å¼ÃêÏ1› fÌ.Ò%Xp`.Ø`(sŠvõÊ)ÒnŠà

Re: [ovs-dev] [ovs-discuss] Open vSwitch STT support

2015-02-02 Thread John W. Linville
On Mon, Feb 02, 2015 at 10:55:25AM -0800, Pravin Shelar wrote: > STT patches were posted on netdev mailing list, But it was rejected. > As policy datapath patches must be accepted first in upstream kernel > before ported to OVS repo. But considering STT is well known protocol, > it is used in produ

[ovs-dev] Fwd: Error in openflow

2015-02-02 Thread Amer
Dear All, Thank you Justin I would like to change the size of VLAN tag in openveswitch. May you please help me in doing so. Where and what to change? Thank you Best regards, Amer Begin forwarded message: > From: Justin Pettit > Date: ٢ فبراير، ٢٠١٥ ٩:٣٢:٢٤ م جرينتش+٣ > To: Amer > Subject: R

[ovs-dev] Open vSwitch STT support

2015-02-02 Thread Pravin Shelar
STT patches were posted on netdev mailing list, But it was rejected. As policy datapath patches must be accepted first in upstream kernel before ported to OVS repo. But considering STT is well known protocol, it is used in production and it can be useful for community, we can make exception for STT

Re: [ovs-dev] OFPAT10_VENDOR and ofp-actions.c

2015-02-02 Thread Raul Suarez Marin
Solved. I finally know how it works. Sorry for the inconvenience. 2015-02-02 17:04 GMT+01:00 Raul Suarez Marin : > Hello, > > I am looking at decode_openflow10_action function at lib/ofp-actions.c. I > am trying to understand how the code is performed. I have been testing it, > but still no clue.

[ovs-dev] OFPAT10_VENDOR and ofp-actions.c

2015-02-02 Thread Raul Suarez Marin
Hello, I am looking at decode_openflow10_action function at lib/ofp-actions.c. I am trying to understand how the code is performed. I have been testing it, but still no clue. I provide, at the end, my "test code". My problem is that I have created a custom action with type = 0x000d, and I am try

Re: [ovs-dev] [PATCH] ofp-util: Issue error when OFPGC_DELETE command includes buckets.

2015-02-02 Thread Thomas Graf
On 01/30/15 at 02:24pm, Ben Pfaff wrote: > An OFPGC_DELETE command deletes a whole group, including all of its > buckets, and so it doesn't make sense for the command itself to include any > specification of buckets. > > ONF-JIRA: EXT-510 > Signed-off-by: Ben Pfaff LGTM Acked-by: Thomas Graf __

Re: [ovs-dev] [PATCH] NEWS: Mention group support in version 2.1.

2015-02-02 Thread Thomas Graf
On 02/01/15 at 01:50pm, Ben Pfaff wrote: > Someone asked about support and I realized that we forgot to mention it, > so do so belatedly. > > Signed-off-by: Ben Pfaff Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.or