[ovs-dev] [PATCH] travis: support versioning of DPDK and options to specify git repo and tag

2015-01-02 Thread Shu Shen
Use DPDK_VER to specify the version of DPDK, and DPDK_GIT to specify the URL of the DPDK git repository. Both flags require "DPDK=1" and "--with-dpdk" shall no longer be specified as part of "OPTS" environment. Example uses: - skip both flags to use v1.7.1 tarball from dpdk.org as before: KE

Re: [ovs-dev] [PATCH] datapath: Consistently include VLAN header in flow and port stats.

2015-01-02 Thread Pravin Shelar
On Fri, Jan 2, 2015 at 2:54 PM, Ben Pfaff wrote: > Until now, when VLAN acceleration was in use, the bytes of the VLAN header > were not included in port or flow byte counters. They were however > included when VLAN acceleration was not used. This commit corrects the > inconsistency, by always i

Re: [ovs-dev] [PATCH] datapath: Consistently include VLAN header in flow and port stats.

2015-01-02 Thread Pravin Shelar
On Fri, Jan 2, 2015 at 3:03 PM, Ben Pfaff wrote: > Pravin, you already acked this on netdev. This is the crossport to > the OVS tree. I didn't know whether the netdev ack was good enough to > just push to OVS too, so to play it safe I separately posted it for > review here. > It is good idea to

Re: [ovs-dev] [PATCH RFC] SECURITY: New document describing proposed security process for OVS.

2015-01-02 Thread Ben Pfaff
On Fri, Jan 02, 2015 at 01:44:49PM -0800, Ben Pfaff wrote: > Open vSwitch needs some kind of process for handling vulnerabilities. So > far, we've been pretty lucky that way, but it can't last forever, and I > think we'll be better off if we have at least the outline of an established > process wh

Re: [ovs-dev] [PATCH] configure: Omit -O2 from $CFLAGS when configuring with --enable-coverage.

2015-01-02 Thread Madhu Challa
sure, sounds good. Thanks. On Fri, Jan 2, 2015 at 3:06 PM, Ben Pfaff wrote: > I think it'd be best to do that as a separate patch, though, since I > would want to get a review from the Windows developers to make sure > that whatever we do doesn't screw up something on their end. > > On Fri, Jan

Re: [ovs-dev] [PATCH RFC] SECURITY: New document describing proposed security process for OVS.

2015-01-02 Thread Thomas Graf
On 01/02/15 at 03:01pm, Ben Pfaff wrote: > On Fri, Jan 02, 2015 at 11:53:26PM +0100, Thomas Graf wrote: > > Looks great. Do we want to include a couple of examples of what > > would classify as a vulnerability? > > Sure. Some that come randomly to mind: > > * A crafted packet that causes

Re: [ovs-dev] [PATCH] configure: Omit -O2 from $CFLAGS when configuring with --enable-coverage.

2015-01-02 Thread Ben Pfaff
I think it'd be best to do that as a separate patch, though, since I would want to get a review from the Windows developers to make sure that whatever we do doesn't screw up something on their end. On Fri, Jan 02, 2015 at 02:52:47PM -0800, Ben Pfaff wrote: > Hmm. Currently --with-debug has no eff

Re: [ovs-dev] [PATCH] datapath: Consistently include VLAN header in flow and port stats.

2015-01-02 Thread Ben Pfaff
Pravin, you already acked this on netdev. This is the crossport to the OVS tree. I didn't know whether the netdev ack was good enough to just push to OVS too, so to play it safe I separately posted it for review here. On Fri, Jan 02, 2015 at 02:54:50PM -0800, Ben Pfaff wrote: > Until now, when V

Re: [ovs-dev] [PATCH RFC] SECURITY: New document describing proposed security process for OVS.

2015-01-02 Thread Ben Pfaff
On Fri, Jan 02, 2015 at 11:53:26PM +0100, Thomas Graf wrote: > On 01/02/15 at 01:44pm, Ben Pfaff wrote: > > Open vSwitch needs some kind of process for handling vulnerabilities. So > > far, we've been pretty lucky that way, but it can't last forever, and I > > think we'll be better off if we have

[ovs-dev] [PATCH] datapath: Consistently include VLAN header in flow and port stats.

2015-01-02 Thread Ben Pfaff
Until now, when VLAN acceleration was in use, the bytes of the VLAN header were not included in port or flow byte counters. They were however included when VLAN acceleration was not used. This commit corrects the inconsistency, by always including the VLAN header in byte counters. Previous discu

Re: [ovs-dev] [PATCH RFC] SECURITY: New document describing proposed security process for OVS.

2015-01-02 Thread Thomas Graf
On 01/02/15 at 01:44pm, Ben Pfaff wrote: > Open vSwitch needs some kind of process for handling vulnerabilities. So > far, we've been pretty lucky that way, but it can't last forever, and I > think we'll be better off if we have at least the outline of an established > process whenever a significa

Re: [ovs-dev] [PATCH] configure: Omit -O2 from $CFLAGS when configuring with --enable-coverage.

2015-01-02 Thread Ben Pfaff
Hmm. Currently --with-debug has no effect at all outside of Windows. I agree, it would make sense to do the same thing. On Fri, Jan 02, 2015 at 02:50:58PM -0800, Madhu Challa wrote: > It would be nice if we have the same behavior for --with-debug as well. > Today the debug build adds -g -O2, I ma

Re: [ovs-dev] [PATCH] configure: Omit -O2 from $CFLAGS when configuring with --enable-coverage.

2015-01-02 Thread Madhu Challa
It would be nice if we have the same behavior for --with-debug as well. Today the debug build adds -g -O2, I manually change it to O0 since some of the local variables get optimized out otherwise. Thanks. On Fri, Jan 2, 2015 at 2:39 PM, Ben Pfaff wrote: > CFLAGS follows OVS_CFLAGS in the compil

Re: [ovs-dev] [PATCH net-next] openvswitch: Do not set skb ignore_df

2015-01-02 Thread Pravin Shelar
On Fri, Jan 2, 2015 at 12:03 PM, Jesse Gross wrote: > On Fri, Jan 2, 2015 at 1:27 PM, Pravin B Shelar wrote: >> Tunnel transmit code clear this bit, so setting ignore_df has >> no effect. >> >> Signed-off-by: Pravin B Shelar > > Is it actually right for the bit to be cleared though? As discussed

Re: [ovs-dev] [PATCH 0/7] Datapath backports to support 3.18.x, net, net-next

2015-01-02 Thread Ben Pfaff
On Fri, Jan 02, 2015 at 07:33:57PM +0100, Thomas Graf wrote: > On 12/31/14 at 01:14pm, Pravin Shelar wrote: > > I still do not see it. > > I'm resending the whole series as v2 with a changed commit message > to work around the spam filter. I do see patch 2 in version 2. __

Re: [ovs-dev] [PATCH 1/2] [RFC] Fix build flags when using code coverage

2015-01-02 Thread Ben Pfaff
On Fri, Jan 02, 2015 at 09:45:35PM +0100, Mijo Safradin wrote: > Currently multiple optimization flags are defined when building with > coverage support. Currently the coverage optimization -O0 flag gets > overruled by a later '-O2' setting. For coverage, only the default > flags for coverage sh

[ovs-dev] [PATCH] configure: Omit -O2 from $CFLAGS when configuring with --enable-coverage.

2015-01-02 Thread Ben Pfaff
CFLAGS follows OVS_CFLAGS in the compiler command line, and should, so that the user can override any automatically determined compiler options. That means that the -O0 that the code here added to OVS_CFLAGS didn't really have any effect since CFLAGS by default includes "-O2". However, we do real

[ovs-dev] [PATCH RFC] SECURITY: New document describing proposed security process for OVS.

2015-01-02 Thread Ben Pfaff
Open vSwitch needs some kind of process for handling vulnerabilities. So far, we've been pretty lucky that way, but it can't last forever, and I think we'll be better off if we have at least the outline of an established process whenever a significant vulnerability comes along. Here's my draft of

Re: [ovs-dev] [PATCH net] openvswitch: Consistently include VLAN header in flow and port stats.

2015-01-02 Thread David Miller
From: Ben Pfaff Date: Wed, 31 Dec 2014 08:45:46 -0800 > Until now, when VLAN acceleration was in use, the bytes of the VLAN header > were not included in port or flow byte counters. They were however > included when VLAN acceleration was not used. This commit corrects the > inconsistency, by al

Re: [ovs-dev] [PATCH net-next] openvswitch: Do not set skb ignore_df

2015-01-02 Thread Thomas Graf
On 01/02/15 at 03:03pm, Jesse Gross wrote: > On Fri, Jan 2, 2015 at 1:27 PM, Pravin B Shelar wrote: > > Tunnel transmit code clear this bit, so setting ignore_df has > > no effect. > > > > Signed-off-by: Pravin B Shelar > > Is it actually right for the bit to be cleared though? As discussed in >

Re: [ovs-dev] [PATCH net-next] openvswitch: Do not set skb ignore_df

2015-01-02 Thread Jesse Gross
On Fri, Jan 2, 2015 at 1:27 PM, Pravin B Shelar wrote: > Tunnel transmit code clear this bit, so setting ignore_df has > no effect. > > Signed-off-by: Pravin B Shelar Is it actually right for the bit to be cleared though? As discussed in the previous thread on tunnel MTU handling, I think that f

Re: [ovs-dev] [PATCH] ofproto: Omit hidden tables from "next tables".

2015-01-02 Thread Ben Pfaff
On Fri, Jan 02, 2015 at 07:25:18PM +0100, Thomas Graf wrote: > On 01/01/15 at 02:41pm, Ben Pfaff wrote: > > Hidden tables are intended to be concealed from OpenFlow, but their > > presence leaked through the "next tables" and "instructions" in the OF1.3+ > > table features reply. This fixes the pr

[ovs-dev] [PATCH 8/8] travis: Update build matrix to include latest stable kernels

2015-01-02 Thread Thomas Graf
Signed-off-by: Thomas Graf --- .travis.yml | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index b91327d..67354c7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,16 +7,17 @@ before_install: ./.travis/prepare.sh env: - OPTS="--

[ovs-dev] [PATCH 7/8] datapath: Account for new flags args of vxlan_sock_add()

2015-01-02 Thread Thomas Graf
The upstream commit 359a0ea ("vxlan: Add support for UDP checksums (v4 sending, v6 zero csums)") has introduced a new flags argument to vxlan_sock_add(). OVS does not pass any flags at this point, thus specyfing 0 will be compatible with both the old ipv6 bool and the new u32 flags argument. Upst

[ovs-dev] [PATCH 6/8] datapath: replace remaining users of arch_fast_hash with jhash

2015-01-02 Thread Thomas Graf
This patch effectively reverts commit 500f80872645 ("net: ovs: use CRC32 accelerated flow hash if available"), and other remaining arch_fast_hash() users such as from nfsd via commit 6282cd565553 ("NFSD: Don't hand out delegations for 30 seconds after recalling them.") where it has been used as a h

[ovs-dev] [PATCH 5/8] datapath: introduce rtnl ops stub

2015-01-02 Thread Thomas Graf
This stub now allows userspace to see IFLA_INFO_KIND for ovs master and IFLA_INFO_SLAVE_KIND for slave. Upstream: 5b9e7e16 ("openvswitch: introduce rtnl ops stub") Signed-off-by: Thomas Graf --- datapath/datapath.c | 9 - datapath/vport-internal_dev.c | 15 +++ dat

[ovs-dev] [PATCH 4/8] datapath: move vlan pop/push functions into common code

2015-01-02 Thread Thomas Graf
So it can be used from out of openvswitch code. Did couple of cosmetic changes on the way, namely variable naming and adding support for 8021AD proto. Note on backwards compatability: Unlike the upstream version, the backport of skb_vlan_push() does not support translating a hardware accelerated 8

[ovs-dev] [PATCH 3/8] datapath: move make_writable helper into common code

2015-01-02 Thread Thomas Graf
note that skb_make_writable already exists in net/netfilter/core.c but does something slightly different. Upstream: e219512 ("net: move make_writable helper into common code") Signed-off-by: Thomas Graf --- acinclude.m4 | 1 + datapath/actions.c

[ovs-dev] [PATCH 2/8] datapath: Add __vlan_insert_tag() compat helper if not available

2015-01-02 Thread Thomas Graf
Since older kernels do not have skb->vlan_proto, it is assumed that kernels which don't provide their own __vlan_insert_tag() will also not have skb->vlan_proto. The backwards compat function therefore only supports ETH_P_8021Q as the protocol type. Upstream: 15255a43 ("vlan: introduce __vlan_inse

[ovs-dev] [PATCH 0/7 v2] Datapath backports to support 3.18.x, net, net-next

2015-01-02 Thread Thomas Graf
This series includes several backports which affect the datapath and brings it closer to upstream. It also allows to build the datapath against current net and net-next kernels. v2: - Improved commit message of patch 2 - New patch to address arg changes to vxlan_sock_add() Thomas Graf (8): da

[ovs-dev] [PATCH 1/8] datapath: Account for rename to vlan_insert_tag_set_proto()

2015-01-02 Thread Thomas Graf
__vlan_put_tag() was renamed to vlan_insert_tag_set_proto() with the argument list kept intact. Upstream: 62749e ("vlan: rename __vlan_put_tag to vlan_insert_tag_set_proto") Signed-off-by: Thomas Graf --- acinclude.m4 | 1 + datapath/actions.c

Re: [ovs-dev] [PATCH 0/7] Datapath backports to support 3.18.x, net, net-next

2015-01-02 Thread Thomas Graf
On 12/31/14 at 01:14pm, Pravin Shelar wrote: > I still do not see it. I'm resending the whole series as v2 with a changed commit message to work around the spam filter. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH net-next] openvswitch: Do not set skb ignore_df

2015-01-02 Thread Pravin B Shelar
Tunnel transmit code clear this bit, so setting ignore_df has no effect. Signed-off-by: Pravin B Shelar --- net/openvswitch/vport-geneve.c |1 - net/openvswitch/vport-gre.c|2 -- net/openvswitch/vport-vxlan.c |2 -- 3 files changed, 0 insertions(+), 5 deletions(-) diff --git a/

Re: [ovs-dev] [PATCH] ofproto: Omit hidden tables from "next tables".

2015-01-02 Thread Thomas Graf
On 01/01/15 at 02:41pm, Ben Pfaff wrote: > Hidden tables are intended to be concealed from OpenFlow, but their > presence leaked through the "next tables" and "instructions" in the OF1.3+ > table features reply. This fixes the problem. > > Reported-by: "Ronaldo A. Ferreira" > Signed-off-by: Ben

Re: [ovs-dev] Support for Provider VLANs

2015-01-02 Thread Thomas F Herbert
Uzi, Do you mean qinq, 802.1ad or PBB, 802.1ah? If you mean qinq, I have submitted a patch and am working on another version now. --Tom On 1/1/15, 11:49 PM, Uzi Golan wrote: Hello can you please state what is the parameter to support prvider vlans on access port and i wish to make it as de

[ovs-dev] Need QA contact details of Openswitch

2015-01-02 Thread Lohit Prasad
Hi Team, I am intersted in OpenSwitch & found id in internet. Kindly provide me pointers if I can help in Testing as I am from QA background. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [RFC 0/2] Add support to control Reports forwarding

2015-01-02 Thread Ben Pfaff
On Wed, Dec 31, 2014 at 04:16:19PM -0200, Flavio Leitner wrote: > On Wednesday, December 31, 2014 08:52:56 AM Ben Pfaff wrote: > > On Thu, Dec 11, 2014 at 09:38:17AM -0200, Flavio Leitner wrote: > > > The RFC4541 section 2.1.1 item 1 allows the snooping switch > > > to provide an administrative con

Re: [ovs-dev] Support for Provider VLANs

2015-01-02 Thread Ben Pfaff
On Fri, Jan 02, 2015 at 06:49:59AM +0200, Uzi Golan wrote: > can you please state what is the parameter to support prvider vlans on > access port > > and i wish to make it as default behavior to any access port created on ovs > bridge If you're talking about PVLANs as described at http://en.wikip

Re: [ovs-dev] [PATCH 2/2] Ignore coverage data files

2015-01-02 Thread Ben Pfaff
On Fri, Jan 02, 2015 at 11:24:33AM +0100, Mijo Safradin wrote: > Add coverage specific data files to gitignore > > Signed-off-by: Mijo Safradin I applied this, thanks. I don't see patch 1/2, where is it? ___ dev mailing list dev@openvswitch.org http:/

Re: [ovs-dev] '27: test atomic operations' unit test hanging

2015-01-02 Thread Sharo, Randall A CIV SPAWARSYSCEN-ATLANTIC, 55200
UPDATE: With a fresh "apt-get dist-upgrade" on Ubuntu 14.10 and a fresh "git pull" on the openvswitch repo, the clang error and test #27 hangup are not reproducible on that platform. The test #27 hangup is still reproducible on CentOS 7 after a fresh "yum upgrade" and "git pull" on the openv

[ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-01-02 Thread Saloni Jain
From: Saloni Jain This commit enables the eviction mechanism on the basis of importance as per the openflow specification 1.4. ovs-ofctl -O OpenFlow14 mod-table evict -Enable eviction on of . Eviction adds a mechanism  enabling the switch to automatically eliminate entries of lower  i

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-01-02 Thread Saloni Jain
Hi Ben, Please find attached the updated patch for eviction feature, rebased with the latest ovs-master as on 02 Jan 2015. This patch has correct code indentation. Kindly review it and provide your comments/inputs. Thanks and Regards, Saloni Jain Tata Consultancy Services Mailto: saloni.j...

[ovs-dev] [PATCH 2/2] Ignore coverage data files

2015-01-02 Thread Mijo Safradin
Add coverage specific data files to gitignore Signed-off-by: Mijo Safradin --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 8201d50..50ec1d7 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,8 @@ #*# *.a *.d +*.gcno +*.gcda *.ko *.la *.lo