Use DPDK_VER to specify the version of DPDK, and DPDK_GIT to specify
the URL of the DPDK git repository.
Both flags require "DPDK=1" and "--with-dpdk" shall no longer be
specified as part of "OPTS" environment.
Example uses:
- skip both flags to use v1.7.1 tarball from dpdk.org as before:
KE
On Fri, Jan 2, 2015 at 2:54 PM, Ben Pfaff wrote:
> Until now, when VLAN acceleration was in use, the bytes of the VLAN header
> were not included in port or flow byte counters. They were however
> included when VLAN acceleration was not used. This commit corrects the
> inconsistency, by always i
On Fri, Jan 2, 2015 at 3:03 PM, Ben Pfaff wrote:
> Pravin, you already acked this on netdev. This is the crossport to
> the OVS tree. I didn't know whether the netdev ack was good enough to
> just push to OVS too, so to play it safe I separately posted it for
> review here.
>
It is good idea to
On Fri, Jan 02, 2015 at 01:44:49PM -0800, Ben Pfaff wrote:
> Open vSwitch needs some kind of process for handling vulnerabilities. So
> far, we've been pretty lucky that way, but it can't last forever, and I
> think we'll be better off if we have at least the outline of an established
> process wh
sure, sounds good.
Thanks.
On Fri, Jan 2, 2015 at 3:06 PM, Ben Pfaff wrote:
> I think it'd be best to do that as a separate patch, though, since I
> would want to get a review from the Windows developers to make sure
> that whatever we do doesn't screw up something on their end.
>
> On Fri, Jan
On 01/02/15 at 03:01pm, Ben Pfaff wrote:
> On Fri, Jan 02, 2015 at 11:53:26PM +0100, Thomas Graf wrote:
> > Looks great. Do we want to include a couple of examples of what
> > would classify as a vulnerability?
>
> Sure. Some that come randomly to mind:
>
> * A crafted packet that causes
I think it'd be best to do that as a separate patch, though, since I
would want to get a review from the Windows developers to make sure
that whatever we do doesn't screw up something on their end.
On Fri, Jan 02, 2015 at 02:52:47PM -0800, Ben Pfaff wrote:
> Hmm. Currently --with-debug has no eff
Pravin, you already acked this on netdev. This is the crossport to
the OVS tree. I didn't know whether the netdev ack was good enough to
just push to OVS too, so to play it safe I separately posted it for
review here.
On Fri, Jan 02, 2015 at 02:54:50PM -0800, Ben Pfaff wrote:
> Until now, when V
On Fri, Jan 02, 2015 at 11:53:26PM +0100, Thomas Graf wrote:
> On 01/02/15 at 01:44pm, Ben Pfaff wrote:
> > Open vSwitch needs some kind of process for handling vulnerabilities. So
> > far, we've been pretty lucky that way, but it can't last forever, and I
> > think we'll be better off if we have
Until now, when VLAN acceleration was in use, the bytes of the VLAN header
were not included in port or flow byte counters. They were however
included when VLAN acceleration was not used. This commit corrects the
inconsistency, by always including the VLAN header in byte counters.
Previous discu
On 01/02/15 at 01:44pm, Ben Pfaff wrote:
> Open vSwitch needs some kind of process for handling vulnerabilities. So
> far, we've been pretty lucky that way, but it can't last forever, and I
> think we'll be better off if we have at least the outline of an established
> process whenever a significa
Hmm. Currently --with-debug has no effect at all outside of Windows.
I agree, it would make sense to do the same thing.
On Fri, Jan 02, 2015 at 02:50:58PM -0800, Madhu Challa wrote:
> It would be nice if we have the same behavior for --with-debug as well.
> Today the debug build adds -g -O2, I ma
It would be nice if we have the same behavior for --with-debug as well.
Today the debug build adds -g -O2, I manually change it to O0 since some of
the local variables get optimized out otherwise.
Thanks.
On Fri, Jan 2, 2015 at 2:39 PM, Ben Pfaff wrote:
> CFLAGS follows OVS_CFLAGS in the compil
On Fri, Jan 2, 2015 at 12:03 PM, Jesse Gross wrote:
> On Fri, Jan 2, 2015 at 1:27 PM, Pravin B Shelar wrote:
>> Tunnel transmit code clear this bit, so setting ignore_df has
>> no effect.
>>
>> Signed-off-by: Pravin B Shelar
>
> Is it actually right for the bit to be cleared though? As discussed
On Fri, Jan 02, 2015 at 07:33:57PM +0100, Thomas Graf wrote:
> On 12/31/14 at 01:14pm, Pravin Shelar wrote:
> > I still do not see it.
>
> I'm resending the whole series as v2 with a changed commit message
> to work around the spam filter.
I do see patch 2 in version 2.
__
On Fri, Jan 02, 2015 at 09:45:35PM +0100, Mijo Safradin wrote:
> Currently multiple optimization flags are defined when building with
> coverage support. Currently the coverage optimization -O0 flag gets
> overruled by a later '-O2' setting. For coverage, only the default
> flags for coverage sh
CFLAGS follows OVS_CFLAGS in the compiler command line, and should, so that
the user can override any automatically determined compiler options. That
means that the -O0 that the code here added to OVS_CFLAGS didn't really
have any effect since CFLAGS by default includes "-O2". However, we do
real
Open vSwitch needs some kind of process for handling vulnerabilities. So
far, we've been pretty lucky that way, but it can't last forever, and I
think we'll be better off if we have at least the outline of an established
process whenever a significant vulnerability comes along. Here's my draft
of
From: Ben Pfaff
Date: Wed, 31 Dec 2014 08:45:46 -0800
> Until now, when VLAN acceleration was in use, the bytes of the VLAN header
> were not included in port or flow byte counters. They were however
> included when VLAN acceleration was not used. This commit corrects the
> inconsistency, by al
On 01/02/15 at 03:03pm, Jesse Gross wrote:
> On Fri, Jan 2, 2015 at 1:27 PM, Pravin B Shelar wrote:
> > Tunnel transmit code clear this bit, so setting ignore_df has
> > no effect.
> >
> > Signed-off-by: Pravin B Shelar
>
> Is it actually right for the bit to be cleared though? As discussed in
>
On Fri, Jan 2, 2015 at 1:27 PM, Pravin B Shelar wrote:
> Tunnel transmit code clear this bit, so setting ignore_df has
> no effect.
>
> Signed-off-by: Pravin B Shelar
Is it actually right for the bit to be cleared though? As discussed in
the previous thread on tunnel MTU handling, I think that f
On Fri, Jan 02, 2015 at 07:25:18PM +0100, Thomas Graf wrote:
> On 01/01/15 at 02:41pm, Ben Pfaff wrote:
> > Hidden tables are intended to be concealed from OpenFlow, but their
> > presence leaked through the "next tables" and "instructions" in the OF1.3+
> > table features reply. This fixes the pr
Signed-off-by: Thomas Graf
---
.travis.yml | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index b91327d..67354c7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -7,16 +7,17 @@ before_install: ./.travis/prepare.sh
env:
- OPTS="--
The upstream commit 359a0ea
("vxlan: Add support for UDP checksums (v4 sending, v6 zero csums)")
has introduced a new flags argument to vxlan_sock_add().
OVS does not pass any flags at this point, thus specyfing 0 will be
compatible with both the old ipv6 bool and the new u32 flags argument.
Upst
This patch effectively reverts commit 500f80872645 ("net: ovs: use CRC32
accelerated flow hash if available"), and other remaining arch_fast_hash()
users such as from nfsd via commit 6282cd565553 ("NFSD: Don't hand out
delegations for 30 seconds after recalling them.") where it has been used
as a h
This stub now allows userspace to see IFLA_INFO_KIND for ovs master and
IFLA_INFO_SLAVE_KIND for slave.
Upstream: 5b9e7e16 ("openvswitch: introduce rtnl ops stub")
Signed-off-by: Thomas Graf
---
datapath/datapath.c | 9 -
datapath/vport-internal_dev.c | 15 +++
dat
So it can be used from out of openvswitch code.
Did couple of cosmetic changes on the way, namely variable naming and
adding support for 8021AD proto.
Note on backwards compatability:
Unlike the upstream version, the backport of skb_vlan_push() does not
support translating a hardware accelerated 8
note that skb_make_writable already exists in net/netfilter/core.c
but does something slightly different.
Upstream: e219512 ("net: move make_writable helper into common code")
Signed-off-by: Thomas Graf
---
acinclude.m4 | 1 +
datapath/actions.c
Since older kernels do not have skb->vlan_proto, it is assumed that
kernels which don't provide their own __vlan_insert_tag() will also
not have skb->vlan_proto. The backwards compat function therefore
only supports ETH_P_8021Q as the protocol type.
Upstream: 15255a43 ("vlan: introduce __vlan_inse
This series includes several backports which affect the datapath
and brings it closer to upstream. It also allows to build the
datapath against current net and net-next kernels.
v2:
- Improved commit message of patch 2
- New patch to address arg changes to vxlan_sock_add()
Thomas Graf (8):
da
__vlan_put_tag() was renamed to vlan_insert_tag_set_proto() with
the argument list kept intact.
Upstream: 62749e ("vlan: rename __vlan_put_tag to vlan_insert_tag_set_proto")
Signed-off-by: Thomas Graf
---
acinclude.m4 | 1 +
datapath/actions.c
On 12/31/14 at 01:14pm, Pravin Shelar wrote:
> I still do not see it.
I'm resending the whole series as v2 with a changed commit message
to work around the spam filter.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Tunnel transmit code clear this bit, so setting ignore_df has
no effect.
Signed-off-by: Pravin B Shelar
---
net/openvswitch/vport-geneve.c |1 -
net/openvswitch/vport-gre.c|2 --
net/openvswitch/vport-vxlan.c |2 --
3 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/
On 01/01/15 at 02:41pm, Ben Pfaff wrote:
> Hidden tables are intended to be concealed from OpenFlow, but their
> presence leaked through the "next tables" and "instructions" in the OF1.3+
> table features reply. This fixes the problem.
>
> Reported-by: "Ronaldo A. Ferreira"
> Signed-off-by: Ben
Uzi,
Do you mean qinq, 802.1ad or PBB, 802.1ah? If you mean qinq, I have
submitted a patch and am working on another version now.
--Tom
On 1/1/15, 11:49 PM, Uzi Golan wrote:
Hello
can you please state what is the parameter to support prvider vlans on
access port
and i wish to make it as de
Hi Team,
I am intersted in OpenSwitch & found id in internet. Kindly provide me
pointers if I can help in Testing as I am from QA background.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Dec 31, 2014 at 04:16:19PM -0200, Flavio Leitner wrote:
> On Wednesday, December 31, 2014 08:52:56 AM Ben Pfaff wrote:
> > On Thu, Dec 11, 2014 at 09:38:17AM -0200, Flavio Leitner wrote:
> > > The RFC4541 section 2.1.1 item 1 allows the snooping switch
> > > to provide an administrative con
On Fri, Jan 02, 2015 at 06:49:59AM +0200, Uzi Golan wrote:
> can you please state what is the parameter to support prvider vlans on
> access port
>
> and i wish to make it as default behavior to any access port created on ovs
> bridge
If you're talking about PVLANs as described at
http://en.wikip
On Fri, Jan 02, 2015 at 11:24:33AM +0100, Mijo Safradin wrote:
> Add coverage specific data files to gitignore
>
> Signed-off-by: Mijo Safradin
I applied this, thanks.
I don't see patch 1/2, where is it?
___
dev mailing list
dev@openvswitch.org
http:/
UPDATE: With a fresh "apt-get dist-upgrade" on Ubuntu 14.10 and a fresh "git
pull" on the openvswitch repo, the clang error and test #27 hangup are not
reproducible on that platform.
The test #27 hangup is still reproducible on CentOS 7 after a fresh "yum
upgrade" and "git pull" on the openv
From: Saloni Jain
This commit enables the eviction mechanism on the basis of importance as
per the openflow specification 1.4.
ovs-ofctl -O OpenFlow14 mod-table evict
-Enable eviction on of . Eviction adds a mechanism
enabling the switch to automatically eliminate entries of lower
i
Hi Ben,
Please find attached the updated patch for eviction feature, rebased with the
latest ovs-master as on 02 Jan 2015.
This patch has correct code indentation. Kindly review it and provide your
comments/inputs.
Thanks and Regards,
Saloni Jain
Tata Consultancy Services
Mailto: saloni.j...
Add coverage specific data files to gitignore
Signed-off-by: Mijo Safradin
---
.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitignore b/.gitignore
index 8201d50..50ec1d7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,6 +1,8 @@
#*#
*.a
*.d
+*.gcno
+*.gcda
*.ko
*.la
*.lo
43 matches
Mail list logo