Re: [ovs-dev] [branch-2.3 V2] recirculation: Do not drop packet when there is no match from internal table.

2014-12-16 Thread YAMAMOTO Takashi
probably we can assign distinct pseudo odp port numbers for each userland-only ports like patch ports and make datapath accept them eg. for match. in that way, we can associate a packet in_port corresponding to the port for the recirculating bridge, rather than of the receiving bridge. YAMAMOTO T

[ovs-dev] OVS DPDK support technical direction

2014-12-16 Thread John Xiao
Hi, As we know that Intel stopped its effort on OVDK and OVS DPDK support will all be in OVS upstream, and I have one question after digging OVDK and OVS DPDK architecture: - IMHO, OVS DPDK support can follow the existing "fast/slow path" model as being done in OVS linux kernel, i.e. just another

Re: [ovs-dev] [branch-2.3 V2] recirculation: Do not drop packet when there is no match from internal table.

2014-12-16 Thread Andy Zhou
It seems recirculation action should be scoped within the same OF-bridge. On Tue, Dec 16, 2014 at 4:43 PM, Alex Wang wrote: > Hey Yamamoto, > > Justin and Ethan just raised the same question you asked, > > Yeah, there is an issue. If say, the vlan is set before recirc action, > the recirc'ed flo

[ovs-dev] [PATCH] revalidator: Don't delete non-existent flow.

2014-12-16 Thread Joe Stringer
If ukey_acquire() returns ENOENT, then it is unable to locate the ukey corresponding to the flow and the flow has disappeared since it was dumped. Don't bother deleting the flow in this case, as it will fail. Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-upcall.c |4 +++- 1 file chang

Re: [ovs-dev] [branch-2.3 V2] recirculation: Do not drop packet when there is no match from internal table.

2014-12-16 Thread Alex Wang
Hey Yamamoto, Justin and Ethan just raised the same question you asked, Yeah, there is an issue. If say, the vlan is set before recirc action, the recirc'ed flow will have a vlan id which could lead to totally different handling result, We will discuss further and address it, Thanks, Alex Wang

Re: [ovs-dev] [branch-2.3 V2] recirculation: Do not drop packet when there is no match from internal table.

2014-12-16 Thread YAMAMOTO Takashi
hi, > Hey Yamamoto, > > >> what will happen if the receiving bridge also has a bond port? >> >> YAMAMOTO Takashi >> > > > For each 'balance-tcp' bond, it will have a unique 'recirc_id'. > > If the receiving bridge has a 'balance-tcp' bond with recirc_id=ABCD, > the bridge's internal table (Ta

[ovs-dev] [PATCH 2/2] route-table-bsd: Retry logic

2014-12-16 Thread YAMAMOTO Takashi
Retry routing requests as the routing socket is unreliable. Also, add some error checks and logs. Signed-off-by: YAMAMOTO Takashi --- lib/route-table-bsd.c | 60 --- 1 file changed, 52 insertions(+), 8 deletions(-) diff --git a/lib/route-table-bs

[ovs-dev] [PATCH 1/2] route-table-bsd: Update vlog.h inclusion

2014-12-16 Thread YAMAMOTO Takashi
This fixes a build failure introduced by the recent vlog change commit e6211adce42c28453e0004c7a3e342a3d52bb97d. ("lib: Move vlog.h to ") Signed-off-by: YAMAMOTO Takashi --- lib/route-table-bsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/route-table-bsd.c b/lib/rout

Re: [ovs-dev] [PATCH] ofproto: Fix MPLS multiple Push pop action.

2014-12-16 Thread Jarno Rajahalme
LGTM, With some comments below: Acked-by: Jarno Rajahalme Jarno On Dec 15, 2014, at 12:37 PM, Pravin B Shelar wrote: > vSwitchd does not generate correct MPLS actions for multiple > MPLS push or pop action. > Datapath can handle multiple push action for in single action list. > But for aft

[ovs-dev] [PATCH] Export OVS datapath performance counters via sFlow

2014-12-16 Thread Neil McKee
Export OVS datapath performance counters via sFlow. The OVS cache hit/miss counters and memory/CPU usage statistics have been identified as important metrics when managing large deployments. This patch allows them to be pushed periodically as part of the sFlow feed, and represents a more efficient

Re: [ovs-dev] [PATCH] daemon-windows: Add a missing header.

2014-12-16 Thread Nithin Raju
Acked-by: Nithin Raju On Dec 16, 2014, at 9:00 AM, Gurucharan Shetty wrote: > Without it, the build on Windows fails. > > Signed-off-by: Gurucharan Shetty ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] daemon-windows: Add a missing header.

2014-12-16 Thread Gurucharan Shetty
On Tue, Dec 16, 2014 at 11:16 AM, Alin Serdean wrote: > Acked-by: Alin Gabriel Serdean Thank you, I applied this patch to master. > > > > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty > Trimis: Tuesday, December 16, 2014 7:00 PM > Către: de

Re: [ovs-dev] [PATCH] daemon-windows: Add a missing header.

2014-12-16 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Gurucharan Shetty Trimis: Tuesday, December 16, 2014 7:00 PM Către: dev@openvswitch.org Cc: Gurucharan Shetty Subiect: [ovs-dev] [PATCH] daemon-windows: Add a missing header. Witho

[ovs-dev] [PATCH] daemon-windows: Add a missing header.

2014-12-16 Thread Gurucharan Shetty
Without it, the build on Windows fails. Signed-off-by: Gurucharan Shetty --- lib/daemon-windows.c |1 + 1 file changed, 1 insertion(+) diff --git a/lib/daemon-windows.c b/lib/daemon-windows.c index cb205ca..04e1f1a 100644 --- a/lib/daemon-windows.c +++ b/lib/daemon-windows.c @@ -19,6 +19,7