[ovs-dev] [PATCH 22/22] ovs-ofctl: Support bucket commands

(Draft) OpenFlow 1.5 flow mod commands include commands to manipulate the buckets of existing groups. This patch add support to ovs-ofctl for these commands. It also adds documentation and tests for them. EXT-350 Signed-off-by: Simon Horman --- tests/ofproto.at | 94 +

[ovs-dev] [PATCH 20/22] ofproto: handle (draft) OpenFlow 1.5 insert and remove group commands

Handle (draft) OpenFlow 1.5 insert and remove group commands of group mod messages. EXT-350 Signed-off-by: Simon Horman --- ofproto/ofproto.c | 110 +- 1 file changed, 109 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto.c b/ofproto/o

[ovs-dev] [PATCH 19/22] ofp-util: Provide bucket list helper functions

This is in preparation for supporting the bucket commands of (draft) Open Flow 1.5 group mod messages. EXT-350 Signed-off-by: Simon Horman --- lib/ofp-util.c | 67 ++ lib/ofp-util.h | 6 ++ 2 files changed, 73 insertions(+) diff --git

[ovs-dev] [PATCH 18/22] ofp-util: Enhanced command error logging during encoding group mod messages

In preparation for supporting (draft) OpenFlow 1.5 group mod commands enhance the error logging of them. EXT-350 Signed-off-by: Simon Horman --- lib/ofp-util.c | 48 1 file changed, 36 insertions(+), 12 deletions(-) diff --git a/lib/ofp-util.c b/

[ovs-dev] [PATCH 17/22] ofproto: Add OpenFlow 1.5 group tests

This motivation for this change is to exercise (draft) OpenFlow 1.5 group messages. EXT-350 Signed-off-by: Simon Horman --- tests/ofproto.at | 68 1 file changed, 64 insertions(+), 4 deletions(-) diff --git a/tests/ofproto.at b/tests/ofpr

[ovs-dev] [PATCH 15/22] ofp-parse: Parse (draft) OpenFlow 1.5 bucket ids

This is part of support for (draft) OpenFlow 1.5 flow mod messages. This adds support for specifying the bucket_id of buckets of groups in ovs-ofctl and documents that accordingly. EXT-350 Signed-off-by: Simon Horman --- lib/ofp-parse.c | 11 +-- utilities/ovs-ofctl.8.in | 7 +

[ovs-dev] [PATCH 16/22] ofproto: Add OpenFlow 1.3 group stats test

This is to exercise OpenFlow 1.3 group stats replies messages which include a duration. Signed-off-by: Simon Horman --- tests/ofproto.at | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/tests/ofproto.at b/tests/ofproto.at index d5998a8..2adce8a 10064

[ovs-dev] [PATCH 21/22] ofp-parse: Parse bucket commands of group mod

(Draft) OpenFlow 1.5 adds bucket commands to group mod. This patch allows parsing of them as a step towards supporting them. EXT-350 Signed-off-by: Simon Horman --- lib/ofp-parse.c | 60 ++--- 1 file changed, 57 insertions(+), 3 deletions(-) d

[ovs-dev] [PATCH 12/22] ofp-util: Encoding and decoding of (draft) OpenFlow 1.5 group messages

This provides the bulk of the ofproto side of support for OpenFlow 1.5 group messages. It provides for encoding and decoding of updated group mod and group desc reply messages. This includes a new bucket format and their properties. Open Flow 1.5 Groups also have properties but as no non-experimen

[ovs-dev] [PATCH 10/22] ofp-util: Refactor encoding of OpenFlow 1.1 group desc reply messages

This refactoring is in preparation for supporting encoding of (draft) OpenFlow 1.5 group mod messages. EXT-350 Signed-off-by: Simon Horman --- lib/ofp-util.c | 39 +++ 1 file changed, 31 insertions(+), 8 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util

[ovs-dev] [PATCH 09/22] ofp-util: Refactor decoding of OpenFlow 1.1 group mod messages

This refactoring is in preparation for supporting encoding of (draft) OpenFlow 1.5 group mod messages. EXT-350 Signed-off-by: Simon Horman --- lib/ofp-util.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c

[ovs-dev] [PATCH 14/22] ofp-print: Support printing of (draft) OpenFlow 1.5 group messages with bucket actions

EXT-350 Signed-off-by: Simon Horman --- lib/ofp-print.c| 50 +++-- tests/ofp-print.at | 60 -- 2 files changed, 97 insertions(+), 13 deletions(-) diff --git a/lib/ofp-print.c b/lib/ofp-print.c index 6

[ovs-dev] [PATCH 11/22] ofp-util: Refactor decoding of OpenFlow 1.1 group desc reply messages

This refactoring is in preparation for supporting encoding of (draft) OpenFlow 1.5 group mod messages. EXT-350 Signed-off-by: Simon Horman --- lib/ofp-util.c | 46 +- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/lib/ofp-util.c b/lib/

[ovs-dev] [PATCH 08/22] ofp-util: Rename OpenFlow 1.1 buckets decoder

Rename ofputil_pull_buckets() as ofputil_pull_buckets11() to denote that it decodes OpenFlow 1.1 buckets (also used in OpenFlow 1.2 to 1.4). This refactoring is in preparation for supporting decoding of (draft) OpenFlow 1.5 group mod messages and their buckets. EXT-350 Signed-off-by: Simon Horman

[ovs-dev] [PATCH 07/22] ofp-util: Break-out encoding of OpenFlow 1.1 group mod messages

This refactoring is in preparation for supporting encoding of (draft) OpenFlow 1.5 group mod messages. EXT-350 Signed-off-by: Simon Horman --- lib/ofp-util.c | 45 + 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/lib/ofp-util.c b/lib/o

[ovs-dev] [PATCH 13/22] ofp-print: print bucket ids of OpenFlow 1.5 group messages

EXT-350 Signed-off-by: Simon Horman --- lib/ofp-print.c | 39 --- tests/ofproto.at | 2 +- 2 files changed, 37 insertions(+), 4 deletions(-) diff --git a/lib/ofp-print.c b/lib/ofp-print.c index d27d8a7..68f5740 100644 --- a/lib/ofp-print.c +++ b/lib/ofp-prin

[ovs-dev] [PATCH 06/22] ofp-util: Provide helper to encode OpenFlow 1.1 group buckets

The group bucket encoding code appears in two places in almost identical form. Consolidate this into a helper function. The helper name includes ofp11 as later patches will add and ofp15 version to support (draft) OpenFlow 1.5 buckets. EXT-350 Signed-off-by: Simon Horman --- lib/ofp-util.c | 46

[ovs-dev] [PATCH 05/22] ofproto: Add OFPRAW_OFPT15_GROUP_MOD

This is in preparation for supporting (draft) OpenFlow1.5 group mod. EXT-350 Signed-off-by: Simon Horman --- lib/ofp-msgs.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/ofp-msgs.h b/lib/ofp-msgs.h index a78747e..fc69586 100644 --- a/lib/ofp-msgs.h +++ b/lib/ofp-

[ovs-dev] [PATCH 04/22] ofproto: Add types for (draft) OpenFlow 1.5 group mod

EXT-350 Signed-off-by: Simon Horman --- include/openflow/openflow-1.5.h | 159 +++- 1 file changed, 158 insertions(+), 1 deletion(-) diff --git a/include/openflow/openflow-1.5.h b/include/openflow/openflow-1.5.h index a5a51c0..a413755 100644 --- a/include/open

[ovs-dev] [PATCH 03/22] ofp-errors: Add (draft) OpenFlow 1.5 errors

Add OFPERR_OFPGMFC_UNKNOWN_BUCKET and OFPERR_OFPGMFC_BUCKET_EXISTS which are part of (draft) OpenFlow 1.5 groups. EXT-350 Signed-off-by: Simon Horman --- lib/ofp-errors.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/ofp-errors.h b/lib/ofp-errors.h index 2516b39..40c7910 100644 -

[ovs-dev] [PATCH 02/22] id-pool: Refactor id_pool_alloc_id to allow any 32 bit value to be an id

id_pool_alloc_id() was created by breaking out the recirculation allocation code. As it is now a library call it makes sense to remove the restriction that id 0 is reserved. Signed-off-by: Simon Horman --- lib/id-pool.c | 43 ++- lib/id-pool.h

[ovs-dev] [PATCH 01/22] id-pool: re-factor recirculation id allocator into stand-alone id pool

Refactor the lock-free portion of the recirculation id allocator into stand-alone id pool. This is in preparation for re-using that portion to allocate bucket ids which are part of (draft) Open Flow 1.5 groups. EXT-350 Signed-off-by: Simon Horman --- lib/automake.mk| 2 + lib/id-po

[ovs-dev] [PATCH 00/22] EXT-350: (draft) OpenFlow 1.5 groups

Hi, this series is intended to provide an implementation of EXT-350, draft OpenFlow 1.5 groups. It is intended for this to be a full implementation including: * New Open Flow group mod message structure - Properties are omitted as none other than experimenter are defined * New Bucket structure

Re: [ovs-dev] [PATCHv9 09/12] datapath: Add support for unique flow identifiers.

On Sat, Nov 8, 2014 at 4:37 PM, Joe Stringer wrote: > On 8 November 2014 14:26, Pravin Shelar wrote: >> >> On Fri, Nov 7, 2014 at 3:55 PM, Joe Stringer >> wrote: >> > On 7 November 2014 14:15, Pravin Shelar wrote: >> >> >> >> On Fri, Oct 31, 2014 at 4:55 PM, Joe Stringer >> >> wrote: >> >> > I