[ovs-dev] [PATCH v3] Build: Shared libraries and versioning

2014-11-07 Thread Scott Mann
From: Scott Mann These changes allow for the building of shared libraries by providing the --enable-shared option to configure. In particular, lib/libopenvwitch.so, lib/libsflow.so, ofproto/libofproto.so, and ovsdb/libovsdb.so will be built. Original behavior of building static remains the same.

[ovs-dev] [PATCH] dpif-netdev: Move 'struct dp_netdev_port' initialization before use.

2014-11-07 Thread Alex Wang
There is a portion of the 'struct dp_netdev_port' initialization that is placed after the reload of pmd threads. This means in theory, there could be a race where pmd threads access half- initialized struct. Although such race has not been seen, it makes sense to fully initialize the struct befor

Re: [ovs-dev] [PATCHv9 09/12] datapath: Add support for unique flow identifiers.

2014-11-07 Thread Joe Stringer
On 7 November 2014 14:15, Pravin Shelar wrote: > On Fri, Oct 31, 2014 at 4:55 PM, Joe Stringer > wrote: > > If a datapath is created with the flag OVS_DP_F_INDEX_BY_UFID, then an > > additional table_instance is added to the flow_table, which is indexed > > by unique identifiers ("UFID"). Usersp

[ovs-dev] [PATCH 2/2] dpif-netdev: Allow direct destroy of 'struct dp_netdev_port'.

2014-11-07 Thread Alex Wang
Before this commit, when 'struct dp_netdev_port' is deleted from 'dpif-netdev' datapath, if there is pmd thread, the pmd thread will release the last reference to the port and ovs-rcu postpone the destroy. However, the delayed close of object like 'struct netdev' could cause failure in immediate r

[ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: Allow direct destroy of previous config.

2014-11-07 Thread Alex Wang
Before this commit, the ofproto-dpif-xlate module uses ovs-rcu to postpone the destroy of previous configuration. However, the delayed close of object like 'struct netdev' could cause failure in immediate re-add or reconfigure of the same device. To fix the above issue, this commit makes the ofpr

Re: [ovs-dev] [PATCHv9 09/12] datapath: Add support for unique flow identifiers.

2014-11-07 Thread Pravin Shelar
On Fri, Oct 31, 2014 at 4:55 PM, Joe Stringer wrote: > If a datapath is created with the flag OVS_DP_F_INDEX_BY_UFID, then an > additional table_instance is added to the flow_table, which is indexed > by unique identifiers ("UFID"). Userspace implementations can specify a > UFID of up to 128 bits

Re: [ovs-dev] [PATCH v2] datapath-windows: Update port property

2014-11-07 Thread Eitan Eliahu
Yes, I agree. As you said this should be managed in a higher level. Regarding the alignment, the parameters are aligned but it does not look aligned in the review email. Thanks for the review! Eitan -Original Message- From: Ankur Sharma Sent: Friday, November 07, 2014 1:46 PM To: Eitan

Re: [ovs-dev] [PATCH v2] datapath-windows: Update port property

2014-11-07 Thread Ankur Sharma
Hi Eitan, In my opinion we should not allow the friendly name to be changed if corresponding ovs port exists (as this will lead to data inconsistency in userspace and kernel). But we need not block your changes as this will definitely help in handling update friendly name cases before vsctl ad

[ovs-dev] [PATCH v2] datapath-windows: Update port property

2014-11-07 Thread Eitan Eliahu
Update Hyper-V port properties on NDIS property port set callback. Driver update the port friendly name in its internal table. Since the NIC Create callback won't be called after we need to maintain the NIC and THE OVS states of the Vport. Setting a new friendly name was tested in the following st

Re: [ovs-dev] all reviews complete

2014-11-07 Thread Michio Honda
I understood, I wait for them to review. Thanks, - Michio From: Ben Pfaff [b...@nicira.com] Sent: Friday, November 07, 2014 5:21 PM To: Michio Honda Cc: dev@openvswitch.org Subject: Re: [ovs-dev] all reviews complete I skipped that series because Jesse and

Re: [ovs-dev] all reviews complete

2014-11-07 Thread Ben Pfaff
I skipped that series because Jesse and Pravin are the primary datapath maintainers. On Fri, Nov 07, 2014 at 08:56:25AM +, Michio Honda wrote: > Hi, > > I've posted two patches to the datapath with the following cover letter. > I'm happy if you review it. > > Thanks, > - Michio > >

Re: [ovs-dev] [PATCH 0/3] auto-attach: auto-attach: Add support for IETF Auto Attach standard (v2)

2014-11-07 Thread Keene, Carl (Carl)
Ben - thanks for your comments and assistance - let me try to provide an answer to the first question, Dennis Flynn will send answers to the other items later today and Paul Unbehagen ( Avaya Chief Architect ) may email additional clarity: We are aware of LLDP use in OpenFlow controllers and rec

[ovs-dev] [PATCH] ovs-ofctl:To set importance of a rule for eviction(OF14)

2014-11-07 Thread Rishi Bamba
From: Rishi Bamba This patch enables a user to set importance for a new rule via add-flow OF1.4+ in the OVS and display the same via dump-flows command OF1.4+ . The changes are made in accordance with OpenFlow 1.4 specs to implement Eviction on the basis of "importance".This patch also enhances t

Re: [ovs-dev] [PATCH] ovs-ofctl:To set importance of a rule for eviction(OF14)

2014-11-07 Thread Rishi Bamba
Hi Ben, > > This patch enables a user to set importance for a new rule via > > add-flow > > OF1.4+ in the OVS and display the same via dump-flows command > > OF1.4+ . > > The changes are made in accordance with OpenFlow 1.4 specs to > > implement > > Eviction on the basis of "importance".This patc

Re: [ovs-dev] [PATCH] rhel: fix tunnel port ifup/ifdown failure

2014-11-07 Thread Flavio Leitner
On Thu, Nov 06, 2014 at 02:14:45PM -0800, Ben Pfaff wrote: > On Thu, Nov 06, 2014 at 04:50:06PM -0200, Flavio Leitner wrote: > > The tunnel port is invisible to the OS, so there is > > no reason to call OTHERSCRIPT in the ifup/ifdown scripts. > > > > Signed-off-by: Flavio Leitner > > Applied, th

Re: [ovs-dev] [PATCH 00/33] Update openvswitch fedora spec file

2014-11-07 Thread Flavio Leitner
On Thu, Nov 06, 2014 at 02:12:55PM -0800, Ben Pfaff wrote: > On Thu, Nov 06, 2014 at 04:45:18PM -0200, Flavio Leitner wrote: > > This patchset updates the fedora spec file to be > > compliant with the distro guidelines and includes > > some fixes as well. > > I can tell when I'm outclassed ;-) >

[ovs-dev] ovs + DPDK: Failed to add dpdk1 as port: Resource temporarily unavailable

2014-11-07 Thread inaki . murilloa
Hello, I am trying to run openvswitch with DPDK, but I am not able to add any dpdk port to the bridge. When I run "ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk ofport_request=10" I get the next error: ovs-vsctl: Error detected while setting up 'dpdk0'. See ovs-vswitchd lo

Re: [ovs-dev] all reviews complete

2014-11-07 Thread Michio Honda
Hi, I've posted two patches to the datapath with the following cover letter. I'm happy if you review it. Thanks, - Michio From: dev [dev-boun...@openvswitch.org] on behalf of Michio Honda [michio.ho...@neclab.eu] Sent: Wednesday, November 05, 2014 11:23