I have mixed feelings about this change. I think it might be better to
change the classifier priority type to "int", then document that negative
values are reserved for use by the classifier.
Signed-off-by: Ben Pfaff
---
lib/classifier.c | 11 +--
lib/pvector.h| 18 +
A "conjunctive match" allows higher-level matches in the flow table, such
as set membership matches, without causing a cross-product explosion for
multidimensional matches. Please refer to the documentation that this
commit adds to ovs-ofctl(8) for a better explanation, including an example.
Issu
WHY-OVS has been renamed to WHY-OVS.md. Update the filenames in run-oftest
and run-ryu scripts
Signed-off-by: Wang Sheng-Hui
---
tests/run-oftest | 2 +-
tests/run-ryu| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/run-oftest b/tests/run-oftest
index c73c25c..32c
Hi,
I used CentOS 6.5, and failed building the latest ovs:
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wno-format-zero-length -Wswitch-enum -Wunused-parameter
-Wbad-functi
dp read operations depends on ovs_dp_cmd_fill_info(). This API
needs to looup vport to find dp name, but vport lookup can
fail. Therefore to keep vport reference alive we need to
take ovs lock.
Found by code inspection.
Signed-off-by: Pravin B Shelar
---
datapath/datapath.c | 12 ++--
1
These changes allow for the building of shared libraries by providing
the --enable-shared option to configure. In particular, lib/libopenvwitch.so,
lib/libsflow.so, ofproto/libofproto.so, and ovsdb/libovsdb.so will be built.
Original behavior of building static remains the same.
Additionally, vers
These changes allow for the building of shared libraries by providing
the --enable-shared option to configure. In particular, lib/libopenvwitch.so,
lib/libsflow.so, ofproto/libofproto.so, and ovsdb/libovsdb.so will be built.
Original behavior of building static remains the same.
Additionally, vers
Please ignore this patch as it has an incorrect commit message.
On Wed, Oct 29, 2014 at 2:55 PM, Scott Mann wrote:
> These changes cause shared libraries to be built by default.
> In particular, lib/libopenvwitch.so, lib/libsflow.so,
> ofproto/libofproto.so,
> and ovsdb/libovsdb.so will be built
On Wed, Oct 29, 2014 at 04:15:51PM -0700, Jarno Rajahalme wrote:
>
> On Oct 9, 2014, at 11:11 PM, Ben Pfaff wrote:
>
> > On Thu, Oct 09, 2014 at 09:16:24AM -0700, Ben Pfaff wrote:
> >> On Thu, Oct 09, 2014 at 08:46:00AM -0700, Jarno Rajahalme wrote:
> >>> Small issues with the tests, otherwise:
On Oct 9, 2014, at 11:11 PM, Ben Pfaff wrote:
> On Thu, Oct 09, 2014 at 09:16:24AM -0700, Ben Pfaff wrote:
>> On Thu, Oct 09, 2014 at 08:46:00AM -0700, Jarno Rajahalme wrote:
>>> Small issues with the tests, otherwise:
>>>
>>> Acked-by: Jarno Rajahalme
>>
>> Thanks.
>>
>>> On Oct 9, 2014, at
On Wed, Oct 29, 2014 at 3:03 PM, Ben Pfaff wrote:
> On Wed, Oct 29, 2014 at 01:54:24PM -0700, Gurucharan Shetty wrote:
>> Signed-off-by: Gurucharan Shetty
>
> Acked-by: Ben Pfaff
Thanks, Applied!
___
dev mailing list
dev@openvswitch.org
http://openvswi
We were acquiring locks twice, and forgotten to release a lock in an
error case.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index b28
We were using USE_NEW_VPORT_ADD_WORKFLOW while transitioning from old
workflow for adding ports. We don't need it anymore.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/datapath-windows/ovsex
In userspace, port name sizes are restricted to IFNAMSIZ which is
defined to IF_NAME_SIZE in:
C:\Program Files (x86)\Windows Kits\8.1\Include\shared\netioapi.h
In the kernel, since IFNAMSIZ was not available, we previously defined a
value of 16 for the kernel. This is restrictive for Openstack
int
1. Flows with an explicit match on nw_frag, where the LATER bit is 1:
Prohibit setting transport header fields (port numbers) with
set_field or move, or using such a field as a source in a move.
2. Flows that wildcard the nw_frag LATER bit: At flow translation
time, detect the fact that t
Transport ports are already cleared for lookup if need be, and they
should be available for action processing, so do not clear them in
xlate_actions().
A drop flow takes care of dropping the packet, so no special case is
needed in xlate_actions().
Signed-off-by: Jarno Rajahalme
---
ofproto/ofpr
Add transport port modifications to the existing frags handling test
case.
This demonstrates incorrect behavior by not moving the destination
port number to source port in normal mode for first fragment, as the
transport port numbers have been zeroed and the move has no effect,
and by allowing mov
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
> Sent: Wednesday, October 29, 2014 2:15 PM
> To: dev@openvswitch.org
> Cc: Ben Pfaff; Nithin Raju; Gurucharan Shetty
> Subject: [PATCH] ovs-vsctl: Allow referring to rows whose names are UUIDs by
> those names.
>
> Every row
On Wed, Oct 29, 2014 at 01:54:24PM -0700, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Gurucharan Shetty
---
debian/openvswitch-common.docs |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/debian/openvswitch-common.docs b/debian/openvswitch-common.docs
index 3bd2ca3..7c1bc44 100644
--- a/debian/openvswitch-common.docs
+++ b/debian/openvswitc
On Wed, Oct 29, 2014 at 02:31:27PM -0700, Gurucharan Shetty wrote:
> On Wed, Oct 29, 2014 at 2:15 PM, Ben Pfaff wrote:
> > Every row in the database has a UUID, generated by the database server.
> > Rows in most tables also have a user-assigned name (e.g. a bridge or port
> > or interface name).
On Wed, Oct 29, 2014 at 2:15 PM, Ben Pfaff wrote:
> Every row in the database has a UUID, generated by the database server.
> Rows in most tables also have a user-assigned name (e.g. a bridge or port
> or interface name). The ovs-vsctl database commands (e.g. "set", "get",
> "list", ...) accept b
Every row in the database has a UUID, generated by the database server.
Rows in most tables also have a user-assigned name (e.g. a bridge or port
or interface name). The ovs-vsctl database commands (e.g. "set", "get",
"list", ...) accept both UUIDs and names, but until now if a command's
argument
On Wed, Oct 29, 2014 at 7:02 AM, Flavio Leitner wrote:
> On Wed, Oct 29, 2014 at 05:57:13AM -0700, Gurucharan Shetty wrote:
>> Requested-by: Flavio Leitner
>> Signed-off-by: Gurucharan Shetty
>> ---
>
> Acked-by: Flavio Leitner
Thanks, I applied this!
>
> Thanks again
> fbl
>
__
These changes cause shared libraries to be built by default.
In particular, lib/libopenvwitch.so, lib/libsflow.so, ofproto/libofproto.so,
and ovsdb/libovsdb.so will be built. Original behavior of building static
objects excusively may be accomplished by providing the --disable-shared
argument to co
./configure accepts --enable-ndebug option. Make ovs_assert() honor
it, and make sure all test programs disable it.
The order of include files in test programs is also made uniform:
1. #include
2. #undef NDEBUG
3. Include file of the test subject (to make sure it itself has
sufficient includ
All of the list functions are really small, so inlining them should be
beneficial.
Requested-by: Ben Pfaff
Signed-off-by: Jarno Rajahalme
---
lib/automake.mk |1 -
lib/list.c | 203
lib/list.h | 229 +++
This patch shifts the responsibility for determining the hash for a flow
from the revalidation logic down to the dpif layer. This assists in
handling backward-compatibility for revalidation with the upcoming
unique identifier "UFID" patches.
A 128-bit UFID was selected to minimize the likelihood o
This allows us to ignore most fields of a flow_dump, requiring only the
flow key for looking up the ukey. Fetching flows can also be avoided in
the corner case where a flow is missed from a dump but revalidation is
required.
A future patch will modify the datapath interface to allow datapaths to
s
If a datapath is created with the flag OVS_DP_F_INDEX_BY_UFID, then an
additional table_instance is added to the flow_table, which is indexed
by unique identifiers ("UFID"). Userspace implementations can specify a
UFID of up to 128 bits along with a flow operation as shorthand for the
key. This all
This patch modifies the dpif interface to allow flows to be manipulated
using a 128-bit identifier. This allows revalidator threads to perform
datapath operations faster, as they do not need to serialise the entire
flow key for operations like flow_get and flow_delete. In conjunction
with a future
Future patches will make use of the 'struct dump_op' in a broader sense,
so this patch renames it to make things a bit clearer.
Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
---
v8: No change.
v7: Rebase.
v4-v6: No change.
v3: Rebase.
v2: No change.
RFC: First post.
---
ofproto/ofproto-dpif-u
An upcoming patch will change the access patterns for ukey maps to
increase the number of writers, and shift write-access from revalidator
threads to upcall handler threads. As such, it no longer makes sense to
tie these maps to revalidators in a 1:1 relationship.
This patch separates the ukey map
Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
---
v4-v8: No change.
v3: Rebase.
v2: Call ovsrcu_quiesce() unconditionally.
RFC: Initial Post.
---
ofproto/ofproto-dpif-upcall.c | 61 ++---
1 file changed, 33 insertions(+), 28 deletions(-)
diff --git a/ofpr
Add the 128-bit murmurhash by Austin Appleby, r150 from:
http://code.google.com/p/smhasher/source/browse/trunk/MurmurHash3.cpp
Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
---
v8: Build fix for 32-bit (non-static function).
v7: Replace getblock*() with get_unaligned_u*().
Add ovs_u128_equ
Currently, when a revalidator thread first dumps a flow, it creates a
'udpif_key' object and caches a copy of a kernel flow key. This allows
us to perform lookups in the classifier to attribute stats and validate
the correctness of the datapath flow.
This patch sets up this cache from the handler
This series modifies the dpif interface for flow commands to use 128-bit unique
identifiers as an alternative to the netlink-formatted flow key, and caches the
mask/actions in the udpif_key. This significantly reduces the cost of
assembling messages between revalidators and the datapath, improving
Currently, udpif_keys are protected during revalidator_sweep__() as only
one thread accesses the ukey at a time. This is ensured using barriers:
all revalidators will be in the GC phase, so they will only access their
own ukey collection.
A future patch will change the access patterns to allow the
Thanks for the review!
Pushed,
Jarno
On Oct 28, 2014, at 4:28 PM, Ben Pfaff wrote:
> On Fri, Oct 24, 2014 at 01:36:39PM -0700, Jarno Rajahalme wrote:
>> Following patches add stricter checks of RCU memory management of
>> rules removed from a classifier. This patch properly postpones
>> fre
On Oct 28, 2014, at 4:25 PM, Ben Pfaff wrote:
> On Fri, Oct 24, 2014 at 01:36:38PM -0700, Jarno Rajahalme wrote:
>> rculist allows concurrent lockless list iteration, while a writer may
>> be modifying the list. Multiple writers can be supported by using a
>> mutex in addition to rculist.
>>
>
Reported-by: Andrey Korolyov
Signed-off-by: Ben Pfaff
---
AUTHORS| 1 +
configure.ac | 2 ++
lib/netdev-linux.c | 77 ++
3 files changed, 75 insertions(+), 5 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index 3af0fd5..1503c3
On Wed, Oct 29, 2014 at 05:57:13AM -0700, Gurucharan Shetty wrote:
> Requested-by: Flavio Leitner
> Signed-off-by: Gurucharan Shetty
> ---
Acked-by: Flavio Leitner
Thanks again
fbl
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mail
On Wed, Oct 29, 2014 at 06:43:10AM -0700, Gurucharan Shetty wrote:
> On Wed, Oct 29, 2014 at 6:29 AM, Flavio Leitner wrote:
> > On Wed, Oct 29, 2014 at 06:09:10AM -0700, Gurucharan Shetty wrote:
> >> On Wed, Oct 29, 2014 at 5:49 AM, Flavio Leitner wrote:
> >> > On Thu, Oct 16, 2014 at 01:26:37AM
Requested-by: Flavio Leitner
Signed-off-by: Gurucharan Shetty
---
INSTALL.Docker.md |4 +++-
NEWS |3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/INSTALL.Docker.md b/INSTALL.Docker.md
index 2956036..ca7249f 100644
--- a/INSTALL.Docker.md
+++ b/INSTALL.
On Wed, Oct 29, 2014 at 6:29 AM, Flavio Leitner wrote:
> On Wed, Oct 29, 2014 at 06:09:10AM -0700, Gurucharan Shetty wrote:
>> On Wed, Oct 29, 2014 at 5:49 AM, Flavio Leitner wrote:
>> > On Thu, Oct 16, 2014 at 01:26:37AM -0700, Gurucharan Shetty wrote:
>> >> Open vSwitch does not have native int
On Wed, Oct 29, 2014 at 06:09:10AM -0700, Gurucharan Shetty wrote:
> On Wed, Oct 29, 2014 at 5:49 AM, Flavio Leitner wrote:
> > On Thu, Oct 16, 2014 at 01:26:37AM -0700, Gurucharan Shetty wrote:
> >> Open vSwitch does not have native integration with Docker.
> >> INSTALL.Docker explains how Open v
On Wed, Oct 29, 2014 at 06:05:10AM -0700, Gurucharan Shetty wrote:
> On Wed, Oct 29, 2014 at 5:49 AM, Flavio Leitner wrote:
> > On Thu, Oct 16, 2014 at 01:26:37AM -0700, Gurucharan Shetty wrote:
> >> Open vSwitch does not have native integration with Docker.
> >> INSTALL.Docker explains how Open v
On Wed, Oct 29, 2014 at 5:49 AM, Flavio Leitner wrote:
> On Thu, Oct 16, 2014 at 01:26:37AM -0700, Gurucharan Shetty wrote:
>> Open vSwitch does not have native integration with Docker.
>> INSTALL.Docker explains how Open vSwitch can be integrated
>> with docker non-natively.
>>
>> ovs-docker is a
On Wed, Oct 29, 2014 at 5:49 AM, Flavio Leitner wrote:
> On Thu, Oct 16, 2014 at 01:26:37AM -0700, Gurucharan Shetty wrote:
>> Open vSwitch does not have native integration with Docker.
>> INSTALL.Docker explains how Open vSwitch can be integrated
>> with docker non-natively.
>>
>> ovs-docker is a
On Thu, Oct 16, 2014 at 01:26:37AM -0700, Gurucharan Shetty wrote:
> Open vSwitch does not have native integration with Docker.
> INSTALL.Docker explains how Open vSwitch can be integrated
> with docker non-natively.
>
> ovs-docker is a helper script to add network interfaces to
> docker container
Dr Mrs Drissa Mambo. Diretor do Projeto de Implementação Africano Anglo-Gold
Corporation Abidjan Cote Divoire
Bom dia!
Eu sou o Dr Mrs Drissa Mambo, Diretor do Projeto de Implementação com
Africano Anglo-Gold Corporation aqui em Abidjan, Cote Divoire e membro do
Conselho de Administração
51 matches
Mail list logo
