Nithin, the DP commands are an exception. But, it does not make sense to check
if the driver got initialized in each of the handlers.
One simple way to handle the exception is to condition it by the Family ID (not
DP).
Thanks,
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday,
On Oct 15, 2014, at 8:33 PM, Eitan Eliahu
wrote:
> Hi Nithin,
> Perhaps, it would be better to have the check for gOvsSwitchContext much
> earlier at the Dispatcher function and avoid this check in
> ValidateNetlinkCmd() and in every handler function as well.
Eitan,
Some of the commands suc
Hi Nithin,
Perhaps, it would be better to have the check for gOvsSwitchContext much
earlier at the Dispatcher function and avoid this check in
ValidateNetlinkCmd() and in every handler function as well.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On B
From: Fabian Frederick
Date: Wed, 15 Oct 2014 21:03:41 +0200
> All functions used struct vport *vport except
> ovs_vport_find_upcall_portid.
>
> This fixes 1 kerneldoc warning
>
> Signed-off-by: Fabian Frederick
Applied.
___
dev mailing list
dev@ope
From: Fabian Frederick
Date: Wed, 15 Oct 2014 21:03:18 +0200
> s/sock/gs
>
> Signed-off-by: Fabian Frederick
Applied.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Oct 15, 2014 at 12:03 PM, Fabian Frederick wrote:
> s/sock/gs
>
> Signed-off-by: Fabian Frederick
Looks good.
Acked-by: Pravin B Shelar
Thanks.
> ---
> net/openvswitch/vport-geneve.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/openvswitch/vport-genev
On Wed, Oct 15, 2014 at 12:03 PM, Fabian Frederick wrote:
> All functions used struct vport *vport except
> ovs_vport_find_upcall_portid.
>
> This fixes 1 kerneldoc warning
>
> Signed-off-by: Fabian Frederick
Acked-by: Pravin B Shelar
Thanks.
> ---
> net/openvswitch/vport.c | 4 ++--
> 1 fi
Signed-off-by: Samuel Ghinet
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c | 119
1 files changed, 119 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datap
In this patch, we make a few simple fixes based on reviewing the code.
The code as such is not tested. We'll be hitting the code path soon
and might make more fixes at that time.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c | 42
On Oct 15, 2014, at 5:09 PM, Ben Pfaff
wrote:
>>>
>>> Changes look fine.
>>> Please remove following comment
>>> /*XXX: this function is dummy */
>>>
>>> Acked-by: Ankur Sharma
>>
>> Thanks for the review. The 'dummy' comment has been removed in 2/2 patch.
>
> I don't see where that happen
In this patch, we make a few simple fixes based on reviewing the code.
The code as such is not tested. We'll be hitting the code path soon
and might make more fixes at that time.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 42 +++
1 files
Signed-off-by: Samuel Ghinet
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 119
1 files changed, 119 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index 9a4827a..83b
I applied all the patches in this series. Thank you!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Oct 15, 2014 at 11:21:59PM +, Nithin Raju wrote:
> On Oct 15, 2014, at 4:14 PM, Ankur Sharma
> wrote:
>
> > Changes look fine.
> > Please remove following comment
> > /*XXX: this function is dummy */
> >
> > Acked-by: Ankur Sharma
>
> Thanks for the review. The 'dummy' comment ha
On Wed, Oct 15, 2014 at 04:13:10PM -0700, Ankur Sharma wrote:
> Added the handlers for update_flags and set_etheraddr.
> These handlers were needed for vswitchd bringup on windows
> platform.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Nithin Raju
I don't understand why the flags code in this p
Pravin could you please review these two openvswitch kerneldoc
fixes from Fabian?
Thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Oct 14, 2014 at 03:52:40AM -0700, Gurucharan Shetty wrote:
> Open vSwitch does not have native integration with Docker.
> INSTALL.Docker explains how Open vSwitch can be integrated
> with docker non-natively.
>
> Signed-off-by: Gurucharan Shetty
Maybe we should mention INSTALL.Docker nea
On Oct 15, 2014, at 4:14 PM, Ankur Sharma
wrote:
> Changes look fine.
> Please remove following comment
> /*XXX: this function is dummy */
>
> Acked-by: Ankur Sharma
Thanks for the review. The 'dummy' comment has been removed in 2/2 patch.
-- Nithin
_
On Tue, Oct 14, 2014 at 03:52:39AM -0700, Gurucharan Shetty wrote:
> ovs-docker is a helper script to add network interfaces to
> docker containers and to attach them as ports to OVS bridge.
>
> This script can be further enhanced as we understand different
> use cases.
>
> Signed-off-by: Gurucha
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Wednesday, October 15, 2014 2:08 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 2/2] datapath-windows: Fixes in
OvsSetVportCmdHandler()
In this patch, we make a few simple fixe
Changes look fine.
Please remove following comment
/*XXX: this function is dummy */
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Wednesday, October 15, 2014 2:08 PM
To: dev@openvswitch.org
Cc: Samuel Ghinet
Subject: [ovs-dev] [PATCH
Added the handlers for update_flags and set_etheraddr.
These handlers were needed for vswitchd bringup on windows
platform.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
---
lib/netdev-windows.c | 83 +++-
1 file changed, 82 insertions(+), 1 d
Added the handlers for update_flags and set_etheraddr.
These handlers were needed for vswitchd bringup on windows
platform.
Signed-off-by: Ankur Sharma
---
lib/netdev-windows.c | 83 +++-
1 file changed, 82 insertions(+), 1 deletion(-)
diff --git
Added the handlers for update_flags and set_etheraddr.
These handlers were needed for vswitchd bringup on windows
platform.
Signed-off-by: Ankur Sharma
---
lib/netdev-windows.c | 83 +++-
1 file changed, 82 insertions(+), 1 deletion(-)
diff --git
On Tue, Oct 14, 2014 at 04:02:20PM -0700, Ankur Sharma wrote:
> My changes for trasacation error handling for not needed for dump commands.
> Fixed the same.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Nithin Raju
> Acked-by: Eitan Eliahu
Applied, thanks!
__
On Oct 15, 2014, at 2:48 PM, Ankur Sharma wrote:
> Added the handlers for update_flags and set_etheraddr.
> These handlers were needed for vswitchd bringup on windows
> platform.
>
> Signed-off-by: Ankur Sharma
Can you pls. add a XXX comment or a regular comment in netdev_win_set_flag()
and n
On Sat, Oct 11, 2014 at 08:56:07PM -0400, Thomas F Herbert wrote:
> This is the userspace portion of the patch.
>
> Signed-off-by: Thomas F Herbert
Thanks for the patch. I have some comments.
I don't understand the struct flow members yet. Previously, there was
a vlan_tci member, which indica
Added changes to support error handling for non supported actions.
Added changes in packet execute for sending transactional errors.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Actions.c | 4 +--
datapath-windows/ovsext/Netlink/NetlinkError.h | 17
In this patch we have implemented the handler for OVS_PACKET_CMD_EXECUTE
command.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
---
datapath-windows/ovsext/User.c | 111 +++--
1 file changed, 107 insertions(+), 4 deletions(-)
dif
In this patch we have made following changes:
OvsPacketExecute =>
Changed the data structure to have packet and
actions as pointer (instead of zero length array). It is done because
we will not do memcpy of packet now, pointer will just point
to corresponding offset in input buffer.
OvsExecuteDpI
In this patch we cover the basic registeration of OVS_PACKET_CMD_EXECUTE
command handler.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 18 +-
datapath-windows/ovsext/User.c | 18 ++
datapat
In this patch we have made the Flow parsing policies global.
Pakcet execute handling requires these policies.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Flow.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/
On Oct 15, 2014, at 3:26 PM, Ankur Sharma wrote:
> Added changes to support error handling for non supported actions.
> Added changes in packet execute for sending transactional errors.
>
> Signed-off-by: Ankur Sharma
Looks like the cover letter and the cumulative patch has also got included i
On Oct 15, 2014, at 3:26 PM, Ankur Sharma wrote:
> In this patch we have implemented the handler for OVS_PACKET_CMD_EXECUTE
> command.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
___
dev mailing list
dev@openvs
On Sat, Oct 11, 2014 at 08:56:06PM -0400, Thomas F Herbert wrote:
> This is the linux kernel portion of the patch.
>
> Signed-off-by: Thomas F Herbert
In the subject, it's customary to put the version number inside the
brackets so that it doesn't get into the commit message.
Compiling against L
In this patch we cover the basic registeration of OVS_PACKET_CMD_EXECUTE
command handler.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 18 +-
datapath-windows/ovsext/User.c | 18 ++
datapat
In this patch we have made following changes:
OvsPacketExecute =>
Changed the data structure to have packet and
actions as pointer (instead of zero length array). It is done because
we will not do memcpy of packet now, pointer will just point
to corresponding offset in input buffer.
OvsExecuteDpI
In this patch we have made the Flow parsing policies global.
Pakcet execute handling requires these policies.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Flow.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/
In this patch we have implemented the handler for OVS_PACKET_CMD_EXECUTE
command.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/User.c | 111 +++--
1 file changed, 107 insertions(+), 4 deletions(-)
diff --git a/datapath-wind
Added changes to support error handling for non supported actions.
Added changes in packet execute for sending transactional errors.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Actions.c | 4 +-
datapath-windows/ovsext/Netlink/NetlinkError.h | 17 +++
datapath
Thanks Nithin.
I am able to complete OvsReadDpIoctl now as my previous patch was applied.
-Original Message-
From: Nithin Raju
Sent: Wednesday, October 15, 2014 3:08 PM
To: Eitan Eliahu
Cc:
Subject: Re: [ovs-dev] [PATCH] datapath-windows: packet miss read NL command
hi Eitan,
I think
hi Eitan,
I think there are additional changes needed in OvsReadDpIoctl() for checksum
calculation. It might be easier to explain it in a patch:
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
index e27bd76..9d15ef9 100644
--- a/datapath-windows/ovsext/User.c
+++ b/da
Added the handlers for update_flags and set_etheraddr.
These handlers were needed for vswitchd bringup on windows
platform.
Signed-off-by: Ankur Sharma
---
lib/netdev-windows.c | 78 +++-
1 file changed, 77 insertions(+), 1 deletion(-)
diff --git
On Wed, Oct 15, 2014 at 2:08 PM, Ben Pfaff wrote:
> On Tue, Oct 14, 2014 at 03:52:39AM -0700, Gurucharan Shetty wrote:
>> ovs-docker is a helper script to add network interfaces to
>> docker containers and to attach them as ports to OVS bridge.
>>
>> This script can be further enhanced as we under
All applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
The first of the patch is the rebased version of Samuel Ghinet's
original patch. The second is fixes.
Nithin Raju (2):
datapath-windows: Add netlink command vport set
datapath-windows: Fixes in OvsSetVportCmdHandler()
datapath-windows/ovsext/Datapath.c | 133
On Tue, Oct 14, 2014 at 03:52:39AM -0700, Gurucharan Shetty wrote:
> ovs-docker is a helper script to add network interfaces to
> docker containers and to attach them as ports to OVS bridge.
>
> This script can be further enhanced as we understand different
> use cases.
>
> Signed-off-by: Gurucha
Signed-off-by: Samuel Ghinet
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 119
1 files changed, 119 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index 6c78ab8..076
In this patch, we make a few simple fixes based on reviewing the code.
The code as such is not tested. We'll be hitting the code path soon
and might make more fixes at that time.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 40 ---
1 files
On Wed, Oct 15, 2014 at 06:14:16AM -0400, Thomas F Herbert wrote:
> I am late in commenting on Ben's comments on Dave's patch but I
> thought I would add my two cents.
I need to review your patches, too, obviously. I'll try to do that
soon.
My guess is that your patches are more mature, because
On Wed, Oct 15, 2014 at 02:01:02PM -0700, Nithin Raju wrote:
> Signed-off-by: Samuel Ghinet
Since you're submitting Samuel's patch to be applied, you should add
your own sign-off following Samuel's.
Thanks,
Ben.
___
dev mailing list
dev@openvswitch.or
In this patch, we make a few simple fixes based on reviewing the code.
The code as such is not tested. We'll be hitting the code path soon
and might make more fixes at that time.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 40 ---
1 files
The first of the patch is the rebased version of Samuel Ghinet's
original patch. The second is fixes.
Nithin Raju (2):
datapath-windows: Add netlink command vport set
datapath-windows: Fixes in OvsSetVportCmdHandler()
datapath-windows/ovsext/Datapath.c | 133
Signed-off-by: Samuel Ghinet
---
datapath-windows/ovsext/Datapath.c | 119
1 files changed, 119 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index 6c78ab8..076cd1a 100644
--- a/datapath-w
Signed-off-by: Ben Pfaff
---
vswitchd/vswitch.xml |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index d90f221..3f0f22d 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -4142,7 +4142,7 @@
tunnelType:
A coworker came by yesterday with a question about IPFIX in Open vSwitch.
I did not know the answer, so I read the documentation. The documentation
was harder to understand than necessary. This change should make it easier
to understand by providing an overview of the two forms of configuration
a
All functions used struct vport *vport except
ovs_vport_find_upcall_portid.
This fixes 1 kerneldoc warning
Signed-off-by: Fabian Frederick
---
net/openvswitch/vport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
index
s/sock/gs
Signed-off-by: Fabian Frederick
---
net/openvswitch/vport-geneve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/openvswitch/vport-geneve.c b/net/openvswitch/vport-geneve.c
index 910b3ef..106a9d8 100644
--- a/net/openvswitch/vport-geneve.c
+++ b/net/openvswitc
hi Ankur,
Change looks good but for the comments. I'll wait for the next version to ACK
the change.
On Oct 15, 2014, at 10:32 AM, Ankur Sharma
wrote:
> In this patch we have implemented the handler for OVS_PACKET_CMD_EXECUTE
> command.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Eitan Eliah
On Oct 15, 2014, at 10:32 AM, Ankur Sharma
wrote:
> In this patch we cover the basic registeration of OVS_PACKET_CMD_EXECUTE
> command handler.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
Thanks,
-- Nithin
___
On Oct 15, 2014, at 10:32 AM, Ankur Sharma
wrote:
> In this patch we have made following changes:
>
> OvsPacketExecute =>
> Changed the data structure to have packet and
> actions as pointer (instead of zero length array). It is done because
> we will not do memcpy of packet now, pointer will
Acked-by: Nithin Raju
On Oct 15, 2014, at 10:32 AM, Ankur Sharma
wrote:
> In this patch we have made the Flow parsing policies global.
> Pakcet execute handling requires these policies.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Eitan Eliahu
> ---
> datapath-windows/ovsext/Flow.c | 8 -
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index 6c78ab8..50ea2ff 100644
--- a/datapath-windows/ovsext/Datapath.c
+++ b/datap
I just reverted this patch. I had failed to compile it with clang, which
revealed a thread safety annotation warning.
I’ll post a more complete patch later.
Jarno
On Oct 14, 2014, at 1:35 PM, Jarno Rajahalme wrote:
> Pushed,
>
> Thanks for the review!
>
> Jarno
>
> On Oct 13, 2014, at 1
In this patch we have implemented the handler for OVS_PACKET_CMD_EXECUTE
command.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/User.c | 111 +++--
1 file changed, 108 insertions(+), 3 deletions(-)
diff --git a/datapath-wind
In this patch we cover the basic registeration of OVS_PACKET_CMD_EXECUTE
command handler.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/Datapath.c | 18 +-
datapath-windows/ovsext/User.c | 18 ++
datapath-windows/ovsext/User.h
In this patch we have made following changes:
OvsPacketExecute =>
Changed the data structure to have packet and
actions as pointer (instead of zero length array). It is done because
we will not do memcpy of packet now, pointer will just point
to corresponding offset in input buffer.
OvsExecuteDpI
In this patch we have made the Flow parsing policies global.
Pakcet execute handling requires these policies.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/Flow.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/datapath-windows/ovsext
Thx for the review,
I adopted all your suggestions,
I'm extending the bash completion to maybe all ovs-* cmds except ovs-vsctl.
I'm changing the 'struct command' like this:
diff --git a/lib/command-line.h b/lib/command-line.h
index 157cb58..57fdff5 100644
--- a/lib/command-line.h
+++ b/lib/comm
LG
Few comments:
[1] Please use variable name "status" for all variable of the type NTSTATUS.
[2] I didn't find any place where nlError is set (besides initialization)
[3] NlFillOvsMsg should we send OVS_PACKET_VERSION instead of FLOW_VERSION
Thanks,
Eitan
-Original Message-
From: dev [ma
Acked-by: Eitan Eliahu
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ankur Sharma
Sent: Saturday, October 11, 2014 5:34 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v2 2/4] datapath-windows: OVS_PACKET_CMD_EXECUTE
command handler.
I
OVS userspace translates the multiple OpenFlow tables a packet traverses to a
single kernel flow table entry. This way the following packets hitting the same
kernel flow only need one flow table lookup, even though there were multiple
OpenFlow tables.
So the answer to your question is that yes,
On Oct 14, 2014, at 8:32 AM, Sorin Vinturis
wrote:
> In the ingress datapath the creation of a missed packet doesn't
> need to be guarded by the dispatchLock. Same for the NBL context
> initialization.
>
> In the OvsInjectPacketThroughActions function extracting flow
> parameters (OvsExtractFlo
Integration of each interface' status as confirmed by BFD into the
FastFailover Group table. When BFD is configured and function
bfd_forwarding() reports false, odp_port_is_alive also reports false in
order to have a watched interface report false and omit to another
backup.
Test-suite has been su
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Dave,
I apologize for being late in responding to your patch,
http://openvswitch.org/pipermail/dev/2014-October/047158.html
I also included an updated patch a few days after you submitted yours,
http://openvswitch.org/pipermail/dev/2014-October/047231.html
I think it is great that you inclu
I am late in commenting on Ben's comments on Dave's patch but I thought
I would add my two cents.
On 10/10/14, 6:43 PM, Ben Pfaff wrote:
On Fri, Oct 10, 2014 at 10:06:29AM -0400, Dave Benson wrote:
One direction that we will probably have to take at some point is to
allow matching and setting
Hi,
Does OVS-2.x support multiple table in kernel or is it just in user space?
If only in user-space, is there a reason not to move it to kernel fast path?
Thanks
Martin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/de
78 matches
Mail list logo
