[ovs-dev] [PATCH 2/2] V4 user space Adds 802.1ad (qinq) support.

This is the userspace portion of the patch. Signed-off-by: Thomas F Herbert --- lib/flow.c | 31 +-- lib/flow.h | 12 ++-- lib/match.c | 2 +- lib/nx-match.c | 2 +- lib/odp-execute.c| 3 +- lib/odp-ut

[ovs-dev] [PATCH 1/2] V4 linux datapath Adds 802.1ad (qinq) support

This is the linux kernel portion of the patch. Signed-off-by: Thomas F Herbert --- datapath/actions.c| 27 ++-- datapath/flow.c | 80 +++ datapath/flow.h | 1 + datapath/f

[ovs-dev] [PATCH 0/2] V4 Add 802.1ad (qinq) Support to OVS

This patch adds 802.1ad support to OVS. It includes the user space and linux kernel portions. This effort is supported by Entry Point LLC. It has been tested in VMs and real-world environment at ATC Communications Inc. We would be interested in results from any other testers. Thomas F Herbert

[ovs-dev] [PATCH v2 2/4] datapath-windows: OVS_PACKET_CMD_EXECUTE command handler.

In this patch we cover the basic registeration of OVS_PACKET_CMD_EXECUTE command handler. Signed-off-by: Ankur Sharma --- datapath-windows/ovsext/Datapath.c | 18 +- datapath-windows/ovsext/User.c | 18 ++ datapath-windows/ovsext/User.h | 5 + 3 files

[ovs-dev] [PATCH v2 1/4] datapath-windows: Making Flow parsing policies global.

In this patch we have made the Flow parsing policies global. Pakcet execute handling requires these policies. Signed-off-by: Ankur Sharma --- datapath-windows/ovsext/Flow.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windo

[ovs-dev] [PATCH v2 4/4] datapath-windows: OVS_PACKET_CMD_EXECUTE handler.

In this patch we have implemented the handler for OVS_PACKET_CMD_EXECUTE command. Signed-off-by: Ankur Sharma --- datapath-windows/ovsext/User.c | 104 - 1 file changed, 103 insertions(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/User.c b/datapa

[ovs-dev] [PATCH v2 3/4] datapath-windows: changes to existing PACKET_CMD handler.

In this patch we have made following changes: OvsPacketExecute => Changed the data structure to have packet and actions as pointer (instead of zero length array). It is done because we will not do memcpy of packet now, pointer will just point to corresponding offset in input buffer. OvsExecuteDpI

Re: [ovs-dev] [PATCH v2 1/6] datapath-windows: Transactional error support in Flow commands.

On Oct 11, 2014, at 3:07 PM, Ankur Sharma wrote: > In this patch we added the code to handle transactional errors > in flow commands. > > Signed-off-by: Ankur Sharma Thanks for incorporating the review comments. Acked-by: Nithin Raju http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v2 6/6] datapath-windows: Assert fix in Netlink.c

NlBufAt should be called with valid boundary limits (within head and tail). Incorrect argument to NlBufAt was leading to assert hit, fixed the same. Signed-off-by: Ankur Sharma Acked-by: Nithin Raju Tested-by: Nithin Raju --- datapath-windows/ovsext/Netlink/Netlink.c | 4 ++-- 1 file changed,

[ovs-dev] [PATCH v2 3/6] datapath-windows: Reply for Flow Flush.

Added changes to send a reply for FLOW_FUSH case. This is needed as with nithin's transaction reply changes we'll need reply for each command. This patch also contains minor fixes for sending replies in success case as well. Signed-off-by: Ankur Sharma Acked-by: Nithin Raju --- datapath-window

[ovs-dev] [PATCH v2 4/6] datapath-windows: Remove setting of replyLen to zero.

This was one of the review comment which i forgot to address in FLOW_DUMP checkin. We do not need to explicitly set replyLen to zero as caller would have already set it. Signed-off-by: Ankur Sharma Acked-by: Nithin Raju --- datapath-windows/ovsext/Flow.c | 6 -- 1 file changed, 6 deletions

[ovs-dev] [PATCH v2 5/6] datapath-windows: remove invalid assert.

Assert(rc) would always hit for a valid case, hence replaced it with error code based check. Signed-off-by: Ankur Sharma Acked-by: Nithin Raju Tested-by: Nithin Raju --- datapath-windows/ovsext/Flow.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/datapath-windows/ovse

[ovs-dev] [PATCH v2 1/6] datapath-windows: Transactional error support in Flow commands.

In this patch we added the code to handle transactional errors in flow commands. Signed-off-by: Ankur Sharma --- datapath-windows/ovsext/Flow.c | 66 ++ datapath-windows/ovsext/Netlink/NetlinkError.h | 2 +- 2 files changed, 48 insertions(+), 20 deletions

[ovs-dev] [PATCH v2 2/6] datapath-windows: validate ETHERTYPE and ETHERNET attribute.

During vswitchd boot up kernel is receiving FLOW_ADD commands without ETHERTYPE attribute. Added additional check for the same in this patch. During the same phase kernel is also receiving packet_execute with no ETHERNET attribute. Signed-off-by: Ankur Sharma Acked-by: Nithin Raju --- datapath-

Re: [ovs-dev] [PATCH v1 1/6] datapath-windows: Transactional error support in Flow commands.

> NL_ERROR_TXTBSY = ((ULONG)-139), > /*the operation would block */ > NL_ERROR_WOULDBLOCK = ((ULONG)-140), > +/* parsing failed */ > +NL_ERROR_PARSEFAIL = ((ULONG)-141) One more thing is, I don't know the basis of the netlink transactional error numbers that got defined in a p

Re: [ovs-dev] [PATCH v1 5/6] datapath-windows: remove invalid assert.

On Oct 9, 2014, at 11:02 PM, Ankur Sharma wrote: > Assert(rc) would always hit for a valid case, hence > replaced it with error code based check. > > Signed-off-by: Ankur Sharma Acked-by: Nithin Raju Tested-by: Nithin Raju ___ dev mailing list

Re: [ovs-dev] [PATCH v1 6/6] datapath-windows: Assert fix in Netlink.c

On Oct 9, 2014, at 11:02 PM, Ankur Sharma wrote: > NlBufAt should be called with valid boundary limits (within head and tail). > Incorrect argument to NlBufAt was leading to assert hit, fixed the same. > > Signed-off-by: Ankur Sharma Acked-by: Nithin Raju Tested-by: Nithin Raju __

Re: [ovs-dev] [PATCH v1 4/6] datapath-windows: Remove setting of replyLen to zero.

On Oct 9, 2014, at 11:02 PM, Ankur Sharma wrote: > This was one of the review comment which i forgot to address in > FLOW_DUMP checkin. We do not need to explicitly set replyLen to zero > as caller would have already set it. > > Signed-off-by: Ankur Sharma s/i forgot/I forgot Acked-by: Nithi

Re: [ovs-dev] [PATCH v1 3/6] datapath-windows: Reply for Flow Flush.

On Oct 11, 2014, at 12:11 PM, Nithin Raju wrote: > On Oct 9, 2014, at 11:02 PM, Ankur Sharma > wrote: > >> Added changes to send a reply for FLOW_FUSH case. This is needed >> as with nithin's transaction reply changes we'll need reply for each >> command. >> >> Signed-off-by: Ankur Sharma >

Re: [ovs-dev] [PATCH v1 3/6] datapath-windows: Reply for Flow Flush.

On Oct 9, 2014, at 11:02 PM, Ankur Sharma wrote: > Added changes to send a reply for FLOW_FUSH case. This is needed > as with nithin's transaction reply changes we'll need reply for each > command. > > Signed-off-by: Ankur Sharma Generally, I have not seen the practice of quoting a developer

Re: [ovs-dev] [PATCH v1 1/6] datapath-windows: Transactional error support in Flow commands.

On Oct 9, 2014, at 11:02 PM, Ankur Sharma wrote: > In this patch we added the code to handle transactional errors > in flow commands. > > Signed-off-by: Ankur Sharma Ankur, Thanks for the fixes. One general comment is that, you seem to be returning a transactional error even for ioctl error

[ovs-dev] Bug#764847: openvswitch-switch: tuntap issues (commands)

Package: openvswitch-switch Version: 2.3.0+git20140819-2 Severity: important (I gave a previous message containing a link to the thread http://openvswitch.org/pipermail/discuss/2011-October/005914.html , but over here in Debian, the device creates "half-way") ovs-vsctl add-port -- set Inter

[ovs-dev] Bug#764843: openvswitch-switch: tuntap creation failure

Package: openvswitch Version: 2.3.0+git20140819-2 Severity: important http://openvswitch.org/pipermail/discuss/2011-October/005922.html An old bug is lingering somewhere in this latest edition.. Either it is recursive or something else is causing it. ___