On Fri, Oct 10, 2014 at 08:56:22AM +0400, Dmitry Krivenok wrote:
> On ArchLinux "python" points to 3.x version and the right
> 2.x python binary is "python2.7".
>
> Signed-off-by: Dmitry V. Krivenok
Thanks, applied.
___
dev mailing list
dev@openvswitch
On Thu, Oct 09, 2014 at 09:16:24AM -0700, Ben Pfaff wrote:
> On Thu, Oct 09, 2014 at 08:46:00AM -0700, Jarno Rajahalme wrote:
> > Small issues with the tests, otherwise:
> >
> > Acked-by: Jarno Rajahalme
>
> Thanks.
>
> > On Oct 9, 2014, at 8:05 AM, Ben Pfaff wrote:
> >
> > > This field allow
This field allows a flow table to match on the output port currently in the
action set.
ONF-JIRA: EXT-233
Signed-off-by: Ben Pfaff
Acked-by: Jarno Rajahalme
---
NEWS| 1 +
build-aux/extract-ofp-fields| 1 +
include/openflow/openflow-1.0.h | 7 ---
lib/flow
actset_output, to be added in an upcoming commit, has one OXM assignment
in OpenFlow 1.3 and another one in OpenFlow 1.5. This commit allows both
of them to be supported in appropriate OpenFlow versions.
This feature is difficult to test on its own, so the same commit that adds
actset_output supp
v1->v2:
* Patch 1 is new.
* Patch 2:
- Use correct OXM with each OpenFlow version.
- Remove uncredited and unrelated tests from Jean Tourrilhes.
- Fix behavior of "clear_actions" instruction.
Ben Pfaff (2):
nx-match: Add support for multiple OXM field assignments for one
fiel
They divide the file into logical pages for grouping of functions, as
explained in CodingStyle:
Within a file, non-static functions should come first, in the order
that they are declared in the header file, followed by static
functions. Static functions should be in one or more sepa
Hi Team,
We are working on the implementation on eviction mechanism on basis of
importance as per openflow specs-1.4. We have added importance parameter
in the flow entry. And are going through various commands (replace-flows,
diff-flows) for enhancement.
We wanted to confirm about the "ovs-of
I don't know how the symbol use to, when I add and create the pbb patch, I
find those symbol in file ofp-actions.c,
I thought those symbols were unused.
On 2014/10/10 13:49, Ben Pfaff wrote:
> On Fri, Oct 10, 2014 at 01:39:55PM +0800, Liuyongqiang(A) wrote:
>> From: liuyongqiang
>>
>> Signed-of
In this series we have fixed issues observed in flow netlink handler code
observed during vswitch and datapath-windows integration.
Ankur Sharma (6):
datapath-windows: Transactional error support in Flow commands.
datapath-windows: validate ETHERTYPE attribute.
datapath-windows: Reply for Fl
NlBufAt should be called with valid boundary limits (within head and tail).
Incorrect argument to NlBufAt was leading to assert hit, fixed the same.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Netlink/Netlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
This was one of the review comment which i forgot to address in
FLOW_DUMP checkin. We do not need to explicitly set replyLen to zero
as caller would have already set it.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/datap
During vswitchd boot up kernel is receiving FLOW_ADD commands
without ETHERTYPE attribute. Added additional check for the same
in this patch.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/datapath-windows
Added changes to send a reply for FLOW_FUSH case. This is needed
as with nithin's transaction reply changes we'll need reply for each
command.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/
Assert(rc) would always hit for a valid case, hence
replaced it with error code based check.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
inde
In this patch we added the code to handle transactional errors
in flow commands.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 54 +++---
datapath-windows/ovsext/Netlink/NetlinkError.h | 32 ++-
2 files changed, 70 insertions(+),
On Fri, Oct 10, 2014 at 01:39:55PM +0800, Liuyongqiang(A) wrote:
> From: liuyongqiang
>
> Signed-off-by: liuyongqiang
Those are page breaks. Why are they causing you trouble, and why only
in this file?
___
dev mailing list
dev@openvswitch.org
http://
From: liuyongqiang
Signed-off-by: liuyongqiang
---
lib/ofp-actions.c | 105 +++---
1 file changed, 52 insertions(+), 53 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index 7d9ee58..9904fed 100644
--- a/lib/ofp-actions.c
+++ b/li
From: liuyongqiang
this patch work for the ovs serporting the IEEE 802.1ah
protocol(Mac in Mac or PBB)
IEEE 802.1ah (PBB or MAC-in-MAC):
PBB (also known as MAC-in-MAC) is used by SPs to resolve these problems.
PBB introduces a hierarchical network architecture with associated new
frame formats w
On ArchLinux "python" points to 3.x version and the right
2.x python binary is "python2.7".
Signed-off-by: Dmitry V. Krivenok
---
m4/openvswitch.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4
index 6e24f25..3f0d097 100644
--- a/m4/ope
classifier already provides lockless lookups, and protected
modifications. When user wants to remove a flow, we currently require
the flow to exist in the classifier. To be thread safe, this requires
the caller to introduce their own mutex, lock it before a lookup, and
then issue classifier_remov
All patches applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Some more comments:
(snip)
>> +}
>> +
>> +static void
>> +tnl_port_unref(struct cls_rule *cr)
>> +{
>> +if (cr) {
>> +struct tunnel_ports *p;
>> +
>> +p = tnl_port_cast(cr);
>> +if (ovs_refcount_unref_relaxed(&p->ref_cnt) == 1) {
>> + classifier_remove(&cls,
On Wed, Oct 08, 2014 at 09:46:52PM +, Kyle Mestery wrote:
> Update the email address for myself in the AUTHORS file.
>
> Signed-off-by: Kyle Mestery
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/d
Pravin,
Please find my comments below. I did not snip any code to make it easier for
you to keep into context while reading this review.
Jarno
On Oct 3, 2014, at 8:24 PM, Pravin B Shelar wrote:
> Following patch adds support for userspace tunneling. Tunneling
> needs three more component fi
On Thu, Oct 9, 2014 at 10:57 AM, Jarno Rajahalme wrote:
> Pravin,
>
> This patch did not work by itself, I applied the following incremental (some
> of which are purely cosmetically, though) to make this pass the unit tests.
> Also, please find some further comments below.
>
I did make check but
Update the email address for myself in the AUTHORS file.
Signed-off-by: Kyle Mestery
---
AUTHORS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/AUTHORS b/AUTHORS
index 2c7c107..d5adbce 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -83,7 +83,7 @@ Keith Amidonke...@nicira.
Thanks for the review. Pushed to master.
On Thu, Oct 9, 2014 at 8:30 AM, Ben Pfaff wrote:
> On Wed, Oct 08, 2014 at 05:18:33PM -0700, Andy Zhou wrote:
>> Fdb entries can provide useful information. Collect them in bugtool.
>>
>> Signed-off-by: Andy Zhou
>
> Acked-by: Ben Pfaff
_
Pravin,
This patch did not work by itself, I applied the following incremental (some of
which are purely cosmetically, though) to make this pass the unit tests. Also,
please find some further comments below.
With these:
Acked-by: Jarno Rajahalme
commit 502f8c94c11e1994b5f4a6e73aa865ee29642b
The port friendly name will be set by WMI / powershell script.
It will be used from within the netlink command vport new to
identify the hyper-v switch port it represents.
This patch also adds a function to lookup a vport by the
port friendly name.
Signed-off-by: Samuel Ghinet
Co-authored-by: Al
For this, the old method of finding vports based on the
ovs port numbers is removed. Now, the lookup of a vport
by ovs port number is done the same way as the lookup by
hyper-v switch port id.
This is done so that the kernel is able to interact with
the userspace correctly when using vport channel
The field portLink of the OVS_VPORT_ENTRY is the link within the
OVS_SWITCH_CONTEXT's hash array of vports portHashArray, hashed by the
portId field of the OVS_VPORT_ENTRY.
Later on, we will need to modify the OVS_VPORT_ENTRY so that its port
numbers are set to maximum MAXUINT16. This will require
The field nameLink of the OVS_VPORT_ENTRY is the link within the
OVS_SWITCH_CONTEXT's hash array of vports nameHashArray, hashed by the
ovsName field of the OVS_VPORT_ENTRY.
Later on, the friendly name of the hyper-v switch port will need to be
set from userspace using WMI. This will require that
OvsGetVportNo computes a new port number. Therefore, OvsComputeVportNo
is a more clear name for what the function does. Reading OvsGetVportNo
may give the false impression that it returns the port number of an
existing vport.
Also, since the responsibility of assigning dp port numbers no longer
fa
The fields externalVport and internalVport of the OVS_SWITCH_CONTEXT
struct are currently defined as PVOID. However, all over the code they
are used as POVS_VPORT_ENTRY. In order to improve clarity and reduce the
need for useless casts to POVS_VPORT_ENTRY, this patch changes the type
from PVOID to
The fields externalVport and internalVport of the OVS_SWITCH_CONTEXT
struct are currently defined as PVOID. However, all over the code they
are used as POVS_VPORT_ENTRY. In order to improve clarity and reduce the
need for useless casts to POVS_VPORT_ENTRY, this patch changes the type
from PVOID to
The old IOCTL vport functions (using the non-netlink device) are no
longer needed. They should be removed.
Signed-off-by: Samuel Ghinet
Co-authored-by: Alin Gabriel Serdean
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 276
datapath-window
Validation ports are used internally by the hyper-v switch to validate
and verify settings for the real hyper-v switch ports that will be
connected to the VNic. The validation ports are of no use to us - we
must skip handling them, and return STATUS_SUCCESS as the OID result.
Signed-off-by: Samuel
Functions such as OvsCreatePort are vague in regard to who creates it or
when. It wasn't a problem thus far, since the vports were created,
updated and destroyed from one place only (hyper-v switch part). But
now, with the netlink implementation of the vport commands, a part of
the vport is constru
Thx for the review, applied to master
Also, backported the recent change + unit tests added in ovs-vswitchd.at
to branch-2.3.
On Thu, Oct 9, 2014 at 8:31 AM, Ben Pfaff wrote:
> On Wed, Oct 08, 2014 at 05:23:37PM -0700, Alex Wang wrote:
> > When ovs-vswitchd fails to acquire the ovsdb idl lock (
Thanks for the review, applied to master and branch-2.3~
On Thu, Oct 9, 2014 at 7:45 AM, Gurucharan Shetty
wrote:
> On Thu, Oct 9, 2014 at 12:18 AM, Alex Wang wrote:
> > When trying to install the kernel module rpm built for RHEL7,
> > the install failed with following conflicts:
> >
> > # rp
On Thu, Oct 09, 2014 at 08:46:00AM -0700, Jarno Rajahalme wrote:
> Small issues with the tests, otherwise:
>
> Acked-by: Jarno Rajahalme
Thanks.
> On Oct 9, 2014, at 8:05 AM, Ben Pfaff wrote:
>
> > This field allows a flow table to match on the output port currently in the
> > action set.
> >
>>> +
>>> +PWSTR wsName = OvsAllocateMemory(wstrSize);
>>> +if (!wsName) {
>>> +vport = NULL;
>>> +goto Cleanup;
>>
>> If we jump to 'Cleanup', and call OvsFreeMemory(wsName) while wsName ==
>> NULL, we'll hit an ASSERT in OvsFreeMemory() that checks for a valid pointer.
>
Small issues with the tests, otherwise:
Acked-by: Jarno Rajahalme
On Oct 9, 2014, at 8:05 AM, Ben Pfaff wrote:
> This field allows a flow table to match on the output port currently in the
> action set.
>
> OF1.3 and OF1.4 should use ONFOXM_ET_ACTSET_OUTPUT; OF1.5+ should use
> OXM_OF_ACTSET_
On Mon, Oct 06, 2014 at 06:05:39PM -0700, Nithin Raju wrote:
> I applied the patches for the new vport add workflow that is out for
> review, and found that some of the existing code in OvsGetExtInfoIoctl()
> needs to be updated. In this patch, we add a CPP called
> USE_NEW_VPORT_ADD_WORKFLOW and a
>
>
>>-Mesaj original-
>De la: Nithin Raju [mailto:nit...@vmware.com]
>Trimis: Thursday, October 9, 2014 9:10 AM
>Către: Alin Serdean
>Cc: dev@openvswitch.org; Samuel Ghinet
>Subiect: Re: [ovs-dev] [PATCH 10/10] datapath-windows: Add port friendly name
>to OVS_VPORT_ENTRY
>
>> +/* OvsFind
On Wed, Oct 08, 2014 at 02:21:50PM -0700, Nithin Raju wrote:
> In this change, we add support for the 'OVS_DP_CMD_NEW' netlink command
> in the kernel. We don't really support creation of a new datapath. If
> the name of the userspace is the same as the single datapath we support,
> we return EEXIS
Thanks, applied to master.
On Thu, Oct 09, 2014 at 02:49:01PM +, Alin Serdean wrote:
> Tested-by: Alin Gabriel Serdean
> Acked-by: Alin Gabriel Serdean
>
>
> -Mesaj original-
> De la: Ben Pfaff [mailto:b...@nicira.com]
> Trimis: Thursday, October 9, 2014 8:14 AM
> Către: dev@openv
On Wed, Oct 08, 2014 at 05:23:37PM -0700, Alex Wang wrote:
> When ovs-vswitchd fails to acquire the ovsdb idl lock (either due to
> contention or due to invalid database path), ovs-vswitchd will spin
> on the global connectivity sequence number and consume 100% cpu.
> This is in that the local copy
On Wed, Oct 08, 2014 at 05:18:33PM -0700, Andy Zhou wrote:
> Fdb entries can provide useful information. Collect them in bugtool.
>
> Signed-off-by: Andy Zhou
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/
This field allows a flow table to match on the output port currently in the
action set.
OF1.3 and OF1.4 should use ONFOXM_ET_ACTSET_OUTPUT; OF1.5+ should use
OXM_OF_ACTSET_OUTPUT. The current patch uses the former for all
versions.
ONF-JIRA: EXT-233
Signed-off-by: Ben Pfaff
---
NEWS
Tested-by: Alin Gabriel Serdean
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: Ben Pfaff [mailto:b...@nicira.com]
Trimis: Thursday, October 9, 2014 8:14 AM
Către: dev@openvswitch.org
Cc: Ben Pfaff; Alin Serdean
Subiect: [PATCH] unaligned: Make get_unaligned_be64() compatible on
On Thu, Oct 9, 2014 at 12:18 AM, Alex Wang wrote:
> When trying to install the kernel module rpm built for RHEL7,
> the install failed with following conflicts:
>
> # rpm -i kmod-openvswitch-2.3.1-1.el7.x86_64.rpm
> file /lib/modules/3.10.0-123.8.1.el7.x86_64/modules.devname
> from insta
The original message was received at Thu, 9 Oct 2014 16:06:17 +0530 from
sinclair.net [68.152.95.227]
- The following addresses had permanent fatal errors -
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Hi Jesse,
Sorry for the long delay in replying to the thread, was busy with
OpenDaylight. See inline below:
On 9/12/14 12:26 AM, Jesse Gross wrote:
On Mon, Sep 8, 2014 at 5:43 AM, Lori Jakab wrote:
On 8/25/14 3:33 AM, Jesse Gross wrote:
On Thu, Aug 21, 2014 at 12:24 PM, Lori Jakab wrote:
When trying to install the kernel module rpm built for RHEL7,
the install failed with following conflicts:
# rpm -i kmod-openvswitch-2.3.1-1.el7.x86_64.rpm
file /lib/modules/3.10.0-123.8.1.el7.x86_64/modules.devname
from install of kmod-openvswitch-2.3.1-1.el7.x86_64 conflicts
with f
55 matches
Mail list logo
