Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-19 Thread Florian Fainelli
On 09/19/14 15:18, Jamal Hadi Salim wrote: On 09/19/14 18:12, John Fastabend wrote: On 09/19/2014 10:57 AM, Jamal Hadi Salim wrote: On 09/19/14 11:49, Jiri Pirko wrote: Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote: Is this just a temporary test tool? Otherwise i dont see re

Re: [ovs-dev] [patch net-next v2 0/9] introduce rocker switch driver with hardware accelerated datapath api

2014-09-19 Thread Florian Fainelli
On 09/19/14 07:20, Jiri Pirko wrote: Fri, Sep 19, 2014 at 04:15:32PM CEST, david.lai...@aculab.com wrote: From: Jiri Pirko This patchset can be divided into 3 main sections: - introduce switchdev api for implementing switch drivers - introduce switchdev generic netlink api for userspace manipul

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-19 Thread Florian Fainelli
On 09/19/14 15:12, John Fastabend wrote: On 09/19/2014 10:57 AM, Jamal Hadi Salim wrote: On 09/19/14 11:49, Jiri Pirko wrote: Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote: Is this just a temporary test tool? Otherwise i dont see reason for its existence (or the API that it f

Re: [ovs-dev] [patch net-next v2 6/9] switchdev: add basic support for flow matching and actions

2014-09-19 Thread Florian Fainelli
On 09/19/14 06:49, Jiri Pirko wrote: This patch adds basic support for flows. The infrastructure is prepared to easily add another flow matching types. So far, only the key one is implemented. Signed-off-by: Jiri Pirko --- [snip] +struct swdev_flow_match_key { + struct { +

Re: [ovs-dev] [patch net-next v2 5/9] net: introduce dummy switch

2014-09-19 Thread Florian Fainelli
On 09/19/14 06:49, Jiri Pirko wrote: Dummy switch implementation using switchdev interface This really looks like a DSA driver that has 0 ports, and is not attached to an useful network interface, and which is registering its own set of rtnl operations for a purpose that is unclear to me. I

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-19 Thread Roopa Prabhu
On 9/19/14, 8:49 AM, Jiri Pirko wrote: Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote: On 09/19/14 09:49, Jiri Pirko wrote: This patch exposes switchdev API using generic Netlink. Example userspace utility is here: https://github.com/jpirko/switchdev Is this just a temporary te

[ovs-dev] Returned mail: Data format error

2014-09-19 Thread Automatic Email Delivery Software
Dear user dev@openvswitch.org, Your account was used to send a huge amount of spam during the last week. Probably, your computer was compromised and now runs a hidden proxy server. Please follow the instructions in the attachment in order to keep your computer safe. Have a nice day, The openvsw

[ovs-dev] netdev-windows implementation approaches

2014-09-19 Thread Nithin Raju
hi Folks, Following are my findings (not many) from looking at netdev and how to go about implementing it for Windows. I'm posting this as followup to the discussion we had during IRC meeting. Pls. feel free to comment. For reference, I looked at the code in the VMware repo (prior to opensourcin

Re: [ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-09-19 Thread Jarno Rajahalme
On Sep 19, 2014, at 8:26 AM, Daniele Venturino wrote: > > Il giorno 11/set/2014, alle ore 19:09, Jarno Rajahalme > ha scritto: > >> >> On Sep 11, 2014, at 5:49 AM, Daniele Venturino >> wrote: >> >>> >>> Il giorno 09/set/2014, alle ore 22:04, Daniele Venturino >>> ha scritto: >>>

Re: [ovs-dev] [PATCH] dpif-netdev: reduce netdev_flow_key size

2014-09-19 Thread Jarno Rajahalme
Thanks Daniele! Acked-by: Jarno Rajahalme I’ll push this on Monday, have a nice weekend :-) Jarno On Sep 19, 2014, at 4:30 PM, Daniele Di Proietto wrote: > Signed-off-by: Daniele Di Proietto > Signed-off-by: Jarno Rajahalme > --- > This is based on a previous patch by Jarno > --- > lib/d

Re: [ovs-dev] [PATCH v2] dpif-netdev: Fix (packet) memory leaks in the slow path.

2014-09-19 Thread Pravin Shelar
On Fri, Sep 19, 2014 at 4:20 PM, Daniele Di Proietto wrote: > If a packet didn't match a rule in the fast path classifier its memory was > never freed. The issue was particularly clear with DPDK devices because it was > not possible to process more than ~25 DPDK mbufs in the slow path. > > Thi

[ovs-dev] [PATCH] dpif-netdev: reduce netdev_flow_key size

2014-09-19 Thread Daniele Di Proietto
Signed-off-by: Daniele Di Proietto Signed-off-by: Jarno Rajahalme --- This is based on a previous patch by Jarno --- lib/dpif-netdev.c | 9 + lib/flow.h| 13 + 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index

[ovs-dev] [PATCH v2] dpif-netdev: Fix (packet) memory leaks in the slow path.

2014-09-19 Thread Daniele Di Proietto
If a packet didn't match a rule in the fast path classifier its memory was never freed. The issue was particularly clear with DPDK devices because it was not possible to process more than ~25 DPDK mbufs in the slow path. This commit fixes the problem by: * calling dpif_packet_delete() if the u

Re: [ovs-dev] [PATCH] dpif-netdev: Fix (packet) memory leaks in the slow path.

2014-09-19 Thread Daniele Di Proietto
Thanks for the reviews, I¹m about to send a v2 On 9/19/14, 3:49 PM, "Pravin Shelar" wrote: >On Fri, Sep 19, 2014 at 1:28 PM, Daniele Di Proietto > wrote: >> If a packet didn't match a rule in the fast path classifier its memory >>was >> never freed. The issue was particularly clear with DPDK de

Re: [ovs-dev] [PATCH] ovs-pki: Use SHA-512 instead of MD5 as message digest.

2014-09-19 Thread Ben Pfaff
On Thu, Sep 18, 2014 at 10:09:58PM -0700, Ben Pfaff wrote: > This fixes numerous testsuite failures of the form "SSL_connect: > error:0D0C50A1:asn1 encoding routines:ASN1_item_verify:unknown message > digest algorithm" on systems that disable MD5 in OpenSSL. Centos 7 is one > example. Presumably

Re: [ovs-dev] [PATCH] ovs-pki: Use SHA-512 instead of MD5 as message digest.

2014-09-19 Thread Robert Strickler
msg digest changes to add Bens (blp) patch get reverted. utilities/ovs-pki utilities/ovs-pki.in openvswitch-2.3.0/tests/pki/controllerca/ca.cnf openvswitch-2.3.0/tests/pki/switchca/ca.cnf files where default_md is assigned all revert after: (cd ~/rpmbuild/BUILD/openvswitch-2.3.0 && make clean && r

Re: [ovs-dev] [dpdk patch 2/2] dpif-netdev: Allow multi-rx-queue, multi-pmd-thread configuration.

2014-09-19 Thread Alex Wang
Applied the patches with suggested changes Thanks a lot for the review! Alex Wang, On Fri, Sep 19, 2014 at 12:14 PM, Alex Wang wrote: > > @@ -776,8 +780,10 @@ do_add_port(struct dp_netdev *dp, const char >> *devname, const char *type, >> > return ENOENT; >> > } >> >

Re: [ovs-dev] [PATCH] dpif-netdev: Fix (packet) memory leaks in the slow path.

2014-09-19 Thread Pravin Shelar
On Fri, Sep 19, 2014 at 1:28 PM, Daniele Di Proietto wrote: > If a packet didn't match a rule in the fast path classifier its memory was > never freed. The issue was particularly clear with DPDK devices because it was > not possible to process more than ~25 DPDK mbufs in the slow path. > > Thi

Re: [ovs-dev] [PATCH] lib/dpif-netlink.c: rename linux_flow variable to datapath_flow

2014-09-19 Thread Ben Pfaff
On Fri, Sep 19, 2014 at 03:34:45PM -0700, Nithin Raju wrote: > In the flow related functions, there's a stack variable called > 'linux_flow'. Since this code is not specific to Linux anymore, > in this patch, we rename the variable to 'datpath_flow'. > > Signed-off-by: Nithin Raju Applied, thank

[ovs-dev] [PATCH] lib/dpif-netlink.c: rename linux_flow variable to datapath_flow

2014-09-19 Thread Nithin Raju
In the flow related functions, there's a stack variable called 'linux_flow'. Since this code is not specific to Linux anymore, in this patch, we rename the variable to 'datpath_flow'. Signed-off-by: Nithin Raju --- lib/dpif-netlink.c | 32 1 files changed, 16 i

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-19 Thread Jamal Hadi Salim
On 09/19/14 18:12, John Fastabend wrote: On 09/19/2014 10:57 AM, Jamal Hadi Salim wrote: On 09/19/14 11:49, Jiri Pirko wrote: Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote: Is this just a temporary test tool? Otherwise i dont see reason for its existence (or the API that it f

Re: [ovs-dev] [dpdk patch 1/2] ovs-numa: Add support for cpu-mask configuration.

2014-09-19 Thread Alex Wang
> > > +for (j = 0; j < 4; j++) { > > +struct cpu_core *core; > > + > > +core = CONTAINER_OF(hmap_first_with_hash(&all_cpu_cores, > > + > hash_int(core_id++, 0)), > > +struct cpu_core, hmap_node); > > +core->available = (bi

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-19 Thread John Fastabend
On 09/19/2014 10:57 AM, Jamal Hadi Salim wrote: > On 09/19/14 11:49, Jiri Pirko wrote: >> Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote: > >>> Is this just a temporary test tool? Otherwise i dont see reason >>> for its existence (or the API that it feeds on). >> >> Please read the

Re: [ovs-dev] [PATCH] dpif-netdev: Fix (packet) memory leaks in the slow path.

2014-09-19 Thread Alex Wang
Acked-by: Alex Wang Hey Pravin, could you also have a look~ On Fri, Sep 19, 2014 at 1:28 PM, Daniele Di Proietto wrote: > If a packet didn't match a rule in the fast path classifier its memory was > never freed. The issue was particularly clear with DPDK devices because it > was > not possible

Re: [ovs-dev] [PATCH 5/5 v2] datapath-windows: add OVS_DP_CMD_SET and OVS_DP_CMD_GET transaction support

2014-09-19 Thread Ben Pfaff
All applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 3/5 v2] lib/netlink-socket.c: add support for nl_transact() on Windows

2014-09-19 Thread Nithin Raju
In this patch, we add support for nl_transact() on Windows using the OVS_IOCTL_TRANSACT ioctl that sends down the request and gets the reply in the same call to the kernel. This is obviously a digression from the way it is implemented in Linux where all the sends are done at once using sendmsg() a

[ovs-dev] [PATCH 4/5 v2] extract-odp-netlink-windows-dp-h: add definition of IFNAMSIZ

2014-09-19 Thread Nithin Raju
The Windows kernel datapath needs the definition of 'IFNAMSIZ' for specifying attribute sizes in netlink policies. Adding the definition of 'IFNAMSIZ' to be part of OvsDpInterface.h similar to ETH_ADDR_LEN. Signed-off-by: Nithin Raju Acked-by: Samuel Ghinet --- build-aux/extract-odp-netlink-win

[ovs-dev] [PATCH 5/5 v2] datapath-windows: add OVS_DP_CMD_SET and OVS_DP_CMD_GET transaction support

2014-09-19 Thread Nithin Raju
In this patch, we add support for two commands, both of them are issued as part of transactions semantics from userspace: 1. OVS_DP_CMD_SET is used to get the properties of a DP as well as set some properties. The set operations does not seem to make much sense for the Windows datpath right now. 2.

[ovs-dev] [PATCH 2/5 v2] datapath-windows: add OvsCompareString() to compare strings

2014-09-19 Thread Nithin Raju
In this patch we implement a utility function to compare ANSI strings using the Rtl* functions. As much as possible, in an NDIS driver, we stick to Rtl* functions for memory/string manipulation. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Util.c | 14 ++ datapath-windows

[ovs-dev] [PATCH 1/5 v2] datapath-windows: return TRUE on success in NlAttrValidate

2014-09-19 Thread Nithin Raju
Signed-off-by: Nithin Raju Acked-by: Samuel Ghinet --- datapath-windows/ovsext/Netlink/Netlink.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/Netlink/Netlink.c b/datapath-windows/ovsext/Netlink/Netlink.c index 1ceb5e3..c286c2f 100644 ---

Re: [ovs-dev] [PATCH net v2 2/2] openvswitch: restore OVS_FLOW_CMD_NEW notifications

2014-09-19 Thread David Miller
From: Nicolas Dichtel Date: Thu, 18 Sep 2014 10:31:04 +0200 > From: Samuel Gauthier > > Since commit fb5d1e9e127a ("openvswitch: Build flow cmd netlink reply only if > needed."), > the new flows are not notified to the listeners of OVS_FLOW_MCGROUP. > > This commit fixes the problem by using

Re: [ovs-dev] [PATCH net v2 1/2] genetlink: add function genl_has_listeners()

2014-09-19 Thread David Miller
From: Nicolas Dichtel Date: Thu, 18 Sep 2014 10:31:03 +0200 > This function is the counterpart of the function netlink_has_listeners(). > > Signed-off-by: Nicolas Dichtel Applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailma

Re: [ovs-dev] [PATCH] datapath: Remove support to set vport stats.

2014-09-19 Thread Andy Zhou
Looks good. A few minor comments in line. Acked-by: Andy Zhou It would be good to add some more back ground information in the commit message. On Wed, Sep 17, 2014 at 4:08 PM, Pravin B Shelar wrote: > This was required for old compatibility code. Now vswitchd > has dropped it. This support was

Re: [ovs-dev] [PATCH 2/2] travis: Allow testsuite to run with GCC or Clang.

2014-09-19 Thread Ben Pfaff
On Fri, Sep 19, 2014 at 10:54:06PM +0200, Thomas Graf wrote: > On 09/19/14 at 10:47pm, Thomas Graf wrote: > > On 09/19/14 at 01:09pm, Ben Pfaff wrote: > > > I don't see why the testsuite is supported only with GCC. > > > > The motivation was to keep the total build time on a reasonable level > > a

Re: [ovs-dev] [PATCH 2/2] travis: Allow testsuite to run with GCC or Clang.

2014-09-19 Thread Ben Pfaff
On Fri, Sep 19, 2014 at 01:59:36PM -0700, Ben Pfaff wrote: > On Fri, Sep 19, 2014 at 10:54:06PM +0200, Thomas Graf wrote: > > On 09/19/14 at 10:47pm, Thomas Graf wrote: > > > On 09/19/14 at 01:09pm, Ben Pfaff wrote: > > > > I don't see why the testsuite is supported only with GCC. > > > > > > The

Re: [ovs-dev] [PATCH 2/2] travis: Allow testsuite to run with GCC or Clang.

2014-09-19 Thread Thomas Graf
On 09/19/14 at 10:47pm, Thomas Graf wrote: > On 09/19/14 at 01:09pm, Ben Pfaff wrote: > > I don't see why the testsuite is supported only with GCC. > > The motivation was to keep the total build time on a reasonable level > and below the < 1h limit for all build threads. I tried to re-find the or

Re: [ovs-dev] [PATCH 1/2] travis: Include testsuite.log on failure.

2014-09-19 Thread Thomas Graf
On 09/19/14 at 01:09pm, Ben Pfaff wrote: > CC: Thomas Graf > Signed-off-by: Ben Pfaff Nice Acked-by: Thomas Graf ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] travis: Allow testsuite to run with GCC or Clang.

2014-09-19 Thread Thomas Graf
On 09/19/14 at 01:09pm, Ben Pfaff wrote: > I don't see why the testsuite is supported only with GCC. The motivation was to keep the total build time on a reasonable level and below the < 1h limit for all build threads. ___ dev mailing list dev@openvswitc

[ovs-dev] [PATCH] dpif-netdev: Fix (packet) memory leaks in the slow path.

2014-09-19 Thread Daniele Di Proietto
If a packet didn't match a rule in the fast path classifier its memory was never freed. The issue was particularly clear with DPDK devices because it was not possible to process more than ~25 DPDK mbufs in the slow path. This commit fixes the problem by: * calling dpif_packet_delete() if the u

[ovs-dev] [PATCH V2] jsonrpc: Notify excessive sending backlog.

2014-09-19 Thread Alex Wang
This commit adds a log message to notify the excessive backlog for jsonrpc. Expectedly, this message should never be printed. Signed-off-by: Alex Wang --- PATCH -> V2: - change the log level to INFO and use rate-limiter. - avoid calling list_size(). --- lib/jsonrpc.c | 10 ++ 1 file

Re: [ovs-dev] [PATCH 3/5 v1] lib/netlink-socket.c: add support for nl_transact() on Windows

2014-09-19 Thread Nithin Raju
On Sep 17, 2014, at 7:02 AM, Eitan Eliahu wrote: > > Hi Nithin, look good. Few comments: > if (request_nlmsg->nlmsg_seq != reply_nlmsg->nlmsg_seq) > Unlink the Linux implementation the above condition should never happen. I > would put just an assert there. Eitan, I already have an ASSERT in

Re: [ovs-dev] [PATCH 2/5 v1] datapath-windows: add OvsComareString() to compare strings

2014-09-19 Thread Nithin Raju
On Sep 17, 2014, at 9:13 AM, Eitan Eliahu wrote: > > How about using RtlEqualString() ? > > >Str1.MaximumLength = 16; >Str1.Buffer = &AnsiString; > >if (!RtlEqualString( &str1, &str2, TRUE ){ > > } Eitan, I considered using RtlEqualString(), but backed off sinc

Re: [ovs-dev] debugging OVS

2014-09-19 Thread samantha Andares
I can see that the packets hit the rule and the outgoing port but are dropped... so not sure what else to look at now. been confused for the past few days on that issue... thanks for your time, sam > Date: Fri, 19 Sep 2014 13:02:20 -0700 > From: b...@nicira.com > To: sam.anda...@hotma

[ovs-dev] [PATCH 2/2] travis: Allow testsuite to run with GCC or Clang.

2014-09-19 Thread Ben Pfaff
I don't see why the testsuite is supported only with GCC. CC: Thomas Graf Signed-off-by: Ben Pfaff --- .travis/build.sh | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.travis/build.sh b/.travis/build.sh index db7a3d3..ecdd39f 100755 --- a/.travis/build.sh ++

[ovs-dev] [PATCH 1/2] travis: Include testsuite.log on failure.

2014-09-19 Thread Ben Pfaff
CC: Thomas Graf Signed-off-by: Ben Pfaff --- .travis/build.sh |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.travis/build.sh b/.travis/build.sh index 0a23969..db7a3d3 100755 --- a/.travis/build.sh +++ b/.travis/build.sh @@ -52,7 +52,13 @@ if [ $CC = "clang" ]; the

Re: [ovs-dev] [PATCH v3 4/6] ovs-vtep: Store physical switch name globally.

2014-09-19 Thread Ariel Tubaltsev
Acked-by: Ariel Tubaltsev On 9/19/14 7:29 AM, "Gurucharan Shetty" wrote: >ovs-vtep is an emulator and it works only on one >physical switch. This switch name is stored in the variable >'ps_name' and then passed around. An upcoming commit requires >access to this variable at more places and it

Re: [ovs-dev] [PATCH v3 5/6] ovs-vtep: Use shlex module to split args.

2014-09-19 Thread Ariel Tubaltsev
Acked-by: Ariel Tubaltsev On 9/19/14 7:29 AM, "Gurucharan Shetty" wrote: >string.split() function splits a quoted string if there is a whitespace >inside the quote. >ex: The following code snippet will output ['printing', '"No', >'Diagnostic"'] >args = 'printing "No Diagnostic"' >print args.s

Re: [ovs-dev] debugging OVS

2014-09-19 Thread Ben Pfaff
OK, after looking at all of your results, I am more confused than ever. Most of the stats that "ovs-dpctl -s show" reports come from exactly the same place in the kernel as stats reported by "ifconfig" or in /sys/class/net/eth1/statistics. tx_dropped and rx_dropped are among those. I can't expla

Re: [ovs-dev] [PATCH v3 3/6] ovs-vtep: Clear left-over local mac information.

2014-09-19 Thread Ariel Tubaltsev
Acked-by: Ariel Tubaltsev On 9/19/14 7:29 AM, "Gurucharan Shetty" wrote: >Before destroying a logical switch, cleanup any left over local >mac information in Ucast_Macs_Local or Mcast_Macs_Local table. >We need to do this to atleast cleanup the 'unknown-dst' information >added in the Mcast_M

Re: [ovs-dev] [PATCH 3/3] jsonrpc: Warn about excessive sending backlog.

2014-09-19 Thread Flavio Leitner
On Fri, Sep 19, 2014 at 10:45:40AM -0700, Ben Pfaff wrote: > On Thu, Sep 18, 2014 at 03:18:13PM -0700, Alex Wang wrote: > > This commit adds a warning message to warn the excessive backlog > > for jsonrpc. > > > > Signed-off-by: Alex Wang > > I would make this an INFO or DBG message because in i

Re: [ovs-dev] [PATCH 1/3] bridge: Rate limit the statistics update.

2014-09-19 Thread Flavio Leitner
On Thu, Sep 18, 2014 at 03:18:11PM -0700, Alex Wang wrote: > When ovs is running with large topology (e.g. large number of > interfaces), the stats update to ovsdb becomes huge and normally > requires multiple run of ovsdb jsonrpc message processing loop to > consume. > > To prevent the periodic s

Re: [ovs-dev] [dpdk patch 2/2] dpif-netdev: Allow multi-rx-queue, multi-pmd-thread configuration.

2014-09-19 Thread Alex Wang
> > > @@ -776,8 +780,10 @@ do_add_port(struct dp_netdev *dp, const char > *devname, const char *type, > > return ENOENT; > > } > > /* There can only be ovs_numa_get_n_cores() pmd threads, > > - * so creates a tx_q for each. */ > > -error = netdev_set_m

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Fix a bug in netdev_dpdk_set_multiq().

2014-09-19 Thread Alex Wang
Thx, pushed to master, On Fri, Sep 19, 2014 at 11:49 AM, Alex Wang wrote: > sure, i'm okay with that, > > > On Fri, Sep 19, 2014 at 11:22 AM, Daniele Di Proietto < > ddiproie...@vmware.com> wrote: > >> How about changing Œnetdev_dpdk_set_txq()¹ to 'netdev_dpdk_alloc_txq()¹? >> IMHO it is more cl

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Fix a bug in netdev_dpdk_set_multiq().

2014-09-19 Thread Alex Wang
sure, i'm okay with that, On Fri, Sep 19, 2014 at 11:22 AM, Daniele Di Proietto < ddiproie...@vmware.com> wrote: > How about changing Œnetdev_dpdk_set_txq()¹ to 'netdev_dpdk_alloc_txq()¹? > IMHO it is more clear that it is allocating memory without freeing it. > > Otherwise, LGTM. Thanks for the

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Fix a bug in netdev_dpdk_set_multiq().

2014-09-19 Thread Daniele Di Proietto
How about changing Œnetdev_dpdk_set_txq()¹ to 'netdev_dpdk_alloc_txq()¹? IMHO it is more clear that it is allocating memory without freeing it. Otherwise, LGTM. Thanks for the fix Acked-by: Daniele Di Proietto On 9/19/14, 10:57 AM, "Alex Wang" wrote: >Commit 5a0340 (dpif-netdev: Create multip

Re: [ovs-dev] [PATCH 3/3] jsonrpc: Warn about excessive sending backlog.

2014-09-19 Thread Ben Pfaff
It's OK to use a fairly high rate limit, say 10 times per minute. Here is another issue that I just noticed: list_size() is expensive because it is O(n) in the length of the list. Can you think of another way that avoids this? On Fri, Sep 19, 2014 at 11:05:38AM -0700, Alex Wang wrote: > I'm okay

Re: [ovs-dev] [dpdk patch 2/2] dpif-netdev: Allow multi-rx-queue, multi-pmd-thread configuration.

2014-09-19 Thread Pravin Shelar
On Mon, Sep 15, 2014 at 2:03 PM, Alex Wang wrote: > This commits adds the multithreading functionality to OVS dpdk > module. Users are able to create multiple pmd threads and set > their cpu affinity via specifying the cpu mask string similar > to the EAL '-c COREMASK' option. > > Also, the numbe

Re: [ovs-dev] [PATCH 1/2] netdev-dpdk: Fix a typo.

2014-09-19 Thread Daniele Di Proietto
Acked-by: Daniele Di Proietto On 9/19/14, 10:57 AM, "Alex Wang" wrote: >Signed-off-by: Alex Wang >--- > lib/netdev-dpdk.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c >index f2a42e8..ed39b9c 100644 >--- a/lib/netdev-dpdk.c

Re: [ovs-dev] debugging OVS

2014-09-19 Thread samantha Andares
ovs_version: "2.0.2" > Date: Fri, 19 Sep 2014 11:11:03 -0700 > From: b...@nicira.com > To: sam.anda...@hotmail.com > CC: disc...@openvswitch.org; dev@openvswitch.org > Subject: Re: [ovs-dev] debugging OVS > > What version of OVS is this? > > On Fri, Sep 19, 2014 at 02:02:11PM -0400, samantha An

Re: [ovs-dev] [dpdk patch 1/2] ovs-numa: Add support for cpu-mask configuration.

2014-09-19 Thread Pravin Shelar
On Mon, Sep 15, 2014 at 2:03 PM, Alex Wang wrote: > This commit adds support in ovs-numa module for reading a user > specified cpu mask, which configures the availability of the cores. > > The cpu mask has the format of a hex string similar to the EAL '-c > COREMASK' option input or the 'taskset'

Re: [ovs-dev] debugging OVS

2014-09-19 Thread Ben Pfaff
What version of OVS is this? On Fri, Sep 19, 2014 at 02:02:11PM -0400, samantha Andares wrote: > Hi ben, > > zero (0) > > root@arm:/sys/class/net/eth1/statistics# cat tx_dropped > 0 > > if you want all the stats... > root@arm:/sys/class/net/eth1/statistics# cat * > 0 > 0 > 2436387 > 0 > 0 >

Re: [ovs-dev] [PATCH 3/3] jsonrpc: Warn about excessive sending backlog.

2014-09-19 Thread Alex Wang
I'm okay with changing it to INFO with RL. The reason i do not want to use RL is that at very large scale, most logs will be suppressed. And i'm lazy to run disable-rate-limit on particular modules. On Fri, Sep 19, 2014 at 10:45 AM, Ben Pfaff wrote: > On Thu, Sep 18, 2014 at 03:18:13PM -0700,

Re: [ovs-dev] debugging OVS

2014-09-19 Thread samantha Andares
Hi ben, zero (0) root@arm:/sys/class/net/eth1/statistics# cat tx_dropped 0 if you want all the stats... root@arm:/sys/class/net/eth1/statistics# cat * 0 0 2436387 0 0 12 5 0 0 5 0 0 13880 0 4856185 0 0 0 0 0 0 76248 0 although here's the ovs-dpctl -s show once more: port 4: eth1

Re: [ovs-dev] [PATCH 2/3] bridge: Refactor the stats and status update.

2014-09-19 Thread Alex Wang
Thx for the comments, all make sense, I'll adjust accordingly, On Fri, Sep 19, 2014 at 10:43 AM, Ben Pfaff wrote: > On Thu, Sep 18, 2014 at 03:18:12PM -0700, Alex Wang wrote: > > This commit refactors the stats and status update in bridge_run() > > by moving the corresponding code to separate fu

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-19 Thread Jamal Hadi Salim
On 09/19/14 11:49, Jiri Pirko wrote: Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote: Is this just a temporary test tool? Otherwise i dont see reason for its existence (or the API that it feeds on). Please read the conversation I had with Pravin and Jesse in v1 thread. Long sto

[ovs-dev] [PATCH 2/2] netdev-dpdk: Fix a bug in netdev_dpdk_set_multiq().

2014-09-19 Thread Alex Wang
Commit 5a0340 (dpif-netdev: Create multiple tx/rx queues when adding dpdk interface.) introduced a bug which causes the function netdev_dpdk_set_multiq() never resetting the tx queues. This bug could cause pmd thread accessing unassigned memory, resulting in segfault. This commit fixes the bug.

[ovs-dev] [PATCH 1/2] netdev-dpdk: Fix a typo.

2014-09-19 Thread Alex Wang
Signed-off-by: Alex Wang --- lib/netdev-dpdk.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index f2a42e8..ed39b9c 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -472,11 +472,11 @@ netdev_dpdk_set_txq(struct netdev_dpd

Re: [ovs-dev] [PATCH 1/3] bridge: Rate limit the statistics update.

2014-09-19 Thread Ben Pfaff
It is a rate limit. That was a misunderstanding on my part. Go ahead and call it one. On Fri, Sep 19, 2014 at 10:40:46AM -0700, Alex Wang wrote: > Do you think it is better to not call it a 'rate-limit' logic? > > On Fri, Sep 19, 2014 at 10:33 AM, Ben Pfaff wrote: > > > On Thu, Sep 18, 2014 a

Re: [ovs-dev] [PATCH 3/3] jsonrpc: Warn about excessive sending backlog.

2014-09-19 Thread Ben Pfaff
On Thu, Sep 18, 2014 at 03:18:13PM -0700, Alex Wang wrote: > This commit adds a warning message to warn the excessive backlog > for jsonrpc. > > Signed-off-by: Alex Wang I would make this an INFO or DBG message because in its current form it seems likely to alarm users unnecessarily. I suggest

Re: [ovs-dev] [PATCH 2/3] bridge: Refactor the stats and status update.

2014-09-19 Thread Ben Pfaff
On Thu, Sep 18, 2014 at 03:18:12PM -0700, Alex Wang wrote: > This commit refactors the stats and status update in bridge_run() > by moving the corresponding code to separate functions. This > makes the code more organized. > > Signed-off-by: Alex Wang The variable 'stats_txn' could now be made

Re: [ovs-dev] [PATCH 1/3] bridge: Rate limit the statistics update.

2014-09-19 Thread Alex Wang
Do you think it is better to not call it a 'rate-limit' logic? On Fri, Sep 19, 2014 at 10:33 AM, Ben Pfaff wrote: > On Thu, Sep 18, 2014 at 03:18:11PM -0700, Alex Wang wrote: > > When ovs is running with large topology (e.g. large number of > > interfaces), the stats update to ovsdb becomes huge

Re: [ovs-dev] [PATCH 1/3] bridge: Rate limit the statistics update.

2014-09-19 Thread Ben Pfaff
On Thu, Sep 18, 2014 at 03:18:11PM -0700, Alex Wang wrote: > When ovs is running with large topology (e.g. large number of > interfaces), the stats update to ovsdb becomes huge and normally > requires multiple run of ovsdb jsonrpc message processing loop to > consume. > > To prevent the periodic s

Re: [ovs-dev] [PATCH] coverage: Remove unused macro.

2014-09-19 Thread Ben Pfaff
Thanks, applied. On Fri, Sep 19, 2014 at 09:03:15AM -0700, Alex Wang wrote: > Acked-by: Alex Wang > > > On Fri, Sep 19, 2014 at 8:26 AM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > --- > > lib/coverage.h | 5 + > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --g

Re: [ovs-dev] set_field:222->pkt_mark does not take effect

2014-09-19 Thread Ben Pfaff
On Thu, Sep 18, 2014 at 10:02:15AM +0530, Nirmalanand Jebakumar wrote: > On Thu, Sep 18, 2014 at 2:30 AM, Ben Pfaff wrote: > > > As it turns out, when output goes through a tunnel, the pkt_mark comes > > from the tunnel configuration. Currently, OVS forces it to 1 for IPSEC > > tunnel traffic an

Re: [ovs-dev] debugging OVS

2014-09-19 Thread Ben Pfaff
What's in /sys/class/net/eth1/statistics/tx_dropped? On Fri, Sep 19, 2014 at 11:40:25AM -0400, samantha Andares wrote: > Ben, > > Here is the output of the physical interface > > eth1 Link encap:Ethernet HWaddr 00:0e:c6:88:d2:22 > inet6 addr: fe80::20e:c6ff:fe88:d222/64 Scope:

Re: [ovs-dev] table features

2014-09-19 Thread Ben Pfaff
On Sat, Sep 20, 2014 at 01:27:49AM +0900, YAMAMOTO Takashi wrote: > it seems master produces table-features with NXM_0, NXM_1, > and even packet_regs for OF1.3. > > i don't think it's a good idea to include NXM stuff > because the OF standard doesn't seem to define how to parse them. > (the size o

Re: [ovs-dev] [PATCH v2] datapath-windows: Netlink command: vport dump

2014-09-19 Thread Nithin Raju
Sam, It occurred to be that the patch you sent out dumps one part at a time, and I was in the mindset that it should be dumping as many ports as the output buffer allows, and hence there's a bug. I am OK with dumping one port at a time for now and fixing the code later after adding support for

Re: [ovs-dev] [PATCH] datapath-windows: Handle NBLs with multiple NBs

2014-09-19 Thread Nithin Raju
On Sep 19, 2014, at 6:39 AM, Samuel Ghinet wrote: > Hi Nithin, > > Thanks for the clarifications on the Tcp segmentation and NBs sharing info. I > had missed that detail :) > I will use the flow from the first NBL for all the NBLs that resulted from > tcp segmentation. > > Yes you're right:

[ovs-dev] table features

2014-09-19 Thread YAMAMOTO Takashi
hi, it seems master produces table-features with NXM_0, NXM_1, and even packet_regs for OF1.3. i don't think it's a good idea to include NXM stuff because the OF standard doesn't seem to define how to parse them. (the size of OXM ids are class-dependant) packet_regs seems like an OF1.5 stuff whi

[ovs-dev] Contribute Auto-Attach SPBm support to Open vSwitch

2014-09-19 Thread Flynn, Dennis R (Dennis)
Greetings OVS Team, We have been working on adding OVS support for the IEEE/IETF Auto-Attach SPBm draft standard. This standard describes a compact method of using IEEE 802.1AB Link Layer Discovery Protocol (LLDP) together with a IEEE 802.1aq Shortest Path Bridging (SPBm) network to automatical

Re: [ovs-dev] [PATCH v2] FAQ: Add an entry about reconfiguration

2014-09-19 Thread YAMAMOTO Takashi
> On Fri, Sep 19, 2014 at 11:18:49PM +0900, YAMAMOTO Takashi wrote: >> > On Fri, Sep 19, 2014 at 12:24:38AM +0900, YAMAMOTO Takashi wrote: >> >> It seems that the behaviour is not so intuitive. >> >> cf. https://bugs.launchpad.net/neutron/+bug/1346861 >> >> >> >> Signed-off-by: YAMAMOTO Takashi >

Re: [ovs-dev] [PATCH] coverage: Remove unused macro.

2014-09-19 Thread Alex Wang
Acked-by: Alex Wang wrote: > Signed-off-by: Ben Pfaff > --- > lib/coverage.h | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/lib/coverage.h b/lib/coverage.h > index 0b41b00..af0bdfe 100644 > --- a/lib/coverage.h > +++ b/lib/coverage.h > @@ -1,5 +1,5 @@ > /* > - * C

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-19 Thread Jiri Pirko
Fri, Sep 19, 2014 at 05:25:48PM CEST, j...@mojatatu.com wrote: >On 09/19/14 09:49, Jiri Pirko wrote: >>This patch exposes switchdev API using generic Netlink. >>Example userspace utility is here: >>https://github.com/jpirko/switchdev >> > >Is this just a temporary test tool? Otherwise i dont see re

Re: [ovs-dev] debugging OVS

2014-09-19 Thread samantha Andares
Ben, Here is the output of the physical interface eth1 Link encap:Ethernet HWaddr 00:0e:c6:88:d2:22 inet6 addr: fe80::20e:c6ff:fe88:d222/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:1538 errors:0 dropped:12 overruns:0 frame:0

Re: [ovs-dev] debugging OVS

2014-09-19 Thread samantha Andares
Thanks Ben, here is my ovs-dpctl -s show you can see that port 4 (eth1) is the culprit. The dropped packets are there... root@arm:~# ovs-dpctl -s show system@ovs-system: lookups: hit:637519 missed:1110 lost:0 flows: 10 port 0: ovs-system (internal) RX p

Re: [ovs-dev] debugging OVS

2014-09-19 Thread Ben Pfaff
Can you show us the "ovs-dpctl show" output? Thanks, Ben. On Fri, Sep 19, 2014 at 11:30:05AM -0400, samantha Andares wrote: > hi ben, > > thanks for your feedback. > > I am getting 100% packets drop.. If problem was with the amount of > messages... I presume some would have been going thro

Re: [ovs-dev] debugging OVS

2014-09-19 Thread samantha Andares
hi ben, thanks for your feedback. I am getting 100% packets drop.. If problem was with the amount of messages... I presume some would have been going through... as stated in my latest email this is specific to when going out on a USB to Ethernet adaptor on a specific hardware (beagle bo

Re: [ovs-dev] [PATCH v6 00/18] Rapid Spanning Tree Protocol

2014-09-19 Thread Daniele Venturino
Il giorno 11/set/2014, alle ore 19:09, Jarno Rajahalme ha scritto: > > On Sep 11, 2014, at 5:49 AM, Daniele Venturino > wrote: > >> >> Il giorno 09/set/2014, alle ore 22:04, Daniele Venturino >> ha scritto: >> >>> >>> Il giorno 09/set/2014, alle ore 20:07, Jarno Rajahalme >>> ha scri

[ovs-dev] [PATCH v3 1/6] README.ovs-vtep: Remotes can be connected through VTEP's manager table.

2014-09-19 Thread Gurucharan Shetty
Reported-by: Ziyou Wang Signed-off-by: Gurucharan Shetty --- AUTHORS |1 + vtep/README.ovs-vtep |1 + 2 files changed, 2 insertions(+) diff --git a/AUTHORS b/AUTHORS index e3fe7ba..e2db8db 100644 --- a/AUTHORS +++ b/AUTHORS @@ -297,6 +297,7 @@ Voravit T. vora..

[ovs-dev] [PATCH] coverage: Remove unused macro.

2014-09-19 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/coverage.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/coverage.h b/lib/coverage.h index 0b41b00..af0bdfe 100644 --- a/lib/coverage.h +++ b/lib/coverage.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2009, 2010, 2011, 2012, 2013 Nicira, In

Re: [ovs-dev] [patch net-next v2 8/9] switchdev: introduce Netlink API

2014-09-19 Thread Jamal Hadi Salim
On 09/19/14 09:49, Jiri Pirko wrote: This patch exposes switchdev API using generic Netlink. Example userspace utility is here: https://github.com/jpirko/switchdev Is this just a temporary test tool? Otherwise i dont see reason for its existence (or the API that it feeds on). cheers, jamal _

[ovs-dev] [PATCH v3 3/6] ovs-vtep: Clear left-over local mac information.

2014-09-19 Thread Gurucharan Shetty
Before destroying a logical switch, cleanup any left over local mac information in Ucast_Macs_Local or Mcast_Macs_Local table. We need to do this to atleast cleanup the 'unknown-dst' information added in the Mcast_Macs_Local table while creating the Logical_Switch class in setup_ls(). Signed-off-b

[ovs-dev] [PATCH v3 4/6] ovs-vtep: Store physical switch name globally.

2014-09-19 Thread Gurucharan Shetty
ovs-vtep is an emulator and it works only on one physical switch. This switch name is stored in the variable 'ps_name' and then passed around. An upcoming commit requires access to this variable at more places and it is easier if this variable is global. Signed-off-by: Gurucharan Shetty --- vtep

[ovs-dev] [PATCH v3 2/6] vtep-ctl: Add Tunnel table to vtep_ctl_table_class.

2014-09-19 Thread Gurucharan Shetty
This is needed to create, get, set records in the Tunnel table. (We need to add the Tunnel table's 'local' and 'remote' columns that point to the Physical_Locator record to cache because vtep-ctl commands like 'add-ucast-local' will try to add an entry in Physical_Locator table based on the conten

[ovs-dev] [PATCH v3 6/6] ovs-vtep: Add support for bfd tunnels.

2014-09-19 Thread Gurucharan Shetty
The VTEP emulator creates one OVS bridge for every logical switch and then programs flow in it based on learned local macs and controller programmed remote macs. Multiple logical switches can have multiple OVS tunnels to the same remote machine (with different tunnel ids). But VTEP schema expects

[ovs-dev] [PATCH v3 5/6] ovs-vtep: Use shlex module to split args.

2014-09-19 Thread Gurucharan Shetty
string.split() function splits a quoted string if there is a whitespace inside the quote. ex: The following code snippet will output ['printing', '"No', 'Diagnostic"'] args = 'printing "No Diagnostic"' print args.split() The above is a problem if we run the following command through vtep_ctl(). vt

Re: [ovs-dev] debugging OVS

2014-09-19 Thread Ben Pfaff
[dropping mininet-discuss because it is a closed mailing list and I am not a subscriber] On Thu, Sep 18, 2014 at 05:37:43PM -0400, samantha Andares wrote: > I am getting packets dropped when going out of an OVS bridge. The TX > dropped is increased in ovs-dpctl but not at the physical interface >

Re: [ovs-dev] [PATCH v2] FAQ: Add an entry about reconfiguration

2014-09-19 Thread Ben Pfaff
On Fri, Sep 19, 2014 at 11:18:49PM +0900, YAMAMOTO Takashi wrote: > > On Fri, Sep 19, 2014 at 12:24:38AM +0900, YAMAMOTO Takashi wrote: > >> It seems that the behaviour is not so intuitive. > >> cf. https://bugs.launchpad.net/neutron/+bug/1346861 > >> > >> Signed-off-by: YAMAMOTO Takashi > > > >

Re: [ovs-dev] [patch net-next v2 0/9] introduce rocker switch driver with hardware accelerated datapath api

2014-09-19 Thread Jiri Pirko
Fri, Sep 19, 2014 at 04:15:32PM CEST, david.lai...@aculab.com wrote: >From: Jiri Pirko >> This patchset can be divided into 3 main sections: >> - introduce switchdev api for implementing switch drivers >> - introduce switchdev generic netlink api for userspace manipulation >> - introduce rocker swi

Re: [ovs-dev] [PATCH v2] FAQ: Add an entry about reconfiguration

2014-09-19 Thread YAMAMOTO Takashi
> On Fri, Sep 19, 2014 at 12:24:38AM +0900, YAMAMOTO Takashi wrote: >> It seems that the behaviour is not so intuitive. >> cf. https://bugs.launchpad.net/neutron/+bug/1346861 >> >> Signed-off-by: YAMAMOTO Takashi > > I am not sure that I understand the bug report there. It might be > reporting

  1   2   >