Re: [ovs-dev] [DPDK Upcalls v2 3/3] dpif-netdev: Streamline miss handling.

2014-08-17 Thread Joe Stringer
On 13 August 2014 06:24, Ben Pfaff wrote: > > dp_netdev_flow_add() goes to some trouble to log matches as if they > were provided as datapath flows, even though they aren't. I think > that match_format() would be simpler and probably less confusing. In the majority of cases, I agree---however t

[ovs-dev] [PATCH v11] Extend OVS IPFIX exporter to export tunnel headers

2014-08-17 Thread Wenyu Zhang
Extend IPFIX exporter to export tunnel headers when both input and output of the port. Add three other_config options in IPFIX table: enable-input-sampling, enable-output-sampling and enable-tunnel-sampling, to control whether sampling tunnel info, on which direction (input or output). Insert sampl

Re: [ovs-dev] [PATCH v10] Extend OVS IPFIX exporter to export tunnel headers

2014-08-17 Thread Wenyu Zhang
Thanks for the reviewing. I have applied the attached patch, and add a check about vport->ops->get_egress_tun_info before calling it, because that get_egress_tun_info() is only implemented on tunnel ports now. I will send the new patch later. Bests, Wenyu -Original Message- Fr

Re: [ovs-dev] [PATCH 1/4] datapath: Remove recirc stack depth limit check

2014-08-17 Thread Pravin Shelar
On Fri, Aug 15, 2014 at 3:12 AM, Andy Zhou wrote: > Future patches will change the recirc action implementation to not > using recursion. The stack depth detection is no longer necessary. > Once there is no recursion in OVS, only recursion left is recursion due to networking stack. networking stac

Re: [ovs-dev] [PATCH 2/4] datapath: Add per-CPU recirc stack infrasturcutre

2014-08-17 Thread Pravin Shelar
On Fri, Aug 15, 2014 at 3:12 AM, Andy Zhou wrote: > Future pathces will make use of those functions. > > Signed-off-by: Andy Zhou > --- > datapath/Modules.mk | 1 + > datapath/actions.c | 27 > datapath/actions.h | 90 > + >

Re: [ovs-dev] [PATCH 4/4] datapath: Implement recirc action without recursion

2014-08-17 Thread Pravin Shelar
On Fri, Aug 15, 2014 at 3:12 AM, Andy Zhou wrote: > Since kernel stack is limited in size, it is not wise to using > recursive function with large stack frames. > > This patch provides an alternative implementation of recirc action with > out using recursion. > > A recirc action can be embedded in

[ovs-dev] [PATCH] net/openvswitch/flow.c: Replace rcu_dereference() with rcu_access_pointer()

2014-08-17 Thread Andreea-Cristina Bernat
The "rcu_dereference()" call is used directly in a condition. Since its return value is never dereferenced it is recommended to use "rcu_access_pointer()" instead of "rcu_dereference()". Therefore, this patch makes the replacement. The following Coccinelle semantic patch was used: @@ @@ ( if( (