Samuel,
Is this a pre-cursor for implementing the persistent ports feature that the
cloudbase repo had implemented. We really liked that feature to be able to set
the port name from userspace.
Can the persistent port patch be implemented on the of the VPORT array data
structure we have today in
Sam,
There are lot of assumptions here about how code should be structured and
written. eg. there's an implicit assumption that 'Cleanup' should be defined.
Let's table this for sometime till we get the current code starts working with
netlink.
If you can point me to some code what is using the
On Aug 6, 2014, at 9:11 AM, Samuel Ghinet
wrote:
> Replace Types.h
>
> The coding style on windows kernel is to use uppercase for all types. This
> also applies to builtin types.
> We shouldn't use int64_t, uint64_t, etc. Instead, we should use windows style
> builtin types: INT64, UINT64, et
hi Sam,
I don't understand this change completely. Can you pls. give some background?
If someone else can ack it, that is fine with me.
> - Condition="'$(Configuration)|$(Platform)'=='Win8.1
> Debug|x64'">..\..\datapath\linux\compat\include\linux;$(IntDir);%(AdditionalIncludeDirectories);.
On Aug 6, 2014, at 9:14 AM, Samuel Ghinet
wrote:
> How it works:
> Say we have a list of OVS_FLOWs, where OVS_FLOW uses OVS_REF_COUNT.
>
> * The OVS_REF_COUNT must be initialized to 0 at object creation.
> * Assign a destruction function to the func ptr "Destroy" of OVS_REF_COUNT.
> * When you
On Aug 13, 2014, at 7:25 AM, Samuel Ghinet
wrote:
> Create a NBL for each NB when required
>
> ovs/ovs-issues#15
>
> All NET_BUFFERs of a NET_BUFFER_LIST must go through
> the pipeline: extract, find flow, execute. Previously,
> only the first NET_BUFFER of a NET_BUFFER_LIST was going
> throug
Pushed,
Jarno
On Aug 15, 2014, at 4:15 PM, Pravin Shelar wrote:
> On Fri, Aug 15, 2014 at 3:17 PM, Jarno Rajahalme
> wrote:
>> It could be possible that the thread misses a signal when it reads the
>> change_seq again after reload. Also, the counter has no dependent
>> data, so the memory
The netflow member was not used for anything, so it can be removed.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-dpif-upcall.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index 9f68a7d..a7c845e 100
"xlate_receive" did not tell much about what it is used for. We have
two users of it that only want the ofproto and the OF port number, use the
new xlate_lookup_ofproto() for those.
Fix the comments of xlate_receive() as we no longer change the flow.
Also, the helper ofproto_dpif_contains_flow()
xlate configuration (via xcfg) is already holding the references, so
the callers of xlate_receive() can safely use the returned pointers
upto the point when they quiesce. If the objects are needed for
longer term, the callers can take additional references themselves.
Signed-off-by: Jarno Rajahal
Seems better as we no longer modify the flow.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-dpif-upcall.c | 12 ++--
ofproto/ofproto-dpif-xlate.c |8
ofproto/ofproto-dpif-xlate.h |8
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/ofpro
On Fri, Aug 15, 2014 at 3:17 PM, Jarno Rajahalme wrote:
> It could be possible that the thread misses a signal when it reads the
> change_seq again after reload. Also, the counter has no dependent
> data, so the memory model for the atomic read can be relaxed.
>
> Signed-off-by: Jarno Rajahalme
It could be possible that the thread misses a signal when it reads the
change_seq again after reload. Also, the counter has no dependent
data, so the memory model for the atomic read can be relaxed.
Signed-off-by: Jarno Rajahalme
---
lib/dpif-netdev.c | 27 ++-
1 file
On Thu, Aug 14, 2014 at 10:03 PM, Joe Stringer wrote:
> This allows future patches to reuse the nla error detection code, by
> passing their own definitions for expected attribute lengths and types.
>
> Signed-off-by: Joe Stringer
> ---
> datapath/flow_netlink.c | 34 +++---
On 8/15/14, 2:13 PM, "Gurucharan Shetty" wrote:
>On Tue, Aug 12, 2014 at 5:39 PM, Pravin Shelar wrote:
>> On Tue, Aug 12, 2014 at 10:43 AM, Daniele Di Proietto
>> wrote:
>>> With this commit we move our DPDK support to 1.7.0.
>>> DPDK binaries (starting with dpdk 1.7.0) should be linked with
Not a review, only one vey small comment below,
Jarno
On Aug 15, 2014, at 12:43 PM, Daniele Di Proietto
wrote:
>
> + * A miniflow with a given hash can be in one of EM_FLOW_HASH_SEGS different
> + * entries. Given its hash (h), the miniflow can be in the entries whose
> index
> + * is:
> +
On Aug 13, 2014, at 8:16 AM, Alin Serdean
wrote:
> The following changes are just a start to begin a discussion.
>
> Bypass all epoll functionality.
>
> IOCP work the other way around than epoll: you get if the operation finished
> for a HANDLE in contrast of getting the number of file descrip
On Tue, Aug 12, 2014 at 5:39 PM, Pravin Shelar wrote:
> On Tue, Aug 12, 2014 at 10:43 AM, Daniele Di Proietto
> wrote:
>> With this commit we move our DPDK support to 1.7.0.
>> DPDK binaries (starting with dpdk 1.7.0) should be linked with
>> --whole-archive
>> to include pmd drivers
>>
> I upda
Samuel,
Thanks for writing this up. I don't agree with some of them, but do like some
of the suggestions. I am actually encouraged that the CodingStyle for
datapath-windows is evolving.
> - For types, use all upper case for all letters with words separated by '_'.
> If
> - camel casing is pre
Thx, applied to master,
On Fri, Aug 15, 2014 at 1:33 PM, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
> Thanks for taking care of this.
>
> Ethan
>
> On Fri, Aug 15, 2014 at 1:15 AM, Alex Wang wrote:
> > Commit cc377352d (ofproto: Reorganize in preparation for direct
> > dpdk upcalls.) in
2014-08-15 20:15 GMT+04:00 Ben Pfaff :
> https://github.com/openvswitch/ovs/releases/tag/v2.3
Thank, i' try to find 2.3.0 and miss it =)
--
Vasiliy Tolstov,
e-mail: v.tols...@selfip.ru
jabber: v...@selfip.ru
___
dev mailing list
dev@openvswitch.org
ht
Acked-by: Ethan Jackson
Thanks for taking care of this.
Ethan
On Fri, Aug 15, 2014 at 1:15 AM, Alex Wang wrote:
> Commit cc377352d (ofproto: Reorganize in preparation for direct
> dpdk upcalls.) introduced the bug that uses variable defined on
> the stack inside while loop for reading dpif upc
On Aug 15, 2014, at 1:24 PM, Ben Pfaff
wrote:
> I'm fine with this. I'd like someone else to review the actual
> Windows-specific bits.
Thanks Ben. Ankur and Saurabh have reviewed the Windows bits and are fine with
it. I am waiting for Alin and Samuel's review.
thanks,
Nithin
___
On Thu, Aug 14, 2014 at 08:35:36PM -0700, Nithin Raju wrote:
> The datapath interface defined in odp-netlink.h needs some extensions
> that are platform dependent. Some examples are the name of the communication
> device on Windows and a set of commands that are specific to Windows.
>
> In this ch
Since lookups in the classifier can be pretty expensive, we introduce this
(thread local) cache which simply compares the miniflows of the packets
Signed-off-by: Daniele Di Proietto
---
lib/dpif-netdev.c | 422 +-
1 file changed, 357 insertions
This new function uses ofpbuf_rss(), or hashes the packet 5-tuple, to get the
hash of a packet. Used by OVS_ACTION_ATTR_HASH and future commits.
Signed-off-by: Daniele Di Proietto
---
lib/dpif-netdev.c | 29 ++---
1 file changed, 22 insertions(+), 7 deletions(-)
diff --g
ofpbuf_rss() is introduced to get the RSS hash from the NIC. It works only for
packets received by DPDK (otherwise it returns 0, which tells the caller to
compute the hash in another way)
This commit also configure DPDK devices to compute RSS hash for UDP and IPv6
packets
Signed-off-by: Daniele D
This series introduces in dpif-netdev an exact match cache for frequently
used flows. It uses the RSS hash (currently implemented only for netdev-dpdk)
to search the miniflow in an hash table.
While there might be still some tuning left to do, these patch provides
significant performance improveme
On Fri, Aug 15, 2014 at 12:53 AM, Wenyu Zhang wrote:
> Extend IPFIX exporter to export tunnel headers when both input and output
> of the port.
> Add three other_config options in IPFIX table: enable-input-sampling,
> enable-output-sampling and enable-tunnel-sampling, to control whether
> sampling
On Fri, Aug 15, 2014 at 9:44 AM, Ben Pfaff wrote:
> [adding Jesse and ovs-dev]
>
> On Thu, Aug 14, 2014 at 11:03:52AM -0400, Neal Shrader wrote:
>> I came across an issue today what I was attempting to modify the source
>> ipv6 address of a router advertisement generated from a local server. The
The checksum of ICMPv6 packets uses the IP pseudoheader as part of
the calculation, unlike ICMP in IPv4. This was not implemented,
which means that modifying the IP addresses of an ICMPv6 packet
would cause the checksum to no longer be correct as the psuedoheader
did not match.
Reported-by: Neal S
mininet uses the Open vSwitch controller by default, for testing.
CC: 757...@bugs.debian.org
Reported-at: https://bugs.debian.org/757761
Requested-by: Tomasz Buchert
Requested-by: Dariusz Dwornikowski
Signed-off-by: Ben Pfaff
---
v1->v2: Drop numerous incorrectly included changes. Fix various
On Thu, Aug 14, 2014 at 12:59:05PM -0700, Justin Pettit wrote:
> On August 14, 2014 at 11:16:51 AM, Ben Pfaff (b...@nicira.com) wrote:
>
> > diff --git a/FAQ b/FAQ
> > index 3470983..7fbf9a9 100644
> > --- a/FAQ
> > +++ b/FAQ
> > @@ -89,9 +89,10 @@ A: Distributed vswitch applications (e.g., VMware
Hey Guru,
I can add a follow up on the after the version 2 to propose a solution on how
to make the compilation faster :).
I can add the switch for the kernel driver on windows no problem.
Thanks for your thoughts as well,
Alin.
-Mesaj original-
De la: Gurucharan Shetty [mailto:shet..
On Fri, Aug 15, 2014 at 06:02:56AM +0900, Simon Horman wrote:
> On Thu, Aug 14, 2014 at 11:17:30AM -0700, Ben Pfaff wrote:
> > The recent mailing list thread about MPLS reminded me that the FAQ needs an
> > update.
> >
> > CC: Simon Horman
> > Signed-off-by: Ben Pfaff
>
>
> Acked-by: Simon Hor
On Wed, Aug 13, 2014 at 03:14:32PM +, Alin Serdean wrote:
> Issue: cannot build properly when local date differs from UTC date.
>
> Since Stampinf stamps the driver inf file with the local date set the Inf2Cat
> to use local date as well.
>
> Signed-off-by: Alin Gabriel Serdean
Applied, tha
On Wed, Aug 13, 2014 at 8:13 AM, Alin Serdean
wrote:
> This commit adds to the automake build system the full build required by the
> forwarding extension solution.
>
> It will help a lot in the future CI to check the full build of the project.
>
> Also the documentation was updated.
>
> Signed-of
By the way, if you feel the need to CC me (which is fine), I much
prefer that you use b...@nicira.com instead of bpf...@vmware.com.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
[adding Jesse and ovs-dev]
On Thu, Aug 14, 2014 at 11:03:52AM -0400, Neal Shrader wrote:
> I came across an issue today what I was attempting to modify the source
> ipv6 address of a router advertisement generated from a local server. The
> flow in question looks like:
>
> ovs-ofctl add-flow pub
Current hash uses just the dl_dst field. This patch expands the hash to
include all L2, L3 and L4 fields, allowing for more balanced selection.
Signed-off-by: Srini Seetharaman
---
ofproto/ofproto-dpif-xlate.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/
On Fri, Aug 15, 2014 at 01:01:50AM +0200, Thomas Graf wrote:
> Treating OFPACT_REG_MOVE as a "set" action preserves the order of loads
> and moves and allows a load to overwrite a previous move to the same
> register.
>
> This makes the following work:
>
> add-group br0 group_id=1234,type=all, \
s/linux/netlink/ is fine with me.
On Fri, Aug 15, 2014 at 04:25:49PM +, Alin Serdean wrote:
> Hi Saurabh,
>
> If Ben is ok with the name change I would be glad to send out a V2
> of the patch.
>
> Thanks,
> Alin.
>
> -Mesaj original-
> De la: Saurabh Shah [mailto:ssaur...@vmware.com
Nithin,
Thanks for the review I will send out a V2 as soon as possible.
Thanks,
Alin.
-Mesaj original-
De la: Nithin Raju [mailto:nit...@vmware.com]
Trimis: Friday, August 15, 2014 3:52 AM
Către: Alin Serdean
Cc: dev@openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] Add build of ovsext.sln
Hi Saurabh,
If Ben is ok with the name change I would be glad to send out a V2 of the patch.
Thanks,
Alin.
-Mesaj original-
De la: Saurabh Shah [mailto:ssaur...@vmware.com]
Trimis: Friday, August 15, 2014 4:21 AM
Către: Alin Serdean; dev@openvswitch.org
Subiect: RE: [ovs-dev] [PATCH 3/4
Hi Saurabh,
Thank you for the review.
The issue I was following can be related to the following:
https://connect.microsoft.com/VisualStudio/feedback/details/787203/driver-package-building-problem
Thanks,
Alin.
-Mesaj original-
De la: Saurabh Shah [mailto:ssaur...@vmware.com]
Trimis: Fr
On Fri, Aug 15, 2014 at 11:18:48AM +0400, Vasiliy Tolstov wrote:
> Thanks for new LTS release of openvswitch, please tag it on github.
https://github.com/openvswitch/ovs/releases/tag/v2.3
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/ma
Adds documentation on how to run IVSHMEM communication through VM.
Signed-off-by: Mike A. Polehn
diff --git a/INSTALL.DPDK b/INSTALL.DPDK
index 4551f4c..8d866e9 100644
--- a/INSTALL.DPDK
+++ b/INSTALL.DPDK
@@ -19,10 +19,14 @@ Recommended to use DPDK 1.6.
DPDK:
Set dir i.g.: export DPDK_DIR=/
Separates loop list process size from the endpoint DPDK queue size.
Corrected DPDK queue size to be a power of 2 which allows dpdkr interface to be
created.
Increased queue size to improve zero loss data rate.
Changed NIC queue size comment to make NIC queue size formula more clear.
Signed-off-by
Future patches will change the recirc action implementation to not
using recursion. The stack depth detection is no longer necessary.
Signed-off-by: Andy Zhou
---
datapath/actions.c | 34 ++
datapath/datapath.c | 6 +++---
datapath/datapath.h | 4 ++--
datapath
Future pathces will make use of those functions.
Signed-off-by: Andy Zhou
---
datapath/Modules.mk | 1 +
datapath/actions.c | 27
datapath/actions.h | 90 +
datapath/datapath.c | 4 +++
datapath/datapath.h | 2 +-
5 files
Since kernel stack is limited in size, it is not wise to using
recursive function with large stack frames.
This patch provides an alternative implementation of recirc action with
out using recursion.
A recirc action can be embedded in the middle of an actions list.
Instead of immediately (and rec
Split ovs_dp_packet_flow_lookup() into its own API. In preparation for
the next patch.
Signed-off-by: Andy Zhou
---
datapath/datapath.c | 27 ---
datapath/datapath.h | 1 +
2 files changed, 21 insertions(+), 7 deletions(-)
diff --git a/datapath/datapath.c b/datapath/dat
Commit cc377352d (ofproto: Reorganize in preparation for direct
dpdk upcalls.) introduced the bug that uses variable defined on
the stack inside while loop for reading dpif upcalls and keeps
reference to attributes of the variable within the same function
after the stack is cleared. This bug can c
Extend IPFIX exporter to export tunnel headers when both input and output
of the port.
Add three other_config options in IPFIX table: enable-input-sampling,
enable-output-sampling and enable-tunnel-sampling, to control whether
sampling tunnel info, on which direction (input or output).
Insert sampl
I am working on it, will send the updated patch later.
-Original Message-
From: Pravin Shelar [mailto:pshe...@nicira.com]
Sent: Friday, August 15, 2014 2:59 PM
To: Ben Pfaff
Cc: Wenyu Zhang; Romain Lenglet; Jesse Gross; dev@openvswitch.org
Subject: Re: [PATCH v9] Extend OVS IPFIX exporter
Thanks for new LTS release of openvswitch, please tag it on github.
--
Vasiliy Tolstov,
e-mail: v.tols...@selfip.ru
jabber: v...@selfip.ru
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Aug 14, 2014 at 9:04 AM, Ben Pfaff wrote:
> On Wed, Aug 13, 2014 at 08:57:28PM -0700, Wenyu Zhang wrote:
>> Extend IPFIX exporter to export tunnel headers when both input and output
>> of the port.
>> Add three other_config options in IPFIX table: enable-input-sampling,
>> enable-output-sa
57 matches
Mail list logo
