Re: [ovs-dev] [PATCH] revalidator: Selectively perform xlate side-effects.

2014-06-22 Thread Joe Stringer
Alex, could you review this series? I think that the correct solution is to perform "retroactive side-effects", that is, perform side effects as though they had happened at the time that the flow was hit. Anything that may hide these effects (like mac table flush) would need to be taken into accou

Re: [ovs-dev] [branch-2.0] ofproto-dpif: Configure datapath max-idle through ovs-vsctl.

2014-06-22 Thread Alex Wang
Thx, Applied to corresponding branches, On Fri, Jun 20, 2014 at 7:42 PM, Joe Stringer wrote: > LGTM (branches 1.10-.2.0) > > Acked-by: Joe Stringer > > > On 20 June 2014 16:22, Alex Wang wrote: > >> This patch adds a new configuration option, "max-idle" to the >> Open_vSwitch "other-config"

Re: [ovs-dev] [branch-2.1 1/2] upcall: Add appctl call to set flow_limit.

2014-06-22 Thread Alex Wang
I'll mention it in the commit message, thx for the review. Applied both to branch-2.1 Alex Wang, On Fri, Jun 20, 2014 at 7:47 PM, Joe Stringer wrote: > I assume these two backported cleanly? Looks good, not sure if you want to > mention that it's a backport in the commit message. > > Acked-by

Re: [ovs-dev] Cloudbase - OVS Hyper-V porting availability

2014-06-22 Thread Alessandro Pilotti
Hi everyone, In addition to the code repositories made previously available, here’s a wiki document describing our OVS Hyper-V porting architecture and implementation: http://wiki.cloudbase.it/ovs-hyperv-architecture Please let me know if you have any questions on the document or any specific Hy

[ovs-dev] [PATCH v7 1/3] dpif-netdev: use dpif_packet structure for packets

2014-06-22 Thread Daniele Di Proietto
This commit introduces a new data structure used for receiving packets from netdevs and passing them to dpifs. The purpose of this change is to allow storing some private data for each packet. The subsequent commits make use of it. Signed-off-by: Daniele Di Proietto --- lib/automake.mk

[ovs-dev] [PATCH v7 2/3] netdev: netdev_send accepts multiple packets

2014-06-22 Thread Daniele Di Proietto
The netdev_send function has been modified to accept multiple packets, to allow netdev providers to amortize locking and queuing costs. This is especially true for netdev-dpdk. Later commits exploit the new API. Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c | 2 +- lib/netdev-b

[ovs-dev] [PATCH v7 3/3] dpif-netdev: batch packet processing

2014-06-22 Thread Daniele Di Proietto
This change in dpif-netdev allows faster packet processing for devices which implement batching (netdev-dpdk currently). Signed-off-by: Daniele Di Proietto --- lib/dpif-netdev.c| 325 +-- lib/dpif.c | 12 +- lib/odp-execute.c

[ovs-dev] [PATCH v7 0/3] DPDK batch packet processing

2014-06-22 Thread Daniele Di Proietto
I had to resend to add a minor fix in netdev-dpdk.h Changes from v6: free_dpdk_buf should accept dpif_packet also if DPDK_NETDEV is not defined Changes from v5: Pravin's suggestions: reintroduced dpif_packet_delete() removed extra spaces dp_netdev_input keeps only one miniflow now

[ovs-dev] [PATCH] tests: Remove extraneous parenthesis from test name.

2014-06-22 Thread Joe Stringer
This could cause configuration failure on earlier versions of autoconf. Reported-by: Lin Shaopeng Signed-off-by: Joe Stringer --- tests/ofp-print.at |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ofp-print.at b/tests/ofp-print.at index cfb604e..f2b896f 100644 --- a

[ovs-dev] [PATCH] Makefile.am: fix printf-check in out-of-tree build

2014-06-22 Thread Daniele Di Proietto
The intrduction of a %zu in datapath/flow_netlink.c with commit c1fc1411 revealed a problem with out-of-tree builds. printf-check and thread-safety-check skip some directories with a 'grep -v'. In the case of and out-of-tree build, the grep -v pattern doesn't work, because it assumes the pathnames