Same comment about the commit message.
Acked-by: Joe Stringer
On 20 June 2014 16:23, Alex Wang wrote:
> From: Joe Stringer
>
> This patch adds a new configuration option, "max-idle" to the
> Open_vSwitch "other-config" column. This sets how long datapath flows
> are cached in the datapath be
I assume these two backported cleanly? Looks good, not sure if you want to
mention that it's a backport in the commit message.
Acked-by: Joe Stringer
On 20 June 2014 16:23, Alex Wang wrote:
> From: Joe Stringer
>
> This should assist testing of datapath performance, as it allows us to
> skip
LGTM (branches 1.10-.2.0)
Acked-by: Joe Stringer
On 20 June 2014 16:22, Alex Wang wrote:
> This patch adds a new configuration option, "max-idle" to the
> Open_vSwitch "other-config" column. This sets how long datapath flows
> are cached in the datapath before ovs-vswitchd thread expire them.
On Fri, Jun 20, 2014 at 4:18 PM, Changbin Liu
wrote:
> Right, I tried other values like 4 and 30, same thing, still 15 seconds
> delay.
When I try it, I see 11 seconds as the minimum based on your other
configuration values. According to this definition from the spec, 11
seconds is correct bas
This commit introduces a new data structure used for receiving packets from
netdevs and passing them to dpifs.
The purpose of this change is to allow storing some private data for each
packet. The subsequent commits make use of it.
Signed-off-by: Daniele Di Proietto
---
lib/automake.mk
This change in dpif-netdev allows faster packet processing for devices which
implement batching (netdev-dpdk currently).
Signed-off-by: Daniele Di Proietto
---
lib/dpif-netdev.c| 325 +--
lib/dpif.c | 12 +-
lib/odp-execute.c
Changes from v5:
Pravin's suggestions:
reintroduced dpif_packet_delete()
removed extra spaces
dp_netdev_input keeps only one miniflow now
netdev_send takes a dpif_packet now
fixed a bug when skipping packets in dpdk_do_tx_copy()
Changes from v4:
rebased
simplified error handling
The netdev_send function has been modified to accept multiple packets, to
allow netdev providers to amortize locking and queuing costs.
This is especially true for netdev-dpdk.
Later commits exploit the new API.
Signed-off-by: Daniele Di Proietto
---
lib/dpif-netdev.c | 2 +-
lib/netdev-b
Ok just kidding, I actually just sent a v3 of the patch since the other
optimizations may take me a bit longer. Sorry for the spam, have a good weekend!
Ryan
From: Ryan Wilson mailto:wr...@vmware.com>>
Date: Friday, June 20, 2014 4:15 PM
To: Ryan Wilson mailto:wr...@nicira.com>>, Joe Stringer
m
Previously, flows were retrieved one by one when dumping flows for
datapaths of type 'netdev'. This increased contention for the dump's
mutex, negatively affecting revalidator performance.
This patch retrieves batches of flows when dumping flows for datapaths
of type 'netdev'.
Signed-off-by: Ryan
Right, I tried other values like 4 and 30, same thing, still 15 seconds
delay.
I also wonder why it must be 4-30 seconds. Linux bridge supports setting
forwarding delay to 0, so that VM live migration won't have network
disruptions.
Changbin
On Friday, June 20, 2014, Justin Pettit wrote:
> On
Hey Joe,
Not sure if you were looking at this patch, but I believe I found a more
efficient way to do this. I will likely send this out as a larger series of
revalidator optimizations for dpif-netdev.
Ryan
From: Ryan Wilson mailto:wr...@nicira.com>>
Date: Thursday, June 19, 2014 5:49 PM
To: Jo
On Thu, Jun 19, 2014 at 8:56 PM, Changbin Liu
wrote:
> ovs-vsctl settting forwarding delay does not seem to be working.
> Forwarding delay is always 15 seconds.
>
> # ovs-vsctl set bridge obr2 other_config:stp-forward-delay=0
>
As documented in ovs-vswitchd.conf.db (and the STP specification), t
Put in a DPDK queue to receive from multiple core SMP input from vSwitch for
NIC TX output.
Eliminated the inside polling loop SMP TX output lock (DPDK queue handles SMP).
Added a SMP lock for non-polling operation to allow TX output by the
non-polling thread
when interface not being polled
There are always a few unit tests that have some race conditions
that cause them to occasionally fail. It is probably a good idea
to re-run the failed tests once while building deb packages.
Co-Authored-By: Keith Amidon
Signed-off-by: Keith Amidon
Signed-off-by: Gurucharan Shetty
---
debian/ru
Run the following command on Xenserver:
PYTHONPATH=`pwd`/python/compat::`pwd`/python python ./tests/test-ovsdb.py \
parse-atoms '{"type": "string", "minLength": 2}'\
'[""]' '["a"]' '["ab"]' '["abc"]' '["\ud834\udd1e"]'
And we get the following error:
UnicodeEncodeError: 'ascii'
> I had done an internal patch on OVS 2.0 code, does not seem like years ago,
> but the default timeout
> was 5 seconds for flow counts less than flow_eviction_threshold.
> The histogram as written had some algorithm issues, so had the potential to
> thrash the
> system for excessive flow removal
There is no 'errno' field in socket.error. Instead use the
get_exception_errno() function to get the error number.
Signed-off-by: Gurucharan Shetty
---
python/ovs/socket_util.py |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/python/ovs/socket_util.py b/python/ovs/sock
Run the following command on Xenserver:
PYTHONPATH=`pwd`/python/compat::`pwd`/python python ./tests/test-ovsdb.py \
parse-atoms '{"type": "string", "minLength": 2}'\
'[""]' '["a"]' '["ab"]' '["abc"]' '["\ud834\udd1e"]'
And we get the following error:
UnicodeEncodeError: 'ascii
I had done an internal patch on OVS 2.0 code, does not seem like years ago, but
the default timeout
was 5 seconds for flow counts less than flow_eviction_threshold.
The histogram as written had some algorithm issues, so had the potential to
thrash the
system for excessive flow removal counts pe
On Fri, Jun 13, 2014 at 5:00 PM, Daniele Di Proietto
wrote:
> The netdev_send function has been modified to accept multiple packets, to
> allow netdev providers to amortize locking and queuing costs.
> This is especially true for netdev-dpdk.
>
> Later commits exploit the new API.
>
> Signed-off-b
On Fri, Jun 13, 2014 at 5:00 PM, Daniele Di Proietto
wrote:
> This commit introduces a new data structure used for receiving packets from
> netdevs and passing them to dpifs.
> The purpose of this change is to allow storing some private data for each
> packet. The subsequent commits make use of it
On Fri, Jun 13, 2014 at 5:00 PM, Daniele Di Proietto
wrote:
> This change in dpif-netdev allows faster packet processing for devices which
> implement batching (netdev-dpdk currently).
>
> Signed-off-by: Daniele Di Proietto
> ---
> lib/dpif-netdev.c| 354
> ++
> I think the setting of 1.5 seconds is due to inexperience and needs to be
> drastically changed. If flow timeout is specified on the OpenFlow command,
> the exact match flow timeout should use the OpenFlow set timeout and not an
> arbitrary value since there was probably a reason for setting t
Hey Mike,
Thanks for the concern, please see my reply below:
I guess you only care about ovs master right?
On Fri, Jun 20, 2014 at 8:03 AM, Polehn, Mike A
wrote:
> The idle timeout of 1.5 seconds for exact match flows creates big problems
> for testing. I suspect that other than for intern
From: "maryam.tahhan"
This patch enables arbitrary port naming for vhost patches, so
they no longer need to be called dpdkvhost.
Signed-off-by: maryam.tahhan
---
INSTALL.DPDK | 6 +++---
lib/netdev-dpdk.c | 30 --
2 files changed, 19 insertions(+), 17 deletion
The idle timeout of 1.5 seconds for exact match flows creates big problems for
testing. I suspect that other than for internal generated flows within the
system, that 1.5 seconds is not a reasonable timeout. I worry about thrashing
of the flows in a congested setting where the load is so high th
Make the parser compatible with how we print group buckets and allow
actions= to be specified, e.g.:
group_id=1,type=all,bucket=actions=output:2,bucket=actions=output:3
Also, better document the supported syntax in the manual page.
Signed-off-by: Thomas Graf
---
lib/ofp-parse.c | 6 +
Signed-off-by: Thomas Graf
---
utilities/ovs-ofctl.8.in | 50
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index efd8c11..4ebaa18 100644
--- a/utilities/ovs-ofctl.8.in
+++ b/uti
Signed-off-by: Thomas Graf
---
utilities/ovs-ofctl.8.in | 4
1 file changed, 4 insertions(+)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index cc811ff..efd8c11 100644
--- a/utilities/ovs-ofctl.8.in
+++ b/utilities/ovs-ofctl.8.in
@@ -1144,6 +1144,10 @@ This form of \fBou
30 matches
Mail list logo
