Re: [ovs-dev] [PATCH v3 3/3] datapath: add layer 3 flow/port support

On Tue, Jun 17, 2014 at 12:21 PM, Lori Jakab wrote: > Hi Jesse, > > > On 5/23/14, 2:07 AM, Jesse Gross wrote: >> >> On Tue, May 20, 2014 at 9:27 PM, Lori Jakab wrote: >>> >>> On 5/21/14, 4:10 AM, Jesse Gross wrote: On Tue, May 13, 2014 at 7:02 AM, Lorand Jakab wrote: > > Implem

[ovs-dev] [PATCH v4 5/7] ofproto-dpif: Add mcast snooping db show and flush cmds

This patch adds the command 'ovs-appctl mdb/show bridge' to show learned groups on a bridge from the multicast snooping database. It also adds the command 'ovs-appctl mdb/flush [bridge]' to flush learned groups on a bridge or on all bridges. Acked-by: Ben Pfaff Acked-by: Thomas Graf Acked-by: D

[ovs-dev] [PATCH v4 6/7] dpif-xlate: Snoop multicast packets and send them properly

If the packet is multicast and the snooping feature is enabled, update the multicast snooping database accordingly and send it to the right ports. If the packet is not multicast or the snooping feature is disabled, let the MAC learning handle the packet as before. Acked-by: Ben Pfaff Signed-off-

[ovs-dev] [PATCH v4 4/7] ofproto: Add functions to configure multicast snooping

Acked-by: Ben Pfaff Signed-off-by: Flavio Leitner --- ofproto/ofproto-dpif.c | 52 ++ ofproto/ofproto-provider.h | 25 ++ ofproto/ofproto.c | 27 ofproto/ofproto.h | 13 4

[ovs-dev] [PATCH v4 3/7] ofproto-dpif: Introduce multicast snooping handler

It follows mac learning, but since the multicast snooping feature can be disabled, the locking is handled in the library. Acked-by: Ben Pfaff Signed-off-by: Flavio Leitner --- ofproto/ofproto-dpif-xlate.c | 21 - ofproto/ofproto-dpif-xlate.h | 2 ++ ofproto/ofproto-dpif.c

[ovs-dev] [PATCH v4 7/7] bridge: Enable multicast support on the bridge

Acked-by: Ben Pfaff Signed-off-by: Flavio Leitner --- NEWS | 1 + tests/ovs-vsctl.at | 2 ++ utilities/ovs-vsctl.8.in | 30 vswitchd/bridge.c | 49 + vswitchd/vswitch.ovsschema |

[ovs-dev] [PATCH v4 2/7] flow: extend it to carry IGMP protocol information

Add IGMP info to struct flow, flow compose and flow extract. Signed-off-by: Flavio Leitner --- lib/flow.c | 22 -- lib/flow.h | 11 ++- lib/match.c | 8 +++- lib/nx-match.c | 2 +- lib/odp-util.h

[ovs-dev] [PATCH v4 1/7] lib: Add IGMP snooping library bits

This patch adds generic IGMP snooping library code that is used in follow-up patches. Signed-off-by: Cong Wang Signed-off-by: Daniel Borkmann Acked-by: Thomas Graf Signed-off-by: Flavio Leitner --- lib/automake.mk | 2 + lib/mcast-snooping.c | 758 ++

[ovs-dev] [PATCH v4 0/7] Add multicast snooping support

Currently it supports IGMPv1 and IGMPv2 only. Flavio Leitner (7): lib: Add IGMP snooping library bits flow: extend it to carry IGMP protocol information ofproto-dpif: Introduce multicast snooping handler ofproto: Add functions to configure multicast snooping ofproto-dpif: Add mcast snoop

Re: [ovs-dev] [PATCH] vswitchd: skip right number of arguments in dpdk_init()

Well we're really not 'skipping' the '--dpdk' argument since that is passed to rte_eal_init() as well. We're skipping the program name which is the path to ovs-vswitchd. I'd change the comment in the patch to something like: diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index fbdb6b3..5cd4a07

[ovs-dev] [PATCH] dpif-netdev: Implement batched flow dumping.

Previously, flows were retrieved one by one when dumping flows for datapaths of type 'netdev'. This increased contention for the dump's mutex, negatively affecting revalidator performance. This patch retrieves batches of flows when dumping flows for datapaths of type 'netdev'. Signed-off-by: Ryan

Re: [ovs-dev] [mask array v6 1/2] datapath: simplify ovs_flow_tbl_lookup_stats()

On Mon, Jun 16, 2014 at 1:18 PM, Andy Zhou wrote: > Simplify flow mask cache replacement without using expensive atomic > memory access to the mask pointers. > > Signed-off-by: Andy Zhou > --- > datapath/flow_table.c | 44 +--- > 1 file changed, 21 inserti

Re: [ovs-dev] [mask array v6 2/2] datapath: keep mask array compact when deleting mask

On Mon, Jun 16, 2014 at 1:18 PM, Andy Zhou wrote: > When deleting a mask from the mask array, we always move the last entry > into its current location. Another approach can be NULL in its > current place, and periodically compact it. > > The approach taken by this patch is more efficient during r

Re: [ovs-dev] [PATCH v2] dpif-netdev: Polling threads directly call ofproto upcall functions.

Thanks for the review! I fixed all these things in my next version (v3). Ryan From: Daniele Di Proietto mailto:ddiproie...@vmware.com>> Date: Wednesday, June 18, 2014 9:05 AM To: Ryan Wilson mailto:wr...@nicira.com>> Cc: "dev@openvswitch.org" mailto:dev@openvswitch.o

[ovs-dev] [PATCH v3] dpif-netdev: Polling threads directly call ofproto upcall functions.

Typically, kernel datapath threads send upcalls to userspace where handler threads process the upcalls. For TAP and DPDK devices, the datapath threads operate in userspace, so there is no need for separate handler threads. This patch allows userspace datapath threads to directly call the ofproto u

Re: [ovs-dev] [PATCH v2] dpif-netdev: Polling threads directly call ofproto upcall functions.

Hi Ryan, some quick thoughts about the code: > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c > index 6c281fe..626b3e6 100644 > --- a/lib/dpif-netdev.c > +++ b/lib/dpif-netdev.c > @@ -15,8 +15,6 @@ > */ > > #include > -#include "dpif.h" > - > #include > #include > #include > @@ -35,6 +3

[ovs-dev] [PATCH v2.61] datapath: Add basic MPLS support to kernel

Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer. Cc: Ravi K Cc: Leo Alterman Cc: Isaku Yamahata Cc: Joe Stringer Signed-off-by: Sim

Re: [ovs-dev] [PATCH v2.60] datapath: Add basic MPLS support to kernel

On Tue, Jun 17, 2014 at 11:02:21PM -0700, Jesse Gross wrote: > I'm currently seeing this compiler error: > > CC [M] /home/jesse/openvswitch/datapath/linux/gso.o > /home/jesse/openvswitch/datapath/linux/gso.c: In function > ‘tnl_skb_gso_segment’: > /home/jesse/openvswitch/datapath/linux/gso.c:1