Thanks for getting to the bottom of the issue.
On Thu, May 15, 2014 at 8:42 PM, Joe Stringer wrote:
> On 16 May 2014 15:38, Andy Zhou wrote:
>>
>> On Thu, May 15, 2014 at 8:34 PM, Joe Stringer
>> wrote:
>> > On 16 May 2014 15:11, Andy Zhou wrote:
>> >>
>> >> On Wed, May 14, 2014 at 11:57 PM, J
On Mon, May 12, 2014 at 10:30:04AM -0700, Andy Zhou wrote:
> Without this patch, the match passed into to
> ofproto_dpif_add_internal_flow() are modified. The mask of dl_type will
> always be converted from wildcarded match into exact match due to
> calling rule_dpif_lookup_in_table(). The fix make
On 16 May 2014 15:38, Andy Zhou wrote:
> On Thu, May 15, 2014 at 8:34 PM, Joe Stringer
> wrote:
> > On 16 May 2014 15:11, Andy Zhou wrote:
> >>
> >> On Wed, May 14, 2014 at 11:57 PM, Joe Stringer
> >> wrote:
> >> > Signed-off-by: Joe Stringer
> >> > ---
> >> > v3: First post.
> >> > ---
> >>
On Thu, May 15, 2014 at 8:34 PM, Joe Stringer wrote:
> On 16 May 2014 15:11, Andy Zhou wrote:
>>
>> On Wed, May 14, 2014 at 11:57 PM, Joe Stringer
>> wrote:
>> > Signed-off-by: Joe Stringer
>> > ---
>> > v3: First post.
>> > ---
>> > lib/odp-util.c | 41 +-
On 16 May 2014 15:11, Andy Zhou wrote:
> On Wed, May 14, 2014 at 11:57 PM, Joe Stringer
> wrote:
> > Signed-off-by: Joe Stringer
> > ---
> > v3: First post.
> > ---
> > lib/odp-util.c | 41 +
> > 1 file changed, 25 insertions(+), 16 deletions(-)
> >
>
On Wed, May 14, 2014 at 11:57 PM, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
> ---
> v3: First post.
> ---
> lib/odp-util.c | 41 +
> 1 file changed, 25 insertions(+), 16 deletions(-)
>
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index 6cff2f
With recirculation in place this should be safe.
Signed-off-by: Simon Horman
---
v2 - v5
* No change
---
lib/ofp-actions.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index cc1f9a0..119677e 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
This makes maintaining the controller test slightly easier
by splitting it in two.
Based on a similar patch by Joe Stringer.
Cc: Joe Stringer
Signed-off-by: Simon Horman
--
v4 - v5
* No change
v3
* Rebase
v2
* No change
v1
* Taken from another patch-set and re-worked
---
tests/ofproto-dpif
This is in preparation for using the same helper as part of support
for using recirculation in conjunction series of actions including
with MPLS actions that are currently not able to be translated.
In that scenario the idle timeout will be used to expire internal
rules that are added to handle re
This is to allow a recirculation id to be associated with a rule
in the case that its actions cause recirculation.
In such a case if the recirc_id field is non-zero then that value should be
used, otherwise a value should be obtained using
ofproto_dpif_alloc_recirc_id and saved in recirc_id field.
In some cases an pop MPLS action changes a packet to be a non-mpls packet.
In this case subsequent any L3+ actions require access to portions
of the packet which were not decoded as they were opaque when the
packet was MPLS. Allow such actions to be translated by
first recirculating the packet.
Si
This is in preparation for using this value
in ofproto-dpif-xlate.c when composing recirculation
actions added as a result of processing (MPLS) actions.
Signed-off-by: Simon Horman
---
v3 - v5
* No change
v2
* First post
---
ofproto/bond.c | 1 -
ofproto/ofproto-dpif.h | 3 +++
2 files
The motivation of this series is to allow some sequences of actions
that include MPLS actions to be performed using recirculation.
Sequences of actions that could not previously be handled.
For example pop_mpls:0x0800,dec_ttl.
This uses recirculation after the pop_mpls action to allow access to L
On Thu, May 15, 2014 at 1:28 AM, wrote:
> Hi Jesse,
>
> (below)
>
> 2014-05-09, Jesse Gross:
>> On Fri, Apr 25, 2014 at 4:56 AM, wrote:
>>> Hi Jesse,
>>>
>>> (inlined below)
>>>
>>> Jesse Gross :
>
> In general, I think it would be a good idea for the flow key to
>>>
Hi Jesse, Hi Pravin, Hi All,
This patchset makes use of a whitelist to only allow mpls_push actions to
be applied to packets with an ethertype where the tag order is well defined
and implemented. This avoids the problem of where an MPLS LSE should be
added in relation to a VLAN or similar tag.
Th
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer.
Cc: Ravi K
Cc: Leo Alterman
Cc: Isaku Yamahata
Cc: Joe Stringer
Signed-off-by: Sim
Thank you. I applied this to master and the branches for 2.2 and
2.3. (Earlier branches did not have the problem.)
On Fri, May 16, 2014 at 10:49:53AM +1200, Joe Stringer wrote:
> Acked-by: Joe Stringer
>
>
> On 16 May 2014 10:36, Ben Pfaff wrote:
>
> > The loop in revalidate() needs to ensu
Acked-by: Joe Stringer
On 16 May 2014 10:36, Ben Pfaff wrote:
> The loop in revalidate() needs to ensure that any data obtained from
> dpif_flow_dump_next() is used before it is destroyed, as indicated by
> dpif_flow_dump_next_may_destroy_keys(). In the common case, where
> processing reaches
On Wed, May 14, 2014 at 5:39 PM, Simon Horman wrote:
> On Wed, May 14, 2014 at 05:22:21PM -0700, Jesse Gross wrote:
>> On Wed, May 14, 2014 at 5:05 PM, Simon Horman wrote:
>> > The sample action is rather generic, allowing arbitrary actions to be
>> > executed based on a probability. However its
The loop in revalidate() needs to ensure that any data obtained from
dpif_flow_dump_next() is used before it is destroyed, as indicated by
dpif_flow_dump_next_may_destroy_keys(). In the common case, where
processing reaches the end of the main "while" loop, it does this, but
in two corner cases th
Hey Ryan,
Glad to see this workaround,
To my understanding, we only remove/free netdev when the iface is removed
by main thread. So, I think this would work.
I'll wait for Ben's review.
void netdev_parse_name(const char *netdev_name, char **name, char **type);
> diff --git a/vswitchd/bridge.
On Wed, May 14, 2014 at 6:59 PM, longguang.yue wrote:
> hi,all
> can ovs work with sr-iov?
No.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On May 15, 2014 at 5:22:28 PM, Ben Pfaff (b...@nicira.com) wrote:
> On Thu, May 15, 2014 at 02:14:09PM -0700, Justin Pettit wrote:
> > Signed-off-by: Justin Pettit
>
> I'm OK with these. Thanks.
Thanks. I pushed them and created the new "branch-2.3".
--Justin
_
On Thu, May 15, 2014 at 02:14:09PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
I'm OK with these. Thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, May 15, 2014 at 1:50 PM, Pravin Shelar wrote:
> On Thu, May 8, 2014 at 11:19 PM, Andy Zhou wrote:
>> When deleting a mask from the mask array, we always move the last entry
>> into its current location. Another approach can be NULL in its current
>> place, and periodically compact it.
>>
Signed-off-by: Justin Pettit
---
NEWS |4 ++--
configure.ac |2 +-
debian/changelog | 16 +---
3 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/NEWS b/NEWS
index 704513e..dc5ec7d 100644
--- a/NEWS
+++ b/NEWS
@@ -1,4 +1,4 @@
-Post-v2.2.0
+v2.3.0
Signed-off-by: Justin Pettit
---
NEWS |4
configure.ac |2 +-
debian/changelog |7 +++
3 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index dc5ec7d..ebf3979 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
+Post-v2.3.0
+---
Hey Ben,
Could you help review this? also,
Since, there can be some scenarios about netdev deletion we do not know,
Thanks,
Alex Wang,
On Thu, May 15, 2014 at 3:01 AM, Ryan Wilson wrote:
> When the user changes port type (i.e. changing p0 from type 'internal' to
> 'gre'), the netdev must fir
On Thu, May 8, 2014 at 11:19 PM, Andy Zhou wrote:
> When deleting a mask from the mask array, we always move the last entry
> into its current location. Another approach can be NULL in its current
> place, and periodically compact it.
>
> The approach taken by this patch is more efficient during r
On Tue, May 13, 2014 at 09:03:24AM -0700, Gurucharan Shetty wrote:
> In Windows, we use kernel assigned TCP port for ssl/tcp and
> unixctl. In tests, we parse the log files of ovsdb-server.log,
> test-sflow.log and test-netflow.log to get this port. In all
> the above cases, tcp port is allocated f
On Tue, May 13, 2014 at 09:03:23AM -0700, Gurucharan Shetty wrote:
> Windows port does not yet implement ovsdb-server's "--run" option.
> Till it is implemented, skip the tests.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing
Here's my newest patch addressing this issue:
http://permalink.gmane.org/gmane.network.openvswitch.devel/33292
Also, the second idea to resolve this issue which I discussed offline with
Ethan was to have the netdev struct have a pointer to its subclass (i.e. netdev
with name 'p0' has a pointer
When the user changes port type (i.e. changing p0 from type 'internal' to
'gre'), the netdev must first be deleted, then re-created with the new type.
Deleting the netdev requires there exist no more references to the netdev.
However, the xlate cache holds references to netdevs and the cache is onl
Hi Jesse,
(below)
2014-05-09, Jesse Gross:
> On Fri, Apr 25, 2014 at 4:56 AM, wrote:
>> Hi Jesse,
>>
>> (inlined below)
>>
>> Jesse Gross :
In general, I think it would be a good idea for the flow key to
have
a
field
Ensure that upcall key matches flow install and flow_dump for userspace
datapath. This was previously assumed, but not tested. This makes the
assumption more explicit.
Signed-off-by: Joe Stringer
---
v3: No change.
v2: Shift to dpif-netdev.at.
---
tests/dpif-netdev.at | 70
35 matches
Mail list logo
