Re: [ovs-dev] [PATCH 3/3] netdev: Warn on opening netdev as unexpected type.

2014-05-05 Thread Joe Stringer
Thanks for taking a look Ryan. That sounds exactly like the issue I encountered. Looking at your assessment made me take a look at it again, and I found a much better solution. Do you mind taking a look at that one? http://openvswitch.org/pipermail/dev/2014-May/039790.html On 6 May 2014 09:18,

[ovs-dev] [PATCH] tunnel: Fix bug where misconfiguration persists.

2014-05-05 Thread Joe Stringer
Previously, misconfiguring a tunnel port to use the exact same settings would cause the corresponding netdev to never be destroyed. When attempting to re-use the port as a different type, this would fail and result in a discrepancy between reported port type and actual netdev in use. An example co

Re: [ovs-dev] [PATCH 2/2] FAQ: Mention packet filter incompatibility

2014-05-05 Thread YAMAMOTO Takashi
> On Mon, May 05, 2014 at 09:13:53AM +0900, YAMAMOTO Takashi wrote: >> +Q: Open vSwitch does not seem to obey my packet filter rules. >> + >> +A: It's by design. Open vSwitch interacts with packets at a lower layer >> + than typical packet-filter implementations like iptables. >> + For simple

Re: [ovs-dev] [PATCH 1/4] util: Disallow zero-sized xmalloc_cacheline

2014-05-05 Thread YAMAMOTO Takashi
> On Mon, May 05, 2014 at 08:32:34AM +0900, YAMAMOTO Takashi wrote: >> > On Sat, May 03, 2014 at 09:01:01AM +0900, YAMAMOTO Takashi wrote: >> >> xmalloc_cacheline API is relatively new. It's better >> >> not to inherit the kludge from xmalloc. This kind of >> >> kludge rather hurts these days. >>

Re: [ovs-dev] [PATCH] Fix dot2pic make dependencies

2014-05-05 Thread YAMAMOTO Takashi
> On Mon, May 05, 2014 at 09:39:02AM +0900, YAMAMOTO Takashi wrote: >> Signed-off-by: YAMAMOTO Takashi > > I'm surprised it makes any difference. i occasionally see the failure with make -j32. YAMAMOTO Takashi > > Acked-by: Ben Pfaff ___ dev mailin

Re: [ovs-dev] [PATCH 3/3] netdev: Warn on opening netdev as unexpected type.

2014-05-05 Thread Ryan Wilson
I've seen this issue before as well when adding RCU locking to xlate. It happens because refs to a netdev still exist (in this case, likely the tunnel has a ref to the netdev) when the main thread tries to delete the netdev. Thus, the netdev never gets deleted and the netdev cannot be recreated

Re: [ovs-dev] [PATCH] vlog: Use python 2.4 compatible functions.

2014-05-05 Thread Ben Pfaff
On Mon, May 05, 2014 at 12:33:44PM -0700, Gurucharan Shetty wrote: > Xenserver uses python 2.4. > > Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] vlog: Use python 2.4 compatible functions.

2014-05-05 Thread Gurucharan Shetty
Xenserver uses python 2.4. Signed-off-by: Gurucharan Shetty --- python/ovs/vlog.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/ovs/vlog.py b/python/ovs/vlog.py index 580b1bc..1bd42c4 100644 --- a/python/ovs/vlog.py +++ b/python/ovs/vlog.py @@ -107,12 +107,12

Re: [ovs-dev] [PATCH 4/4] ofproto: Log flow mod statistics per controller rather than per switch.

2014-05-05 Thread Ben Pfaff
Applied, thank you! On Fri, May 02, 2014 at 04:25:03PM -0700, Alex Wang wrote: > All four patches look good to me, > > Acked-by: Alex Wang > > > On Wed, Apr 30, 2014 at 10:51 AM, Ben Pfaff wrote: > > > I've had a number of requests for more specific logging of flow_mod > > information. It i

Re: [ovs-dev] 1 million flows.

2014-05-05 Thread Jarno Rajahalme
There is an upper limit of 20 datapath flows currently. Also, as the datapath flows expire when idle, your test would need to keep the flows active throughout the test. Jarno > On May 5, 2014, at 3:12 AM, Neelakantam Gaddam wrote: > > Hi All, > > I am trying to test 1 million datapat

Re: [ovs-dev] [PATCH] Fix dot2pic make dependencies

2014-05-05 Thread Ben Pfaff
On Mon, May 05, 2014 at 09:39:02AM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi I'm surprised it makes any difference. Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] util: Use posix_memalign for xmalloc_cacheline if available

2014-05-05 Thread Ben Pfaff
On Mon, May 05, 2014 at 08:33:37AM +0900, YAMAMOTO Takashi wrote: > A malloc library is expected to provide a better implementation > using the knowledge of its internal details. > > ax_func_posix_memalign.m4 was obtained from: > http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_pl

Re: [ovs-dev] [v2] ofp-util: compile group stats with visual studio

2014-05-05 Thread Ben Pfaff
On Thu, Apr 24, 2014 at 05:34:09PM -0700, Andy Zhou wrote: > Visual studio supports zero-size array within a struct or union, > but has to be the last element. GCC does not have this restriction. > > Commits 644cfd84772eb7d8 and 6fdaa45a6f6c9 make use of 0 size array. > Remove them so that visual

Re: [ovs-dev] [PATCH 2/2] FAQ: Mention packet filter incompatibility

2014-05-05 Thread Ben Pfaff
On Mon, May 05, 2014 at 09:13:53AM +0900, YAMAMOTO Takashi wrote: > +Q: Open vSwitch does not seem to obey my packet filter rules. > + > +A: It's by design. Open vSwitch interacts with packets at a lower layer > + than typical packet-filter implementations like iptables. > + For simple filteri

Re: [ovs-dev] [PATCH 1/2] FAQ: Expand tabs

2014-05-05 Thread Ben Pfaff
On Mon, May 05, 2014 at 09:13:52AM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/4] util: Disallow zero-sized xmalloc_cacheline

2014-05-05 Thread Ben Pfaff
On Mon, May 05, 2014 at 08:32:34AM +0900, YAMAMOTO Takashi wrote: > > On Sat, May 03, 2014 at 09:01:01AM +0900, YAMAMOTO Takashi wrote: > >> xmalloc_cacheline API is relatively new. It's better > >> not to inherit the kludge from xmalloc. This kind of > >> kludge rather hurts these days. > >> >

Re: [ovs-dev] 1 million flows.

2014-05-05 Thread Ben Pfaff
On Mon, May 05, 2014 at 03:42:59PM +0530, Neelakantam Gaddam wrote: > I am trying to test 1 million datapath flows with openvswitch. Why? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] 1 million flows.

2014-05-05 Thread Neelakantam Gaddam
Hi All, I am trying to test 1 million datapath flows with openvswitch. What is the preferred test setup and the procedure to do the test ? Please guide/point me to test 1 million flows. -- Thanks & Regards Neelakantam Gaddam ___ dev mailing list de