Masked set action allows more megaflow wildcarding. Masked set action
is now supported for all writeable key types, except for the tunnel
key.
It is not clear whether masked set is useful for skb_priority.
However, we already use the LSB of pkt_mark for IPSec in tunnels, so
it might be useful to
Signed-off-by: Jarno Rajahalme
---
lib/odp-util.c |2 +-
tests/odp.at |1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index b58f1c0..10bf925 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -1308,7 +1308,7 @@ format_odp_key_attr(con
Diagnostic code path dereferenced a NULL pointer.
Signed-off-by: Jarno Rajahalme
---
lib/odp-util.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index 10bf925..f61c2b2 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -1
Signed-off-by: Jarno Rajahalme
---
lib/odp-util.c | 368 ++
lib/odp-util.h |5 +-
ofproto/ofproto-dpif-xlate.c | 12 +-
tests/ofproto-dpif.at| 49 +++---
tests/tunnel.at |8 +-
5 files changed, 2
Key attributes relating to actual packet headers are ignored for
OVS_PACKET_CMD_EXECUTE as the header key attributes are retrieved
from the packet itself.
Signed-off-by: Jarno Rajahalme
---
include/linux/openvswitch.h |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/incl
Add a new action type OVS_ACTION_ATTR_SET_MASKED, and support for
parsing, printing, and committing them.
Masked set actions add a mask, immediately following the netlink
attribute data, within the netlink attribute itself. Thus the key
attribute size for a masked set action is exactly double of
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-dpif-xlate.c |8 +-
ofproto/ofproto-dpif-xlate.h |3 ++-
ofproto/ofproto-dpif.c | 58 +-
3 files changed, 66 insertions(+), 3 deletions(-)
diff --git a/ofproto/ofproto-dpif-xlate.c b/of
In general, all Netlink 64-bit data may be 4-byte aligned, due to
netlink header and attributes being 4-aligned.
To avoid unaligned access the data should be copied out of the netlink
attribute before access.
Signed-off-by: Jarno Rajahalme
---
include/linux/openvswitch.h |1 +
1 file change
Please ignore this version. I have sent out a re-based version.
On Wed, Apr 9, 2014 at 10:08 PM, Andy Zhou wrote:
> Currently recirculation action can optionally compute hash. This patch
> adds a hash action that is independent of the recirc action, which
> no longer computes hash. For megaflow
Implements Linux kernel datapath recirc action. Recirc action allows
kernel data patch reprocess the packet as if it is received from its
original input port, with a recirc_id added to its flow key.
The recirc action follows a sub routine call model. The packet change
by actions during recirculat
Currently recirculation action can optionally compute hash. This patch
adds a hash action that is independent of the recirc action, which
no longer computes hash. For megaflow bond with recirc, the output
to a bond port action will look like:
hash(hash_l4(0)), recric()
Obviously, when a reci
Implements Linux kernel datapath hash action. Hash action computes
hash and stores it into current packet key.
Signed-off-by: Andy Zhou
hash fix
---
datapath/actions.c | 19 +++
datapath/flow.h |2 ++
datapath/flow_netlink.c | 29
Acked-by: Thomas Graf
Acked-by: Daniel Borkmann
Signed-off-by: Flavio Leitner
---
utilities/ovs-vsctl.8.in | 30 ++
vswitchd/vswitch.xml | 37 +
2 files changed, 67 insertions(+)
diff --git a/utilities/ovs-vsctl.8.in b/utiliti
This patch adds the command 'ovs-appctl mdb/show bridge'
to show learned groups on a bridge from the multicast
snooping database.
It also adds the command 'ovs-appctl mdb/flush [bridge]'
to flush learned groups on a bridge or on all bridges.
Acked-by: Thomas Graf
Acked-by: Daniel Borkmann
Signe
First check if the packet is a multicast and if the multicast
snooping feature is enabled. If so, then update the multicast
snooping database accordingly and send it to the correct ports.
If the packet is not multicast, let the MAC learning handle the
packet as before.
This patch also removes OV
This patch adds the functions needed to update the multicast
snooping database based on the Report/Leave/Query received.
They are marked with OVS_UNUSED for now.
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif-xlate.c | 80
1 file changed, 80
Acked-by: Thomas Graf
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif.c | 55 ++
ofproto/ofproto-provider.h | 22 +++
ofproto/ofproto.c | 28 +++
ofproto/ofproto.h | 17 ++
4
Fix bridge to create and configure multicast snooping.
Acked-by: Thomas Graf
Signed-off-by: Flavio Leitner
---
vswitchd/bridge.c | 70 +++
1 file changed, 70 insertions(+)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index f46d002..28d0
This patch adds the functions needed for multicast snooping
in order to send the packets to the correct ports.
They are marked as OVS_UNUSED for now.
Acked-by: Thomas Graf
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif-xlate.c | 65
1 file c
It follows mac learning, but since the multicast snooping
feature can be disabled, the locking is handled in the
library.
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif-xlate.c | 11 ++-
ofproto/ofproto-dpif-xlate.h | 4 +++-
ofproto/ofproto-dpif.c | 17 -
This is also needed for multicast snooping.
Acked-by: Thomas Graf
Acked-by: Daniel Borkmann
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif-xlate.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/
This patch adds IGMP support to flow_compose and
flow_extract.
Acked-by: Daniel Borkmann
Acked-by: Thomas Graf
Signed-off-by: Flavio Leitner
---
lib/flow.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/lib/flow.c b/lib/flow.c
index 83b926f..cdf1ae1 100644
--- a/lib
Signed-off-by: Flavio Leitner
---
lib/flow.c | 4 ++--
lib/flow.h | 22 --
lib/match.c | 2 +-
lib/nx-match.c | 2 +-
lib/ofp-util.c | 2 +-
ofproto/ofproto-dpif-xlate.c | 2 +-
6 files chang
No functionality is changed. This is needed on
a further commit adding REV_MCAST_SNOOPING.
Acked-by: Thomas Graf
Acked-by: Daniel Borkmann
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/ofproto/ofproto-d
Add a switch to enable or disable multicast snooping on
the bridge. This feature is disabled by default.
Acked-by: Thomas Graf
Acked-by: Daniel Borkmann
Signed-off-by: Flavio Leitner
---
tests/ovs-vsctl.at | 2 ++
vswitchd/vswitch.ovsschema | 6 --
vswitchd/vswitch.xml | 12
No functional changes. This is just for better readability
when the multicast snooping learning and sending functions
are added to the code.
Acked-by: Thomas Graf
Acked-by: Daniel Borkmann
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif-xlate.c | 120 +--
RFC4541- IGMP and MLD Snooping Switches Considerations
recommends to have different actions for local and
non-local multicast traffic.
Acked-by: Daniel Borkmann
Signed-off-by: Thomas Graf
Signed-off-by: Flavio Leitner
---
lib/packets.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/l
From: Daniel Borkmann
Add the definition of Internet Group Management Protocol.
Signed-off-by: Cong Wang
Signed-off-by: Daniel Borkmann
Acked-by: Thomas Graf
Signed-off-by: Flavio Leitner
---
AUTHORS | 2 ++
include/sparse/netinet/in.h | 1 +
2 files changed, 3 insertion
From: Daniel Borkmann
Add basic header structure and definitions into packet.h.
Acked-by: Thomas Graf
Signed-off-by: Daniel Borkmann
Signed-off-by: Flavio Leitner
---
lib/packets.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/lib/packets.h b/lib/packets.h
index eca24d
Currently it supports IGMPv1 and IGMPv2 only.
Daniel Borkmann (2):
netinet: Add IPPROTO_IGMP definition
packets: Add igmp header definitions
Flavio Leitner (16):
packet: Add function ip_is_local_multicast()
lib: Add igmp generic snooping library bits
flow: Add IGMP bits to the struct fl
This patch adds generic IPv4 library code to deal with
igmp snooping that is implemented in follow-up patches.
Signed-off-by: Cong Wang
Signed-off-by: Daniel Borkmann
Acked-by: Thomas Graf
Signed-off-by: Flavio Leitner
---
lib/automake.mk | 2 +
lib/mcast-snooping.c | 794 +
Thanks, applied to master.
On Sun, Apr 06, 2014 at 04:38:11PM -0700, Alex Wang wrote:
> Tested, and it works,
>
> Acked-by: Alex Wang
>
>
>
>
> On Tue, Feb 25, 2014 at 11:32 AM, Ben Pfaff wrote:
>
> > If the .git directory is there, and "git --version" works, but "git
> > ls-files" fails t
On Fri, Apr 11, 2014 at 10:37:18AM +0300, Alexandru Copot wrote:
> On Thu, Apr 10, 2014 at 9:41 PM, Ben Pfaff wrote:
> > On Fri, Apr 04, 2014 at 11:58:30AM +0300, Alexandru Copot wrote:
> >> This also enables OF1.4 for all the tests.
> >>
> >> Signed-off-by: Alexandru Copot
> >> Cc: Daniel Baluta
On Fri, Apr 11, 2014 at 03:44:47PM +0300, Alexandru Copot wrote:
> Thanks a lot for the feedback. You can find my answers inline.
> We will get back with v4 asap.
Great! There is no rush: I'll be out on vacation all next week, so I
will probably not get to it quickly, even if you send the new ver
This is Version 2 of a patch to add 802.1ad (qinq) to OVS. It accepts
0x88a8 tpid. It incorporates comments from Andy Zhou and fixes a problem
that showed up in testing and is merged with MASTER.
I plan to do real-world compatibility testing. I will
send out a V3 in response to comments and resu
Hi, all,
I did a round of clean up of outstanding patches needs to be reviewed at
patchwork.openvswitch.org/project/openvswitch/list
I believe the list is accurate for patches sent in April. I plan to
clean up the rest in coming weeks.
If you have outstanding patch needs to be reviewed but not
In general, all Netlink 64-bit data may be 4-byte aligned, due to
netlink header and attributes being 4-aligned.
To avoid unaligned access the data should be copied out of the netlink
attribute before access.
Signed-off-by: Jarno Rajahalme
---
include/linux/openvswitch.h |1 +
1 file change
Pushed to master with an updated comment and description:
Clarify tunnel wildcarding.
It would seem we should set the 'tunnel.ip_dst' in 'wc' when calling
tnl_port_should_receive(), as it is reading that flow field. However,
since tunnels' datapath port numbers are different from
Andy noted offline that matching on the in_port will prevent tunneled packets
matching with non-tunneled flows. Tunnels have their own datapath port number
and we always unwildcard the in_port. SO, I’ll just update the comment and the
commit description.
Jarno
On Apr 11, 2014, at 11:12 AM, J
Hey Ben, Joe,
Could you review this V3 series?
I think it is closer, and better,~
besides, no backlogged transactions when flapping all 5K tunnels for the
entire morning ;D
Alex Wang,
On Fri, Apr 11, 2014 at 11:20 AM, Alex Wang wrote:
> This commit removes the 'Instant' stats related logic
Had an off-line discussion with Jesse. He suggested to split this into
two patches, one for recirc action and another for hash action.
I will drop this patch. Repost this as a two patch series.
On Mon, Apr 7, 2014 at 8:13 PM, Andy Zhou wrote:
> Recirculation implementation for Linux kernel data
This commit removes the 'Instant' stats related logic in bridge.c.
Instead, the corresponding status is updated immediately after the
global connectivity sequence number changes.
This change brings the following effects:
1. The status database update is slightly faster, since the 'Instant'
sta
This commit adds boolean flag in bfd/cfm module for checking
status change. If there is no status change, the current
update to OVS database will skip the bfd/cfm session.
In the experiment with 5K bfd sessions, when one session is
flapping at rate of every 0.3 second, this patch reduces the
cpu
On Fri, Apr 11, 2014 at 10:45:13AM -0700, Gurucharan Shetty wrote:
> On Fri, Apr 11, 2014 at 10:39 AM, Ben Pfaff wrote:
> > This moves existing text from INSTALL.Debian into the README.Debian
> > installed as part of the openvswitch-switch package, and adds a reference
> > from the former to the l
It seems that it is useful to admins after all.
Reported-by: Brian Candler
Signed-off-by: Ben Pfaff
---
debian/openvswitch-switch.manpages |1 +
rhel/openvswitch-fedora.spec.in|3 ++-
utilities/automake.mk |2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
dif
Upon further research I think I was wrong about this, and we actually need to
unwildcard the ‘tun_dst’ bits to prevent tunneled packets matching on
non-tunneled flows.
I’ll send a revised patch soon.
Jarno
On Apr 9, 2014, at 1:38 PM, Ben Pfaff wrote:
> On Tue, Apr 08, 2014 at 04:38:52PM -0
On Fri, Apr 11, 2014 at 10:39 AM, Ben Pfaff wrote:
> This moves existing text from INSTALL.Debian into the README.Debian
> installed as part of the openvswitch-switch package, and adds a reference
> from the former to the latter.
>
> Reported-by: Brian Candler
> Signed-off-by: Ben Pfaff
Acked-by
Hi Thomas,
On 4/11/14, 4:24 PM, thomas.mo...@orange.com wrote:
Hi Lori,
I've ported my GRE patches to your l3port patches.
You can find my changes at:
https://github.com/tmmorin/openvswitch/tree/l3_v3_gre
Great! Always good to see one's work being useful to others. Also, it
looks lik
This moves existing text from INSTALL.Debian into the README.Debian
installed as part of the openvswitch-switch package, and adds a reference
from the former to the latter.
Reported-by: Brian Candler
Signed-off-by: Ben Pfaff
---
INSTALL.Debian | 39 ++-
>
>
>>> +/* Check the need to update status. */
>>> +seq = seq_read(connectivity_seq_get());
>>> +if (seq != connectivity_seqno) {
>>> +struct ovsdb_idl_txn *txn;
>>> +
>>> +connectivity_seqno = seq;
>>> +txn = ovsdb_idl_txn_create(idl);
>>> +HMAP_FOR_EAC
Your message dated Fri, 11 Apr 2014 16:44:54 +
with message-id
and subject line Bug#744136: fixed in openvswitch 2.1.0+git20140411-1
has caused the Debian Bug report #744136,
regarding ovsdbmonitor lacks depends on python-zope.interface and
python-twisted-conch
to be marked as done.
This mea
Accepted:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Format: 1.8
Date: Fri, 11 Apr 2014 08:35:10 -0700
Source: openvswitch
Binary: openvswitch-datapath-source openvswitch-datapath-dkms
openvswitch-common openvswitch-switch openvswitch-ipsec openvswitch-pki
openvswitch-dbg python-openvswi
This is the ported version of commit 36d5fe6a with the same name from net-next.
Apart from the small datapath.c changes it adjust the compat layer files as
well. This is the original commit message:
"skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
orphan them. Also,
openvswitch_2.1.0+git20140411-1_i386.changes uploaded successfully to localhost
along with the files:
openvswitch_2.1.0+git20140411-1.dsc
openvswitch_2.1.0+git20140411.orig.tar.xz
openvswitch_2.1.0+git20140411-1.debian.tar.xz
openvswitch-common_2.1.0+git20140411-1_i386.deb
openvswitch-swi
On Thu, Apr 10, 2014 at 08:44:29AM -0700, Ben Pfaff wrote:
> A Debian bug was recently filed against ovsdbmonitor:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=744136
>
> I suspect that, if fixed, additional bugs will follow, because
> ovsdbmonitor was poorly maintained and not wide
Hi Lori,
I've ported my GRE patches to your l3port patches.
You can find my changes at:
https://github.com/tmmorin/openvswitch/tree/l3_v3_gre
The result is the following:
- an option is added to GRE tunnel port, to allow making them OVS l3ports
- the vport-gre.c code is adapted to treat GRE
Thanks a lot for the feedback. You can find my answers inline.
We will get back with v4 asap.
On Thu, Apr 10, 2014 at 9:38 PM, Ben Pfaff wrote:
> On Fri, Apr 04, 2014 at 11:58:29AM +0300, Alexandru Copot wrote:
>> This is only the communication part of the bundles functionality.
>> The actual mes
On 4/11/14, 1:47 AM, Jesse Gross wrote:
On Thu, Mar 20, 2014 at 4:37 AM, Lori Jakab wrote:
On 1/6/14, 7:55 PM, Jesse Gross wrote:
On Tue, Dec 24, 2013 at 9:02 AM, Lorand Jakab wrote:
diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
index 7d193d8..8f0d5ab 100644
--- a/datapath/f
On 4/11/14, 11:40 AM, Thomas Graf wrote:
On 03/20/2014 12:37 PM, Lori Jakab wrote:
+static int push_eth(struct sk_buff *skb, const struct
ovs_action_push_eth *ethh)
+{
+ int err;
+
+ skb_push(skb, ETH_HLEN);
+ skb_reset_mac_header(skb);
+
+ err = set_eth_addr(skb, ðh->add
On 03/20/2014 12:37 PM, Lori Jakab wrote:
+static int push_eth(struct sk_buff *skb, const struct
ovs_action_push_eth *ethh)
+{
+ int err;
+
+ skb_push(skb, ETH_HLEN);
+ skb_reset_mac_header(skb);
+
+ err = set_eth_addr(skb, ðh->addresses);
+ if (unlikely(err))
+
> On Fri, Mar 14, 2014 at 04:19:52PM +0900, Simon Horman wrote:
>> When creating a flow in the datapath as the result of an upcall
>> the match itself is the match supplied in the upcall while
>> the mask of the match, if supplied, is generated based on the
>> flow and mask composed during action t
On Thu, Apr 10, 2014 at 10:19 PM, Ben Pfaff wrote:
> On Fri, Apr 04, 2014 at 11:58:31AM +0300, Alexandru Copot wrote:
>> These tests can now properly print packets with the new protocol version.
>>
>> Signed-off-by: Alexandru Copot
>> Cc: Daniel Baluta
>
> I guess these tests got broken by the o
On Thu, Apr 10, 2014 at 9:41 PM, Ben Pfaff wrote:
> On Fri, Apr 04, 2014 at 11:58:30AM +0300, Alexandru Copot wrote:
>> This also enables OF1.4 for all the tests.
>>
>> Signed-off-by: Alexandru Copot
>> Cc: Daniel Baluta
>
> It's good as far as it goes, but ideally we'd add bundle support to
> o
63 matches
Mail list logo
