[ovs-dev] [PATCH] ofproto-macros.at: Make OVS_VSWITCHD_START wait for daemons start

2014-04-01 Thread YAMAMOTO Takashi
Without this change, I observed that "ofproto-dpif - ofproto-dpif-monitor 2" test, which merely accesses ovsdb, failed in OVS_VSWITCHD_STOP's "ovs-appctl -t ovs-vswitchd exit". Signed-off-by: YAMAMOTO Takashi --- tests/ofproto-macros.at | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests

[ovs-dev] [PATCH] ofproto-dpif-upcall: Expire netflow flow when revalidate_ukey failed

2014-04-01 Thread YAMAMOTO Takashi
This fixes missing netflow flows in "ofproto-dpif - NetFlow flow expiration" tests. Signed-off-by: YAMAMOTO Takashi --- ofproto/ofproto-dpif-upcall.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c inde

Re: [ovs-dev] [PATCH 4/5] ofproto.at: Fix races in rule eviciton tests

2014-04-01 Thread Kmindg G
On Tue, Apr 1, 2014 at 8:38 PM, YAMAMOTO Takashi wrote: >>> +ovs-appctl time/warp 4000 >>> AT_CHECK([ovs-ofctl mod-flows br0 in_port=1,actions=drop]) >>> -sleep 2 >>> +# At this point the table would looks like: >>> +# in_port seconds to expire >>> +# 113 >>> +# 2

Re: [ovs-dev] [bond megaflow v4 4/4 rebased] ofproto/bond: Implement bond megaflow using recirculation

2014-04-01 Thread Simon Horman
On Tue, Apr 01, 2014 at 10:16:05AM -0700, Andy Zhou wrote: > On Mon, Mar 31, 2014 at 9:11 PM, Simon Horman wrote: > > On Tue, Mar 25, 2014 at 01:48:39PM -0700, Andy Zhou wrote: > >> Infrastructure to enable megaflow support for bond ports using > >> recirculation. This patch adds the following fea

Re: [ovs-dev] [PATCH v6 6/6] datapath: Minimize ovs_flow_cmd_new|set critical sections.

2014-04-01 Thread Pravin Shelar
On Mon, Mar 31, 2014 at 11:18 AM, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme > --- > v6: Use key fields of the newly allocated flow directly in ovs_flow_cmd_new(). > Correctly handle the case of no acts in ovs_flow_cmd_set(). > > datapath/datapath.c | 193 > ++

Re: [ovs-dev] [PATCH v6 4/6] datapath: Minimize ovs_flow_cmd_del critical section.

2014-04-01 Thread Pravin Shelar
On Mon, Mar 31, 2014 at 11:18 AM, Jarno Rajahalme wrote: > ovs_flow_cmd_del() now allocates reply (if needed) after the flow has > already been removed from the flow table. If the reply allocation > fails, a netlink error is signaled with netlink_set_err(), as is > already done in ovs_flow_cmd_ne

Re: [ovs-dev] [PATCH v6 5/6] datapath: Split ovs_flow_cmd_new_or_set().

2014-04-01 Thread Pravin Shelar
On Mon, Mar 31, 2014 at 11:18 AM, Jarno Rajahalme wrote: > Following patch will be easier to reason about with separate > ovs_flow_cmd_new() and ovs_flow_cmd_set() functions. > > Signed-off-by: Jarno Rajahalme LGTM Acked-by: Pravin B Shelar ___ dev

Re: [ovs-dev] [PATCH v6 3/6] datapath: Reduce locking requirements.

2014-04-01 Thread Pravin Shelar
On Mon, Mar 31, 2014 at 11:18 AM, Jarno Rajahalme wrote: > Reduce and clarify locking requirements for ovs_flow_cmd_alloc_info(), > ovs_flow_cmd_fill_info() and ovs_flow_cmd_build_info(). > > A datapath pointer is available only when holding a lock. Change > ovs_flow_cmd_fill_info() and ovs_flow_

Re: [ovs-dev] [PATCH v6 2/6] datapath/flow: Fix ovs_flow_stats_get/clear RCU dereference.

2014-04-01 Thread Pravin Shelar
On Mon, Mar 31, 2014 at 11:18 AM, Jarno Rajahalme wrote: > For ovs_flow_stats_get() using ovsl_dereference() was wrong, since > flow dumps call this with RCU read lock. > > ovs_flow_stats_clear() is always called with ovs_mutex, so can use > ovsl_dereference(). > > Also, make the ovs_flow_stats_ge

Re: [ovs-dev] [PATCH v6 1/6] datapath: Fix typo.

2014-04-01 Thread Pravin Shelar
On Mon, Mar 31, 2014 at 11:18 AM, Jarno Rajahalme wrote: > Incorrect struct name was confusing, even though otherwise > inconsequental. > > Signed-off-by: Jarno Rajahalme LGTM Acked-by: Pravin B Shelar ___ dev mailing list dev@openvswitch.org http://o

[ovs-dev] [PATCH] vtep: add IP address configuration for bfd

2014-04-01 Thread Bruce Davie
The OVS implementation of BFD allows configuration of the source and destination IP addresses of BFD packets. This patch adds the same configuration option to the VTEP schema. Signed-off-by: Bruce Davie --- vtep/vtep.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/vtep/vtep.x

[ovs-dev] [PATCH v3] bridge: don't bring up internal ports by default.

2014-04-01 Thread Flavio Leitner
It should be an administrator task to bring up devices as they are configured properly. Currently, Fedora is deleting the bridges when the interface is brought down. Therefore, there is no bridge on the next boot and the initscripts can apply the networking configuration properly for a new bridge.

Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

2014-04-01 Thread Lori Jakab
On 4/1/14, 5:43 PM, Jarno Rajahalme wrote: Sent from my iPhone On Apr 1, 2014, at 7:27 AM, Ben Pfaff wrote: On Tue, Apr 01, 2014 at 03:14:16PM +0300, Lori Jakab wrote: On 3/26/14, 2:16 AM, Ben Pfaff wrote: On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalme wrote: This patch shrinks

[ovs-dev] WARNING: CPU: 0 PID: 3630 at net/core/dev.c:2218 skb_warn_bad_offload+0xcd/0xda()

2014-04-01 Thread Michele Baldessari
Hi all, in Fedora we've received a couple of reports of the above warning (https://bugzilla.redhat.com/show_bug.cgi?id=1047693). The trace looks as follows: reporter: libreport-2.1.10 WARNING: CPU: 0 PID: 3630 at net/core/dev.c:2218 skb_warn_bad_offload+0xcd/0xda() : caps=(0x0008801948

Re: [ovs-dev] datapath/linux/compat question

2014-04-01 Thread Jesse Gross
On Tue, Apr 1, 2014 at 11:41 AM, Kyle Mestery wrote: > On Tue, Apr 1, 2014 at 1:27 PM, Zoltan Kiss wrote: >> Hi, >> >> I have a recent patch on net-next which affects OVS as well: >> >> http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=36d5fe6a000790f56039afe26834265db0a3a

[ovs-dev] curveball

2014-04-01 Thread Maile Coolbaugh
d begun to hate her--yes, to _hat you every man should be content with three wives. More than this verges upon polygamy. But blessed is he who finds the three in one! Mrs. Denham. Indeed. Have you found that in Gyp? Denham. No, not directly; though Gyp fills me with thoughts that do often lie

Re: [ovs-dev] datapath/linux/compat question

2014-04-01 Thread Kyle Mestery
On Tue, Apr 1, 2014 at 1:27 PM, Zoltan Kiss wrote: > Hi, > > I have a recent patch on net-next which affects OVS as well: > > http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=36d5fe6a000790f56039afe26834265db0a3ad4c > > I guess the changes for datapatch.c will turn up auto

[ovs-dev] datapath/linux/compat question

2014-04-01 Thread Zoltan Kiss
Hi, I have a recent patch on net-next which affects OVS as well: http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=36d5fe6a000790f56039afe26834265db0a3ad4c I guess the changes for datapatch.c will turn up automagically sometime during a merge, is that correct? But there

Re: [ovs-dev] [PATCH] openvswitch: supply a dummy err_handler of gre_cisco_protocol to prevent kernel crash

2014-04-01 Thread Jesse Gross
On Tue, Apr 1, 2014 at 8:24 AM, wei zhang wrote: > At 2014-04-01 08:49:53,"Jesse Gross" wrote: >>On Sun, Mar 30, 2014 at 5:12 AM, wei zhang wrote: >>> At 2014-03-29 06:02:25,"Jesse Gross" wrote: > >>> Maybe I misunderstand something? I think if we discard all packet pass to us >>> when we use g

[ovs-dev] openvswitch 2.1 on openSUSE13.1 - ovsbd-server enters infinite loop

2014-04-01 Thread Karol Mroz
Hello, I'm experiencing a problem starting openvswitch 2.1 on an openSUSE13.1 (kernel version 3.11.10) system. Specifically, ovsdb-server enters an infinite loop during logging bringup. When setting up logging levels for the various vlog_modules (please see lib/vlog.c:set_facility_level() and lib

Re: [ovs-dev] [PATCH v2] bridge: don't bring up internal ports by default.

2014-04-01 Thread Flavio Leitner
On Mon, Mar 31, 2014 at 01:19:39PM -0700, Ben Pfaff wrote: > On Tue, Mar 25, 2014 at 02:50:17PM -0300, Flavio Leitner wrote: > > It should be an administrator task to bring up devices as they > > are configured properly. > > > > Currently, Fedora is deleting the bridges when the interface is > > b

Re: [ovs-dev] [bond megaflow v4 4/4 rebased] ofproto/bond: Implement bond megaflow using recirculation

2014-04-01 Thread Andy Zhou
On Mon, Mar 31, 2014 at 9:11 PM, Simon Horman wrote: > On Tue, Mar 25, 2014 at 01:48:39PM -0700, Andy Zhou wrote: >> Infrastructure to enable megaflow support for bond ports using >> recirculation. This patch adds the following features: >> * Generate RECIRC action when bond can benefit from recir

[ovs-dev] VMware User Community

2014-04-01 Thread Kathleen MacLeod
Hi, As a leading database provider, I was inquisitive to check if you would be interested in owning a list of companies using VMware that can be used for your marketing campaigns? These lists can be customized based on application, geography, titles and more. Some of the other Virtualizatio

Re: [ovs-dev] [PATCH] rhel: Add Patch Port support to initscripts

2014-04-01 Thread Gurucharan Shetty
On Mon, Mar 31, 2014 at 4:34 PM, Jason Kölker wrote: > Allows setting up type=patch ports through sysconfig ifcfg-* files. > > Signed-off-by: Jason Kölker Thank you for the patch. Looks good to me. I added you to AUTHORS and applied it on master. > --- > rhel/README.RHEL

Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

2014-04-01 Thread Jarno Rajahalme
Sent from my iPhone > On Apr 1, 2014, at 7:27 AM, Ben Pfaff wrote: > >> On Tue, Apr 01, 2014 at 03:14:16PM +0300, Lori Jakab wrote: >>> On 3/26/14, 2:16 AM, Ben Pfaff wrote: On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalme wrote: This patch shrinks the struct ofpbuf from 104

Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

2014-04-01 Thread Ben Pfaff
On Tue, Apr 01, 2014 at 03:14:16PM +0300, Lori Jakab wrote: > On 3/26/14, 2:16 AM, Ben Pfaff wrote: > >On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalme wrote: > >>This patch shrinks the struct ofpbuf from 104 to 48 bytes on 64-bit > >>systems, or from 52 to 36 bytes on 32-bit systems (coun

[ovs-dev] [PATCH] datapath: Add support for kernels 3.13 and 3.14

2014-04-01 Thread Kyle Mestery
Add support for building the in-tree kernel datapath for Linux kernels up to 3.14. There were some changes in the netlink area which required adding new compatibility code for this layer. Also, some new per-cpu stats initialization code was added. Encompasses changes from the following upstream Li

Re: [ovs-dev] [PATCH 5/5] ofproto-dpif.at: Sprinkle --overwrite-pidfile

2014-04-01 Thread YAMAMOTO Takashi
>> On Mon, Mar 31, 2014 at 03:24:31PM +0900, YAMAMOTO Takashi wrote: >>> These tests invokes ovs-ofctl monitor twice or more. >>> Because "ovs-appctl -t ofctl exit" does not wait for the target >>> process exit, there are chances to see the pid file from the previous >>> incarnation. >>> >>> Signe

Re: [ovs-dev] [PATCH 4/5] ofproto.at: Fix races in rule eviciton tests

2014-04-01 Thread YAMAMOTO Takashi
>> +ovs-appctl time/warp 4000 >> AT_CHECK([ovs-ofctl mod-flows br0 in_port=1,actions=drop]) >> -sleep 2 >> +# At this point the table would looks like: >> +# in_port seconds to expire >> +# 113 >> +# 211 > This seems to be 12s to expire. And I realize that I made

Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

2014-04-01 Thread Lori Jakab
On 3/26/14, 2:16 AM, Ben Pfaff wrote: On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalme wrote: This patch shrinks the struct ofpbuf from 104 to 48 bytes on 64-bit systems, or from 52 to 36 bytes on 32-bit systems (counting in the 'l7' removal by the previous patch). This may help contri

Re: [ovs-dev] hackathon idea list

2014-04-01 Thread Alexandru Copot
On Mar 28, 2014 11:27 PM, "Ben Pfaff" wrote: > > On Fri, Mar 28, 2014 at 09:24:42PM +0200, Alexandru Copot wrote: > > On Wed, Mar 26, 2014 at 7:11 AM, Ben Pfaff wrote: > > > > > OpenFlow 1.4 Role Status Message > > > > > > > > > OpenFlow 1.4 section 7.4.4 ``Contro

Re: [ovs-dev] [PATCH 4/5] ofproto.at: Fix races in rule eviciton tests

2014-04-01 Thread Kmindg G
On Tue, Apr 1, 2014 at 6:20 PM, YAMAMOTO Takashi wrote: >>> # Sleep and modify the one that expires soonest >>> -sleep 2 >>> +ovs-appctl time/warp 3000 >>> AT_CHECK([ovs-ofctl mod-flows br0 in_port=1,actions=drop]) >> >> at this point, flow table would be: >> hard_timeout=12, in_port=1 actions=d

Re: [ovs-dev] [PATCH 4/5] ofproto.at: Fix races in rule eviciton tests

2014-04-01 Thread YAMAMOTO Takashi
>> # Sleep and modify the one that expires soonest >> -sleep 2 >> +ovs-appctl time/warp 3000 >> AT_CHECK([ovs-ofctl mod-flows br0 in_port=1,actions=drop]) > > at this point, flow table would be: > hard_timeout=12, in_port=1 actions=drop > hard_timeout=11, in_port=2 actions=drop > hard_timeout=13

[ovs-dev] [ovstest v2 1/2] unit-test: Add ovstest

2014-04-01 Thread Andy Zhou
Changing one of the files in the Open vSwitch ``lib'' directory causes 43 binaries to be relinked, which takes a lot of time even with parallel ``make''. 31 of those binaries are in the ``tests'' directory. ovs-test attemps to combine most of those binaries into a single test program that just ta

[ovs-dev] [unit-test: improve link speed 2/2] unit-test: Link 29 test programs into ovstest

2014-04-01 Thread Andy Zhou
Improve link speed by linking 29 test programs into ovstest. On my machine, running the following command against a fully built tree: $ touch lib/random.c; time make Improve the overall build time from 7 seconds to 3.5 seconds. Signed-off-by: Andy Zhou --- tests/aes128.at |2 +-