Re: [ovs-dev] [PATCH] recirculation: Adjust ovs_key_attr ABI

Thanks. Pushed. On Fri, Mar 28, 2014 at 3:03 PM, Jesse Gross wrote: > On Fri, Mar 28, 2014 at 1:42 PM, Andy Zhou wrote: >> Jesse helped to clarify how to maintain the ABI. Making the >> adjustment accordingly and add some comments. >> >> Signed-off-by: Andy Zhou > > Acked-by: Jesse Gross _

[ovs-dev] [ovstest v2 2/2] unit-test: merge test-heap into ovstest

Modify test-heap.c to use ovstest framework. Signed-off-by: Andy Zhou --- v1-v2: Coding style fixes --- tests/automake.mk |8 ++-- tests/heap.at |2 +- tests/test-heap.c | 12 +++- 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/tests/automake.mk b/tes

[ovs-dev] [ovstest v2 1/2] unit-test: Add ovstest

Changing one of the files in the Open vSwitch ``lib'' directory causes 43 binaries to be relinked, which takes a lot of time even with parallel ``make''. 31 of those binaries are in the ``tests'' directory. ovs-test attemps to combine most of those binaries into a single test program that just ta

[ovs-dev] [ovstest 0/2] improve linking speed

Combine majority of stand alone test programs into a single executable, ovstest, to improve linking speed. ovstest.h has some usage comments. I have only coverted test-heap.c as an example usage. If this approach looks O.K. We can apply to other programs. Andy Zhou (2): unit-test: Add ovstest

[ovs-dev] [ovstest 1/2] unit-test: Add ovstest

Changing one of the files in the Open vSwitch ``lib'' directory causes 43 binaries to be relinked, which takes a lot of time even with parallel ``make''. 31 of those binaries are in the ``tests'' directory. ovs-test attemps to combine most of those binaries into a single test program that just ta

[ovs-dev] [ovstest 2/2] unit-test: merge test-heap into ovstest

Modify test-heap.c to use ovstest framework. Signed-off-by: Andy Zhou --- tests/automake.mk |8 ++-- tests/heap.at |2 +- tests/test-heap.c | 12 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/automake.mk b/tests/automake.mk index fc584d6..6

Re: [ovs-dev] [PATCH v3 04/10] datapath: Compact sw_flow_key.

On Mar 28, 2014, at 2:52 PM, Jesse Gross wrote: > On Fri, Mar 28, 2014 at 8:50 AM, Jarno Rajahalme > wrote: >> >>> On Mar 27, 2014, at 3:59 PM, Jesse Gross wrote: >>> On Fri, Feb 21, 2014 at 11:41 AM, Jarno Rajahalme wrote: Minimize padding in sw_flow_key and move 'tp' top

Re: [ovs-dev] [RFC PATCH 4/4] lib/ofpbuf: Compact

Thanks for the review! Pushed to master with the proposed changes. See a small comment below, though. Jarno On Mar 25, 2014, at 5:16 PM, Ben Pfaff wrote: > On Mon, Mar 24, 2014 at 10:59:06AM -0700, Jarno Rajahalme wrote: >> This patch shrinks the struct ofpbuf from 104 to 48 bytes on 64-bit >

Re: [ovs-dev] [PATCH v5 9/9] datapath: Minimize dp and vport critical sections.

Pushed to master with the function name change (ovs_vport_cmd_alloc() -> ovs_vport_cmd_alloc_info()). Jarno On Mar 28, 2014, at 1:26 PM, Pravin Shelar wrote: > On Tue, Mar 25, 2014 at 2:35 PM, Jarno Rajahalme > wrote: >> Move most memory allocations away from the ovs_mutex critical >> sect

[ovs-dev] [PATCH v2 1/1] Python Logging Formatting Improvements

The Open vSwitch daemons written in C support user-configured logging patterns as described in ovs-appctl(8). This commit adds this capability to the daemons written in Python. - Add a '__log_patterns' attribute to the Vlog class - Populate this using the default patterns in ovs-appctl(8) - Add a

Re: [ovs-dev] [PATCH v5 8/9] datapath: Minimize ovs_flow_cmd_new|set critical sections.

On Mar 28, 2014, at 1:26 PM, Pravin Shelar wrote: > On Tue, Mar 25, 2014 at 2:35 PM, Jarno Rajahalme > wrote: >> Signed-off-by: Jarno Rajahalme >> --- >> v5: Make functionality after ovs_unlock() case specific to make the common >>case more optimal. >> >> datapath/datapath.c | 135 >> +

Re: [ovs-dev] [PATCH/RFC] ofproto-dpif-upcall: Filter translated mask using flow

On Thu, Mar 20, 2014 at 09:37:14AM -0700, Ben Pfaff wrote: > On Thu, Mar 20, 2014 at 05:34:23PM +0900, Simon Horman wrote: > > When revalidating a flow convert xout.wc.masks, the mask calculated by > > translation, to a key that relates to the flow present in the datapath. > > Only > > mask eleme

Re: [ovs-dev] [PATCH v5 4/9] datapath: Avoid passing datapath pointer around.

On Mar 28, 2014, at 1:26 PM, Pravin Shelar wrote: > On Tue, Mar 25, 2014 at 2:35 PM, Jarno Rajahalme > wrote: >> A datapath pointer is available only when holding a lock. Change >> ovs_flow_cmd_fill_info() and ovs_flow_cmd_build_info() to take a >> dp_ifindex directly, rather than a datapath

Re: [ovs-dev] [PATCH v5 2/9] datapath: Make flow mask removal symmetric.

Thanks for the review, pushed to master, Jarno On Mar 28, 2014, at 1:25 PM, Pravin Shelar wrote: > On Tue, Mar 25, 2014 at 2:35 PM, Jarno Rajahalme > wrote: >> Masks are inserted when flows are inserted to the table, so it is >> logical to correspondingly remove masks when flows are removed

Re: [ovs-dev] [PATCH v5 1/9] datapath: Build flow cmd netlink reply only if needed.

Thanks for the review, pushed to master, Jarno On Mar 28, 2014, at 1:25 PM, Pravin Shelar wrote: > On Tue, Mar 25, 2014 at 2:35 PM, Jarno Rajahalme > wrote: >> Use netlink_has_listeners() and NLM_F_ECHO flag to determine if a >> reply is needed or not for OVS_FLOW_CMD_NEW, OVS_FLOW_CMD_SET,