On Tue, Mar 18, 2014 at 10:19:44AM +0530, Anshuman Manral wrote:
> I am using outlook web client and used 'plain text' to send the
> patch. Do you have any suggestions on best way to send patch? Are
> attachments better?
It's best to use "git send-email", but an attachment is better than a
patch t
Thanks Ben
For both the patches
Strange as I had emailed to myself and applied and it worked fine!!
I am using outlook web client and used 'plain text' to send the patch. Do you
have any suggestions on best way to send patch? Are attachments better?
Regards
Anshuman
> Date: Mon, 17 Mar 2014
Thanks, I'll roll these in when I rebase and repost.
On Wed, Mar 12, 2014 at 12:32 PM, Ben Pfaff wrote:
> On Thu, Mar 06, 2014 at 05:20:30PM -0800, Joe Stringer wrote:
> > This patch adds a new object called 'struct xlate_cache' which can be
> > set in 'struct xlate_in', and passed to xlate_act
On Wed, Mar 12, 2014 at 12:47 PM, Ben Pfaff wrote:
> I applied patches 1 through 4 to master.
>
Great, thanks.
> I think I'm happy with patches 5 through 7, but I want Ethan's
> feedback on them.
>
Likewise. I've responded to Ethan's initial query, and we'll see how the
discussion goes.
> Y
On Fri, Mar 7, 2014 at 2:45 PM, Ethan Jackson wrote:
> I'm surprised its only 10%, do you have a sense of why? Perhaps when
> running TCP_CRR we delete the flow the first time we see it, and we
> need to do xlate_actions() to generate the list of things to push
> stats to anyways? If this is wh
Signed-off-by: Alex Wang
---
V3 -> V4:
- add check of handler_id range.
V2 -> V3:
- use OVS_DP_ATTR_USER_FEATURES to inform datapath about the type of
OVS_VPORT_ATTR_UPCALL_PID attribute.
- close epoll fd when destroying all channels.
PATCH -> V2:
- rebase.
major changes since RFC:
- free th
With the foundation laid in previous commits, this commit
removes the 'dispatcher' thread by allowing 'handler'
threads to read upcalls directly from dpif.
This commit significantly simplifies the flow miss handling
code and brings slight improvement to flow setup rate.
Note:
- the flow setup rat
This commit implements the API functions to allow multiple handler
threads read upcall.
Also, this commit removes the handling priority of DPIF_UC_MISS
over DPIF_UC_ACTION. So, both misses will be put to the same
queue. The decision is based on the fact that a lot has changed
since the age when
In order to allow handlers directly read upcalls from datapath,
we need to support per-handler netlink socket for each vport in
datapath. This commit makes this happen. Also, it is guaranteed
backward and forward compatibility with previous branch.
Signed-off-by: Alex Wang
---
V3 -> V4:
- defi
This commit changes the API in 'dpif-provider.h' to allow multiple
handler threads call dpif_recv() simultaneously.
Signed-off-by: Alex Wang
---
V3 -> V4:
- refines the port_get_pid() comments as suggested.
V2 -> V3:
- detach the channel refreshing from recv_set().
Note:
the recv_set() still
I have received many good reviews. I think it is good to apply the
suggestions and rebase the whole series. So everyone can have a good
new start point.
V3 -> V4:
- Implement the recv_set() in dpif-netdev.
- Add check to the range of handler_id in recv() and recv_wait().
- Use reciprocal_div() t
Applied, thx~
On Mon, Mar 17, 2014 at 5:03 PM, Alex Wang wrote:
> Thanks a lot for the review, ;D
>
>
>> > +#endif /* _LINUX_RECIPROCAL_DIV_WRAPPER_H */
>> > diff --git a/datapath/linux/compat/reciprocal_div.c
>> b/datapath/linux/compat/reciprocal_div.c
>> > index 7ec7528..8027214 100644
>> > -
Thanks a lot for the review, ;D
> > +#endif /* _LINUX_RECIPROCAL_DIV_WRAPPER_H */
> > diff --git a/datapath/linux/compat/reciprocal_div.c
> b/datapath/linux/compat/reciprocal_div.c
> > index 7ec7528..8027214 100644
> > --- a/datapath/linux/compat/reciprocal_div.c
> > +++ b/datapath/linux/compat/r
On Mon, Mar 17, 2014 at 3:34 PM, Alex Wang wrote:
> The reciprocal division code used in datapath is flawed. The bug
> has been fixed in the linux kernel repo in commit 809fa972fd(
> reciprocal_divide: update/correction of the algorithm).
>
> This commit downstreams the reciprocal_div.{c,h} from
Thanks, pushed to master.
On Mon, Mar 17, 2014 at 3:37 PM, Ben Pfaff wrote:
> On Mon, Mar 17, 2014 at 10:14:22PM -0700, Andy Zhou wrote:
> > It is better to explicitly initialize the dp->destroy than to rely
> > on xzalloc().
> >
> > Signed-off-by: Andy Zhou
>
> Acked-by: Ben Pfaff
>
On Tue, Mar 11, 2014 at 04:56:17PM -0700, Andy Zhou wrote:
> Recirculation ID needs to be unique per datapath. Its usage will be
> tracked by the backer that corresponds to the datapath.
>
> In theory, Recirculation ID can be any uint32_t value, except 0. This
> implementation limits to a smaller
On Mon, Mar 17, 2014 at 10:14:22PM -0700, Andy Zhou wrote:
> It is better to explicitly initialize the dp->destroy than to rely
> on xzalloc().
>
> Signed-off-by: Andy Zhou
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitc
The reciprocal division code used in datapath is flawed. The bug
has been fixed in the linux kernel repo in commit 809fa972fd(
reciprocal_divide: update/correction of the algorithm).
This commit downstreams the reciprocal_div.{c,h} from the linux
kernel repo.
Signed-off-by: Alex Wang
---
PATCH
On Sat, Mar 08, 2014 at 01:09:05PM +0100, Pasquale Dir wrote:
> I'd need to create some java apis who would allow to interact with
> openvswitch, creating bridges, adding ports, creating gre tunnels...in
> short: the exact same thing ovs-vsctl does.
>
> As c code seems fairly complex I write here
This patch didn't apply as-is (it is corrupted), but I made a similar
fix to SubmittingPatches and applied it.
On Sun, Mar 16, 2014 at 03:27:26AM +0530, Anshuman Manral wrote:
> From ff045ce5933c32bd426fc1d81873a5179fb6c74b Mon Sep 17 00:00:00 2001
> From: Anshuman Manral
> Date: Sun, 16 Mar 2014
This patch didn't apply as-is (it is corrupted), but I made a similar
fix to INSTALL and applied it.
On Sun, Mar 16, 2014 at 03:05:46AM +0530, Anshuman Manral wrote:
> From d3c5335882452d78871fcd5dc09adb806d7ce6a6 Mon Sep 17 00:00:00 2001
> From: Anshuman Manral
> Date: Sun, 16 Mar 2014 02:17:41
On Mon, Mar 17, 2014 at 02:55:09PM -0700, Gurucharan Shetty wrote:
> On Mon, Mar 17, 2014 at 2:10 PM, Ben Pfaff wrote:
> > On Mon, Mar 17, 2014 at 01:13:32PM -0700, Gurucharan Shetty wrote:
> >> The WSAStartup function initiates use of the Winsock DLL by a process.
> >> The function should be call
On Mon, Mar 17, 2014 at 02:33:34PM -0700, Gurucharan Shetty wrote:
> On Mon, Mar 17, 2014 at 2:08 PM, Ben Pfaff wrote:
> > On Mon, Mar 17, 2014 at 01:13:31PM -0700, Gurucharan Shetty wrote:
> >> Signed-off-by: Gurucharan Shetty
> >
> > Does Windows have an ENOPROTOOPT? If not, can we #define ENO
Thanks Pravin for the review~,
make all-recursive
> make[1]: Entering directory `/home/pravin/ovs/openvswitch'
> Making all in datapath
> make[2]: Entering directory `/home/pravin/ovs/openvswitch/datapath'
> Making all in linux
> make[3]: Entering directory `/home/pravin/ovs/openvswitch/datapath
On Mon, Mar 17, 2014 at 10:39:01AM +0200, Alexandru Copot wrote:
> On Mon, Mar 17, 2014 at 7:08 AM, Ben Pfaff wrote:
> > On Mon, Mar 03, 2014 at 03:22:32PM +0200, Alexandru Copot wrote:
> >> This defines the version number for OpenFlow 1.4 so that the switch
> >> can actually use it. The ovsdb sch
On Mon, Mar 17, 2014 at 2:10 PM, Ben Pfaff wrote:
> On Mon, Mar 17, 2014 at 01:13:32PM -0700, Gurucharan Shetty wrote:
>> The WSAStartup function initiates use of the Winsock DLL by a process.
>> The function should be called before any winsock related functions
>> are called.
>>
>> Since, we use
Somehow a lot of ovs-* mail has ended up in my spam folder lately. I
just now fished this out.
On Tue, Mar 11, 2014 at 11:56:02AM +0200, Lior Neudorfer wrote:
> I've recompiled openvswitch without the "nf_flow->created = 0" code, and
> start_time looks good.
> Any reason why this line should stay
'created' is supposed to be the time the flow was created, but it was
getting reset to zero on every expiration, causing the flow start time to
be wonky after the first active expiration on a flow.
Reported-by: Lior Neudorfer
Signed-off-by: Ben Pfaff
---
ofproto/netflow.c |1 -
1 file chang
On Mon, Mar 17, 2014 at 2:08 PM, Ben Pfaff wrote:
> On Mon, Mar 17, 2014 at 01:13:31PM -0700, Gurucharan Shetty wrote:
>> Signed-off-by: Gurucharan Shetty
>
> Does Windows have an ENOPROTOOPT? If not, can we #define ENOPROTOOPT
> WSAENOPROTOOPT?
Windows has both ENOPROTOOPT (errno.h) and WSAENOP
On Mon, Mar 17, 2014 at 01:13:32PM -0700, Gurucharan Shetty wrote:
> The WSAStartup function initiates use of the Winsock DLL by a process.
> The function should be called before any winsock related functions
> are called.
>
> Since, we use stream-fd-windows through pstream_open or stream_open
> a
On Mon, Mar 17, 2014 at 01:13:31PM -0700, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
Does Windows have an ENOPROTOOPT? If not, can we #define ENOPROTOOPT
WSAENOPROTOOPT?
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/m
Thanks, pushed with the incremental patch folded in.
On Mon, Mar 17, 2014 at 1:56 PM, Ben Pfaff wrote:
> Yes, that looks good, thanks.
>
> On Mon, Mar 17, 2014 at 01:56:08PM -0700, Andy Zhou wrote:
> > Thanks for pointing them out. How about the following incremental
> changes
> > to address b
On Mon, Mar 17, 2014 at 01:51:44PM -0700, Gurucharan Shetty wrote:
> On Mon, Mar 17, 2014 at 1:37 PM, Ben Pfaff wrote:
> > On Fri, Mar 14, 2014 at 08:18:44AM -0700, Gurucharan Shetty wrote:
> >> Windows does not have a srandom() and random(). But it does
> >> have a srand() and rand(). We use thes
Yes, that looks good, thanks.
On Mon, Mar 17, 2014 at 01:56:08PM -0700, Andy Zhou wrote:
> Thanks for pointing them out. How about the following incremental changes
> to address both issues?
>
> diff --git a/lib/backtrace.c b/lib/backtrace.c
> index 3ff3fce..9b7c52b 100644
> --- a/lib/backtrace.
Thanks for pointing them out. How about the following incremental changes
to address both issues?
diff --git a/lib/backtrace.c b/lib/backtrace.c
index 3ff3fce..9b7c52b 100644
--- a/lib/backtrace.c
+++ b/lib/backtrace.c
@@ -15,9 +15,9 @@
*/
#include
+#include
#include "backtrace.h"
-#inclu
Subject prefix should start with datapath for kernel patches. You can
use "compat" to specify extra context.
On Sat, Mar 15, 2014 at 5:13 PM, Alex Wang wrote:
> The reciprocal division code used in datapath is flawed. The bug
> has been fixed in the linux kernel repo in commit 809fa972fd(
> reci
On Mon, Mar 17, 2014 at 1:37 PM, Ben Pfaff wrote:
> On Fri, Mar 14, 2014 at 08:18:44AM -0700, Gurucharan Shetty wrote:
>> Windows does not have a srandom() and random(). But it does
>> have a srand() and rand(). We use these functions in sflow code.
>>
>> Signed-off-by: Gurucharan Shetty
>
> How
On Fri, Mar 14, 2014 at 02:24:33PM -0700, Andy Zhou wrote:
> log_backtrace() and log_backtrace_msg() logs the back trace into
> the log file. It may be most useful when debugging unit tests.
> "backtrace.h" documents the usage. It is not being called directly
> in the code, but rather as a handy to
On Fri, Mar 14, 2014 at 08:18:46AM -0700, Gurucharan Shetty wrote:
> We can now compile a few OVS userspace components on Windows.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org
On Fri, Mar 14, 2014 at 08:18:45AM -0700, Gurucharan Shetty wrote:
> This does not provide us all the functionality that
> is available in Linux. But should be a start.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@
On Fri, Mar 14, 2014 at 08:18:44AM -0700, Gurucharan Shetty wrote:
> Windows does not have a srandom() and random(). But it does
> have a srand() and rand(). We use these functions in sflow code.
>
> Signed-off-by: Gurucharan Shetty
How do these functions get called? As far as I can tell, they
On Fri, Mar 14, 2014 at 08:18:43AM -0700, Gurucharan Shetty wrote:
> Windows does not have a strsep.
>
> Signed-off-by: Gurucharan Shetty
Do we have anything that might define HAVE_STRSEP? If not, the test
for it is confusing.
Acked-by: Ben Pfaff
_
On Fri, Mar 14, 2014 at 08:18:42AM -0700, Gurucharan Shetty wrote:
> sflow.h uses u_int32_t that needs windefs.h for compilation
> in visual studio.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http
On Fri, Mar 14, 2014 at 08:18:41AM -0700, Gurucharan Shetty wrote:
> Visual studio does not like it. It is mostly a keyword.
>
> Signed-off-by: Gurucharan Shetty
Weird.
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.o
On Fri, Mar 14, 2014 at 08:18:40AM -0700, Gurucharan Shetty wrote:
> Windows does not have a sys/fcntl.h
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Mar 14, 2014 at 08:18:39AM -0700, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Mar 14, 2014 at 08:18:38AM -0700, Gurucharan Shetty wrote:
> advapi32 is needed by multiple functions
> So include it in a common place.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://o
It is better to explicitly initialize the dp->destroy than to rely
on xzalloc().
Signed-off-by: Andy Zhou
---
lib/dpif-netdev.c |1 +
1 file changed, 1 insertion(+)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 54b8f50..3bbfd2a 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev
The WSAStartup function initiates use of the Winsock DLL by a process.
The function should be called before any winsock related functions
are called.
Since, we use stream-fd-windows through pstream_open or stream_open
add the WSAStartup() call there.
The current version of the Windows Sockets spe
Signed-off-by: Gurucharan Shetty
---
lib/socket-util.c |8
1 file changed, 8 insertions(+)
diff --git a/lib/socket-util.c b/lib/socket-util.c
index 4c79cd6..daf406f 100644
--- a/lib/socket-util.c
+++ b/lib/socket-util.c
@@ -120,14 +120,22 @@ set_dscp(int fd, uint8_t dscp)
succe
Thanks, applied to master.
On Mon, Mar 17, 2014 at 06:06:10PM +, Pritesh Kothari (pritkoth) wrote:
> Acked-by: Pritesh Kothari
>
> On Mar 15, 2014, at 9:20 AM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > FAQ | 7 +++
> > 1 file changed, 7 insertions(+)
> >
> > diff --g
Thanks! I applied this.
On Mon, Mar 17, 2014 at 06:10:13PM +, Pritesh Kothari (pritkoth) wrote:
> Acked-by: Pritesh Kothari
>
> On Mar 14, 2014, at 4:00 PM, Ben Pfaff wrote:
>
> > Reported-by: Mukesh Hira
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/socket-util.c |4 ++--
> > 1 file
Acked-by: Pritesh Kothari
On Mar 14, 2014, at 4:00 PM, Ben Pfaff wrote:
> Reported-by: Mukesh Hira
> Signed-off-by: Ben Pfaff
> ---
> lib/socket-util.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/socket-util.c b/lib/socket-util.c
> index 4c79cd6..aeda54
Acked-by: Pritesh Kothari
On Mar 15, 2014, at 9:20 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> FAQ | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/FAQ b/FAQ
> index f46170c..a54bbf9 100644
> --- a/FAQ
> +++ b/FAQ
> @@ -774,6 +774,13 @@ A: With the Linux kernel, the
This commit abstracts the tunnel monitoring logic in 'ofproto-dpif-monitor'
into a generic 'monitor' library. The 'monitor' library is designed to
allow user monitor using multiple protocols (e.g. bfd/cfm) together. Also,
it employs heap to order the sessions for efficiency. The code in the
'ofp
To facilitates the code review, I break the original libbfd patch into series.
Also, the ofproto-dpif-monitor logic is abstracted into a generic monitor
library module. This marks a step forward in making Open Vswitch library
functions easily applicable outside the project.
Alex Wang (4):
bfd:
This commit requires user define logging functions in bfd-aux.h.
Code is added in bfd.c to log the variable and operation status.
Signed-off-by: Alex Wang
---
lib/bfd-aux.h | 60 -
lib/bfd.c | 49
This commit removes the '#include' of Open Vswitch specific library
in 'bfd.c'. Instead, an auxiliary header 'bfd-aux.h' is created to
allow user of generic BFD state machine to define those platform
dependent functions.
Signed-off-by: Alex Wang
---
lib/automake.mk |1 +
lib/bfd-aux.h |
On 03/16/2014 01:13 AM, Alex Wang wrote:
The reciprocal division code used in datapath is flawed. The bug
has been fixed in the linux kernel repo in commit 809fa972fd(
reciprocal_divide: update/correction of the algorithm).
This commit downstreams the reciprocal_div.{c,h} from the linux
kernel
On Mon, Mar 17, 2014 at 7:08 AM, Ben Pfaff wrote:
> On Mon, Mar 03, 2014 at 03:22:32PM +0200, Alexandru Copot wrote:
>> This defines the version number for OpenFlow 1.4 so that the switch
>> can actually use it. The ovsdb schema is also modified.
>>
>> Signed-off-by: Alexandru Copot
>> Cc: Daniel
60 matches
Mail list logo
