[ovs-dev] [PATCH v2 2/3] ofproto-dpif: Differentiate between different miss types in packet in

Replace the generated_by_table_miss field of struct ofproto_packet_in with a miss_type field. The generated_by_table_miss field allowed packet-in messages generated by table-miss rules to be differentiated. This differentiation is still provided for by miss_type being set to OFPROTO_PACKET_IN_MISS

[ovs-dev] [PATCH v2 3/3] ofproto: Support OF version-specific table-miss behaviours

OpenFlow 1.1 and 1.2 specify that if a table-miss occurs then the default behaviour is to forward the packet the controller using a packet-in message. And until this patch this is the default behaviour that Open vSwitch uses for all OpenFlow versions. OpenFlow1.3+ specifies that if a table-miss oc

[ovs-dev] [PATCH v2 1/3] ofproto-dpif: Add table-miss flow tests

Cc: YAMAMOTO Takashi Signed-off-by: Simon Horman -- v2 * First post --- tests/ofproto-dpif.at | 84 +++ 1 file changed, 84 insertions(+) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index a7da1f7..9081f30 100644 --- a/tests/ofproto-

[ovs-dev] [PATCH v2 0/3] ofproto: Support OF version-specific table-miss behaviours

OpenFlow 1.1 and 1.2 specify that if a table-miss occurs then the default behaviour is to forward the packet the controller using a packet-in message. And until this patch this is the default behaviour that Open vSwitch uses for all OpenFlow versions. OpenFlow1.3+ specifies that if a table-miss oc

Re: [ovs-dev] [PATCH 3/3] learn.at: fix a race in "self-modifying flow with hard_timeout" test

On Wed, Mar 12, 2014 at 07:06:20PM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi All applied. Thank you! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] lib/classifier: Use a prefix tree to optimize ports wildcarding.

Jarno doesn't have that data at the moment, so here's a summary which you can put in the commit message if you'd like. To test this we took real customer ACL tables, and systematically sent every port from 1 to 65k through them to see how many megaflows are generated. If you do nothing, you end u

[ovs-dev] [PATCH] .gitignore: Ignore visual studio created files.

Signed-off-by: Gurucharan Shetty --- .gitignore |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index d205227..bd87a7f 100644 --- a/.gitignore +++ b/.gitignore @@ -7,7 +7,12 @@ *.loT *.mod.c *.o -*.o +*.obj +*.exe +*.exp +*.ilk +*.lib +*.pdb

[ovs-dev] [PATCH] timeval: Sleep instead of poll().

The WSAPoll() function, which is similar to poll() doesnot simply sleep when the fd array is NULL. So use Sleep() instead. Signed-off-by: Gurucharan Shetty --- lib/timeval.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/timeval.c b/lib/timeval.c index 74efa59..

[ovs-dev] [PATCH] stdio: fseeko for Windows.

Signed-off-by: Gurucharan Shetty --- lib/stdio.c| 12 lib/stdio.h.in |3 +++ 2 files changed, 15 insertions(+) diff --git a/lib/stdio.c b/lib/stdio.c index 49a5078..5c5c924 100644 --- a/lib/stdio.c +++ b/lib/stdio.c @@ -17,6 +17,7 @@ #include #include +#include #

[ovs-dev] [PATCH] netdev-vport: Don't look for ovs-monitor-ipsec's pid file.

We do not have pidfiles in Windows. And we do not yet have support for ipsec tunnels. This lets us move forward with compilation. Signed-off-by: Gurucharan Shetty --- lib/netdev-vport.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c index 165c1c6

[ovs-dev] [PATCH] stream-fd-windows: Fix compilation error.

Signed-off-by: Gurucharan Shetty --- lib/stream-fd-windows.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stream-fd-windows.c b/lib/stream-fd-windows.c index 7a4a995..db60810 100644 --- a/lib/stream-fd-windows.c +++ b/lib/stream-fd-windows.c @@ -138,7 +138,7 @@ fd_wa

[ovs-dev] [PATCH] automake: Use route-table-stub for Windows.

Signed-off-by: Gurucharan Shetty --- lib/automake.mk |1 + 1 file changed, 1 insertion(+) diff --git a/lib/automake.mk b/lib/automake.mk index c2cfb16..926767c 100644 --- a/lib/automake.mk +++ b/lib/automake.mk @@ -243,6 +243,7 @@ lib_libopenvswitch_la_SOURCES += \ lib/getopt_long.c

[ovs-dev] [PATCH] windefs: Add definition for pid_t.

Signed-off-by: Gurucharan Shetty --- include/windows/windefs.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/include/windows/windefs.h b/include/windows/windefs.h index 6d36adc..0a2e064 100644 --- a/include/windows/windefs.h +++ b/include/windows/windefs.h @@ -32,4 +32,6 @@ #define u_

[ovs-dev] [PATCH] ovs-thread: We don't use fork in Windows.

Signed-off-by: Gurucharan Shetty --- lib/ovs-thread.c |5 + 1 file changed, 5 insertions(+) diff --git a/lib/ovs-thread.c b/lib/ovs-thread.c index 85de014..ed9f83e 100644 --- a/lib/ovs-thread.c +++ b/lib/ovs-thread.c @@ -332,6 +332,7 @@ assert_single_threaded_at(const char *where) pid_t

[ovs-dev] [PATCH] BUILD.Windows: Build idl headers separately.

idl headers won't be built, if we build individual executables e..g., "make ovsbd/ovsdb-server.exe". According to http://www.gnu.org/software/automake/manual/html_node/Built-Sources-Example.html we may have to add the headers as dependecies for every executables. Currently the lack of a ovs-appctl

[ovs-dev] [PATCH] windows/net: Define name size for easy compilation.

I am not yet sure of the network name size limitation on Windows. To move forward with compilation of netdev-vport, have the same limitation as that in Linux. Signed-off-by: Gurucharan Shetty --- include/windows/net/if.h | 23 +++ 1 file changed, 23 insertions(+) diff --gi

[ovs-dev] [PATCH] windows/sys: Define sa_family_t for easy compilation.

Signed-off-by: Gurucharan Shetty --- include/windows/sys/socket.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/include/windows/sys/socket.h b/include/windows/sys/socket.h index e69de29..ab6e822 100644 --- a/include/windows/sys/socket.h +++ b/include/windows/sys/so

[ovs-dev] [PATCH] ofp-actions: Relax build assertion condition for ofpact_nest struct.

struct ofpact has enums that are packed in case of __GNUC__. This packing does not occur for visual studio. For 'struct ofpact_nest', we are currently expecting that "struct ofpact actions[]" has an offset of 8 bytes. This condition won't be true in compilers where enums are not packed. It is goo

[ovs-dev] [PATCH] ovsdb: fsync() for Windows.

There is no fsync() in Windows. But there is a _commit() which does the same thing. Signed-off-by: Gurucharan Shetty --- include/windows/unistd.h | 21 + 1 file changed, 21 insertions(+) diff --git a/include/windows/unistd.h b/include/windows/unistd.h index e69de29..0f553b

[ovs-dev] [PATCH] windows/netinet: Add some #defines needed for Windows.

Signed-off-by: Gurucharan Shetty --- include/windows/netinet/ip.h | 25 + 1 file changed, 25 insertions(+) diff --git a/include/windows/netinet/ip.h b/include/windows/netinet/ip.h index e69de29..f37f476 100644 --- a/include/windows/netinet/ip.h +++ b/include/windows/net

[ovs-dev] [PATCH] bfd: Remove unnecessary include of netlink header.

Signed-off-by: Gurucharan Shetty --- lib/bfd.c |1 - 1 file changed, 1 deletion(-) diff --git a/lib/bfd.c b/lib/bfd.c index 5413105..1860cb6 100644 --- a/lib/bfd.c +++ b/lib/bfd.c @@ -30,7 +30,6 @@ #include "hmap.h" #include "list.h" #include "netdev.h" -#include "netlink.h" #include "od

[ovs-dev] [PATCH] windows/netinet: Import ip6.h and icmp6.h from netbsd.

There are a few structure definitions that is used from these headers. The keyword "__packed" has been removed from the headers as the corresponding Linux headers don't do packing. Signed-off-by: Gurucharan Shetty --- COPYING |4 + debian/copyright.in |

[ovs-dev] [PATCH] configure: Include pthread-win32 libraries for Windows build.

From: Gurucharan Shetty Signed-off-by: Gurucharan Shetty Signed-off-by: Saurabh Shah Co-authored-by: Saurabh Shah --- BUILD.Windows |7 ++- Makefile.am |2 ++ build-aux/cccl |2 +- lib/automake.mk |5 + m4/openvswitch.m4 | 21

[ovs-dev] [PATCH] ovsdb: Do not look for symbolic links for db creation.

We start with not supporting symbolic links for database creation in Windows. Signed-off-by: Gurucharan Shetty --- ovsdb/log.c |4 1 file changed, 4 insertions(+) diff --git a/ovsdb/log.c b/ovsdb/log.c index 807b983..48fa847 100644 --- a/ovsdb/log.c +++ b/ovsdb/log.c @@ -91,6 +91,7 @@

Re: [ovs-dev] [PATCH V3 1/5] dpif: Change dpif API to allow multiple handler threads read upcall.

> - fold in Ben's clarification. > > - refine the comments. > > - invoke dpif_handlers_set() in udpif_set_threads(). this is a bug. > > the previous code will cause the handlers polling from closed > > fd. > > I'm still trying to figure out whether I properly understand the new > API. Here's

Re: [ovs-dev] [PATCH V3 2/5] dpif-netdev: Implement the API functions to allow multiple handler threads read upcall.

> > > PATCH -> V2: > > > > - explain the drop of upcall queueing priority in dpif-netdev. > > > > - use mhash to calculate the 5-tuple hash. > > > > > > Why does dpif_netdev_recv_set() ignore its 'enable' argument? > > > > I saw in current dpif-netdev.c, the dpif_netdev_recv_set() does nothing. >

Re: [ovs-dev] [PATCH v2] uuid: Use current time to compute sha.

On Wed, Mar 12, 2014 at 08:12:16AM -0700, Gurucharan Shetty wrote: > Windows does not have the getppid(), getuid(), getgid() functions. > We do get a random seed from CryptGenRandom(). That seed along with > process id and current time hopefully is good enough. > > Signed-off-by: Gurucharan Shetty

Re: [ovs-dev] [PATCH v2] ovsdb-server: Truncate file for Windows.

On Wed, Mar 12, 2014 at 08:12:15AM -0700, Gurucharan Shetty wrote: > There is no ftruncate() in visual studio. There is a _chsize_s() > which has a similar functionality. > > Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff ___ dev mailing list de

Re: [ovs-dev] [PATCH v2] ofp-print: __attribute__ format in visual studio.

On Wed, Mar 12, 2014 at 08:12:14AM -0700, Gurucharan Shetty wrote: > Visual studio does not understand __attribute__ format. > > Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailm

[ovs-dev] [PATCH v2] ofp-print: __attribute__ format in visual studio.

Visual studio does not understand __attribute__ format. Signed-off-by: Gurucharan Shetty --- lib/ofp-print.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ofp-print.c b/lib/ofp-print.c index 06e64f6..5b53366 100644 --- a/lib/ofp-print.c +++ b/lib/ofp-print.c @@ -572,

[ovs-dev] [PATCH v2] ovsdb-server: Truncate file for Windows.

There is no ftruncate() in visual studio. There is a _chsize_s() which has a similar functionality. Signed-off-by: Gurucharan Shetty --- include/windows/windefs.h |1 + lib/util.c| 12 lib/util.h|1 + 3 files changed, 14 insertions(+) diff

[ovs-dev] [PATCH v2] uuid: Use current time to compute sha.

Windows does not have the getppid(), getuid(), getgid() functions. We do get a random seed from CryptGenRandom(). That seed along with process id and current time hopefully is good enough. Signed-off-by: Gurucharan Shetty --- lib/uuid.c | 24 +--- 1 file changed, 13 inserti

[ovs-dev] Rackspace Users

Hi, Found your company is interested in *Rackspace Users*. We provide Top Decision Makers information like Name, Email, Title, Phone Number and Company Name, Address, Revenue, Employees Size and other details. Few of the *Technology* are mentioned below as per you interest: *AT&T SAVVIS Siri

[ovs-dev] [PATCH 2/3] learn.at: fix a comment

Signed-off-by: YAMAMOTO Takashi --- tests/learn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/learn.at b/tests/learn.at index b88ea12..8807723 100644 --- a/tests/learn.at +++ b/tests/learn.at @@ -372,7 +372,7 @@ NXST_FLOW reply: OVS_VSWITCHD_STOP AT_CLEANUP -# T

[ovs-dev] [PATCH 3/3] learn.at: fix a race in "self-modifying flow with hard_timeout" test

Signed-off-by: YAMAMOTO Takashi --- tests/learn.at | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/tests/learn.at b/tests/learn.at index 8807723..e656c97 100644 --- a/tests/learn.at +++ b/tests/learn.at @@ -381,25 +381,31 @@ ADD_OF_PORTS([br0], 1, 2, 3)

[ovs-dev] [PATCH 1/3] learn.at: wrap long comments

Signed-off-by: YAMAMOTO Takashi --- tests/learn.at | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/learn.at b/tests/learn.at index 9bd3c44..b88ea12 100644 --- a/tests/learn.at +++ b/tests/learn.at @@ -350,7 +350,8 @@ for i in `seq 1 10`; do fi done -# Check

Re: [ovs-dev] [PATCH 2/4] connmgr: Remove unnecessary reason fixup logic

On Wed, Mar 12, 2014 at 05:00:09PM +0900, YAMAMOTO Takashi wrote: > > On Wed, Mar 12, 2014 at 12:00:12PM +0900, YAMAMOTO Takashi wrote: > >> > A packet_in message may be sent for one of two reasons. > >> > > >> > 1. As the result of an controller action supplied in a rule. > >> >This is execut

Re: [ovs-dev] [PATCH 2/4] connmgr: Remove unnecessary reason fixup logic

> On Wed, Mar 12, 2014 at 12:00:12PM +0900, YAMAMOTO Takashi wrote: >> > A packet_in message may be sent for one of two reasons. >> > >> > 1. As the result of an controller action supplied in a rule. >> >This is executed if a packet matches the match for the rule. >> >The packet_in reason

Re: [ovs-dev] [PATCH] stp: Fix bpdu tx problem in listening state

On Wed, Mar 12, 2014 at 1:41 PM, Ben Pfaff wrote: > On Sun, Mar 09, 2014 at 05:48:52PM +0800, kmindg wrote: >> The restriction only allows to send bpdu in forwarding state in >> compose_output_action__. But a port could send bpdu in listening >> and learning state according to comments in lib/stp.