Thanks, I fixed that. I'll push this in a moment.
On Sat, Mar 01, 2014 at 05:30:55PM -0800, Ethan Jackson wrote:
> You mispelled commit in the commit message.
>
>
> Acked-by: Ethan Jackson
>
>
> On Sat, Mar 1, 2014 at 5:25 PM, Ben Pfaff wrote:
> > On most architectures other than 32-bit x86
You mispelled commit in the commit message.
Acked-by: Ethan Jackson
On Sat, Mar 1, 2014 at 5:25 PM, Ben Pfaff wrote:
> On most architectures other than 32-bit x86, struct flow_tnl ends with 4
> padding bytes. Until now, tnl_xlate_init() set those bytes to nonzero
> values in the wildcard mas
Acked-by: Ethan Jackson
On Sat, Mar 1, 2014 at 5:25 PM, Ben Pfaff wrote:
> When a flow_tnl is being translated to Netlink attributes, the tun_id field
> was included only if the FLOW_TNL_F_KEY flag was set. This meant that for
> a mask, where one would not necessarily expect that flag to be se
On most architectures other than 32-bit x86, struct flow_tnl ends with 4
padding bytes. Until now, tnl_xlate_init() set those bytes to nonzero
values in the wildcard mask. When the wildcard mask passed through Netlink
attributes and back to userspace, the padding bytes of course became zero
again
When a flow_tnl is being translated to Netlink attributes, the tun_id field
was included only if the FLOW_TNL_F_KEY flag was set. This meant that for
a mask, where one would not necessarily expect that flag to be set even if
there were a key, the tun_id could be omitted even if it were nonzero.
Th
Please.
On Fri, Feb 28, 2014 at 02:43:27PM -0800, Joe Stringer wrote:
> I figured that if we're not using the retval currently, then it doesn't
> matter too much. But I'm happy to change it.
>
>
> On 28 February 2014 13:53, Ben Pfaff wrote:
>
> > On Fri, Feb 28, 2014 at 01:42:13PM -0800, Joe S
