Signed-off-by: YAMAMOTO Takashi
---
tests/ofproto-dpif.at | 4
1 file changed, 4 insertions(+)
diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index 8e21d11..2611682 100644
--- a/tests/ofproto-dpif.at
+++ b/tests/ofproto-dpif.at
@@ -1143,6 +1143,7 @@ AT_CHECK([ovs-ofctl --protoco
>> On Wed, Feb 05, 2014 at 07:04:05PM +0900, YAMAMOTO Takashi wrote:
>>> Following OpenFlow 1.4 semantics, make barriers wait for
>>> flow monitor replies. This should fix a race in
>>> "ofproto - flow monitoring pause and resume" test.
>>>
>>> Signed-off-by: YAMAMOTO Takashi
>>
>> I still don'
ping!
>> Patch bf06c4fe (tests/ofproto-dpif.at: Workaround a race.), fixed a
>> race condition which patch 0a8763f (ofproto-dpif-upcall: Hardcode
>> max_idle to 1500ms.) unfixed.
>>
>> Signed-off-by: Ethan Jackson
>> Reported-by: YAMAMOTO Takashi
>
> looks good to me.
>
> YAMAMOTO Takashi
>
On Wed, Feb 26, 2014 at 04:35:44PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Feb 26, 2014 at 04:35:43PM -0800, Justin Pettit wrote:
> Issue #16648
>
> Suggested-by: Anupam Chanda
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Feb 26, 2014 at 04:35:42PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Feb 26, 2014 at 8:28 PM, Ben Pfaff wrote:
> On Wed, Feb 26, 2014 at 11:19:15PM -0300, Flavio Leitner wrote:
>> It prevents non-root users to check service status.
>>
>> Signed-off-by: Flavio Leitner
>
> Guru, if you're OK with this change, it's fine by me. Otherwise, if
> it's important
On Wed, Feb 26, 2014 at 04:35:40PM -0800, Justin Pettit wrote:
> Suggested-by: Bruce Davie
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Feb 26, 2014 at 04:35:41PM -0800, Justin Pettit wrote:
> Future patches will make use of the ability to retrieve the schema
> version against which they were compiled.
>
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
d
On Wed, Feb 26, 2014 at 04:35:39PM -0800, Justin Pettit wrote:
> Suggested-by: Bruce Davie
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Feb 26, 2014 at 11:19:15PM -0300, Flavio Leitner wrote:
> It prevents non-root users to check service status.
>
> Signed-off-by: Flavio Leitner
Guru, if you're OK with this change, it's fine by me. Otherwise, if
it's important to log, then we could compromise by using "tee" only if
"tes
On Wed, Feb 26, 2014 at 06:22:39PM -0800, Andy Zhou wrote:
> Change the flow_extract() API to accept struct pkt_metadta,
> instead of individual metadata fields. It will make the API more
> logical and easier to maintain when we need to expand metadata
> down the road.
>
> Signed-off-by: Andy Zhou
On Wed, Feb 26, 2014 at 07:15:37PM -0800, Andy Zhou wrote:
> Fixed sparse non static symbol warning.
>
> Signed-off-by: Andy Zhou
It's a little odd that we have a HANDLE outside of Windows anyway.
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswi
On Wed, Feb 26, 2014 at 07:15:38PM -0800, Andy Zhou wrote:
> Fixed sparse undefined symbol warnings.
>
> Signed-off-by: Andy Zhou
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Feb 26, 2014 at 7:15 PM, Andy Zhou wrote:
> Fixed sparse non static symbol warning.
>
> Signed-off-by: Andy Zhou
Sorry about that. Looks good to me.
> ---
> lib/fatal-signal.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/fatal-signal.c b/lib/fatal-sign
Fixed sparse non static symbol warning.
Signed-off-by: Andy Zhou
---
lib/fatal-signal.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/fatal-signal.c b/lib/fatal-signal.c
index df67a09..ef3fbc0 100644
--- a/lib/fatal-signal.c
+++ b/lib/fatal-signal.c
@@ -59,7 +59,7 @@
Fixed sparse undefined symbol warnings.
Signed-off-by: Andy Zhou
---
include/sparse/netinet/in.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/sparse/netinet/in.h b/include/sparse/netinet/in.h
index a220428..d51722e 100644
--- a/include/sparse/netinet/in.h
+++ b/include/spars
Change the flow_extract() API to accept struct pkt_metadta,
instead of individual metadata fields. It will make the API more
logical and easier to maintain when we need to expand metadata
down the road.
Signed-off-by: Andy Zhou
---
lib/dpif-netdev.c |6 ++
lib/flow.c
It prevents non-root users to check service status.
Signed-off-by: Flavio Leitner
---
utilities/ovs-lib.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in
index 029ed3b..f14862d 100644
--- a/utilities/ovs-lib.in
+++ b/utilities/
On Feb 25, 2014, at 2:58 PM, Ben Pfaff wrote:
> On Mon, Feb 24, 2014 at 04:11:23PM +0100, Martino Fornasa wrote:
>> The attached patch is an implementation of the Rapid Spanning Tree Protocol
>> (RSTP, IEEE 802.1D-2004) on Open vSwitch.
>>
>> We have now performed some more in-depth tests on th
Future patches will make use of the ability to retrieve the schema
version against which they were compiled.
Signed-off-by: Justin Pettit
---
ovsdb/ovsdb-idlc.in | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/ovsdb/ovsdb-idlc.in b/ovsdb/ovsdb-idlc.in
index e
Signed-off-by: Justin Pettit
---
utilities/ovs-vsctl.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c
index 62a66c5..21ac777 100644
--- a/utilities/ovs-vsctl.c
+++ b/utilities/ovs-vsctl.c
@@ -392,6 +392,7 @@ parse_options(int
Signed-off-by: Justin Pettit
---
manpages.mk |4
utilities/ovs-vsctl.8.in |1 +
vtep/vtep-ctl.8.in |1 +
3 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/manpages.mk b/manpages.mk
index 5d5df03..1d9ac45 100644
--- a/manpages.mk
+++ b/manpages.mk
@
Issue #16648
Suggested-by: Anupam Chanda
Signed-off-by: Justin Pettit
---
vtep/vtep-ctl.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/vtep/vtep-ctl.c b/vtep/vtep-ctl.c
index fc7998b..25470ff 100644
--- a/vtep/vtep-ctl.c
+++ b/vtep/vtep-ctl.c
@@ -370,6 +370,7 @@ pars
Suggested-by: Bruce Davie
Signed-off-by: Justin Pettit
---
vtep/automake.mk |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/vtep/automake.mk b/vtep/automake.mk
index 008f5b4..978747d 100644
--- a/vtep/automake.mk
+++ b/vtep/automake.mk
@@ -50,6 +50,7 @@ $(srcdir)/vtep/vt
Suggested-by: Bruce Davie
Signed-off-by: Justin Pettit
---
ovsdb/ovsdb-doc |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ovsdb/ovsdb-doc b/ovsdb/ovsdb-doc
index 46f1101..6200915 100755
--- a/ovsdb/ovsdb-doc
+++ b/ovsdb/ovsdb-doc
@@ -270,7 +270,7 @@ def docsToNroff(s
This reworks lookup of rules for both table 0 and table action translation.
The result is that Table Mod settings, which can alter the miss-behaviour
of tables, including table 0, on a per-table basis may be honoured.
Previous patches proposed by myself which build on earlier merged patches
by And
On Wed, Feb 26, 2014 at 2:09 PM, Kyle Mestery wrote:
> I see this patch [1] in patchwork now from Pravin via James Page.
> I pulled this down and started to look at what it would take to get this
> also working with 3.13. It looks like the netlink interfaces changed a
> bit here. Is anyone working
I see this patch [1] in patchwork now from Pravin via James Page.
I pulled this down and started to look at what it would take to get this
also working with 3.13. It looks like the netlink interfaces changed a
bit here. Is anyone working on this at the moment? If not, I'd like to
take this on. Seco
Applied to master and backported to branch 1.10-2.1~
On Wed, Feb 26, 2014 at 12:53 PM, Ben Pfaff wrote:
> Thanks.
>
> Acked-by: Ben Pfaff
>
>
> On Wed, Feb 26, 2014 at 12:50:55PM -0800, Alex Wang wrote:
> > Me too, will push for Joe soon
> >
> >
> > On Wed, Feb 26, 2014 at 12:42 PM, Ben Pfaff
On Tue, Feb 25, 2014 at 03:44:15PM -0800, Pritesh Kothari wrote:
> NSH service path (nsp) can be set/unset while creating the port
> as well as nsp can be matched on incoming packets.
>
> Signed-off-by: Pritesh Kothari
Here are some preliminary comments.
"git am" says:
Applying: nsh: userl
On Wed, Feb 19, 2014 at 11:59:33AM +0100, Helmut Schaa wrote:
> Limit fake bridge MAC address selection to only consider ports
> that use the same VLAN as the fake bridge itself.
>
> This prevents OVS from selecting a MAC address that was not really
> present in the VLAN of the fake bridge before.
Thanks.
Acked-by: Ben Pfaff
On Wed, Feb 26, 2014 at 12:50:55PM -0800, Alex Wang wrote:
> Me too, will push for Joe soon
>
>
> On Wed, Feb 26, 2014 at 12:42 PM, Ben Pfaff wrote:
>
> > I think I'm OK with this version. Does anyone have any objections to it?
> >
> > On Tue, Feb 18, 2014 at 04
Me too, will push for Joe soon
On Wed, Feb 26, 2014 at 12:42 PM, Ben Pfaff wrote:
> I think I'm OK with this version. Does anyone have any objections to it?
>
> On Tue, Feb 18, 2014 at 04:01:41PM -0800, Joe Stringer wrote:
> > I asked Ethan and he suggested that Ben might have a better idea.
>
On Feb 26, 2014, at 12:44 PM, Ben Pfaff wrote:
> On Tue, Feb 25, 2014 at 03:44:13PM -0800, Pritesh Kothari wrote:
>> This is version 2 for supporting NSH [1] on vxlan. The changes since
>> last patch set are few and mainly just related to the review earlier.
>
> Thanks for sending it along. I
On Tue, Feb 25, 2014 at 03:44:13PM -0800, Pritesh Kothari wrote:
> This is version 2 for supporting NSH [1] on vxlan. The changes since
> last patch set are few and mainly just related to the review earlier.
Thanks for sending it along. I think that we need Jesse's feedback
before anything else.
I think I'm OK with this version. Does anyone have any objections to it?
On Tue, Feb 18, 2014 at 04:01:41PM -0800, Joe Stringer wrote:
> I asked Ethan and he suggested that Ben might have a better idea.
>
> Ben, is this approach fine? I'm not entirely clear on what the relationship
> is between
On Wed, Feb 26, 2014 at 04:52:41PM -0300, Flavio Leitner wrote:
> On Wed, Feb 26, 2014 at 11:21:35AM -0800, Ben Pfaff wrote:
> > It used to be essentially required, but now it's reasonable to use the
> > kernel's builtin module.
> >
> > Signed-off-by: Ben Pfaff
> > ---
>
> Reviewed-by: Flavio Le
On Wed, Feb 26, 2014 at 11:46:51AM -0800, Gurucharan Shetty wrote:
> On Wed, Feb 26, 2014 at 11:21 AM, Ben Pfaff wrote:
> > It used to be essentially required, but now it's reasonable to use the
> > kernel's builtin module.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > INSTALL | 14 +---
On Wed, Feb 26, 2014 at 11:40:54AM -0800, Gurucharan Shetty wrote:
> On Wed, Feb 26, 2014 at 11:24 AM, Ben Pfaff wrote:
> > On Wed, Feb 26, 2014 at 10:51:56AM -0800, Gurucharan Shetty wrote:
> >> Windows does not have a SIGHUP or SIGALRM. It does have
> >> a SIGINT and SIGTERM. The documentation a
On Wed, Feb 26, 2014 at 11:21:35AM -0800, Ben Pfaff wrote:
> It used to be essentially required, but now it's reasonable to use the
> kernel's builtin module.
>
> Signed-off-by: Ben Pfaff
> ---
Reviewed-by: Flavio Leitner
___
dev mailing list
dev@ope
On Wed, Feb 26, 2014 at 11:21 AM, Ben Pfaff wrote:
> It used to be essentially required, but now it's reasonable to use the
> kernel's builtin module.
>
> Signed-off-by: Ben Pfaff
> ---
> INSTALL | 14 +-
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/INSTALL b/
On Wed, Feb 26, 2014 at 11:24 AM, Ben Pfaff wrote:
> On Wed, Feb 26, 2014 at 10:51:56AM -0800, Gurucharan Shetty wrote:
>> Windows does not have a SIGHUP or SIGALRM. It does have
>> a SIGINT and SIGTERM. The documentation at msdn says that
>> SIGINT is not supported for win32 applications because
On Wed, Feb 26, 2014 at 11:13:23AM -0800, Gurucharan Shetty wrote:
> I have not seen a use case where the "lib" prefix is needed.
> In my tests, I see that adding the additional "lib" prefix
> causes libraries to not be recognized.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
__
On Wed, Feb 26, 2014 at 10:51:59AM -0800, Gurucharan Shetty wrote:
> Ctrl+C signals are a special case for Windows and can
> be handled by registering a handle through
> SetConsoleCtrlHandler() routine. This is only useful
> when we run it directly on console and not as services in
> the background
On Wed, Feb 26, 2014 at 10:52:00AM -0800, Gurucharan Shetty wrote:
> Windows does not have a SIGPIPE. We ignore SIGPIPE for
> Linux. To compile on Windows, carve out a new function
> to ignore SIGPIPE on Linux.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
On Wed, Feb 26, 2014 at 10:51:58AM -0800, Gurucharan Shetty wrote:
> Windows does have pipes (the interface is a little different).
> We mostly use pipes in Linux to synchronize between parent and
> children and also to handle fatal signals and then wake from poll_loop().
>
> For Windows, we are u
On Wed, Feb 26, 2014 at 10:51:57AM -0800, Gurucharan Shetty wrote:
> There are no users in Windows for any of the
> function in signals.c
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswi
On Wed, Feb 26, 2014 at 10:51:56AM -0800, Gurucharan Shetty wrote:
> Windows does not have a SIGHUP or SIGALRM. It does have
> a SIGINT and SIGTERM. The documentation at msdn says that
> SIGINT is not supported for win32 applications because
> WIN32 operating systems generate a new thread to specif
I have not seen a use case where the "lib" prefix is needed.
In my tests, I see that adding the additional "lib" prefix
causes libraries to not be recognized.
Signed-off-by: Gurucharan Shetty
---
build-aux/cccl |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/build-aux
It used to be essentially required, but now it's reasonable to use the
kernel's builtin module.
Signed-off-by: Ben Pfaff
---
INSTALL | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/INSTALL b/INSTALL
index 9f9491f..cc89cc3 100644
--- a/INSTALL
+++ b/INSTALL
@@
On Sat, Feb 22, 2014 at 01:14:00PM +0800, Kmindg G wrote:
> On Sat, Feb 22, 2014 at 12:42 AM, Ben Pfaff wrote:
> > On Fri, Feb 21, 2014 at 10:07:14AM +0800, Kmindg G wrote:
> >> On Fri, Feb 21, 2014 at 5:19 AM, Ben Pfaff wrote:
> >> > On Thu, Feb 20, 2014 at 12:45:49PM +0800, Kmindg G wrote:
> >>
Ctrl+C signals are a special case for Windows and can
be handled by registering a handle through
SetConsoleCtrlHandler() routine. This is only useful
when we run it directly on console and not as services in
the background.
Once we get a Ctrl+C signal, we call the cleanup functions
and then exit.
There are no users in Windows for any of the
function in signals.c
Signed-off-by: Gurucharan Shetty
---
lib/automake.mk |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/automake.mk b/lib/automake.mk
index f3868db..9c345e7 100644
--- a/lib/automake.mk
+++ b/lib/autom
Windows does not have a SIGHUP or SIGALRM. It does have
a SIGINT and SIGTERM. The documentation at msdn says that
SIGINT is not supported for win32 applications because
WIN32 operating systems generate a new thread to specifically
handle Ctrl+C.
This commit handles SIGTERM for Windows. The documen
Windows does have pipes (the interface is a little different).
We mostly use pipes in Linux to synchronize between parent and
children and also to handle fatal signals and then wake from poll_loop().
For Windows, we are using events for the same purpose. So don't
implement pipes for Windows.
Sign
Windows does not have a SIGPIPE. We ignore SIGPIPE for
Linux. To compile on Windows, carve out a new function
to ignore SIGPIPE on Linux.
Signed-off-by: Gurucharan Shetty
---
lib/fatal-signal.c |8
lib/fatal-signal.h |1 +
ovsdb/ovsdb-client.c|3 ++-
ovsdb/ovsd
That sounds fine by me.
On 25 February 2014 22:22, Ben Pfaff wrote:
> Joe, based on Ethan's feedback I'll drop this for now unless you prefer
> otherwise.
>
> On Tue, Feb 25, 2014 at 05:37:05PM -0800, Ethan Jackson wrote:
> > I'm not sure this patch makes sense in the current code. If a
> > re
On Mon, Feb 24, 2014 at 11:46:22AM +0900, YAMAMOTO Takashi wrote:
> The name of loopback interface is "lo0" on BSDs.
>
> Signed-off-by: YAMAMOTO Takashi
Applied, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/d
On Sun, Feb 23, 2014 at 12:45:07PM +0900, YAMAMOTO Takashi wrote:
> > On Sat, Feb 22, 2014 at 2:25 AM, YAMAMOTO Takashi
> > wrote:
> >>> On Fri, Feb 21, 2014 at 5:33 PM, YAMAMOTO Takashi
> >>> wrote:
> Fix the regression introduced by commit 4f57ad10.
> ("socket-util: Move get_max_fds()
On Mon, Feb 24, 2014 at 11:46:59AM +0900, YAMAMOTO Takashi wrote:
> Try IPPROTO_IPV6/IPV6_TCLASS socket option as well as IPPROTO_IP/IP_TOS
> so that this can work for IPv6 sockets.
>
> IPPROTO_IP/IP_TOS socket option is, as it's SOL indicates, for IPv4.
> What happens when it's used for IPv6 sock
On Mon, Feb 24, 2014 at 11:46:21AM +0900, YAMAMOTO Takashi wrote:
> Signed-off-by: YAMAMOTO Takashi
Applied, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
62 matches
Mail list logo
