Re: [ovs-dev] [PATCH] Windows implementation of stream-fd.

2014-02-24 Thread Gurucharan Shetty
On Wed, Feb 12, 2014 at 1:50 PM, Linda Sun wrote: > Use send/recv for socket stream instead of read/write. > Use event handle for polling on socket stream. > Check windows specific return code. > > Signed-off-by: Linda Sun I think we need to use the following .gitconfig setting: [diff] rename

[ovs-dev] [PATCH v3] Windows implementation of stream-fd.

2014-02-24 Thread Gurucharan Shetty
From: Linda Sun Use send/recv for socket stream instead of read/write. Use event handle for polling on socket stream. Check windows specific return code. Signed-off-by: Linda Sun Signed-off-by: Gurucharan Shetty --- lib/automake.mk |7 +-- lib/{latch.c => latch-un

Re: [ovs-dev] [PATCH 1/5] ofproto-dpif: Test flow stats reporting.

2014-02-24 Thread Joe Stringer
Ping, the series beginning here fixes various stats duplication bugs introduced with the revalidation threading patches: * Flows missed during a datapath dump will have their stats duplicated (Caused by flow deletions while dumping) * Flows that are dumped twice may have their stats duplicated (Ca

Re: [ovs-dev] [PATCH] Rapid Spanning Protocol Implementation (IEEE 802.1D) + functional tests

2014-02-24 Thread Ben Pfaff
On Mon, Feb 24, 2014 at 04:11:23PM +0100, Martino Fornasa wrote: > The attached patch is an implementation of the Rapid Spanning Tree Protocol > (RSTP, IEEE 802.1D-2004) on Open vSwitch. > > We have now performed some more in-depth tests on the implementation > (you can find the test documentation

Re: [ovs-dev] [PATCH] ofproto-dpif: Complete all packet translations before freeing an ofproto.

2014-02-24 Thread Alex Wang
Acked-by: Alex Wang On Mon, Feb 24, 2014 at 11:10 AM, Ben Pfaff wrote: > The following scenario can occur: > >1. Handler thread grabs a pointer to an ofproto in handle_upcalls(). > >2. Main thread removes ofproto and destroys it in destruct(). > >3. Handler thread uses pointer to

[ovs-dev] [PATCH] ofproto-dpif: Complete all packet translations before freeing an ofproto.

2014-02-24 Thread Ben Pfaff
The following scenario can occur: 1. Handler thread grabs a pointer to an ofproto in handle_upcalls(). 2. Main thread removes ofproto and destroys it in destruct(). 3. Handler thread uses pointer to ofproto and accesses freed memory. BOOM! Each individual step above happens under

Re: [ovs-dev] [PATCH] meta-flow: Remove duplicate break statements.

2014-02-24 Thread Ben Pfaff
You want to push it for Joe? On Mon, Feb 24, 2014 at 10:37:04AM -0800, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > On Feb 24, 2014, at 10:20 AM, Joe Stringer wrote: > > > Commit 8bfd0fda mistakenly introduced duplicate "break;" statements to > > MFF_MPLS_BOS handling. This patch rem

Re: [ovs-dev] [PATCH] meta-flow: Remove duplicate break statements.

2014-02-24 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme On Feb 24, 2014, at 10:20 AM, Joe Stringer wrote: > Commit 8bfd0fda mistakenly introduced duplicate "break;" statements to > MFF_MPLS_BOS handling. This patch removes them. > > Found by inspection. > > Signed-off-by: Joe Stringer > --- > lib/meta-flow.c |4

Re: [ovs-dev] [PATCH v3 04/10] datapath: Compact sw_flow_key.

2014-02-24 Thread Jarno Rajahalme
On Feb 21, 2014, at 11:41 AM, Jarno Rajahalme wrote: > Minimize padding in sw_flow_key and move 'tp' top the main struct. > These changes simplify code when accessing the transport port numbers > and the tcp flags, and makes the sw_flow_key 8 bytes smaller on 64-bit > systems (128->120 bytes).

[ovs-dev] [PATCH] meta-flow: Remove duplicate break statements.

2014-02-24 Thread Joe Stringer
Commit 8bfd0fda mistakenly introduced duplicate "break;" statements to MFF_MPLS_BOS handling. This patch removes them. Found by inspection. Signed-off-by: Joe Stringer --- lib/meta-flow.c |4 1 file changed, 4 deletions(-) diff --git a/lib/meta-flow.c b/lib/meta-flow.c index 3afcd4c..

Re: [ovs-dev] [PATCH] socket-util: drain_rcvbuf() for Windows.

2014-02-24 Thread Ben Pfaff
On Mon, Feb 24, 2014 at 10:05:46AM -0800, Gurucharan Shetty wrote: > Netlink sockets are created as blocking sockets. So, we can't > afford to remove MSG_DONTWAIT for Linux. > > drain_rcvbuf() is currently called from netlink-socket.c and > netdev-linux.c. As of now, I don't see it being used for

[ovs-dev] [PATCH] socket-util: drain_rcvbuf() for Windows.

2014-02-24 Thread Gurucharan Shetty
Netlink sockets are created as blocking sockets. So, we can't afford to remove MSG_DONTWAIT for Linux. drain_rcvbuf() is currently called from netlink-socket.c and netdev-linux.c. As of now, I don't see it being used for Windows. Bug #1200865. Signed-off-by: Gurucharan Shetty Reported-by: Len Ga