Re: [ovs-dev] [PATCH] ofp-actions: Consider pop MPLS to non-MPLS ethtype as consistent

2014-02-16 Thread Simon Horman
On Mon, Feb 17, 2014 at 10:06:55AM +0900, Simon Horman wrote: > Remove the restriction that pop MPLS to an ethtype is > considered inconsistent. > > As it happens this is allowed for OpenFlow 1.0, and thus > the tests in the Open vSwtich test-suite, by virtue of > inconsistent actions being allowe

[ovs-dev] [PATCH] ofp-actions: Consider pop MPLS to non-MPLS ethtype as consistent

2014-02-16 Thread Simon Horman
Remove the restriction that pop MPLS to an ethtype is considered inconsistent. As it happens this is allowed for OpenFlow 1.0, and thus the tests in the Open vSwtich test-suite, by virtue of inconsistent actions being allowed in the case of OpenFlow 1.0. Its not clear to me why they should be con

Re: [ovs-dev] LED Crysta Lighting

2014-02-16 Thread Ahern
Dear Friends, This is the Liven here. I would like to introduce the NEW modern crystal LED pendant lighting for you. Nice lighting can decorative your house and bring high qulity life. We also can offer different all kinds of modern crtsral LED light for you to bring big business. If you need

Re: [ovs-dev] [PATCH V2] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-02-16 Thread Han Zhou
Hi Alex, Here comes my full review: On Fri, 2014-02-07 at 17:17 -0800, Alex Wang wrote: > diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c > > +/* Adds 'dpif->n_handlers' channels to vport. If upcall_pids is non-NULL, > + * makes it point to the array of channel socket pids. */ > static int

Re: [ovs-dev] [PATCH v7] datapath: Per NUMA node flow stats.

2014-02-16 Thread Jesse Gross
On Fri, Feb 14, 2014 at 4:15 PM, Pravin Shelar wrote: > I got following sparse warning. > > /home/pravin/ovs/w6/datapath/linux/flow_table.c:97:9: warning: > incorrect type in argument 1 (different address spaces) > /home/pravin/ovs/w6/datapath/linux/flow_table.c:97:9:expected > struct spinlock

Re: [ovs-dev] [PATCH v2 01/13] datapath: Remove 5-tuple optimization.

2014-02-16 Thread Jesse Gross
On Tue, Feb 11, 2014 at 4:07 PM, Jarno Rajahalme wrote: > The 5-tuple optimization becomes unnecessary with a later per-NUMA > node stats patch. Remove it first to make the changes easier to > grasp. > > Signed-off-by: Jarno Rajahalme Acked-by: Jesse Gross _