Re: [ovs-dev] [GIT net] Open vSwitch

2014-02-05 Thread Jesse Gross
On Wed, Feb 5, 2014 at 11:09 PM, Or Gerlitz wrote: > On Wed, Feb 5, 2014 at 8:59 AM, Jesse Gross wrote: >> >> A handful of bug fixes for net/3.14. High level fixes are: >> * Regressions introduced by the zerocopy changes, particularly with >>old userspaces. > > Hi, so this post was the 2nd v

Re: [ovs-dev] [GIT net] Open vSwitch

2014-02-05 Thread Or Gerlitz
On Wed, Feb 5, 2014 at 8:59 AM, Jesse Gross wrote: > > A handful of bug fixes for net/3.14. High level fixes are: > * Regressions introduced by the zerocopy changes, particularly with >old userspaces. Hi, so this post was the 2nd version of the five patches you posted earlier, right? it woul

[ovs-dev] [PATCH v6] ofproto: Honour Table Mod settings for table-miss handling

2014-02-05 Thread Simon Horman
This reworks lookup of rules for both table 0 and table action translation. The result is that Table Mod settings, which can alter the miss-behaviour of tables, including table 0, on a per-table basis may be honoured. Previous patches proposed by myself which build on earlier merged patches by And

Re: [ovs-dev] [GIT net] Open vSwitch

2014-02-05 Thread David Miller
From: Jesse Gross Date: Tue, 4 Feb 2014 22:59:16 -0800 > A handful of bug fixes for net/3.14. High level fixes are: > * Regressions introduced by the zerocopy changes, particularly with >old userspaces. > * A few bugs lingering from the introduction of megaflows. > * Overly zealous error

Re: [ovs-dev] [PATCH 1/2] datapath: Fix race and clarify locking.

2014-02-05 Thread Jarno Rajahalme
I just send a new version, but forgot to add a version tag to the subject line. Jarno On Feb 4, 2014, at 2:28 PM, Jesse Gross wrote: > On Tue, Feb 4, 2014 at 1:25 PM, Pravin Shelar wrote: >> On Tue, Feb 4, 2014 at 11:10 AM, Jarno Rajahalme >> wrote: >>> diff --git a/datapath/datapath.c b/d

[ovs-dev] [PATCH 2/3] datapath: Avoid assigning a NULL pointer to flow actions.

2014-02-05 Thread Jarno Rajahalme
Actions are optional for flow SET. Previously, we assigned the flow's actions pointer to NULL in this case, but we never check for the NULL pointer later on. This patch modifies this case to allocate a valid but empty set of actions instead. Signed-off-by: Jarno Rajahalme --- datapath/datapath

[ovs-dev] [PATCH 1/3] datapath: Fix race.

2014-02-05 Thread Jarno Rajahalme
ovs_vport_cmd_dump() did rcu_read_lock() only after getting the datapath, which could have been deleted in between. Resolved by taking rcu_read_lock() before the get_dp() call. Signed-off-by: Jarno Rajahalme --- datapath/datapath.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[ovs-dev] [PATCH 3/3] datapath: Clarify locking.

2014-02-05 Thread Jarno Rajahalme
Remove unnecessary locking from functions that are always called with appropriate locking and add/fix comments about locking requirements. Signed-off-by: Jarno Rajahalme --- datapath/datapath.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/datapath/datapath.

Re: [ovs-dev] [RFC PATCH 3/4] datapath: Minimize ovs_flow_cmd_new_or_set critical section.

2014-02-05 Thread Jarno Rajahalme
> On Feb 3, 2014, at 10:38 AM, Jesse Gross wrote: > >> On Fri, Jan 24, 2014 at 2:58 PM, Jarno Rajahalme >> wrote: >> diff --git a/datapath/datapath.c b/datapath/datapath.c >> index 92ae66a..5b12a5d 100644 >> --- a/datapath/datapath.c >> +++ b/datapath/datapath.c >> @@ -817,11 +840,27 @@ static

Re: [ovs-dev] [PATCH] pcap-file: Allow capturing TCP streams where the SYN is not seen.

2014-02-05 Thread Vasu Dasari
Ben, The code looks good to me and it also works for me. -Vasu On Tue, Feb 4, 2014 at 12:05 PM, Ben Pfaff wrote: > Until now, the tcp_stream() code has ignored any TCP packets that don't > correspond to a stream that began with a TCP SYN. This commit changes the > code so that any TCP packet

[ovs-dev] [PATCH 2/3] netdev-bsd: suppress clang warnings about alignment

2014-02-05 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- lib/netdev-bsd.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 963fbac..6d4a4b2 100644 --- a/lib/netdev-bsd.c +++ b/lib/netdev-bsd.c @@ -548,7 +548,7 @@ struct pcap_arg { static

[ovs-dev] [PATCH 1/3] netdev-bsd: Fix tx/rx stats for type=tap netdev

2014-02-05 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- lib/netdev-bsd.c | 52 +--- 1 file changed, 49 insertions(+), 3 deletions(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 97291bd..963fbac 100644 --- a/lib/netdev-bsd.c +++ b/lib/netdev-bsd.c @@ -863,7

[ovs-dev] [PATCH 3/3] ofproto-dpif.at: Avoid races in "ofproto-dpif - dummy interface"

2014-02-05 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- tests/ofproto-dpif.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index 1c1f029..8bf234c 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -33,6 +33,7 @@ ovs-appctl time/warp 5000 AT_CHECK([

[ovs-dev] [PATCH] fix monitor vs barrier

2014-02-05 Thread YAMAMOTO Takashi
changes from the previous: - rebase - incorporate Ben's feedbacks - comments YAMAMOTO Takashi (1): ofproto: fix interactions between flow monitors and barriers ofproto/connmgr.c | 44 ofproto/connmgr.h | 1 + ofproto/ofproto.c | 16 +++-

[ovs-dev] [PATCH] ofproto: fix interactions between flow monitors and barriers

2014-02-05 Thread YAMAMOTO Takashi
Following OpenFlow 1.4 semantics, make barriers wait for flow monitor replies. This should fix a race in "ofproto - flow monitoring pause and resume" test. Signed-off-by: YAMAMOTO Takashi --- ofproto/connmgr.c | 44 ofproto/connmgr.h | 1 + ofproto/

[ovs-dev] [PATCH v2.53] datapath: Add basic MPLS support to kernel

2014-02-05 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer. Cc: Ravi K Cc: Leo Alterman Cc: Isaku Yamahata Cc: Joe Stringer Signed-off-by: Sim

[ovs-dev] [PATCH v2.53] datapath: Add basic MPLS support to kernel

2014-02-05 Thread Simon Horman
Hi Jesse, Hi All, after somewhat of a hiatus I would like to once again bring this patch onto the table. Since I posted the previous version (v2.52) a two key things have changed. * Ben's new approach to MPLS in userspace has been merged. Thus there are no user-space patches in this series. *