Perhaps it'd make sense to use net_ratelimit()
instead of printk_once for OVS_NLERR
---
net/openvswitch/datapath.h | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/net/openvswitch/datapath.h b/net/openvswitch/datapath.h
index 6be9fbb..0f5e77c 100644
--- a/net/openvswitch
On Fri, Jan 31, 2014 at 4:59 PM, Ben Pfaff wrote:
> On Fri, Jan 31, 2014 at 10:38:20AM -0800, Jesse Gross wrote:
>> On Thu, Jan 30, 2014 at 1:31 PM, Thomas Morin
>> wrote:
>> > Hi,
>> >
>> > I ran into the same issue as the one described below (post on ovs-discuss a
>> > few months back).
>> >
>
From: Andy Zhou
Both mega flow mask's reference counter and per flow table mask list
should only be accessed when holding ovs_mutex() lock. However
this is not true with ovs_flow_table_flush(). The patch fixes this bug.
Reported-by: Joe Stringer
Signed-off-by: Andy Zhou
Signed-off-by: Jesse Gr
From: Andy Zhou
With subfacets, we'd expect megaflow updates message to carry
the original micro flow. If not, EINVAL is returned and kernel
logs an error message. Now that the user space subfacet layer is
removed, it is expected that flow updates can arrive with a
micro flow other than the orig
From: Daniele Di Proietto
commit 43d4be9cb55f3bac5253e9289996fd9d735531db (openvswitch: Allow user space
to announce ability to accept unaligned Netlink messages) introduced
OVS_DP_ATTR_USER_FEATURES netlink attribute in datapath responses,
but the attribute size was not taken into account in ovs
From: Thomas Graf
While the zerocopy method is correctly omitted if user space
does not support unaligned Netlink messages. The attribute is
still not padded correctly as skb_zerocopy() will not ensure
padding and the attribute size is no longer pre calculated
though nla_reserve() which ensured p
A handful of bug fixes for net/3.14. High level fixes are:
* Regression introduced by the zerocopy changes, particularly with
old userspaces.
* A few bugs lingering from the introduction of megaflows.
* Overly zealous error checking that is now being triggered frequently
in common cases.
From: Pravin B Shelar
ovs_flow_free() is not called under ovs-lock during packet
execute path (ovs_packet_cmd_execute()). Since packet execute
does not touch flow->mask, there is no need to take that
lock either. So move assert in case where flow->mask is checked.
Found by code inspection.
Sign
> Patch bf06c4fe (tests/ofproto-dpif.at: Workaround a race.), fixed a
> race condition which patch 0a8763f (ofproto-dpif-upcall: Hardcode
> max_idle to 1500ms.) unfixed.
>
> Signed-off-by: Ethan Jackson
> Reported-by: YAMAMOTO Takashi
looks good to me.
YAMAMOTO Takashi
> ---
> tests/ofproto-
