[ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: Do not push LSE to flow if its label stack is full

2014-01-28 Thread Simon Horman
If a pop is composed on a flow whose label stack is already full it should not call flow_push_mpls() as that function can't do anything useful (it aborts) given that the label stack is full. Signed-off-by: Simon Horman --- ofproto/ofproto-dpif-xlate.c | 1 + 1 file changed, 1 insertion(+) diff

[ovs-dev] [PATCH 2/2] ofproto-dpif: Test for A MPLS pop on a packet whose label stack going to userspace

2014-01-28 Thread Simon Horman
Update the test for an MPLS pop on on a packet whose label stack going to userspace to test that it goes to userspace, which is currently the case, rather than being dropped, which was the case earlier. Signed-off-by: Simon Horman --- tests/ofproto-dpif.at | 30 +- 1

[ovs-dev] [PATCH 0/2] MPLS push fixes for blp/mpls

2014-01-28 Thread Simon Horman
Hi Ben, This short series attempts to resolve two problems related to changing flow_push_mpls() to use the slow path if there are two many MPLS LSEs present. 1) In this case it is not safe to call flow_push_mpls() as it can't do anything useful: there is no way to correctly update the MPLS

[ovs-dev] [PATCH] ofproto-dpif-xlate: Remove unused fitnessp pararameter from xlate_receive

2014-01-28 Thread Simon Horman
Some functions pass a non-NULL value as this parameter but none of those function uses the value xlate_receive() returns there. So simply remove the parameter all together. Also remove the now unused key_fitness field of struct flow_miss. Signed-off-by: Simon Horman --- ofproto/ofproto-dpif-upc

[ovs-dev] [PATCH v5 REPOST] ofproto: Honour Table Mod settings for table-miss handling

2014-01-28 Thread Simon Horman
This reworks lookup of rules for both table 0 and table action translation. The result is that Table Mod settings, which can alter the miss-behaviour of tables, including table 0, on a per-table basis may be honoured. Previous patches proposed by myself which build on earlier merged patches by And

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add support Intel DPDK based ports.

2014-01-28 Thread Vincent JARDIN
Hi Pravin, >> Few feature questions: - what's about the vNIC supports (toward the guests)? - what's about IPsec support (VxLAN over IPsec for instance)? I do not understand how your patch will solve those 2 cases. At this point I wanted to get basic DPDK support in OVS, once that is done

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Hardcode max_idle to 1500ms.

2014-01-28 Thread Joe Stringer
Looks good to me. This certainly makes it easier to get reproducible performance results. Acked-by: Joe Stringer On 27 January 2014 16:50, Ethan Jackson wrote: > Before this patch, OVS tried to guess an optimal max idle time for > datapath flows based on the number of datapath flows relative

Re: [ovs-dev] [branch-2.0] ofproto-dpif: Fix rule delete deadlock.

2014-01-28 Thread Ben Pfaff
On Tue, Jan 28, 2014 at 02:57:10PM -0800, Ethan Jackson wrote: > When doing rule expiration, ofproto_rule_delete__() take the > ofproto_mutex and calls rule_get_stats(). rule_get_stats() can do an > xlate_actions() which may take the ofproto_mutex, causing a deadlock. > > Signed-off-by: Ethan Jac

[ovs-dev] [branch-2.0] ofproto-dpif: Fix rule delete deadlock.

2014-01-28 Thread Ethan Jackson
When doing rule expiration, ofproto_rule_delete__() take the ofproto_mutex and calls rule_get_stats(). rule_get_stats() can do an xlate_actions() which may take the ofproto_mutex, causing a deadlock. Signed-off-by: Ethan Jackson --- ofproto/ofproto-dpif.c | 18 -- ofproto/of

[ovs-dev] [PATCH v2 2/2] daemon-windows: Add users for windows services.

2014-01-28 Thread Gurucharan Shetty
Start with ovs-vswitchd and ovsdb-server. Signed-off-by: Gurucharan Shetty --- v1->v2: No change --- lib/daemon.man |1 + lib/service.man|1 + lib/util.c |4 manpages.mk|6 ++ ovsdb/ovsdb-server.1.in|3 +++

[ovs-dev] [PATCH v2 1/2] daemon-windows: Ability to handle windows service calls.

2014-01-28 Thread Gurucharan Shetty
The following code does not add any users yet. The visioned workflow that this piece of code should work with is: * Create a windows service through a startup script with a tool like 'sc' ex: sc create ovsdb-server binpath= "C:\openvswitch\usr\sbin\ovsdb-server.exe -vconsole:off -vsyslog:off -vf

[ovs-dev] [PATCH] upcall: Avoid divide-by-zero calculating flow limit

2014-01-28 Thread Joe Stringer
Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-upcall.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 24919db..ff979ba 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c

Re: [ovs-dev] [PATCH v3] util: A generic function to convert error to string for windows.

2014-01-28 Thread Ben Pfaff
On Tue, Jan 28, 2014 at 12:39:00PM -0800, Gurucharan Shetty wrote: > More users will be added in an upcoming commit. > > Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listi

[ovs-dev] [PATCH v3] util: A generic function to convert error to string for windows.

2014-01-28 Thread Gurucharan Shetty
More users will be added in an upcoming commit. Signed-off-by: Gurucharan Shetty --- lib/entropy.c | 12 +--- lib/util.c| 16 lib/util.h|5 + 3 files changed, 22 insertions(+), 11 deletions(-) diff --git a/lib/entropy.c b/lib/entropy.c index fd73566.

Re: [ovs-dev] [PATCH v2] util: A generic function to convert error to string for windows.

2014-01-28 Thread Gurucharan Shetty
On Tue, Jan 28, 2014 at 11:01 AM, Ben Pfaff wrote: > On Tue, Jan 28, 2014 at 10:35:13AM -0800, Gurucharan Shetty wrote: >> More users will be added in an upcoming commit. >> >> Signed-off-by: Gurucharan Shetty > > Looks OK to me. > > It might be even easier to use if it just returned char *. Okay

Re: [ovs-dev] [PATCH v2] util: A generic function to convert error to string for windows.

2014-01-28 Thread Ben Pfaff
On Tue, Jan 28, 2014 at 10:35:13AM -0800, Gurucharan Shetty wrote: > More users will be added in an upcoming commit. > > Signed-off-by: Gurucharan Shetty Looks OK to me. It might be even easier to use if it just returned char *. ___ dev mailing list

[ovs-dev] [PATCH v2] util: A generic function to convert error to string for windows.

2014-01-28 Thread Gurucharan Shetty
More users will be added in an upcoming commit. Signed-off-by: Gurucharan Shetty --- lib/entropy.c | 13 ++--- lib/util.c| 13 + lib/util.h|5 + 3 files changed, 20 insertions(+), 11 deletions(-) diff --git a/lib/entropy.c b/lib/entropy.c index fd73566..f

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add support Intel DPDK based ports.

2014-01-28 Thread Pravin Shelar
On Tue, Jan 28, 2014 at 7:54 AM, Thomas Graf wrote: > On 01/28/2014 03:47 PM, Vincent JARDIN wrote: >> >> Hi Pravin, >> >> Yes, it is a good integration with http://dpdk.org >> >> Few feature questions: >>- what's about the vNIC supports (toward the guests)? >>- what's about IPsec support

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add support Intel DPDK based ports.

2014-01-28 Thread Pravin Shelar
On Tue, Jan 28, 2014 at 7:48 AM, Thomas Graf wrote: > On 01/28/2014 02:48 AM, pshe...@nicira.com wrote: >> >> From: Pravin B Shelar >> >> Following patch adds DPDK netdev-class to userspace datapath. >> Approach taken in this patch differs from IntelĀ® DPDK vSwitch >> where DPDK datapath switching

Re: [ovs-dev] [PATCH 2/4] util: A generic function to convert error to string for windows.

2014-01-28 Thread Gurucharan Shetty
On Fri, Jan 17, 2014 at 1:35 PM, Ben Pfaff wrote: > On Fri, Jan 17, 2014 at 01:22:39PM -0800, Gurucharan Shetty wrote: >> On Fri, Jan 17, 2014 at 1:07 PM, Ben Pfaff wrote: >> > On Fri, Jan 17, 2014 at 12:26:21PM -0800, Gurucharan Shetty wrote: >> >> More users will be added in an upcoming commit.

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add support Intel DPDK based ports.

2014-01-28 Thread Pravin Shelar
Hi Vincent, On Tue, Jan 28, 2014 at 6:47 AM, Vincent JARDIN wrote: > Hi Pravin, > > Yes, it is a good integration with http://dpdk.org > > Few feature questions: > - what's about the vNIC supports (toward the guests)? > - what's about IPsec support (VxLAN over IPsec for instance)? > I do not

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add support Intel DPDK based ports.

2014-01-28 Thread Thomas Graf
On 01/28/2014 03:47 PM, Vincent JARDIN wrote: Hi Pravin, Yes, it is a good integration with http://dpdk.org Few feature questions: - what's about the vNIC supports (toward the guests)? - what's about IPsec support (VxLAN over IPsec for instance)? I would like to extend this question to

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add support Intel DPDK based ports.

2014-01-28 Thread Thomas Graf
On 01/28/2014 02:48 AM, pshe...@nicira.com wrote: From: Pravin B Shelar Following patch adds DPDK netdev-class to userspace datapath. Approach taken in this patch differs from IntelĀ® DPDK vSwitch where DPDK datapath switching is done in saparate process. This patch adds support for DPDK type p

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Add support Intel DPDK based ports.

2014-01-28 Thread Vincent JARDIN
Hi Pravin, Yes, it is a good integration with http://dpdk.org Few feature questions: - what's about the vNIC supports (toward the guests)? - what's about IPsec support (VxLAN over IPsec for instance)? I do not understand how your patch will solve those 2 cases. This is based a patch from G