Re: [ovs-dev] [PATCH] sFlow LAG and Tunnel export

2014-01-03 Thread Ben Pfaff
Hi Neil. I'm on vacation until next Monday, so I'll read your message in detail and get back to you sometime next week. Sorry for the delay. On Jan 3, 2014 7:39 PM, "Neil McKee" wrote: > > On Mon, Dec 30, 2013 at 4:08 PM, Ben Pfaff wrote: > >> On Fri, Dec 20, 2013 at 03:45:37PM -0800, Neil McKee

Re: [ovs-dev] [PATCH] sFlow LAG and Tunnel export

2014-01-03 Thread Neil McKee
On Mon, Dec 30, 2013 at 4:08 PM, Ben Pfaff wrote: > On Fri, Dec 20, 2013 at 03:45:37PM -0800, Neil McKee wrote: > > Sorry. Grappling with a new email client. Here it as an attachment, if > > that's OK. Let me know if I need to rebase again. > > This patch provokes one warning from GCC (and Cla

Re: [ovs-dev] [PATCH for comment only] Allow datapath to pass packets back to the kernel for non-OVS handling

2014-01-03 Thread Chris Luke
Jesse Gross wrote (on Fri 03 Jan, 2014 at 23:48 GMT): On Thu, Jan 2, 2014 at 8:33 PM, Chris Luke wrote: Jesse Gross wrote (on Fri 03 Jan, 2014 at 00:27 GMT): On Thu, Jan 2, 2014 at 6:01 PM, Chris Luke wrote: On Jan 2, 2014, at 16:51, Jesse Gross wrote: On Mon, Dec 23, 2013 at 11:46 PM,

Re: [ovs-dev] [PATCH] datapath: Check for backported sctp_compute_cksum().

2014-01-03 Thread Jesse Gross
Thanks for the review, I applied this. On Fri, Jan 3, 2014 at 7:05 PM, Joe Stringer wrote: > Looks good, thanks Jesse. > > Acked-by: Joe Stringer > > On 3 January 2014 15:44, Jesse Gross wrote: >> This is backported by RHEL7. >> >> Reported-by: Ashok Byahatti >> Signed-off-by: Jesse Gross >>

Re: [ovs-dev] [PATCH] datapath: Check for backported sctp_compute_cksum().

2014-01-03 Thread Joe Stringer
Looks good, thanks Jesse. Acked-by: Joe Stringer On 3 January 2014 15:44, Jesse Gross wrote: > This is backported by RHEL7. > > Reported-by: Ashok Byahatti > Signed-off-by: Jesse Gross > --- > acinclude.m4 | 2 ++ > datapath/linux/compat/include/net/sctp/

Re: [ovs-dev] [PATCH for comment only] Allow datapath to pass packets back to the kernel for non-OVS handling

2014-01-03 Thread Jesse Gross
On Fri, Jan 3, 2014 at 12:47 AM, Chris Luke wrote: > I just discovered a quirk worth being aware of: The two LLDP daemons > out there work in a subtly different way. > > 'lldpd' uses PF_PACKET with ETH_P_ALL as the prtotocol, meaning > it captures all layer 2 frames. Same thing with the packet > c

Re: [ovs-dev] [PATCH for comment only] Allow datapath to pass packets back to the kernel for non-OVS handling

2014-01-03 Thread Jesse Gross
On Thu, Jan 2, 2014 at 8:33 PM, Chris Luke wrote: > Jesse Gross wrote (on Fri 03 Jan, 2014 at 00:27 GMT): > >> On Thu, Jan 2, 2014 at 6:01 PM, Chris Luke wrote: On Jan 2, 2014, at 16:51, Jesse Gross wrote: > > On Mon, Dec 23, 2013 at 11:46 PM, Chris Luke > wrote: > Jes

[ovs-dev] [PATCH] datapath: Check for backported sctp_compute_cksum().

2014-01-03 Thread Jesse Gross
This is backported by RHEL7. Reported-by: Ashok Byahatti Signed-off-by: Jesse Gross --- acinclude.m4 | 2 ++ datapath/linux/compat/include/net/sctp/checksum.h | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4

Re: [ovs-dev] [PATCH] datapath: Use per-cpu allocator for sctp flow-stats.

2014-01-03 Thread Jesse Gross
On Fri, Jan 3, 2014 at 2:43 PM, Joe Stringer wrote: > This patch adds the logic used for TCP and UDP in b0f3a2feef > (datapath: Use percpu allocator for flow-stats.) to SCTP. This should > help to detect longer-lived flows that match on SCTP, for use with the > per-cpu allocator for flow-stats. >

Re: [ovs-dev] [PATCH] datapath: Use per-cpu allocator for sctp flow-stats.

2014-01-03 Thread Joe Stringer
I see. Thanks for the explanation. On 3 January 2014 12:36, Jesse Gross wrote: > On Fri, Jan 3, 2014 at 2:43 PM, Joe Stringer wrote: >> This patch adds the logic used for TCP and UDP in b0f3a2feef >> (datapath: Use percpu allocator for flow-stats.) to SCTP. This should >> help to detect longer-l

[ovs-dev] [PATCH] datapath: Use per-cpu allocator for sctp flow-stats.

2014-01-03 Thread Joe Stringer
This patch adds the logic used for TCP and UDP in b0f3a2feef (datapath: Use percpu allocator for flow-stats.) to SCTP. This should help to detect longer-lived flows that match on SCTP, for use with the per-cpu allocator for flow-stats. Signed-off-by: Joe Stringer --- Pravin, I noticed that this c

Re: [ovs-dev] [PATCH] FAQ: Add entry on GRE module conflicts.

2014-01-03 Thread Jesse Gross
On Fri, Jan 3, 2014 at 12:40 PM, Justin Pettit wrote: > On Fri, Jan 3, 2014 at 9:33 AM, Jesse Gross wrote: >> >> >> +A: On Linux kernels before 3.11, the OVS GRE module and Linux GRE module >> + cannot be loaded at the same time. It is likely that on your system >> the >> + Linux GRE module i

Re: [ovs-dev] [PATCH] FAQ: Add entry on GRE module conflicts.

2014-01-03 Thread Justin Pettit
On Fri, Jan 3, 2014 at 9:33 AM, Jesse Gross wrote: > > +A: On Linux kernels before 3.11, the OVS GRE module and Linux GRE module > + cannot be loaded at the same time. It is likely that on your system the > + Linux GRE module is already loaded and blocking OVS (to confirm, check > + dmesg f

[ovs-dev] [PATCH] FAQ: Add entry on GRE module conflicts.

2014-01-03 Thread Jesse Gross
Signed-off-by: Jesse Gross --- FAQ | 11 +++ 1 file changed, 11 insertions(+) diff --git a/FAQ b/FAQ index 1edcd94..635e548 100644 --- a/FAQ +++ b/FAQ @@ -641,6 +641,17 @@ A: In version 1.9.0, OVS switched to using a single datapath that is shared by all bridges of that type. The "