Hey guys,
I'm Looking into implementing QinQ in OVS and I read in the mailing lists
that a patch has already been created and Ravi/Jesse stopped working on it
about a year ago. I want to port it to OVS 2.x and hopefully commit it.
Can you please help me? I need:
A. The latest working patch
B. From
--
www.facebook.com
Herzlichen Glückwunsch,
Ihr Facebook-Konto wurden nach dem Zufallsprinzip als Begünstigter von
$
1.000.000,00 usd in 2013 Facebook-Konto des Jahres gewählt {}
Grand-Rewards-Gewinner.
Mailen Sie uns, die unterhalb der Details:
general_facebook_deliveryserv...@outlook.com
1
Libtool is now required as of commit 38b7a52b61 (openvswitch: Use libtool
and allow building shared libs).
It seems that a build requirement for Python slipped in a while back, for
generating ovs-vswitchd.conf.db.5, and no one complained, so we might as
well make it official. (That will let us si
Otherwise users get an error later like:
./configure: line 5093: syntax error near unexpected token
`disable-shared' ./configure: line 5093: `LT_INIT(disable-shared)'
It's probably friendlier to make configuration fail earlier.
Signed-off-by: Ben Pfaff
---
configure.ac |2 ++
1 file
Libtool is now required as of commit 38b7a52b61 (openvswitch: Use libtool
and allow building shared libs).
It seems that a build requirement for Python slipped in a while back, for
generating ovs-vswitchd.conf.db.5, and no one complained, so we might as
well make it official. (That will let us si
Acked-by: Ethan Jackson
On Fri, Dec 27, 2013 at 11:03 PM, Ben Pfaff wrote:
> Nothing ever called this function.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/dpif-linux.c|7 ---
> lib/dpif-netdev.c |7 ---
> lib/dpif-provider.h |4
> 3 files changed, 18 deletions(-)
Acked-by: Ethan Jackson
On Fri, Dec 27, 2013 at 11:03 PM, Ben Pfaff wrote:
> Until now, netdev_dummy_rx_wait() has only checked whether the receive
> queue for the dummy device is currently empty. This has worked OK because
> in practice packets were queued to dummy devices only from the same
Acked-by: Ethan Jackson
There was some reason why I thought we needed the mutex before
checking the latch, but I can't seem to figure out what it was.
Ethan
On Fri, Dec 27, 2013 at 11:03 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto-dpif-upcall.c | 10 +++---
>
Acked-by: Ethan Jackson
On Fri, Dec 27, 2013 at 11:03 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/netdev-dummy.c |1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
> index 9515021..8ad9af6 100644
> --- a/lib/netdev-dummy.c
> +++
Thanks, I'll apply this in a moment.
On Tue, Dec 31, 2013 at 11:41:52AM -0800, Andy Zhou wrote:
> LGTM.
>
>
> On Tue, Dec 31, 2013 at 10:45 AM, Ben Pfaff wrote:
>
> > Simplify (a && b) || (!a && c) to just a ? b : c.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/odp-util.c |5 +++--
>
LGTM.
On Tue, Dec 31, 2013 at 10:45 AM, Ben Pfaff wrote:
> Simplify (a && b) || (!a && c) to just a ? b : c.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/odp-util.c |5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index 3227e69..af
Simplify (a && b) || (!a && c) to just a ? b : c.
Signed-off-by: Ben Pfaff
---
lib/odp-util.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index 515b531..cb27980 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -3213,8 +3213,9 @@
Anytime there is a VLAN the flow needs to properly reflect that. Keeping
the TPID in dl_type never makes sense and will probably cause problems.
The existing code did the right thing in the common case but not in corner
cases where it returned ODP_FIT_TOO_MUCH or ODP_FIT_TOO_LITTLE (the cases
wher
v1->v2: The first patch was applied; the rest have been rebased.
Ben Pfaff (2):
odp-util: Fix VLAN parsing behavior in parse_8021q_onward().
odp-util: Simplify logic in odp_flow_key_to_flow__().
lib/odp-util.c | 53 +
1 file changed, 25 i
Fair enough. I made that change and I'll push this soon.
On Tue, Dec 31, 2013 at 11:29:15AM -0800, Justin Pettit wrote:
> This is clearly correct, but the code a little below wraps "0" in an
> htons(), so if you wanted to be consistent style-wise, you could similarly
> wrap the new "0" in a ntohs
Anytime there is a VLAN the flow needs to properly reflect that. Keeping
the TPID in dl_type never makes sense and will probably cause problems.
The existing code did the right thing in the common case but not in corner
cases where it returned ODP_FIT_TOO_MUCH or ODP_FIT_TOO_LITTLE (the cases
wher
Simplify (a && b) || (!a && c) to just a ? b : c.
Signed-off-by: Ben Pfaff
---
lib/odp-util.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index 3227e69..aff6c95 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -3144,8 +3144,9 @@
For parsing a mask, this code in parse_8021q_onward() always read out
the OVS_KEY_ATTR_VLAN attribute without first checking whether it existed.
The correct behavior, implemented by this commit, appears to be treating
the VLAN as wildcarded and to continue parsing the flow.
Bug #22312.
Reported-by
--
Investitions Privilege / Vorschlag
Ich bin ein ehemaliger Wirtschaftsprüfer und Makler, Investoren
Partner, die bereit sind in Projekten, Unternehmen und geben Kredite an
Interessenten
Unternehmen.
Ich und mein Partner sind Finanzinvestoren haben wir über
375,000,000.00
(Three Hundred Seve
凸/△ふゃ∴Ⅻ`。Ⅶぢゃ—
各 行 业 都 有 开 .
验后结款
王 生:電 183--20--79---31--65
业 务
Q:1211--60--1651
≡┻┳з¥ぞ╅↓︺┛Ⅷ·ち___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Rebased and reposted v3.2.
Thanks for the fix on ovsdb-server tests.
On 31/12/13 2:06 AM, "Ben Pfaff" wrote:
>On Mon, Dec 30, 2013 at 11:40:23AM -0800, Ben Pfaff wrote:
>> On Mon, Dec 30, 2013 at 06:09:51PM +0530, Arun Sharma wrote:
>> > As per MASTER, tests/ovsdb-server.at (line 486), there is
21 matches
Mail list logo