LGTM
Acked-by: Jarno Rajahalme
> On Dec 19, 2013, at 1:50 PM, Alex Wang wrote:
>
> This commit fixes a command matching error introduced by commit
> 7155fa52f (ofproto-dpif: Add 'force-miss-model' configuration).
>
> Signed-off-by: Alex Wang
> ---
> vswitchd/bridge.c |4 ++--
> 1 file cha
>
> Thanks for looking into this. Does that also work on x86_64?
Yes. The errors were seen in x86_64 machines.
> The libraries would be installed to lib64 instead, thus not getting
> deleted and thus maybe triggering "unpackaged files found"?
Looking at "./configure --help", I see:
--libdir=DIR
On Thu, Dec 19, 2013 at 10:11 AM, Ben Pfaff wrote:
> Occasionally I run a command like this:
> watch -n.1 ovs-ofctl dump-flows br0
> to see how flows change over time. Until now, it has been more difficult
> than necessary to spot real changes, because flows "jump around" as the
> number of
The netdev-dummy thus far only support passive connection. It will
listen for incoming connections requests. This patch allows
active stream to be configured as well.
This patch effectively allows a netdev-dummy port make point-to-point
connection to another, without being a patch port. This featu
On Thu, Dec 19, 2013 at 03:02:55PM -0800, Saurabh Shah wrote:
>
> On Thu, Dec 19, 2013 at 11:44:54AM -0800, Saurabh Shah wrote:
> So that vsnprintf on windows has C99 like semantics.
> Signed-off-by: Saurabh Shah mailto:ssaur...@nicira.com>>
>
> Doesn't snprintf() need the same treatment? Is the
On Thu, Dec 19, 2013 at 11:44:54AM -0800, Saurabh Shah wrote:
So that vsnprintf on windows has C99 like semantics.
Signed-off-by: Saurabh Shah mailto:ssaur...@nicira.com>>
Doesn't snprintf() need the same treatment? Is there a reason not to
handle it in the same patch?
Ah, thanks, I missed this
On Thu, Dec 19, 2013 at 11:44:54AM -0800, Saurabh Shah wrote:
> So that vsnprintf on windows has C99 like semantics.
>
> Signed-off-by: Saurabh Shah
Doesn't snprintf() need the same treatment? Is there a reason not to
handle it in the same patch?
With this patch applied, if I add a file lib/st
This commit fixes a command matching error introduced by commit
7155fa52f (ofproto-dpif: Add 'force-miss-model' configuration).
Signed-off-by: Alex Wang
---
vswitchd/bridge.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 92
On Thu, Dec 19, 2013 at 01:02:42PM -0800, Jarno Rajahalme wrote:
> We allow zero 'values' in a miniflow for it to have the same map
> as the corresponding minimask. Minimasks themselves never have
> zero data values, though. Document this and optimize the code
> accordingly.
>
> v2:
> - Made min
Thanks I'll merge in a second.
Ethan
On Thu, Dec 19, 2013 at 3:17 PM, Ben Pfaff wrote:
> On Thu, Dec 19, 2013 at 12:51:04PM -0800, Ethan Jackson wrote:
>> This patch moves flow installation and eviction from ofproto-dpif and
>> the main thread, into ofproto-dpif-upcall. This performs
>> signifi
On Thu, Dec 19, 2013 at 12:51:04PM -0800, Ethan Jackson wrote:
> This patch moves flow installation and eviction from ofproto-dpif and
> the main thread, into ofproto-dpif-upcall. This performs
> significantly better (approximately 2x TCP_CRR improvement), and
> allows ovs-vswitchd to maintain sig
We allow zero 'values' in a miniflow for it to have the same map
as the corresponding minimask. Minimasks themselves never have
zero data values, though. Document this and optimize the code
accordingly.
v2:
- Made miniflow_get_map_in_range() to return data offset instead of
a pointer via the l
On Thu, Dec 19, 2013 at 01:01:39PM -0800, Jarno Rajahalme wrote:
>
> On Dec 18, 2013, at 9:42 AM, Ben Pfaff wrote:
>
> > On Fri, Dec 13, 2013 at 02:37:56PM -0800, Jarno Rajahalme wrote:
> >> We allow zero 'values' in a miniflow for it to have the same map
> >> as the corresponding minimask. Min
On Dec 18, 2013, at 9:42 AM, Ben Pfaff wrote:
> On Fri, Dec 13, 2013 at 02:37:56PM -0800, Jarno Rajahalme wrote:
>> We allow zero 'values' in a miniflow for it to have the same map
>> as the corresponding minimask. Minimasks themselves never have
>> zero data values, though. Document this and
> Why does udpif_set_threads() destroy each revalidator thread's ukeys?
> Can't the thread itself do that before it exits?
I actually like that udpif_set_threads() handles the teardown because we can be
absolutely sure that there aren't any threads running when it happens. This
means we dont' hav
So that vsnprintf on windows has C99 like semantics.
Signed-off-by: Saurabh Shah
---
lib/command-line.c |2 +-
lib/dynamic-string.c |4 ++--
lib/util.c | 18 --
lib/util.h |1 +
4 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/li
So that vsnprintf on windows has C99 like semantics.
Signed-off-by: Saurabh Shah
---
lib/command-line.c |2 +-
lib/dynamic-string.c |4 ++--
lib/util.c | 18 --
lib/util.h |1 +
4 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/li
On Thu, Dec 19, 2013 at 10:03:16AM +0900, Simon Horman wrote:
> thanks for applying this patch.
>
> Although it doesn't really do much without
> "[PATCH v3 3/3] ofproto: Honour Table Mod settings for table-miss handling"
> does depend on "[PATCH v3 1/3] ofproto: Make check_table_id() generic".
I
> That was my understanding the first time around too. All I see you trying to
> do is
> creating a bridge with a single port and assigning IP address to it. So I am
> not
> sure why it matters if ovs-vswitchd starts late.
because we want to have working network devices early in the boot proces
I made the modifications and sent in a new patch:
http://openvswitch.org/pipermail/dev/2013-December/035377.html
I dropped WCOREDUMP* and __u* for the moment until(and if) we need them.
Kind Regards,
Alin.
From: Ben Pfaff [b...@nicira.com]
Sent: Wednesday
Signed-off-by: Alin Serdean
---
diff --git a/Makefile.am b/Makefile.am
index 0faed67..558bf63 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -10,6 +10,11 @@ ACLOCAL_AMFLAGS = -I m4
SUBDIRS = datapath
AM_CPPFLAGS = $(SSL_CFLAGS)
+
+if WIN32
+AM_CPPFLAGS += -I $(top_srcdir)/include/windows
+endif
On Thu, Dec 19, 2013 at 04:20:42PM +0100, Thomas Graf wrote:
> Following commit (''netlink: Do not enforce alignment of last Netlink
> attribute''), signal the ability to receive unaligned Netlink messages
> to the datapath to enable utilization of zerocopy optimizations.
>
> Opening a datapath is
Occasionally I run a command like this:
watch -n.1 ovs-ofctl dump-flows br0
to see how flows change over time. Until now, it has been more difficult
than necessary to spot real changes, because flows "jump around" as the
number of decimals printed for duration changes from moment to moment.
Th
On Thu, Nov 28, 2013 at 06:20:26AM -0700, Neil McKee wrote:
> I rebased and cleaned up this patch, and included a longer description
> to capture the reasons why it's OK to leave some fields unpopulated.
This got posted word-wrapped, can you try it again?
__
Hi Francesco. Thanks for the patch.
The sFlow code comes almost unmodified from InMon. I'm adding Neil
McKee from InMon to the thread to review this change. Neil, can you
take a look? (And that reminds me, I need to review your patch too.
I'll do that now.)
Thanks,
Ben.
On Thu, Dec 19, 2013
> You totally missed the problem, so I try to explain again.
>
> The problem is that the ovs-vswitchd is started much too late in the boot
> process (in runlevel 2),
> so it is not available when debian starts the networking setup at boot time
> (started early in rulevel S).
>
> is that more clea
On Thu, Dec 19, 2013 at 01:05:02AM +, Alin Serdean wrote:
> Signed-off-by: Alin Serdean
Applied as follows.
I adjusted indentation, which looked odd.
Thanks,
Ben.
--8<--cut here-->8--
From: Alin Serdean
Date: Thu, 19 Dec 2013 09:20:17 -080
putString pads the string to the 4-byte boundary without
clearing the "padded" memory. This patch simply set the
padding to zero.
Signed-off-by: Francesco Fusco
---
lib/sflow_receiver.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/sflow_receiver.c b/lib/sflow_receiver.c
index 3e5a
> Can you tell the version with:
> ovs-vsctl --version
# ovs-vsctl --version
ovs-vsctl (Open vSwitch) 2.0.90
Compiled Dec 19 2013 10:25:22
> > auto vmbr0
> I don't think the above line will help you.
>
>
> > That works, but it does not work when I boot the host. Simply because
> > ovs-vswitchd
FYI: The status of the openvswitch source package
in Debian's testing distribution has changed.
Previous version: 1.9.3+git20131029-1
Current version: 1.9.3+git20131029-1.1
--
This email is automatically generated once a day. As the installation of
new packages into testing happens multipl
On Wed, Dec 18, 2013 at 10:49 PM, Dietmar Maurer wrote:
> I am testing latest ovs code on debian, using the following
> /etc/network/interfaces
Can you tell the version with:
ovs-vsctl --version
> auto vmbr0
I don't think the above line will help you.
> That works, but it does not work when
Following commit (''netlink: Do not enforce alignment of last Netlink
attribute''), signal the ability to receive unaligned Netlink messages
to the datapath to enable utilization of zerocopy optimizations.
Opening a datapath is now done by issueing a OVS_DP_CMD_SET in order
to overwrite previously
On Wed, Dec 18, 2013 at 10:25 PM, Gurucharan Shetty wrote:
> Reported-by: Igor Sever
> Signed-off-by: Gurucharan Shetty
> ---
> AUTHORS |1 +
> rhel/openvswitch-fedora.spec.in |2 +-
> rhel/openvswitch.spec.in|2 +-
> 3 files changed, 3 insertions(+),
33 matches
Mail list logo
