Until now, the code in dpif_linux_recv_set() has assumed it is starting
from a clean slate with no channels at all. This commit generalizes it to
compare the existing set of channels against the ones that should exist
given the vports that the kernel has, adding any new ones that are missing
and r
These helpers simplify new code to be added in an upcoming commit.
Signed-off-by: Ben Pfaff
---
lib/dpif-linux.c | 46 +-
1 file changed, 33 insertions(+), 13 deletions(-)
diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
index 42958d3..783ef31 10064
When ovs-vswitchd deletes a port with dpif_linux_port_del(), that function
uses del_channel() to delete the corresponding channel, including closing
its Netlink socket fd. However, if the vport gets removed by some other
process (e.g. "ip link delete" for veths) then this function never gets
calle
The first version of this patch series was posted on May 1.
This version is a rebase. Some patches have been dropped
because they are already applied.
Ben Pfaff (3):
dpif-linux: Factor out port dumping helper functions.
dpif-linux: Generalize dpif_linux_recv_set() to synchronize channels.
d
Otherwise, if the port add succeeds but the query that looks up the port
number fails, then ofproto_port_add() would return zero as the OpenFlow
port number and ignore the error.
Reported-by: Guolin Yang
Signed-off-by: Ben Pfaff
---
v1 was posted on March 19. This version is merely a rebase of
The first version of this series was posted on March 27. This
version drops the first three patches because they were already
applied.
Ben Pfaff (2):
ovsdb-client: Make "monitor" command able to monitor all tables.
jsonrpc-server: Add test for disconnecting connections with too long
queue
Users may find this feature useful, but the reason to add this feature is
to allow a test to use it in an upcoming commit.
Signed-off-by: Ben Pfaff
---
NEWS|3 +
ovsdb/ovsdb-client.1.in | 10 ++
ovsdb/ovsdb-client.c| 277
Signed-off-by: Ben Pfaff
---
tests/ovsdb-server.at | 85 +
1 file changed, 85 insertions(+)
diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at
index 444ab96..b05401f 100644
--- a/tests/ovsdb-server.at
+++ b/tests/ovsdb-server.at
@@ -38,6
The previous version of this patch series was posted on May 6.
Version 2 is a rebase. It drops the second patch from the
original series because it is no longer necessary.
Ben Pfaff (2):
ofp-actions: Switch away from odd use of "q" in "enqueue" action
format.
ovs-ofctl: Improve manpage.
Fixes misspelling of "OpenFlow".
Fixes the indentation of the paragraph beginning "Any \fIreason\fR...".
Changes "target" to "action" in the introduction of actions, which seems
like a better name.
Reorders action descriptions to group all the simple forms of output
together.
Consistently menti
The formatting of the "enqueue" action uses a "q" to separate the port
number from the queue number, as in "enqueue:123q456". This is different
from every other action. This commit improves the situation by:
* Switching the formatting to use a colon (e.g. "enqueue:123:456"),
which is a
On Sat, Sep 14, 2013 at 01:46:32PM -0700, Ben Pfaff wrote:
> The update is incomplete, so document that also.
>
> Reported-by: Stephen Finucane
> Signed-off-by: Ben Pfaff
This could use a review.
___
dev mailing list
dev@openvswitch.org
http://openvsw
Thanks! Applied to master.
On Sun, Oct 27, 2013 at 07:49:32PM -0700, Alex Wang wrote:
> LGTM
>
>
> On Wed, Sep 25, 2013 at 3:38 PM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/classifier.h |6 ++
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --
Thanks, applied to master.
On Fri, Nov 01, 2013 at 02:47:02PM -0700, Joe Stringer wrote:
> Acked-by: Joe Stringer
>
> On Fri, Oct 11, 2013 at 4:53 PM, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/daemon.c |2 ++
> > lib/daemon.man |7 ---
> > 2 files changed, 6
On Fri, Nov 01, 2013 at 03:58:02PM -0700, Joe Stringer wrote:
> This needs a rebase.
Done.
> The deletion of the content in 'manpages.mk' is surprising; the file
> states that it is automatically generated, the commit message doesn't
> mention it, and the file isn't actually deleted, only emptied
On Sat, Nov 02, 2013 at 09:01:06PM -0700, Ben Pfaff wrote:
> On Wed, Oct 30, 2013 at 06:06:44AM -0700, Gurucharan Shetty wrote:
> > 'struct dp_netdev_flow' is currently being instantiated as 'flow'.
> > An upcoming commit introduces a classifier to dpif-netdev
> > which uses 'struct flow' at a few
On Wed, Oct 30, 2013 at 06:06:44AM -0700, Gurucharan Shetty wrote:
> 'struct dp_netdev_flow' is currently being instantiated as 'flow'.
> An upcoming commit introduces a classifier to dpif-netdev
> which uses 'struct flow' at a few places and that can cause
> confusion while reading code.
>
> Sign
On Fri, Nov 01, 2013 at 04:34:29PM -0700, Joe Stringer wrote:
> When dealing with a large number of ports, one of the performance
> bottlenecks is that we loop through all netdevs in the main loop. Miimon
> is a contributor to this, checking all devices even if it has never been
> enabled.
>
> Thi
CC: Simon Horman
Signed-off-by: Ben Pfaff
---
OPENFLOW-1.1+ | 17 -
1 file changed, 17 deletions(-)
diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+
index f419803..f978cb5 100644
--- a/OPENFLOW-1.1+
+++ b/OPENFLOW-1.1+
@@ -78,23 +78,6 @@ probably incomplete.
reasonable perfor
On Wed, Oct 30, 2013 at 06:17:20PM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
I adjusted this for highest-random weight, which just meant that I
changed the scoring function to:
uint32_t score = (hash_int(i, basis) & 0x) * bucket->weight;
and then I adjusted the test
On Wed, Oct 30, 2013 at 06:17:19PM +0900, Simon Horman wrote:
> Select bucket from those that are alive based on a hash of the destination
> ethernet address of the packet.
>
> Support for weights is proposed by a subsequent patch.
>
> The selection is based on a hash of the destination ethernet
On Sat, Nov 02, 2013 at 06:14:51PM -0700, Ben Pfaff wrote:
> On Wed, Oct 30, 2013 at 06:17:19PM +0900, Simon Horman wrote:
> > Select bucket from those that are alive based on a hash of the destination
> > ethernet address of the packet.
> >
> > Support for weights is proposed by a subsequent patc
On Wed, Oct 30, 2013 at 06:17:18PM +0900, Simon Horman wrote:
> Fast failover groups use the actions in
> the first bucket that is alive.
>
> Signed-off-by: Simon Horman
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/m
On Wed, Oct 30, 2013 at 06:17:19PM +0900, Simon Horman wrote:
> Select bucket from those that are alive based on a hash of the destination
> ethernet address of the packet.
>
> Support for weights is proposed by a subsequent patch.
>
> The selection is based on a hash of the destination ethernet
On Wed, Oct 30, 2013 at 06:17:17PM +0900, Simon Horman wrote:
> Test that flow mod with groups succeeds only if the group exists.
>
> Signed-off-by: Simon Horman
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/l
On Wed, Oct 30, 2013 at 06:17:16PM +0900, Simon Horman wrote:
> Lightly exercise del-groups
>
> Signed-off-by: Simon Horman
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Oct 30, 2013 at 06:17:15PM +0900, Simon Horman wrote:
> Lightly exercise group desc and stats
>
> Signed-off-by: Simon Horman
I was just thinking that we needed some tests here.
These tests revealed an actual bug, by segfaulting. Running under
valgrind, I found the problem and folded i
On Wed, Oct 30, 2013 at 06:17:14PM +0900, Simon Horman wrote:
> Allow translation of indirect and all groups. Also allow insertion of
> indirect and all groups by changing the maximum permitted number in the
> groups table from 0 to OFPG_MAX.
>
> Implementation note:
>
> After translating the ac
From: Jarno Rajahalme
tcp_flags=flags/mask
Bitwise match on TCP flags. The flags and mask are 16-bit num‐
bers written in decimal or in hexadecimal prefixed by 0x. Each
1-bit in mask requires that the corresponding bit in port must
match. Each 0-bit in m
From: Jarno Rajahalme
Widen TCP flags handling from 7 bits (uint8_t) to 12 bits (uint16_t).
The kernel interface remains at 8 bits, which makes no functional
difference now, as none of the higher bits is currently of interest
to the userspace.
Signed-off-by: Jarno Rajahalme
Signed-off-by: Jesse
From: Pravin B Shelar
Flow->hash can be used to detect hash collisions and avoid flow key
compare in flow lookup.
Signed-off-by: Pravin B Shelar
Signed-off-by: Jesse Gross
---
net/openvswitch/flow_table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/openvswitch/flow
From: Pravin B Shelar
OVS already can handle all types of segmentation offloads that
are supported by the kernel.
Following patch specifically enables UDP and IPV6 segmentation
offloads.
Signed-off-by: Pravin B Shelar
Signed-off-by: Jesse Gross
---
net/openvswitch/vport-internal_dev.c | 2 +-
From: Andy Zhou
Collect mega flow mask stats. ovs-dpctl show command can be used to
display them for debugging and performance tuning.
Signed-off-by: Andy Zhou
Signed-off-by: Jesse Gross
---
include/uapi/linux/openvswitch.h | 17 ++---
net/openvswitch/datapath.c | 38 +++
From: Pravin B Shelar
Hides mega-flow implementation in flow_table.c rather than
datapath.c.
Signed-off-by: Pravin B Shelar
Signed-off-by: Jesse Gross
---
net/openvswitch/datapath.c | 27 +++--
net/openvswitch/flow_table.c | 138 +--
net/openvswi
From: Wei Yongjun
Remove duplicated include.
Signed-off-by: Wei Yongjun
Signed-off-by: Jesse Gross
---
net/openvswitch/vport-gre.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/openvswitch/vport-gre.c b/net/openvswitch/vport-gre.c
index c99dea5..a3d6951 100644
--- a/net/openvswitch
From: Wei Yongjun
Remove duplicated include.
Signed-off-by: Wei Yongjun
Signed-off-by: Jesse Gross
---
net/openvswitch/vport-vxlan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/openvswitch/vport-vxlan.c b/net/openvswitch/vport-vxlan.c
index a481c03..b0da394 100644
--- a/net/openvsw
From: Pravin B Shelar
Rehashing in ovs-workqueue can cause ovs-mutex lock contentions
in case of heavy flow setups where both needs ovs-mutex. So by
moving rehashing to flow-setup we can eliminate contention.
This also simplify ovs locking and reduces dependence on
workqueue.
Signed-off-by: Pra
A set of updates for net-next/3.13. Major changes are:
* Restructure flow handling code to be more logically organized and
easier to read.
* Rehashing of the flow table is moved from a workqueue to flow
installation time. Before, heavy load could block the workqueue for
excessive periods
From: Pravin B Shelar
ovs-flow rehash does not touch mega flow list. Following patch
moves it dp struct datapath. Avoid one extra indirection for
accessing mega-flow list head on every packet receive.
Signed-off-by: Pravin B Shelar
Signed-off-by: Jesse Gross
---
net/openvswitch/datapath.c
On Tue, Oct 29, 2013 at 7:11 PM, David Miller wrote:
> From: Jesse Gross
> Date: Tue, 29 Oct 2013 17:22:21 -0700
>
>> From: Pravin B Shelar
>>
>> With mega flow implementation ovs flow can be shared between
>> multiple CPUs which makes stats updates highly contended
>> operation. Following patch
On Wed, Oct 30, 2013 at 06:17:13PM +0900, Simon Horman wrote:
> Break out resubmit resource checking into a helper function
> xlate_resubmit_resource_check() and use this new function.
> This is to allow the check to be re-used by a subsequent patch.
>
> As suggested by Ben Pfaff
>
> Signed-off-b
On Wed, Oct 30, 2013 at 06:17:12PM +0900, Simon Horman wrote:
> These values will be used by subsequent patches
>
> Signed-off-by: Simon Horman
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Oct 30, 2013 at 06:17:11PM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
The enums are consecutive integers, not bitwise masks, so I changed ENUM
to (1 << ENUM) here:
> +#define OFPAT11_ACTION(ENUM, STRUCT, EXTENSIBLE, NAME) ENUM |
> +#include "ofp-util.def"
> +0;
and I'll
On Fri, Oct 25, 2013 at 05:18:02PM -0700, Alex Wang wrote:
> Commit 348f01e3e3 (cfm: Eight byte MPIDs in extended mode.) allows
> eight byte MPIDs when running in extended mode. This commit explains
> this change in the vswitch.conf.db.
>
> Signed-off-by: Alex Wang
Ethan, are you planning to re
Thanks, applied to master.
On Fri, Nov 01, 2013 at 04:35:48PM -0700, Joe Stringer wrote:
> Acked-by: Joe Stringer
>
> On Thu, Oct 17, 2013 at 3:29 PM, Ben Pfaff wrote:
> > The ARP headers have been acceptable as NXAST_REG_MOVE destinations since
> > commit f6c8a6b163 (Add software switch suppor
On Fri, Nov 01, 2013 at 04:23:12PM -0700, Joe Stringer wrote:
> This looks good in principle.
>
> Test 706 (ofproto-dpif - too many output actions) fails on this, as it
> expects the old VLOG_ERR in the logs.
Oops. Thanks for pointing that out. I fixed it.
> There is also an error from ofproto
Thanks, applied to master.
On Fri, Nov 01, 2013 at 02:21:01PM -0700, Joe Stringer wrote:
> Hopefully I got the right thread here ("FAQ: Elaborate further on how
> one drops packets with OpenFlow.").
>
> Acked-by: Joe Stringer
>
> On Wed, Oct 9, 2013 at 3:22 PM, Ben Pfaff wrote:
> >
> > Signed-
Thanks for the reviews. I applied these to master.
On Wed, Oct 16, 2013 at 02:20:51PM -0700, Alex Wang wrote:
> Looks good to me,
>
>
> On Mon, Sep 30, 2013 at 2:47 PM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/bfd.c |6 --
> > 1 file changed, 4 insertions(+),
On Sun, Oct 27, 2013 at 08:17:33PM -0700, Alex Wang wrote:
> Just reminder, I think this series is ready to be applied,
> LGTM as well,
Thanks for reminding me. I applied these to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/m
49 matches
Mail list logo
