Re: [ovs-dev] [PATCH] OPENFLOW-1.1+: note on table-miss

2013-10-31 Thread YAMAMOTO Takashi
> On Tue, Oct 15, 2013 at 05:12:22PM +0900, YAMAMOTO Takashi wrote: >> Signed-off-by: YAMAMOTO Takashi >> --- >> OPENFLOW-1.1+ | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+ >> index 07b2660..4f30520 100644 >> --- a/OPENFLOW-1.1+ >> +++ b/OPENFLO

Re: [ovs-dev] [PATCH] OPENFLOW-1.1+: note on table-miss

2013-10-31 Thread Simon Horman
On Tue, Oct 15, 2013 at 05:12:22PM +0900, YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi > --- > OPENFLOW-1.1+ | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/OPENFLOW-1.1+ b/OPENFLOW-1.1+ > index 07b2660..4f30520 100644 > --- a/OPENFLOW-1.1+ > +++ b/OPENFLOW-1.1+ > @@

Re: [ovs-dev] [PATCH] meta-flow: Make mf_parse() report bad masks as errors.

2013-10-31 Thread Simon Horman
On Thu, Oct 31, 2013 at 08:56:49PM -0700, Ben Pfaff wrote: > Thanks! I applied this to master. > > I apologize that I failed to add your Reviewed-by: tag. Too quick on > the "push". No problem, thanks for the code. ___ dev mailing list dev@openvswitch

Re: [ovs-dev] [PATCH 1/4] Add/Modify headers for Multipart - Table Features.

2013-10-31 Thread Simon Horman
On Sat, Oct 26, 2013 at 06:12:27PM +0800, Alexander Wu wrote: > Add headers and function prototype for table features. > And modify the limits of mp-table-features msg > > Signed-off-by: Alexander Wu > --- > lib/ofp-msgs.h |4 +- > lib/ofp-util.h | 159 > +++

Re: [ovs-dev] [PATCH 3/4] Add init/destroy funcs and handle Table Features msgs.

2013-10-31 Thread Simon Horman
On Sat, Oct 26, 2013 at 06:15:30PM +0800, Alexander Wu wrote: > Add some functions to init table features(use ofp13_* struct > currently, change it to ofputil later). > Use the encode/decode functions to handle table features request. > > Currently we just implement GET table feature. > SET table

Re: [ovs-dev] [PATCH 2/4] Implement the encode/decode Table Features functions

2013-10-31 Thread Simon Horman
On Sat, Oct 26, 2013 at 06:14:28PM +0800, Alexander Wu wrote: > Implement the encode/decode table features msgs function, and > NOTE that we implement the decode functions *_raw, maybe we > should change it the ofpbuf_pull? > > Signed-off-by: Alexander Wu > --- > lib/ofp-print.c | 128 +

Re: [ovs-dev] [PATCH] meta-flow: Make mf_parse() report bad masks as errors.

2013-10-31 Thread Ben Pfaff
Thanks! I applied this to master. I apologize that I failed to add your Reviewed-by: tag. Too quick on the "push". On Fri, Nov 01, 2013 at 10:05:53AM +0900, Simon Horman wrote: > Thanks Ben, I like this a lot. > > Reviewed-by: Simon Horman > > On Thu, Oct 31, 2013 at 05:22:11PM -0700, Ben Pf

Re: [ovs-dev] [PATCH] meta-flow: Make mf_parse() report bad masks as errors.

2013-10-31 Thread Simon Horman
Thanks Ben, I like this a lot. Reviewed-by: Simon Horman On Thu, Oct 31, 2013 at 05:22:11PM -0700, Ben Pfaff wrote: > Reported-by: Simon Horman > Signed-off-by: Ben Pfaff > --- > lib/meta-flow.c| 37 ++ > tests/ovs-ofctl.at | 65 > +

Re: [ovs-dev] [PATCH 0/2] Return no protocols if mask is supplied for unmaskable match

2013-10-31 Thread Simon Horman
On Thu, Oct 31, 2013 at 05:22:33PM -0700, Ben Pfaff wrote: > On Thu, Oct 31, 2013 at 01:00:00PM +0900, Simon Horman wrote: > > the primary purpose of this series is to return an error message rather > > than segfaulting if ovs-ofctl add-flow is called with a mask for a match > > that does not accep

[ovs-dev] [PATCH] meta-flow: Make mf_parse() report bad masks as errors.

2013-10-31 Thread Ben Pfaff
Reported-by: Simon Horman Signed-off-by: Ben Pfaff --- lib/meta-flow.c| 37 ++ tests/ovs-ofctl.at | 65 2 files changed, 67 insertions(+), 35 deletions(-) diff --git a/lib/meta-flow.c b/lib/meta-flow.c inde

Re: [ovs-dev] [PATCH 0/2] Return no protocols if mask is supplied for unmaskable match

2013-10-31 Thread Ben Pfaff
On Thu, Oct 31, 2013 at 01:00:00PM +0900, Simon Horman wrote: > the primary purpose of this series is to return an error message rather > than segfaulting if ovs-ofctl add-flow is called with a mask for a match > that does not accept a mask. The second patch in the series does that > and updates th

Re: [ovs-dev] [PATCH] debian: Option to create tunnel through 'interfaces'.

2013-10-31 Thread Gurucharan Shetty
On Thu, Oct 31, 2013 at 10:24 AM, Ben Pfaff wrote: > On Thu, Oct 31, 2013 at 09:24:08AM -0700, Gurucharan Shetty wrote: >> This is a port of commit 7b75828bf5654c (rhel: Option to create tunnel >> through ifcfg scripts.) from rhel to debian's ifupdown script. >> >> Signed-off-by: Gurucharan Shetty

Re: [ovs-dev] [PATCH] debian: Option to create tunnel through 'interfaces'.

2013-10-31 Thread Ben Pfaff
On Thu, Oct 31, 2013 at 09:24:08AM -0700, Gurucharan Shetty wrote: > This is a port of commit 7b75828bf5654c (rhel: Option to create tunnel > through ifcfg scripts.) from rhel to debian's ifupdown script. > > Signed-off-by: Gurucharan Shetty It looks like the first and later lines of this comman

[ovs-dev] [PATCH] debian: Option to create tunnel through 'interfaces'.

2013-10-31 Thread Gurucharan Shetty
This is a port of commit 7b75828bf5654c (rhel: Option to create tunnel through ifcfg scripts.) from rhel to debian's ifupdown script. Signed-off-by: Gurucharan Shetty --- debian/ifupdown.sh |8 +++- debian/openvswitch-switch.README.Debian | 30 +

[ovs-dev] [PATCH v2.47 1/4] odp: Allow VLAN actions after MPLS actions

2013-10-31 Thread Simon Horman
From: Joe Stringer OpenFlow 1.1 and 1.2, and 1.3 differ in their handling of MPLS actions in the presence of VLAN tags. To allow correct behaviour to be committed in each situation, this patch adds a second round of VLAN tag action handling to commit_odp_actions(), which occurs after MPLS actions

[ovs-dev] [PATCH v2.47 4/4] datapath: Add basic MPLS support to kernel

2013-10-31 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer. Cc: Ravi K Cc: Leo Alterman Cc: Isaku Yamahata Cc: Joe Stringer Signed-off-by: Sim

[ovs-dev] [PATCH v2.47 2/4] lib: Support pushing of MPLS LSE before or after VLAN tag

2013-10-31 Thread Simon Horman
From: Joe Stringer This patch modifies the push_mpls behaviour to allow pushing of an MPLS LSE either before any VLAN tag that may be present. Pushing the MPLS LSE before any VLAN tag that is present is the behaviour specified in OpenFlow 1.3. Pushing the MPLS LSE after the any VLAN tag that is

[ovs-dev] [PATCH v2.47 0/4] MPLS actions and matches

2013-10-31 Thread Simon Horman
Hi, This series implements MPLS actions and matches based on work by Ravi K, Leo Alterman, Yamahata-san and Joe Stringer. This series provides two changes * Patches 1 - 2 Provide user-space support for the VLAN/MPLS tag insertion order up to and including OpenFlow 1.2, and the different ord

[ovs-dev] [PATCH v2.47 3/4] datapath: Break out deacceleration portion of vlan_push

2013-10-31 Thread Simon Horman
Break out deacceleration portion of vlan_push into vlan_put so that it may be re-used by mpls_push. For both vlan_push and mpls_push if there is an accelerated VLAN tag present then it should be deaccelerated, adding it to the data of the skb, before the new tag is added. Signed-off-by: Simon Hor