Re: [ovs-dev] [PATCH v2 2/2] Implement OFPT_QUEUE_GET_CONFIG_REQUEST and OFPT_QUEUE_GET_CONFIG_REPLY.

2013-10-25 Thread Ben Pfaff
On Fri, Oct 25, 2013 at 03:02:00PM -0700, Joe Stringer wrote: > On Fri, Oct 25, 2013 at 1:12 PM, Ben Pfaff wrote: > > > From: Venkitachalam Gopalakrishnan > > > > Open vSwitch has never implemented this request and reply, even though they > > have been in OpenFlow since version 1.0. This commit

[ovs-dev] Tooling & Molding Supplier

2013-10-25 Thread Alex Wu
Dear Sir/Madam, Glad to learn that you may purchase injection tools, molded plastic products or mould core part. We are a medium-sized manufacturer of plastic injection tools, molded plastic products and mould core parts in China. By writing this email we are in view of establishing a good bus

[ovs-dev] [PATCH] cfm: Refine the cfm_extended manual.

2013-10-25 Thread Alex Wang
Commit 348f01e3e3 (cfm: Eight byte MPIDs in extended mode.) allows eight byte MPIDs when running in extended mode. This commit explains this change in the vswitch.conf.db. Signed-off-by: Alex Wang --- vswitchd/vswitch.xml | 21 ++--- 1 file changed, 14 insertions(+), 7 deletio

[ovs-dev] [RFC PATCH] classifier: Segmented sub-table matching.

2013-10-25 Thread Jarno Rajahalme
Adds additional indices to classifier tables to be able to stop matching as soon as it is evident that a match will not be found or if a single matching rule is found. Especaially avoids folding in the transport port masks, if they need not be examined. The struct flow is re-organized to allow has

[ovs-dev] [PATCH] ovs-dpctl-top: Flow fields display content with mask applied.

2013-10-25 Thread Mark Hamilton
From: Mark Hamilton For example, if the value is ipv4(src=192.168.0.1/255.255.0.0) the output from top is ipv4(src=192.168.0.0/255.255.0.0). Prior to this change, the original flow field content was shown unaltered even though flow statistics where aggregated among several flows. If the flow fie

Re: [ovs-dev] [PATCH] sFlow export: include standard tunnel structures (for GRE, VXLAN etc.)

2013-10-25 Thread Jesse Gross
On Fri, Oct 25, 2013 at 10:49 AM, Romain Lenglet wrote: > On Oct 24, 2013, at 5:46 PM, Jesse Gross wrote: > >> On Thu, Oct 24, 2013 at 3:39 PM, Romain Lenglet wrote: >>> - Original Message - From: "Jesse Gross" To: "Romain Lenglet" Cc: dev@openvswitch.org Sent: Tues

Re: [ovs-dev] [PATCH] datapath: Enable all software GSO on internal port.

2013-10-25 Thread Pravin Shelar
I pushed this patch to master. Thanks. On Fri, Oct 25, 2013 at 2:41 PM, Jesse Gross wrote: > On Fri, Oct 25, 2013 at 1:42 PM, Pravin B Shelar wrote: >> OVS already can handle all types of segmentation offloads that >> are supported by the kernel. >> Following patch specifically enables UDP and I

Re: [ovs-dev] [PATCH v2 1/2] openflow-1.2.h: Remove redundant definition of OFPST12_GROUP_FEATURES.

2013-10-25 Thread Joe Stringer
Acked-by: Joe Stringer On Fri, Oct 25, 2013 at 1:12 PM, Ben Pfaff wrote: > Message types are defined in ofp-msgs.h these days. > > Signed-off-by: Ben Pfaff > --- > include/openflow/openflow-1.2.h |9 - > 1 file changed, 9 deletions(-) > > diff --git a/include/openflow/openflow-1.

Re: [ovs-dev] [PATCH] datapath: Enable all software GSO on internal port.

2013-10-25 Thread Jesse Gross
On Fri, Oct 25, 2013 at 1:42 PM, Pravin B Shelar wrote: > OVS already can handle all types of segmentation offloads that > are supported by the kernel. > Following patch specifically enables UDP and IPV6 segmentation > offloads. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross _

Re: [ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-10-25 Thread Ben Pfaff
On Fri, Oct 25, 2013 at 02:04:44PM -0700, Jarno Rajahalme wrote: > > On Oct 25, 2013, at 1:56 PM, Ben Pfaff wrote: > > > On Fri, Oct 25, 2013 at 01:44:17PM -0700, Jarno Rajahalme wrote: > >> > >> On Oct 25, 2013, at 1:32 PM, Ben Pfaff wrote: > >> > >>> On Thu, Oct 24, 2013 at 02:08:24PM -0700

Re: [ovs-dev] [PATCH] ofproto: Use ofproto_check_ofpacts() from modify_flows__().

2013-10-25 Thread Ben Pfaff
Applied, thanks. On Fri, Oct 25, 2013 at 02:01:01PM -0700, Jarno Rajahalme wrote: > Nice clean-up too :-) > > Acked-by: Jarno Rajahalme > > On Oct 25, 2013, at 1:53 PM, Ben Pfaff wrote: > > > Until now this code has called ofpacts_check() directly, but that omits > > the additional check that

Re: [ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-10-25 Thread Jarno Rajahalme
On Oct 25, 2013, at 1:56 PM, Ben Pfaff wrote: > On Fri, Oct 25, 2013 at 01:44:17PM -0700, Jarno Rajahalme wrote: >> >> On Oct 25, 2013, at 1:32 PM, Ben Pfaff wrote: >> >>> On Thu, Oct 24, 2013 at 02:08:24PM -0700, Jarno Rajahalme wrote: On Oct 21, 2013, at 3:52 PM, Ben Pfaff

Re: [ovs-dev] [PATCH] ofproto: Use ofproto_check_ofpacts() from modify_flows__().

2013-10-25 Thread Jarno Rajahalme
Nice clean-up too :-) Acked-by: Jarno Rajahalme On Oct 25, 2013, at 1:53 PM, Ben Pfaff wrote: > Until now this code has called ofpacts_check() directly, but that omits > the additional check that the ofproto_check_ofpacts() wrapper includes. > > Reported-by: Jarno Rajahalme > Signed-off-by:

Re: [ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-10-25 Thread Ben Pfaff
On Fri, Oct 25, 2013 at 01:44:17PM -0700, Jarno Rajahalme wrote: > > On Oct 25, 2013, at 1:32 PM, Ben Pfaff wrote: > > > On Thu, Oct 24, 2013 at 02:08:24PM -0700, Jarno Rajahalme wrote: > >> > >> > >> On Oct 21, 2013, at 3:52 PM, Ben Pfaff wrote: > >> > >>> Commit e3b5693319c (Fix table chec

[ovs-dev] [PATCH] ofproto: Use ofproto_check_ofpacts() from modify_flows__().

2013-10-25 Thread Ben Pfaff
Until now this code has called ofpacts_check() directly, but that omits the additional check that the ofproto_check_ofpacts() wrapper includes. Reported-by: Jarno Rajahalme Signed-off-by: Ben Pfaff --- ofproto/ofproto.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) d

[ovs-dev] [PATCH] datapath: Enable all software GSO on internal port.

2013-10-25 Thread Pravin B Shelar
OVS already can handle all types of segmentation offloads that are supported by the kernel. Following patch specifically enables UDP and IPV6 segmentation offloads. Signed-off-by: Pravin B Shelar --- datapath/vport-internal_dev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-10-25 Thread Jarno Rajahalme
On Oct 25, 2013, at 1:32 PM, Ben Pfaff wrote: > On Thu, Oct 24, 2013 at 02:08:24PM -0700, Jarno Rajahalme wrote: >> >> >> On Oct 21, 2013, at 3:52 PM, Ben Pfaff wrote: >> >>> Commit e3b5693319c (Fix table checking for goto table instruction.) moved >>> action checking into modify_flows__(),

Re: [ovs-dev] [PATCH] ofproto: Avoid abandoning an ofopgroup without committing it.

2013-10-25 Thread Ben Pfaff
On Thu, Oct 24, 2013 at 02:08:24PM -0700, Jarno Rajahalme wrote: > > > On Oct 21, 2013, at 3:52 PM, Ben Pfaff wrote: > > > Commit e3b5693319c (Fix table checking for goto table instruction.) moved > > action checking into modify_flows__(), for good reason, but as a side > > effect made modify_f

[ovs-dev] [PATCH v2 1/2] openflow-1.2.h: Remove redundant definition of OFPST12_GROUP_FEATURES.

2013-10-25 Thread Ben Pfaff
Message types are defined in ofp-msgs.h these days. Signed-off-by: Ben Pfaff --- include/openflow/openflow-1.2.h |9 - 1 file changed, 9 deletions(-) diff --git a/include/openflow/openflow-1.2.h b/include/openflow/openflow-1.2.h index 541b143..249e861 100644 --- a/include/openflow/o

[ovs-dev] [PATCH v2 0/2] implement queue config request

2013-10-25 Thread Ben Pfaff
v1->v2: - Rebase and fix a conflict - Add signed-off-by - Make two separate patches into a 2-patch series, because they need to be applied in the correct order. Ben Pfaff (1): openflow-1.2.h: Remove redundant definition of OFPST12_GROUP_FEATURES. Venkitachalam Gopalakrishnan (1):

[ovs-dev] [PATCH v2 2/2] Implement OFPT_QUEUE_GET_CONFIG_REQUEST and OFPT_QUEUE_GET_CONFIG_REPLY.

2013-10-25 Thread Ben Pfaff
From: Venkitachalam Gopalakrishnan Open vSwitch has never implemented this request and reply, even though they have been in OpenFlow since version 1.0. This commit adds an implementation. Signed-off: Venkitachalam Gopalakrishnan Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff --- include

Re: [ovs-dev] [PATCH v6 2/2] TCP flags matching support.

2013-10-25 Thread Jesse Gross
On Fri, Oct 25, 2013 at 10:25 AM, Jarno Rajahalme wrote: > > On Oct 25, 2013, at 9:27 AM, Jesse Gross wrote: > >> On Fri, Oct 25, 2013 at 9:13 AM, Jarno Rajahalme >> wrote: >>> On Oct 25, 2013, at 9:06 AM, Jesse Gross wrote: > On Thu, Oct 24, 2013 at 9:01 AM, Jarno Rajahalme >>

Re: [ovs-dev] [PATCH] Handling code for queue get config request. This was done as part of a hackathon and hence is not yet fully tested. Sending it for basic review and this change set needs to be te

2013-10-25 Thread Ben Pfaff
Thanks a lot, I added this to the patch. On Fri, Oct 25, 2013 at 11:40:22AM -0700, Venkitachalam Gopalakrishnan wrote: > Signed-off: Venkitachalam Gopalakrishnan > > On Oct 24, 2013, at 3:55 PM, Ben Pfaff wrote: > > > On Thu, Oct 17, 2013 at 02:20:33PM -0700, Ben Pfaff wrote: > >> On Thu, Oct

Re: [ovs-dev] [PATCH] lib: Remove unreachable JSONRPC case

2013-10-25 Thread Ben Pfaff
On Tue, Oct 22, 2013 at 10:03:08AM -0700, Joe Stringer wrote: > jsonrpc_session_recv() handles echo replies prior to this. > > Found by inspection. > > Signed-off-by: Joe Stringer Applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvs

Re: [ovs-dev] [PATCH] Handling code for queue get config request. This was done as part of a hackathon and hence is not yet fully tested. Sending it for basic review and this change set needs to be te

2013-10-25 Thread Venkitachalam Gopalakrishnan
Signed-off: Venkitachalam Gopalakrishnan On Oct 24, 2013, at 3:55 PM, Ben Pfaff wrote: > On Thu, Oct 17, 2013 at 02:20:33PM -0700, Ben Pfaff wrote: >> On Thu, Oct 17, 2013 at 09:35:27AM -0700, Ben Pfaff wrote: >>> From: Venkitachalam Gopalakrishnan >> >> Thanks gops. >> >> I'm spending a lit

[ovs-dev] [PATCH] lib: Remove unreachable JSONRPC case

2013-10-25 Thread Joe Stringer
jsonrpc_session_recv() handles echo replies prior to this. Found by inspection. Signed-off-by: Joe Stringer --- lib/ovsdb-idl.c |3 --- 1 file changed, 3 deletions(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 4631291..3366523 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@

Re: [ovs-dev] [branch-1.9 Debian 1/2] tests: Skip Python daemon tests in directory with non-ASCII name.

2013-10-25 Thread Ben Pfaff
On Fri, Oct 25, 2013 at 10:46:13AM -0700, Gurucharan Shetty wrote: > > > > I changed my directory name to include a directory with ">>" in it. > > And this test failed for me. > > It was not supposed to fail, right? > Me inserting a ">>" is not actually unicode but rather just 2 ">". So > non_ascii

Re: [ovs-dev] [branch-1.9 Debian 2/2] jsonrpc: Only compose message to log if it's really going to be logged.

2013-10-25 Thread Gurucharan Shetty
On Fri, Oct 25, 2013 at 9:22 AM, Ben Pfaff wrote: > This suppresses a testsuite failure when the testsuite is run from a > directory whose name contains a non-ASCII character. I'd rather fix the > problem but webpages like the following make it sound difficult or > impossible on Python 2.x: http:

Re: [ovs-dev] [PATCH] sFlow export: include standard tunnel structures (for GRE, VXLAN etc.)

2013-10-25 Thread Romain Lenglet
On Oct 24, 2013, at 5:46 PM, Jesse Gross wrote: > On Thu, Oct 24, 2013 at 3:39 PM, Romain Lenglet wrote: >> - Original Message - >>> From: "Jesse Gross" >>> To: "Romain Lenglet" >>> Cc: dev@openvswitch.org >>> Sent: Tuesday, October 22, 2013 3:46:54 PM >>> Subject: Re: [ovs-dev] [PATCH

Re: [ovs-dev] [branch-1.9 Debian 1/2] tests: Skip Python daemon tests in directory with non-ASCII name.

2013-10-25 Thread Gurucharan Shetty
Never mind. The change is to skip the test and not just On Fri, Oct 25, 2013 at 10:29 AM, Gurucharan Shetty wrote: > On Fri, Oct 25, 2013 at 9:22 AM, Ben Pfaff wrote: >> The Debian autobuild machines run their builds inside a top-level >> directory named /«BUILDDIR». That name contains two non-

Re: [ovs-dev] [PATCH] tests: use full table names in ovs-vsctl commands

2013-10-25 Thread Ansis Atteka
On Thu, Oct 24, 2013 at 7:59 PM, Ben Pfaff wrote: > On Thu, Oct 24, 2013 at 06:27:10PM -0700, Ansis Atteka wrote: >> It is more obvious to figure out what exactly test is doing >> if ovs-vsctl commands contain full table names. >> >> Signed-off-by: Ansis Atteka > > Acked-by: Ben Pfaff Thanks, I

Re: [ovs-dev] [branch-1.9 Debian 1/2] tests: Skip Python daemon tests in directory with non-ASCII name.

2013-10-25 Thread Gurucharan Shetty
On Fri, Oct 25, 2013 at 9:22 AM, Ben Pfaff wrote: > The Debian autobuild machines run their builds inside a top-level > directory named /«BUILDDIR». That name contains two non-ASCII characters > that cause the Python code in the interface-reconfigure and ovs-monitor-ipsec > tests to fail. The pr

Re: [ovs-dev] [PATCH v6 2/2] TCP flags matching support.

2013-10-25 Thread Jarno Rajahalme
On Oct 25, 2013, at 9:27 AM, Jesse Gross wrote: > On Fri, Oct 25, 2013 at 9:13 AM, Jarno Rajahalme > wrote: >> >>> On Oct 25, 2013, at 9:06 AM, Jesse Gross wrote: >>> On Thu, Oct 24, 2013 at 9:01 AM, Jarno Rajahalme wrote: diff --git a/datapath/flow_netlink.c b/datapath/flo

Re: [ovs-dev] [PATCH v6 2/2] TCP flags matching support.

2013-10-25 Thread Jesse Gross
On Fri, Oct 25, 2013 at 9:13 AM, Jarno Rajahalme wrote: > >> On Oct 25, 2013, at 9:06 AM, Jesse Gross wrote: >> >>> On Thu, Oct 24, 2013 at 9:01 AM, Jarno Rajahalme >>> wrote: >>> diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c >>> index 515a9f6..fc6f42e 100644 >>> --- a/datapath

[ovs-dev] [branch-1.9 Debian 0/2] fix Debian autobuilder testsuite failures

2013-10-25 Thread Ben Pfaff
These patches fix testsuite failures that appeared on the Debian autobuilder machines, e.g. https://buildd.debian.org/status/fetch.php?pkg=openvswitch&arch=amd64&ver=1.9.3%2Bgit20131021-1&stamp=1382373784 These patches should also apply to master but I started with branch-1.9 because that

[ovs-dev] [branch-1.9 Debian 1/2] tests: Skip Python daemon tests in directory with non-ASCII name.

2013-10-25 Thread Ben Pfaff
The Debian autobuild machines run their builds inside a top-level directory named /«BUILDDIR». That name contains two non-ASCII characters that cause the Python code in the interface-reconfigure and ovs-monitor-ipsec tests to fail. The problem seems to be related to the locale, because switching

[ovs-dev] [branch-1.9 Debian 2/2] jsonrpc: Only compose message to log if it's really going to be logged.

2013-10-25 Thread Ben Pfaff
This suppresses a testsuite failure when the testsuite is run from a directory whose name contains a non-ASCII character. I'd rather fix the problem but webpages like the following make it sound difficult or impossible on Python 2.x: http://stackoverflow.com/a/11742928 Signed-off-by: Ben Pfaff -

Re: [ovs-dev] [PATCH v6 2/2] TCP flags matching support.

2013-10-25 Thread Jarno Rajahalme
> On Oct 25, 2013, at 9:06 AM, Jesse Gross wrote: > >> On Thu, Oct 24, 2013 at 9:01 AM, Jarno Rajahalme >> wrote: >> diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c >> index 515a9f6..fc6f42e 100644 >> --- a/datapath/flow_netlink.c >> +++ b/datapath/flow_netlink.c >> @@ -154,8 +1

Re: [ovs-dev] [PATCH v6 2/2] TCP flags matching support.

2013-10-25 Thread Jesse Gross
On Thu, Oct 24, 2013 at 9:01 AM, Jarno Rajahalme wrote: > diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c > index 515a9f6..fc6f42e 100644 > --- a/datapath/flow_netlink.c > +++ b/datapath/flow_netlink.c > @@ -154,8 +155,10 @@ static bool match_validate(const struct sw_flow_match > *

[ovs-dev] [PATCH v2.45 1/4] odp: Allow VLAN actions after MPLS actions

2013-10-25 Thread Simon Horman
From: Joe Stringer OpenFlow 1.1 and 1.2, and 1.3 differ in their handling of MPLS actions in the presence of VLAN tags. To allow correct behaviour to be committed in each situation, this patch adds a second round of VLAN tag action handling to commit_odp_actions(), which occurs after MPLS actions

[ovs-dev] [PATCH v2.45 2/4] lib: Support pushing of MPLS LSE before or after VLAN tag

2013-10-25 Thread Simon Horman
From: Joe Stringer This patch modifies the push_mpls behaviour to allow pushing of an MPLS LSE either before any VLAN tag that may be present. Pushing the MPLS LSE before any VLAN tag that is present is the behaviour specified in OpenFlow 1.3. Pushing the MPLS LSE after the any VLAN tag that is

[ovs-dev] [PATCH v2.45 0/4] MPLS actions and matches

2013-10-25 Thread Simon Horman
Hi, This series implements MPLS actions and matches based on work by Ravi K, Leo Alterman, Yamahata-san and Joe Stringer. This series provides two changes * Patches 1 - 2 Provide user-space support for the VLAN/MPLS tag insertion order up to and including OpenFlow 1.2, and the different ord

[ovs-dev] [PATCH v2.45 4/4] datapath: Add basic MPLS support to kernel

2013-10-25 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer. Cc: Ravi K Cc: Leo Alterman Cc: Isaku Yamahata Cc: Joe Stringer Signed-off-by: Sim

[ovs-dev] [PATCH v2.45 3/4] datapath: Break out deacceleration portion of vlan_push

2013-10-25 Thread Simon Horman
Break out deacceleration portion of vlan_push into vlan_put so that it may be re-used by mpls_push. For both vlan_push and mpls_push if there is an accelerated VLAN tag present then it should be deaccelerated, adding it to the data of the skb, before the new tag is added. Signed-off-by: Simon Hor

Re: [ovs-dev] [PATCH v4 10/10] Add OF11 SET MPLS LABEL and SET MPLS TC actions.

2013-10-25 Thread Simon Horman
On Thu, Oct 24, 2013 at 01:19:34PM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme This looks good to me. Reviewed-by: Simon Horman > --- > v3: Fix byte order errors. > > include/openflow/nicira-ext.h | 24 > lib/ofp-actions.c | 82 >