[ovs-dev] [PATCH] lib/timeval: don't forget to initialize a rwlock

2013-09-08 Thread YAMAMOTO Takashi
Commit 31ef9f5178 (timeval: Remove CACHE_TIME scheme.) removed initialization of a rwlock which is still used for some operations. This restores it. --- lib/timeval.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/timeval.c b/lib/timeval.c index 37b4353..3262397 100644 --- a/lib/timeval.c

[ovs-dev] [PATCH] openflow-1.1+: OFPT_TABLE_MOD: Use enum ofp11_table_config in struct ofputil_table_mod

2013-09-08 Thread Simon Horman
It seems convenient and in keeping with other Open vSwtich code to use enum ofp11_table_config as the type of the config field in struct ofputil_table_mod. Although the presence of OFPTC11_TABLE_MISS_MASK and need to use it as a mask seems to make things a little untidy. And there only seems to be

Re: [ovs-dev] [PATCH 0/8] ofproto-dpif meters support.

2013-09-08 Thread Simon Horman
On Sat, Sep 07, 2013 at 06:27:06PM -0700, Jarno Rajahalme wrote: > This series fixes some bugs, adds meter support to ovs-ofctl, and provides > dpif-netdev meters implmentation of the DROP band type. > > Jarno Rajahalme (8): > Delete meters in the right place. > ofproto: Use proper error code

[ovs-dev] [PATCH 2/2] ovsdb: timestamp database records to millisecond resolution.

2013-09-08 Thread Paul Ingram
The ovsdb-server compaction timing logic is written assuming milliscond resolution timestamps but ovsdb-server wrote second resolution timestamps. This commit changes ovsdb-server to write millisecond resolution timestamps and ovsdb-tool to report millisecond timestamps. This raises two compatibi

[ovs-dev] [PATCH 1/2] Report timestamps in millisecond resolution in log messages.

2013-09-08 Thread Paul Ingram
To make debugging easier. --- lib/dynamic-string.c | 21 +++-- lib/dynamic-string.h |7 ++--- lib/table.c |2 +- lib/timeval.c | 79 + lib/timeval.h |9 ++ lib/vlog.c| 16 +

Re: [ovs-dev] [PATCH] Don't set subprogram name to empty

2013-09-08 Thread Ben Pfaff
On Fri, Sep 06, 2013 at 09:28:37PM -0700, gy...@nicira.com wrote: > From: Guolin Yang > > In monitor_daemon(), it set subprogram_name to "" which causes > system crash in some platform. This change set subprogram name > to program name. > > Signed-off-by: Guolin Yang This has two effects:

Re: [ovs-dev] [RFC PATCH] ofproto: update flow_stats flags on flow_stats_request

2013-09-08 Thread Ben Pfaff
On Sun, Sep 08, 2013 at 02:21:25AM +0300, Daniel Baluta wrote: > This is a first step in implementing 'on demand flow counters'. > We save flow_mod flags into newly created rule when a new flow > is added, and echo them back in the flow stats request. > > Signed-off-by: Daniel Baluta It's a reas