[ovs-dev] [PATCH] BFD: Unit tests for BFD

2013-07-26 Thread Pavithra Ramesh
Added more comments and removed some unnecessary lines. --- tests/automake.mk |1 + tests/bfd.at | 218 tests/testsuite.at |1 + 3 files changed, 220 insertions(+), 0 deletions(-) create mode 100644 tests/bfd.at diff --git a/te

[ovs-dev] [thread-safety 11/11] ofproto-dpif-ipfix: Make the ofproto-dpif-ipfix module thread safe.

2013-07-26 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- ofproto/ofproto-dpif-ipfix.c | 43 +++--- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto/ofproto-dpif-ipfix.c index 8523afb..396befe 100644 --- a/ofproto/ofproto-dpif-ipf

[ovs-dev] [thread-safety 10/11] ofproto-dpif-sflow: Make the ofproto-dpif-sflow module thread safe.

2013-07-26 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- ofproto/ofproto-dpif-sflow.c | 92 ++ 1 file changed, 75 insertions(+), 17 deletions(-) diff --git a/ofproto/ofproto-dpif-sflow.c b/ofproto/ofproto-dpif-sflow.c index 64e6c96..568565d 100644 --- a/ofproto/ofproto-dpif-sfl

[ovs-dev] [thread-safety 07/11] bond: Make the bond module thread safe.

2013-07-26 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- lib/bond.c | 190 ++-- 1 file changed, 135 insertions(+), 55 deletions(-) diff --git a/lib/bond.c b/lib/bond.c index b3ae0c4..de9966c 100644 --- a/lib/bond.c +++ b/lib/bond.c @@ -109,30 +109,39 @@ struct bo

[ovs-dev] [thread-safety 09/11] tunnel: Make the ofproto-dpif tunnel module thread safe.

2013-07-26 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- ofproto/tunnel.c | 102 ++ 1 file changed, 73 insertions(+), 29 deletions(-) diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c index 4b7f304..97f7ef1 100644 --- a/ofproto/tunnel.c +++ b/ofproto/tunnel.c @@ -53,2

[ovs-dev] [thread-safety 08/11] mac-learning: Make the mac-learning module thread safe.

2013-07-26 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- lib/learning-switch.c|9 ++ lib/mac-learning.c | 17 +++ lib/mac-learning.h | 66 +++--- ofproto/ofproto-dpif-xlate.c | 12 ++-- ofproto/ofproto-dpif.c | 26 +

[ovs-dev] [thread-safety 05/11] bfd: Make the BFD module thread safe.

2013-07-26 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- lib/bfd.c | 166 - 1 file changed, 109 insertions(+), 57 deletions(-) diff --git a/lib/bfd.c b/lib/bfd.c index 3ac257a..054a6ae 100644 --- a/lib/bfd.c +++ b/lib/bfd.c @@ -28,6 +28,7 @@ #include "netlin

[ovs-dev] [thread-safety 06/11] netdev-vport: Make statistics thread safe.

2013-07-26 Thread Ethan Jackson
Statistics are the only part of netdev-vport which need to be manipulated by multiple threads. This patch makes them thread safe. Signed-off-by: Ethan Jackson --- lib/netdev-vport.c | 12 +++- lib/netdev-vport.h | 16 +++- 2 files changed, 22 insertions(+), 6 deletions(-

[ovs-dev] [thread-safety 04/11] lacp: Make the LACP module thread safe.

2013-07-26 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- lib/lacp.c | 165 +++- 1 file changed, 120 insertions(+), 45 deletions(-) diff --git a/lib/lacp.c b/lib/lacp.c index 5d90850..a387a6e 100644 --- a/lib/lacp.c +++ b/lib/lacp.c @@ -103,7 +103,7 @@ struct lacp

[ovs-dev] [thread-safety 03/11] cfm: Make the CFM module thread safe.

2013-07-26 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- lib/cfm.c | 168 +++-- 1 file changed, 120 insertions(+), 48 deletions(-) diff --git a/lib/cfm.c b/lib/cfm.c index a76a3ec..fc58a81 100644 --- a/lib/cfm.c +++ b/lib/cfm.c @@ -91,8 +91,6 @@ struct cfm {

[ovs-dev] [thread-safety 02/11] stp: Make the STP module thread safe.

2013-07-26 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- lib/stp.c | 360 +--- lib/stp.h |3 +- ofproto/ofproto-dpif.c |2 +- tests/test-stp.c |2 +- 4 files changed, 280 insertions(+), 87 deletions(-) diff --git a/lib/stp.c b/lib/

[ovs-dev] [thread-safety 00/11] Thread safety.

2013-07-26 Thread Ethan Jackson
This series of patches adds thread safety to a bunch of modules used by ofproto-dpif-xlate. The first patch of the series adds support for clang's thread safety annotations which as Alex mentioned aren't quite upstreamed yet. I've made some minor modifications on top of what he's sent out already

Re: [ovs-dev] [PATCH] datapath: list: Fix double fetch of pointer in hlist_entry_safe()

2013-07-26 Thread Pravin Shelar
On Fri, Jul 26, 2013 at 1:57 PM, Jesse Gross wrote: > On Fri, Jul 26, 2013 at 1:52 PM, Pravin B Shelar wrote: >> Following patch backports commit f65846a1800ef8c48d (list: Fix double >> fetch of pointer in hlist_entry_safe()) from upstream kernel. >> Thanks to Jesse for helping to debug this issu

[ovs-dev] [PATCH] datapath: Support for Linux kernel 3.9.

2013-07-26 Thread Kyle Mestery
Add support for Linux kernel 3.9. Signed-off-by: Kyle Mestery CC: Pravin B Shelar --- datapath/datapath.c | 4 ++-- datapath/vport-netdev.c | 7 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 4330ce3..e5e0616 100644 ---

Re: [ovs-dev] [PATCH] datapath: list: Fix double fetch of pointer in hlist_entry_safe()

2013-07-26 Thread Jesse Gross
On Fri, Jul 26, 2013 at 1:52 PM, Pravin B Shelar wrote: > Following patch backports commit f65846a1800ef8c48d (list: Fix double > fetch of pointer in hlist_entry_safe()) from upstream kernel. > Thanks to Jesse for helping to debug this issue. > > Original commit msg: > > list: Fix double fetch of

[ovs-dev] [PATCH] datapath: list: Fix double fetch of pointer in hlist_entry_safe()

2013-07-26 Thread Pravin B Shelar
Following patch backports commit f65846a1800ef8c48d (list: Fix double fetch of pointer in hlist_entry_safe()) from upstream kernel. Thanks to Jesse for helping to debug this issue. Original commit msg: list: Fix double fetch of pointer in hlist_entry_safe() The current version of hlist_entry_saf

Re: [ovs-dev] [PATCH] Unit tests for BFD.

2013-07-26 Thread Pavithra Ramesh
Forgot to sign off. Signed-off-by: Pavithra Ramesh Thanks, Pavithra - Original Message - From: "Pavithra Ramesh" To: dev@openvswitch.org Cc: "Pavithra Ramesh" Sent: Friday, July 26, 2013 12:14:20 PM Subject: [PATCH] Unit tests for BFD. --- tests/automake.mk |1 + tests/bfd.at

[ovs-dev] [PATCH] Unit tests for BFD.

2013-07-26 Thread Pavithra Ramesh
--- tests/automake.mk |1 + tests/bfd.at | 206 tests/testsuite.at |1 + 3 files changed, 208 insertions(+), 0 deletions(-) create mode 100644 tests/bfd.at diff --git a/tests/automake.mk b/tests/automake.mk index 755d88e..f531b

Re: [ovs-dev] [PATCH 2/2] Implement OpenFlow 1.3 queue stats duration feature.

2013-07-26 Thread Ben Pfaff
Thanks for the reviews! I apologize: I forgot to add your acks. On Fri, Jul 26, 2013 at 10:03:25AM -0700, Andy Zhou wrote: > acked-by: Andy Zhou > > > On Wed, Jul 17, 2013 at 3:58 PM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > --- > > OPENFLOW-1.1+ |3 --- > > lib/netdev-

Re: [ovs-dev] [PATCH 2/2] Implement OpenFlow 1.3 queue stats duration feature.

2013-07-26 Thread Andy Zhou
acked-by: Andy Zhou On Wed, Jul 17, 2013 at 3:58 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > OPENFLOW-1.1+ |3 --- > lib/netdev-linux.c | 11 --- > lib/netdev.c |8 ++-- > lib/netdev.h |3 +++ > lib/ofp-print.c| 14 +++--- >

Re: [ovs-dev] [PATCH 1/2] ofp-util: Fix port and queue stat counting for OpenFlow 1.3.

2013-07-26 Thread Andy Zhou
acked-by: Andy Zhou On Wed, Jul 17, 2013 at 3:58 PM, Ben Pfaff wrote: > OpenFlow 1.0, 1.1, and 1.2 all have the same struct size for port and > queue stats. OpenFlow 1.3 has larger structs, but the ofp-util code didn't > realize that. This fixes the problem. > > It appears that the only cons

Re: [ovs-dev] Question on reworking the Linux 3.9 patch

2013-07-26 Thread Jesse Gross
On Fri, Jul 26, 2013 at 8:54 AM, Kyle Mestery (kmestery) wrote: > I'm hoping to get this done today, but had a question (was on PTO yesterday): > > I see in Jesse's reply to Pravin's patch [1] a mention of putting the new code > into the main path, and the compatibility code should be for older ke

[ovs-dev] Question on reworking the Linux 3.9 patch

2013-07-26 Thread Kyle Mestery (kmestery)
I'm hoping to get this done today, but had a question (was on PTO yesterday): I see in Jesse's reply to Pravin's patch [1] a mention of putting the new code into the main path, and the compatibility code should be for older kernels. My question to Jesse is this: When you made this comment, did you

[ovs-dev] [patch net-next] openvswitch:: link upper device for port devices

2013-07-26 Thread Jiri Pirko
Link upper device properly. That will make IFLA_MASTER filled up. Set the master to port 0 of the datapath under which the port belongs. Signed-off-by: Jiri Pirko --- net/openvswitch/vport-netdev.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/net/openv

Re: [ovs-dev] [PATCH net-next 2/2] openvswitch: Use skb_zerocopy() to prepare skb for upcall

2013-07-26 Thread Thomas Graf
On 07/25/13 at 06:39pm, Jesse Gross wrote: > On Thu, Jul 25, 2013 at 5:43 AM, Thomas Graf wrote: > > From: Thomas Graf > > > > Use of skb_zerocopy() avoids the expensive call to memcpy() when > > copying the packet data into the Netlink skb. Completes checksum > > through skb_checksum_help() if n