This can be improved later but it is the simple thing to do for now.
I marked a couple of races with XXX. I don't have a really good solution
for these, but I hope to find one. They may be harmless in practice.
Signed-off-by: Ben Pfaff
---
lib/dpif-netdev.c | 203
This seems to be the last remaining thread-unsafe code in dpif-linux.
Signed-off-by: Ben Pfaff
---
lib/dpif-linux.c | 123 ++
1 files changed, 96 insertions(+), 27 deletions(-)
diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
index 3935eff..a
Signed-off-by: Ben Pfaff
---
lib/dpif.c | 108 +--
1 files changed, 82 insertions(+), 26 deletions(-)
diff --git a/lib/dpif.c b/lib/dpif.c
index 4878aac..0d8dd9d 100644
--- a/lib/dpif.c
+++ b/lib/dpif.c
@@ -70,6 +70,9 @@ struct registered_
Signed-off-by: Ben Pfaff
---
lib/dpif-linux.c | 154 ++---
1 files changed, 76 insertions(+), 78 deletions(-)
diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
index c972197..3935eff 100644
--- a/lib/dpif-linux.c
+++ b/lib/dpif-linux.c
@@ -148,26 +
Signed-off-by: Ben Pfaff
---
lib/ovs-thread.c |3 +++
lib/ovs-thread.h |3 +++
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/lib/ovs-thread.c b/lib/ovs-thread.c
index 4776587..91bb3d9 100644
--- a/lib/ovs-thread.c
+++ b/lib/ovs-thread.c
@@ -73,6 +73,7 @@ static bool multi
This series makes the dpif library thread-safe. I have not checked
yet whether the netdev library, which is not yet thread-safe, screws
up this property of the dpif changes yet.
Ben Pfaff (5):
ovs-thread: Add wrappers for "destroy" functions too.
dpif-linux: Make port change notification thre
On Jul 23, 2013, at 3:08 PM, Ben Pfaff wrote:
> On Tue, Jul 23, 2013 at 03:07:03PM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> On both:
> Acked-by: Ben Pfaff
Thanks. I pushed the changes and created branch "branch-1.12".
--Justin
__
On Tue, Jul 23, 2013 at 11:31 AM, Ben Pfaff wrote:
> On Mon, Jul 22, 2013 at 12:17:07PM -0700, Gurucharan Shetty wrote:
> > Currently the openvswitch database is being collected with
> > CAP_NETWORK_CONFIG which has a max size of 50 KB. This is
> > quite low as the database can easily be larger t
Currently the openvswitch database is being collected with
CAP_NETWORK_CONFIG which has a max size of 50 KB. This is
quite low as the database can easily be larger than 50 KB.
Move database collection to CAP_NETWORK_STATUS which does
not have a max size. If database size exceeds 10 MB, create
a co
The '-Wthread-safety' warning flag of 'clang' compiler can be useful
to the compilation of multi-threading code. This commit enables this
flag whenever 'CC=clang'.
Signed-off-by: Alex Wang
---
configure.ac |1 +
1 file changed, 1 insertion(+)
diff --git a/configure.ac b/configure.ac
index 1
On Tue, Jul 23, 2013 at 03:07:03PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
On both:
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Justin Pettit
---
NEWS |4
configure.ac |2 +-
debian/changelog |7 +++
3 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index f422bf8..3bf4421 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
+post-v1.12.0
+--
Signed-off-by: Justin Pettit
---
NEWS |4 ++--
configure.ac |2 +-
debian/changelog | 31 ---
3 files changed, 31 insertions(+), 6 deletions(-)
diff --git a/NEWS b/NEWS
index b46fc43..f422bf8 100644
--- a/NEWS
+++ b/NEWS
@@ -1,11 +1,11 @@
-po
>
> Compacting the database loses tons of information that I often find
> valuable.
+1
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Jul 23, 2013 at 12:29:40PM -0700, Gurucharan Shetty wrote:
> On Tue, Jul 23, 2013 at 11:33 AM, Ben Pfaff wrote:
>
> > On Mon, Jul 22, 2013 at 12:17:08PM -0700, Gurucharan Shetty wrote:
> > > The previously defined config files were never included in
> > > the debug bundle. This will inclu
On Tue, Jul 23, 2013 at 11:39:38AM -0700, Gurucharan Shetty wrote:
> On Tue, Jul 23, 2013 at 11:27 AM, Ben Pfaff wrote:
>
> > On Mon, Jul 22, 2013 at 12:17:06PM -0700, Gurucharan Shetty wrote:
> > > Current situation is that CAP_NETWORK_STATUS has a max size of 50 MB.
> > > When we have around 10
Thanks Ben,
On Tue, Jul 23, 2013 at 12:34 PM, Ben Pfaff wrote:
> On Mon, Jul 22, 2013 at 03:47:19PM -0700, Alex Wang wrote:
> > This commit fixes the warning issued by 'clang' when pointer is casted
> > to one with greater alignment.
> >
> > Signed-off-by: Alex Wang
>
> Thanks, I applied this.
On Mon, Jul 22, 2013 at 12:55:56PM -0700, Ethan Jackson wrote:
> Signed-off-by: Ethan Jackson
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Jul 22, 2013 at 03:47:19PM -0700, Alex Wang wrote:
> This commit fixes the warning issued by 'clang' when pointer is casted
> to one with greater alignment.
>
> Signed-off-by: Alex Wang
Thanks, I applied this.
I noticed one place with an unnecessary cast, so I folded this in:
diff --gi
On Tue, Jul 23, 2013 at 11:33 AM, Ben Pfaff wrote:
> On Mon, Jul 22, 2013 at 12:17:08PM -0700, Gurucharan Shetty wrote:
> > The previously defined config files were never included in
> > the debug bundle. This will include them.
> >
> > Also increase the max size for CAP_NETWORK_CONFIG to 5 MB.
>
Thanks, I applied all of these.
On Tue, Jul 23, 2013 at 11:28:12AM -0700, Alex Wang wrote:
> Thanks,
>
> patches 21/23-23/23 all looks good to me,
>
>
> On Tue, Jul 23, 2013 at 11:24 AM, Ben Pfaff wrote:
>
> > On Tue, Jul 23, 2013 at 08:07:55AM -0700, Alex Wang wrote:
> > > Want to ask, the "
Thanks, I applied all of these.
On Tue, Jul 23, 2013 at 11:28:58AM -0700, Andy Zhou wrote:
> patch 11-20,
> acked-by: Andy Zhou
>
>
>
> On Thu, Jul 18, 2013 at 4:15 PM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/netdev-vport.c |4
> > 1 files changed, 4 insert
On Tue, Jul 23, 2013 at 11:27 AM, Ben Pfaff wrote:
> On Mon, Jul 22, 2013 at 12:17:06PM -0700, Gurucharan Shetty wrote:
> > Current situation is that CAP_NETWORK_STATUS has a max size of 50 MB.
> > When we have around 100,000 openflow flows, we over-run that size
> > by just running the "ovs-ofct
On Mon, Jul 22, 2013 at 12:17:09PM -0700, Gurucharan Shetty wrote:
> Current size feels very low when we are collecting o/p of
> 'dmidecode' and 'lspci -vv'
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.
On Mon, Jul 22, 2013 at 12:17:08PM -0700, Gurucharan Shetty wrote:
> The previously defined config files were never included in
> the debug bundle. This will include them.
>
> Also increase the max size for CAP_NETWORK_CONFIG to 5 MB.
> A pre-compressed size of 5 MB does not amount to much after
>
On Mon, Jul 22, 2013 at 12:17:07PM -0700, Gurucharan Shetty wrote:
> Currently the openvswitch database is being collected with
> CAP_NETWORK_CONFIG which has a max size of 50 KB. This is
> quite low as the database can easily be larger than 50 KB.
>
> Move database collection to CAP_NETWORK_STATU
patch 11-20,
acked-by: Andy Zhou
On Thu, Jul 18, 2013 at 4:15 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/netdev-vport.c |4
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
> index 885bf5e..4214b38 100644
>
Thanks,
patches 21/23-23/23 all looks good to me,
On Tue, Jul 23, 2013 at 11:24 AM, Ben Pfaff wrote:
> On Tue, Jul 23, 2013 at 08:07:55AM -0700, Alex Wang wrote:
> > Want to ask, the "section" attribute specifies that the pointer is placed
> > in "vlog_modules"" section. And this section is au
On Mon, Jul 22, 2013 at 12:17:06PM -0700, Gurucharan Shetty wrote:
> Current situation is that CAP_NETWORK_STATUS has a max size of 50 MB.
> When we have around 100,000 openflow flows, we over-run that size
> by just running the "ovs-ofctl dump-flows" command. All the openvswitch
> commands run thr
On Mon, Jul 22, 2013 at 12:17:05PM -0700, Gurucharan Shetty wrote:
> ovs-appctl bond/show is being run through the plugin by
> calling the script ovs-bugtool-bond-show.
>
> So remove the redundant code.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
__
On Tue, Jul 23, 2013 at 08:07:55AM -0700, Alex Wang wrote:
> Want to ask, the "section" attribute specifies that the pointer is placed
> in "vlog_modules"" section. And this section is automatically created by
> compiler, right?
Yes.
___
dev mailing list
On Mon, Jul 22, 2013 at 06:15:49PM -0700, Alex Wang wrote:
> When "other-config:enable-vlan-splinters=true" is set, the existing
> vlans with ip address must be retained. The bug actually does the
> opposite and retains the vlans without ip address. This commit fixes
> it.
>
> Reported-by: Roman S
Signed-off-by: Ben Pfaff length);
+if (length < sizeof *oh) {
+ovs_fatal(0, "%s: %zu-byte message is too short for OpenFlow",
+ filename, length);
+}
+
+tail_len = length - sizeof *oh;
+tail = ofpbuf_put_uninit(&b, tail_len);
+
Looks good to me, thanks,
On Thu, Jul 18, 2013 at 4:15 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/fatal-signal.c | 56
> +++
> lib/fatal-signal.h |3 +-
> lib/ovs-thread.c |5
> lib/ovs-thread.h |6 +
>
Looks good to me,
Want to ask, the "section" attribute specifies that the pointer is placed
in "vlog_modules"" section. And this section is automatically created by
compiler, right?
Thanks,
On Thu, Jul 18, 2013 at 4:15 PM, Ben Pfaff wrote:
> This makes them more obviously thread-safe.
>
> Sig
Looks good to me, thanks,
On Thu, Jul 18, 2013 at 4:15 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/command-line.c |5 +
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/lib/command-line.c b/lib/command-line.c
> index 7800c0b..39b26da 100644
> --- a/l
On 23/07/13 - 13:46:37, Vasiliy Tolstov wrote:
> 2013/7/23 Christoph Paasch :
> > I do not know the technical details of bridging with vswitch, but from an
> > MPTCP point-of-view this would work.
> >
> > You just have to set the sysctl ndiffports to 2, so that MPTCP creates two
> > subflows and le
2013/7/23 Christoph Paasch :
> I do not know the technical details of bridging with vswitch, but from an
> MPTCP point-of-view this would work.
>
> You just have to set the sysctl ndiffports to 2, so that MPTCP creates two
> subflows and let the openflow-controller route the subflows accordingly.
2013/7/23 Christoph Paasch :
> I do not know the technical details of bridging with vswitch, but from an
> MPTCP point-of-view this would work.
>
> You just have to set the sysctl ndiffports to 2, so that MPTCP creates two
> subflows and let the openflow-controller route the subflows accordingly.
On 23/07/13 - 12:09:12, Vasiliy Tolstov wrote:
> 2013/7/23 Christoph Paasch :
> > yes this is possible. You just need to make MPTCP create two subflows, e.g.,
> > by using the sysctl mptcp_ndiffports [1] or by adding a second IP-address to
> > the interface.
>
>
> Thanks for response. If i don't
2013/7/23 Christoph Paasch :
> yes this is possible. You just need to make MPTCP create two subflows, e.g.,
> by using the sysctl mptcp_ndiffports [1] or by adding a second IP-address to
> the interface.
Thanks for response. If i don't want to use 2 ip adress and use
vSwitch bridge on top of two
Hello,
yes this is possible. You just need to make MPTCP create two subflows, e.g.,
by using the sysctl mptcp_ndiffports [1] or by adding a second IP-address to
the interface.
Cheers,
Christoph
[1]: http://multipath-tcp.org/pmwiki.php/Users/ConfigureMPTCP
On 23/07/13 - 08:56:56, Vasiliy Tolsto
42 matches
Mail list logo
