On Mon, Jun 24, 2013 at 6:13 PM, Alex Wang wrote:
> Thanks for the answers,
>
> On Mon, Jun 24, 2013 at 5:03 PM, Ben Pfaff wrote:
>
>> On Mon, Jun 24, 2013 at 03:56:31PM -0700, Alex Wang wrote:
>> > 1. What is usually the bug in the buggy driver? How can using
>> vlan-splinter
>> > avoid that? I
Please CC the original author and people that participated in the discussion.
On Sat, Jun 22, 2013 at 5:32 AM, Andy Zhou wrote:
> For architectures can load and store unaligned long efficiently, use 4
> or 8 bytes operations. This improves the efficiency compare to byte wise
> operations.
>
> Thi
On Mon, Jun 24, 2013 at 03:50:45PM -0700, Ansis Atteka wrote:
> On Wed, Jun 19, 2013 at 1:17 PM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/random.c | 26 +-
> > 1 files changed, 17 insertions(+), 9 deletions(-)
> >
> > diff --git a/lib/random.c b/
In future patches, ofproto-dpif-xlate may be temporarily out of
sync with ofproto-dpif proper, and pass an unknown ofport to
lacp_process_packet(). This patch handles that edge case
gracefully.
Signed-off-by: Ethan Jackson
---
lib/lacp.c |4
1 file changed, 4 insertions(+)
diff --git
Necessary in a future patch.
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif.c |9 +
ofproto/tunnel.c | 42 --
ofproto/tunnel.h | 12 +++-
3 files changed, 36 insertions(+), 27 deletions(-)
diff --git a/ofproto/of
This simplifies the tunnel module's interface and prevents us from
having to sync 'struct tnl_port' once ofproto-dpif and
ofproto-dpif-xlate are disentangled.
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif-xlate.c |4 +--
ofproto/ofproto-dpif.c | 26 +++
ofproto/of
In future patches, ofproto-dpif-xlate may be temporarily out of
sync with ofproto-dpif and pass a non-bonded ofport into
bond_check_admissibility(). This patch handles that edge case
gracefully.
Signed-off-by: Ethan Jackson
---
lib/bond.c |6 +-
1 file changed, 5 insertions(+), 1 deleti
connmgr_must_output_local() requires a 'struct connmgr' handle,
when in principle, it should simply be enough to know whether or
not in_band is enabled. Breaking this up will allow
ofproto-dpif-xlate to disentangle itself from ofproto-dpif in future
patches.
Signed-off-by: Ethan Jackson
---
ofp
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif-sflow.c | 22 --
ofproto/ofproto-dpif-sflow.h |4 +++-
ofproto/ofproto-dpif.c |4 ++--
3 files changed, 25 insertions(+), 5 deletions(-)
diff --git a/ofproto/ofproto-dpif-sflow.c b/ofproto/ofproto-dpif-sflo
This will be convenient in future patches.
Signed-off-by: Ethan Jackson
---
lib/netdev.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/netdev.c b/lib/netdev.c
index 653f5bc..d255dcc 100644
--- a/lib/netdev.c
+++ b/lib/netdev.c
@@ -277,14 +277,17 @@ netdev_op
Signed-off-by: Ethan Jackson
---
lib/bfd.c | 33 -
lib/bfd.h |2 ++
2 files changed, 30 insertions(+), 5 deletions(-)
diff --git a/lib/bfd.c b/lib/bfd.c
index ddf8c4c..7c15c6a 100644
--- a/lib/bfd.c
+++ b/lib/bfd.c
@@ -179,6 +179,8 @@ struct bfd {
long
Signed-off-by: Ethan Jackson
---
lib/cfm.c | 21 -
lib/cfm.h |3 ++-
ofproto/ofproto-dpif.c |2 +-
3 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/lib/cfm.c b/lib/cfm.c
index 67c2002..9116cba 100644
--- a/lib/cfm.c
+++ b/lib/
This will help disentangle ofproto-dpif and ofproto-dpif-xlate.
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif-xlate.c | 24
ofproto/ofproto-dpif.c | 17 +
ofproto/ofproto-dpif.h |3 ++-
3 files changed, 23 insertions(+), 21 del
Signed-off-by: Ethan Jackson
---
lib/bond.c | 20 +++-
lib/bond.h |3 ++-
ofproto/ofproto-dpif.c |6 +++---
3 files changed, 24 insertions(+), 5 deletions(-)
diff --git a/lib/bond.c b/lib/bond.c
index 68ac068..1136315 100644
--- a/lib/bond.c
+++
It requires ofproto-dpif-xlate to poke into 'struct ofproto-dpif'
which won't be allowed in future patches. It's also a case of
premature optimization.
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif-xlate.c |1 -
ofproto/ofproto-dpif.c |7 +--
ofproto/ofproto-dpif.h
Signed-off-by: Ethan Jackson
---
lib/lacp.c | 23 +--
lib/lacp.h |3 ++-
ofproto/ofproto-dpif.c |4 ++--
3 files changed, 25 insertions(+), 5 deletions(-)
diff --git a/lib/lacp.c b/lib/lacp.c
index 8bc115d..9daca3b 100644
--- a/lib/lacp.c
+++
Before this patch, the mirroring code would retroactively insert
actions for destination mirrors after actions were translated.
This relied on converting datapath output actions into ofports
which doesn't work for tunnels and patch ports. This patch
refactors the code to handle destination mirrors
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif-ipfix.c | 22 --
ofproto/ofproto-dpif-ipfix.h |4 +++-
ofproto/ofproto-dpif.c |2 +-
3 files changed, 24 insertions(+), 4 deletions(-)
diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto/ofproto-dpif-ipfix.
Signed-off-by: Ethan Jackson
---
lib/learning-switch.c |2 +-
lib/mac-learning.c | 23 ---
lib/mac-learning.h |4 +++-
ofproto/ofproto-dpif.c |2 +-
4 files changed, 25 insertions(+), 6 deletions(-)
diff --git a/lib/learning-switch.c b/lib/learning-swit
This code modularizes ofproto-dpif's mirror code by moving it to
ofproto-dpif-mirror. Not only does this shorten ofproto-dpif and
hide complexity, but its also necessary for future patches which
modularize ofproto-dpif-xlate in preparation for multi-threading.
Signed-off-by: Ethan Jackson
---
o
The goal of this series is to modularize xlate_actions() in
preparation for making it thread safe. It gets us most of the way
there, but there's still some further cleanup in that area
necessary.
The first two patches are the same as my "mirror v2" series,
followed by a bunch of trivial reference
For architectures can load and store unaligned long efficiently, use 4
or 8 bytes operations. This improves the efficiency compare to byte wise
operations.
This patch is uses ideas and code from a patch submitted by Peter Klausler
titled "replace memcmp() with specialized comparator". The flow com
Thanks for the answers,
On Mon, Jun 24, 2013 at 5:03 PM, Ben Pfaff wrote:
> On Mon, Jun 24, 2013 at 03:56:31PM -0700, Alex Wang wrote:
> > 1. What is usually the bug in the buggy driver? How can using
> vlan-splinter
> > avoid that? I'm a bit confused here, since the "vlandev.c" code still
> tal
On Mon, Jun 24, 2013 at 03:56:31PM -0700, Alex Wang wrote:
> 1. What is usually the bug in the buggy driver? How can using vlan-splinter
> avoid that? I'm a bit confused here, since the "vlandev.c" code still talks
> to linux device driver (e.g. when creating ADD_VLAN_CMD) via the "ioctl"
> call.
Thanks for the explanation,
Have few more questions below,
1. What is usually the bug in the buggy driver? How can using vlan-splinter
avoid that? I'm a bit confused here, since the "vlandev.c" code still talks
to linux device driver (e.g. when creating ADD_VLAN_CMD) via the "ioctl"
call.
2. If
On Mon, Jun 24, 2013 at 03:47:09PM -0700, Ethan Jackson wrote:
> Signed-off-by: Ethan Jackson
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Jun 19, 2013 at 1:17 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/random.c | 26 +-
> 1 files changed, 17 insertions(+), 9 deletions(-)
>
> diff --git a/lib/random.c b/lib/random.c
> index 45d428c..2572c1e 100644
> --- a/lib/random.c
> +++ b/lib/
Signed-off-by: Ethan Jackson
---
lib/lacp.c |8
lib/lacp.h |1 -
2 files changed, 9 deletions(-)
diff --git a/lib/lacp.c b/lib/lacp.c
index 8fd9d89..8bc115d 100644
--- a/lib/lacp.c
+++ b/lib/lacp.c
@@ -382,14 +382,6 @@ lacp_slave_may_enable(const struct lacp *lacp, const void
*
On Mon, Jun 24, 2013 at 03:39:04PM -0700, Alex Wang wrote:
> On Mon, Jun 24, 2013 at 1:58 PM, Ben Pfaff wrote:
> > > dnl Write-Metadata duplicated.
> > > > -# bad OF1.1 instructions: OFPBAC_UNSUPPORTED_ORDER
> > > > +# bad OF1.1 instructions: NXBIC_DUP_INSTRUCTION
> > > > 0002 0018 fedc
On Mon, Jun 24, 2013 at 1:58 PM, Ben Pfaff wrote:
> experimenter IDs
> > > by adding new *_VENDOR_ID definitions to openflow-common.h.
> > >
> > > Signed-off-by: Ben Pfaff
>
> Please snip more when you add inline comments, so that I don't
> accidentally miss some of your questions among the quot
On Mon, Jun 24, 2013 at 09:52:25PM +, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
>
> On Jun 20, 2013, at 23:55 , ext Ben Pfaff wrote:
>
> > From: Neil Zhu
> >
> > Signed-off-by: Neil Zhu
> > Signed-off-by: Ben Pfaff
> > ---
> > This is the first of a series of Open vSwitch features contrib
On Wed, Jun 19, 2013 at 1:17 PM, Ben Pfaff wrote:
> None of these test programs are threaded, but has little cost and means
> that "grep" doesn't turn up any instances of these thread-unsafe functions
> in our tree.
>
> Signed-off-by: Ben Pfaff
> ---
> tests/test-classifier.c | 25 +++
On Mon, Jun 24, 2013 at 01:39:15PM -0700, Gurucharan Shetty wrote:
> On Mon, Jun 24, 2013 at 1:10 PM, Ben Pfaff wrote:
>
> > On Thu, Jun 20, 2013 at 07:38:48AM -0700, Gurucharan Shetty wrote:
> > > The commit allows a user to add a database file to a
> > > ovsdb-server during run time. One can al
> Alex originally had one of these but I didn't think it was necessary.
> However, I think that your two votes override mine on something that I
> don't care about too much so:
I think with the code as it is now, it could go either way, but I'm
adding more ofp_port hashers in future patches, and I
Thanks, Ill merge shortly.
Ethan
On Mon, Jun 24, 2013 at 2:07 PM, Ben Pfaff wrote:
> On Mon, Jun 24, 2013 at 01:55:27PM -0700, Ethan Jackson wrote:
>> This patch makes some minor tweaks to need_revalidate sets in
>> ofproto-dpif.
>>
>> Signed-off-by: Ethan Jackson
>
> Acked-by: Ben Pfaff
_
> *shrug*
Indeed.
Thanks, I'll merge this in a bit.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Jun 24, 2013 at 01:55:27PM -0700, Ethan Jackson wrote:
> This patch makes some minor tweaks to need_revalidate sets in
> ofproto-dpif.
>
> Signed-off-by: Ethan Jackson
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvsw
On Mon, Jun 24, 2013 at 01:51:09PM -0700, Ethan Jackson wrote:
> XXX is preferred over TODO according to the style guide.
>
> Signed-off-by: Ethan Jackson
*shrug*
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mai
On Mon, Jun 24, 2013 at 01:59:09PM -0700, Ethan Jackson wrote:
> These functions are used so often, that having an easy to read
> helper is worth it.
>
> Signed-off-by: Ethan Jackson
Alex originally had one of these but I didn't think it was necessary.
However, I think that your two votes overri
On Mon, Jun 24, 2013 at 01:53:57PM -0700, Ansis Atteka wrote:
> On Wed, Jun 12, 2013 at 11:38 AM, Ben Pfaff wrote:
>
> > Users are more likely to be able to reasonably interpret OpenFlow port
> > numbers than datapath port numbers.
> >
> > This issue has existed since at least 2011 but only recen
OpenFlow 1.2 standardized experimenter error codes in a way different from
the Nicira extension. This commit implements the OpenFlow 1.2+ version.
This commit also makes it easy to add error codes for new experimenter IDs
by adding new *_VENDOR_ID definitions to openflow-common.h.
Signed-off-by:
On Thu, Jun 20, 2013 at 10:37:08PM -0700, Alex Wang wrote:
> On Wed, Jun 12, 2013 at 11:35 AM, Ben Pfaff wrote:
>
> > OpenFlow 1.2 standardized experimenter error codes in a way different from
> > the Nicira extension. This commit implements the OpenFlow 1.2+ version.
> >
> > This commit also ma
These functions are used so often, that having an easy to read
helper is worth it.
Signed-off-by: Ethan Jackson
---
lib/flow.h | 12
lib/learning-switch.c|4 ++--
ofproto/ofproto-dpif-sflow.c |7 +++
ofproto/ofproto-dpif.c |9 ---
This is a prototype of OpenFlow enhancement proposal EXT-260 "Add error
code for duplicate instruction." It uses the error code proposed there.
Signed-off-by: Ben Pfaff
---
v3->v4: Fold in change to ofp-actions.at that was (and
incorrectly) in the previous patch in older versions.
lib/ofp-acti
This patch makes some minor tweaks to need_revalidate sets in
ofproto-dpif.
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 446b27e..31cb69b 100644
--- a/
On Wed, Jun 12, 2013 at 11:38 AM, Ben Pfaff wrote:
> Users are more likely to be able to reasonably interpret OpenFlow port
> numbers than datapath port numbers.
>
> This issue has existed since at least 2011 but only recently has it been
> possible for OpenFlow and datapath port numbers to diffe
XXX is preferred over TODO according to the style guide.
Signed-off-by: Ethan Jackson
---
ofproto/ofproto-dpif-ipfix.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto/ofproto-dpif-ipfix.c
index 9de8b1c..083fe15 100644
--- a/ofproto/of
On Mon, Jun 24, 2013 at 1:39 PM, Gurucharan Shetty wrote:
>
>
> On Mon, Jun 24, 2013 at 1:10 PM, Ben Pfaff wrote:
>
>> On Thu, Jun 20, 2013 at 07:38:48AM -0700, Gurucharan Shetty wrote:
>> > The commit allows a user to add a database file to a
>> > ovsdb-server during run time. One can also remov
On Mon, Jun 24, 2013 at 1:10 PM, Ben Pfaff wrote:
> On Thu, Jun 20, 2013 at 07:38:48AM -0700, Gurucharan Shetty wrote:
> > The commit allows a user to add a database file to a
> > ovsdb-server during run time. One can also remove a
> > database file from ovsdb-server's control.
> >
> > Feature #1
This code modularizes ofproto-dpif's mirror code by moving it to
ofproto-dpif-mirror. Not only does this shorten ofproto-dpif and
hide complexity, but its also necessary for future patches which
modularize ofproto-dpif-xlate in preparation for multi-threading.
Signed-off-by: Ethan Jackson
---
o
Before this patch, the mirroring code would retroactively insert
actions for destination mirrors after actions were translated.
This relied on converting datapath output actions into ofports
which doesn't work for tunnels and patch ports. This patch
refactors the code to handle destination mirrors
On Mon, Jun 24, 2013 at 12:48:25PM -0700, Ansis Atteka wrote:
> On Wed, Jun 12, 2013 at 11:38 AM, Ben Pfaff wrote:
>
> > This function is more convenient than ofputil_format_port() when a "struct
> > ds" is not already in use. This commit converts one caller for which this
> > was already true,
On Thu, Jun 20, 2013 at 07:38:48AM -0700, Gurucharan Shetty wrote:
> The commit allows a user to add a database file to a
> ovsdb-server during run time. One can also remove a
> database file from ovsdb-server's control.
>
> Feature #14595.
> Signed-off-by: Gurucharan Shetty
The documentation co
Hi all,
Does anybody know how to measure the time consumed by processing a packet
in ovs?
More specifically, by adding some time measuring functions like
clock_gettime() or gettimeofday() in ovs somewhere, I could measure how
much ovs uses to process a packet. The reason that I want to measure it
On Wed, Jun 12, 2013 at 11:38 AM, Ben Pfaff wrote:
> This function is more convenient than ofputil_format_port() when a "struct
> ds" is not already in use. This commit converts one caller for which this
> was already true, and the following commit will add another.
>
> Signed-off-by: Ben Pfaff
On Thu, Jun 20, 2013 at 07:38:47AM -0700, Gurucharan Shetty wrote:
> An upcoming commit provides the ability to add and remove databases.
> Having the databases in a shash instead of an array makes it easier
> to add and remove databases.
>
> Feature #14595.
> Signed-off-by: Gurucharan Shetty
I
Usually we parse strings into enumerations in bridge.c.
On Fri, Jun 21, 2013 at 10:44:12AM +0900, Joe Stringer wrote:
> Sure. Is there a preference for where the string parsing code goes --
> ofproto.c or bridge.c? The configuration applies globally, but it seems
> that similar configuration is pa
On Sun, Jun 23, 2013 at 7:29 PM, Simon Horman wrote:
> It appears that in the case where vs_match_init() is called from
> ovs_flow_metadata_from_nlattrs() it is undesirable to set the flow key as
> some of its values are set earlier on in ovs_flow_metadata_from_nlattrs().
> Furthermore in the case
On Fri, Jun 21, 2013 at 01:26:57PM -0700, Gurucharan Shetty wrote:
> On Wed, Jun 19, 2013 at 1:27 PM, Ben Pfaff wrote:
>
> > On Wed, Jun 19, 2013 at 02:03:15AM -0700, Gurucharan Shetty wrote:
> > > Specifically for the case, where we know that a bridge record
> > > should exist in xapi, if we don
On Fri, Jun 21, 2013 at 01:12:24PM -0400, Ed Maste wrote:
> On 21 June 2013 12:05, Ben Pfaff wrote:
> > By default, clang warns about but does not fail on unknown -W options.
> > This made configure add the option to WARNING_FLAGS, which caused the
> > warning about not-understood warnings to be e
On Mon, Jun 24, 2013 at 10:40:11AM -0700, Alex Wang wrote:
> I saw the AF_INET is used when creating the socket (to be used in
> "ioctl(sock, SIOCSIFVLAN, via)"). Seems to me that we cannot use netlink
> socket here, right? And, generally speaking, is that true that we can only
> use AF_INET, to ta
On Fri, Jun 21, 2013 at 11:36:16AM -0700, Ethan Jackson wrote:
> The #include_next in sparse/pthread.h is a bit exotic. Would you
> please include a short comment explaining why it's necessary?
OK, I added:
/* Get actual definitions for us to annotate and build on. */
We have tons of #include_n
Thanks for the reply,
My review of 06/07 patches is done.
On Mon, Jun 24, 2013 at 10:57 AM, Ben Pfaff wrote:
> On Fri, Jun 21, 2013 at 12:33:29PM -0700, Alex Wang wrote:
> > Looks good to me, just found two places where the line length exceeds 79,
>
> Thanks. I fixed the one in our code and l
On Fri, Jun 21, 2013 at 12:33:29PM -0700, Alex Wang wrote:
> Looks good to me, just found two places where the line length exceeds 79,
Thanks. I fixed the one in our code and left the other one in sflow
code alone (the line was already too long there and I don't like to
mess with the sflow librar
On Fri, Jun 21, 2013 at 09:40:32AM -0400, Ed Maste wrote:
> On 20 June 2013 20:10, Ben Pfaff wrote:
> > Can you confirm that the autoconf test needs #include but
> > the actual program doesn't? It looks funny.
>
> Yes. It looks like it should be added in the actual program; right
> wow we end
Hey Ben,
I'm learning vlan while reviewing this patch. Want to ask a question
unrelated to this patch but vlan.
I saw the AF_INET is used when creating the socket (to be used in
"ioctl(sock, SIOCSIFVLAN, via)"). Seems to me that we cannot use netlink
socket here, right? And, generally speaking,
On Mon, Jun 24, 2013 at 03:26:52PM +, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
>
> On Jun 20, 2013, at 23:36 , ext Ben Pfaff wrote:
>
> > On Thu, Jun 20, 2013 at 05:26:17PM +0300, Jarno Rajahalme wrote:
> >>
> >> Signed-off-by: Jarno Rajahalme
> >
> > I have mixed feelings here. On one h
On Sun, Jun 23, 2013 at 5:59 PM, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
> ---
> datapath/linux/.gitignore |3 +++
> 1 file changed, 3 insertions(+)
Applied, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman
On Jun 20, 2013, at 23:36 , ext Ben Pfaff wrote:
> On Thu, Jun 20, 2013 at 05:26:17PM +0300, Jarno Rajahalme wrote:
>>
>> Signed-off-by: Jarno Rajahalme
>
> I have mixed feelings here. On one hand, it is nice to avoid a big
> copy in some cases (rare cases really). But on the other hand I am
Dear
*
*
*
Lower price sale / Dubai / JBR / 3Bedroom+maid room / 050-8320722
( 3 unit sale)
Located : Jumeirah Beach Residence (JBR) is a prime
waterfront location with upmarket apartments, and all the allure of city
and beachside living. JBR’s The Walk is Dubai’s most happeni
From: Jesse Gross
Date: Fri, 21 Jun 2013 16:17:11 -0700
> Tunnel constants can be used in generic code but in these cases
> the inline functions in ip_tunnels.h cause compilation problems
> if CONFIG_INET is not set.
>
> CC: Pravin Shelar
> Reported-by: Randy Dunlap
> Signed-off-by: Jesse Gros
From: Jesse Gross
Date: Fri, 21 Jun 2013 16:17:10 -0700
> Open vSwitch GRE tunnels are currently only enabled if the GRE
> datapath code is statically compiled in but it should be possible
> to use it as a module as well.
>
> CC: Pravin Shelar
> Signed-off-by: Jesse Gross
Pravin's copy of thi
72 matches
Mail list logo
