On Mon, Jun 10, 2013 at 5:23 PM, Jesse Gross wrote:
> On Mon, Jun 10, 2013 at 3:56 PM, Pravin B Shelar wrote:
>> diff --git a/datapath/actions.c b/datapath/actions.c
>> index 0dac658..6d60cd0 100644
>> --- a/datapath/actions.c
>> +++ b/datapath/actions.c
>> @@ -132,9 +132,17 @@ static int set_eth
Signed-off-by: Joe Stringer
---
lib/odp-execute.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index c5c8c16..e6e8c91 100644
--- a/lib/odp-execute.c
+++ b/lib/odp-execute.c
@@ -91,26 +91,26 @@ odp_execute_
I would strongly recommend using the native support for OVS in libvirt
rather than manually connecting bridges and ports together. There are
a number of tutorials floating around, so hopefully you can find one
for your distribution.
macvtap is primarily intended for getting packets out to the netw
On Tue, Jun 11, 2013 at 10:13:21AM +0900, Simon Horman wrote:
> Hi Ethan, Hi All,
>
> I have observed what appears to be a regression caused by
> 796223f5bc3a4896e6398733c798390158479400 ('netdev: Add new "struct
> netdev_rx" for capturing packets from a netdev.').
>
> In my test environment I am
Hi Ethan, Hi All,
I have observed what appears to be a regression caused by
796223f5bc3a4896e6398733c798390158479400 ('netdev: Add new "struct
netdev_rx" for capturing packets from a netdev.').
In my test environment I am using Open vSwitch with the user-space
datapath inside a KVM virtual machin
On Mon, Jun 10, 2013 at 3:56 PM, Pravin B Shelar wrote:
> diff --git a/datapath/actions.c b/datapath/actions.c
> index 0dac658..6d60cd0 100644
> --- a/datapath/actions.c
> +++ b/datapath/actions.c
> @@ -132,9 +132,17 @@ static int set_eth_addr(struct sk_buff *skb,
> if (unlikely(err))
>
Hi Jesse
Thanks for responding.
I agree that it looks like it not going completely through the OVS..there seems
to be some traffic that goes through though.
I created the bridges following the instructions in
http://git.openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=blob_plain;f=INSTALL.KV
As suggested by Jesse in the comment for patch "gre: Restructure
tunneling", following patch keeps skb->csum correct across ovs.
Signed-off-by: Pravin B Shelar
---
datapath/actions.c|8
datapath/flow.c |2 ++
datapath/vport-gre.c |3 +--
da
On Mon, Jun 10, 2013 at 03:09:33PM -0700, Jesse Gross wrote:
> On Wed, Jun 5, 2013 at 2:56 PM, Lori Jakab wrote:
> > At a high level, we would introduce layer 3 (tunnel) vports, and LISP
> > would be such a vport. Whenever a packet that ingressed on a L2 vport
> > needs to egress on a L3 vport, w
On Wed, Jun 5, 2013 at 2:56 PM, Lori Jakab wrote:
> At a high level, we would introduce layer 3 (tunnel) vports, and LISP
> would be such a vport. Whenever a packet that ingressed on a L2 vport
> needs to egress on a L3 vport, we apply the internal pop_eth action
> automatically. For packets goi
Given the difference in numbers, it seems like the majority of packets
aren't really flowing through OVS at all. I re-read your message and
noticed this time that you are using macvtap. Why is that? It's likely
sending packets directly to the NIC, bypassing OVS.
On Fri, Jun 7, 2013 at 8:52 PM, K.R
On Mon, Apr 29, 2013 at 3:23 PM, Ben Pfaff wrote:
> I don't see any reason for this variable to be static.
>
Looks good to me, thanks.
>
> CC: Ethan Jackson
> Signed-off-by: Ben Pfaff
> ---
> lib/rtnetlink-link.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a
On Jun 6, 2013, at 11:21 PM, "Rajahalme, Jarno (NSN - FI/Espoo)"
wrote:
>
> On Jun 7, 2013, at 1:34 , ext Justin Pettit wrote:
>
>> On Jun 5, 2013, at 10:43 PM, Ben Pfaff wrote:
>>> I think that struct xout_cache could use a top-level comment
>>> explaining its purpose and how it generally fi
On Mon, Jun 10, 2013 at 1:43 PM, David Miller wrote:
> From: Jesse Gross
> Date: Mon, 10 Jun 2013 13:34:23 -0700
>
>> Well, this is the slow path. I don't want to force userspace to deal
>> with this because it's an internal kernel optimization that is
>> platform-specific and requires carrying a
Thanks Alex, I applied patches 2 through 5.
On Mon, Jun 10, 2013 at 11:01:33AM -0700, Alex Wang wrote:
> Thanks Ben,
>
> It all makes sense now.
>
>
> On Mon, Jun 10, 2013 at 10:59 AM, Ben Pfaff wrote:
>
> > On Thu, Jun 06, 2013 at 05:34:26PM -0700, Alex Wang wrote:
> > > On Thu, Jun 6, 2013
Thanks Ansis and Alex, I applied this to master.
On Mon, Jun 10, 2013 at 11:13:50AM -0700, Ansis Atteka wrote:
> Acked-by: Ansis Atteka
>
>
> On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff wrote:
>
> > They are unused.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/process.c | 227
> > ---
From: Jesse Gross
Date: Mon, 10 Jun 2013 13:34:23 -0700
> Well, this is the slow path. I don't want to force userspace to deal
> with this because it's an internal kernel optimization that is
> platform-specific and requires carrying additional metadata around.
I think the grounds for this rejec
On Fri, Jun 7, 2013 at 5:21 AM, Thomas Graf wrote:
> On 05/27/13 at 10:28am, Jesse Gross wrote:
>> On Saturday, May 25, 2013, Eric Dumazet wrote:
>>
>> > On Sat, 2013-05-25 at 08:02 +0100, Thomas Graf wrote:
>> >
>> > > I ran TCP_CRR to verify the SYN/ACK use case and I did not
>> > > observe a di
Applied, thanks.
On Mon, Jun 10, 2013 at 11:25:43AM -0700, Justin Pettit wrote:
> Acked-by: Justin Pettit
>
>
> On Jun 10, 2013, at 11:20 AM, Ben Pfaff wrote:
>
> >cc1: warnings being treated as errors
> >../ofproto/ofproto-dpif.c: In function ‘dpif_show_backer’:
> >../ofproto/ofp
Acked-by: Justin Pettit
On Jun 10, 2013, at 11:20 AM, Ben Pfaff wrote:
>cc1: warnings being treated as errors
>../ofproto/ofproto-dpif.c: In function ‘dpif_show_backer’:
>../ofproto/ofproto-dpif.c:8305: error: format ‘%llu’ expects type ‘long
>long unsigned int’, but argument 4
cc1: warnings being treated as errors
../ofproto/ofproto-dpif.c: In function ‘dpif_show_backer’:
../ofproto/ofproto-dpif.c:8305: error: format ‘%llu’ expects type ‘long
long unsigned int’, but argument 4 has type ‘size_t’
../ofproto/ofproto-dpif.c:8305: error: format ‘%llu’ expe
On Fri, Jun 07, 2013 at 02:07:09PM -0700, Pravin Shelar wrote:
> On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/netdev-vport.c |7 ++-
> > 1 files changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/lib/netdev-vport.c b/lib/netdev-
On Fri, Jun 07, 2013 at 02:30:15PM -0700, Pravin Shelar wrote:
> On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff wrote:
> > Returning a static data buffer makes code more brittle and definitely
> > not thread-safe, so this commit switches to using a caller-provided
> > buffer instead.
> >
> > Signed-off
On Fri, Jun 07, 2013 at 04:14:20PM -0700, Ansis Atteka wrote:
> On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff wrote:
>
> > Returning a static data buffer makes code more brittle and definitely
> > not thread-safe, so this commit switches to using a caller-provided
> > buffer instead.
> >
> > Signed-o
Acked-by: Ansis Atteka
On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff wrote:
> They are unused.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/process.c | 227
> -
> lib/process.h |8 --
> 2 files changed, 0 insertions(+), 235 deletions(-)
>
looks good to me,
this also maks the completion of review for patches 02/17-05/17
On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/process.c |4
> lib/process.h | 14 ++
> 2 files changed, 14 insertions(+), 4 deletions(-)
>
> diff
Thanks Ben,
It all makes sense now.
On Mon, Jun 10, 2013 at 10:59 AM, Ben Pfaff wrote:
> On Thu, Jun 06, 2013 at 05:34:26PM -0700, Alex Wang wrote:
> > On Thu, Jun 6, 2013 at 4:27 PM, Ben Pfaff wrote:
> >
> > > On Thu, Jun 06, 2013 at 09:49:11AM -0700, Alex Wang wrote:
> > > > The 2/17. 3/17
On Thu, Jun 06, 2013 at 05:34:26PM -0700, Alex Wang wrote:
> On Thu, Jun 6, 2013 at 4:27 PM, Ben Pfaff wrote:
>
> > On Thu, Jun 06, 2013 at 09:49:11AM -0700, Alex Wang wrote:
> > > The 2/17. 3/17 look good to me.
> >
> > > For this patch, want to ask few questions:
> > >
> > > 1. why does the pre
Thanks! Applied to master.
On Fri, Jun 07, 2013 at 04:39:36PM -0700, Ansis Atteka wrote:
> Acked-by: Ansis Atteka
>
>
> On Fri, Jun 7, 2013 at 10:14 AM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/ofp-actions.h | 12 ++--
> > 1 files changed, 6 insertions(+),
Thanks, applied to master and branch-1.{11,10,9}.
On Sat, Jun 08, 2013 at 01:27:07PM -0700, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
> On Fri, Jun 7, 2013 at 3:05 PM, Ben Pfaff wrote:
> > Some tools do not like text files that lack a trailing new-line. In
> > particular, Debian's dpkg-
On Mon, Jun 10, 2013 at 9:10 AM, Andy Zhou wrote:
> On Fri, Jun 7, 2013 at 4:43 PM, Jesse Gross wrote:
>> On Wed, Jun 5, 2013 at 10:46 PM, Andy Zhou wrote:
>> > +static void flow_key_mask(struct sw_flow_key *dst,
>> > + const struct sw_flow_key *src,
>> > +
On Sun, Jun 09, 2013 at 05:20:27PM +0800, Baohua Yang wrote:
> I want one packet do two processes in ovs:
>1) resubmit to another table;
> 2) Normal send out.
>
> However, if specifying Normal output action before resubmit action,
> it will work.
> While put
The callback option makes the monitor library more customizable.
Each client of the library can now provide callbacks to run any
tasks in the monitor. It is the responsibility of the client to
return from the function in case the monitored process dies.
An upcoming commit becomes the first client.
commit b421d2af0ab (ovsdb-server: Add commands for adding and removing remotes)
made it possible to make ovsdb-server connect to OVS managers only after
ovs-vswitchd has completed its initial configuration. But this results in an
undesirable effect. Whenever ovsdb-server crashes, the monitor restar
Till now, rxbuf was only used by the worker. An upcoming
commit will have another client. So carve out rxbuf from
the worker files.
Signed-off-by: Gurucharan Shetty
---
lib/automake.mk |2 ++
lib/rxbuf.c | 82 +++
lib/rxbuf.h |
Thanks for the review. I will make the suggested changes. 2 comments
inline:
On Fri, Jun 7, 2013 at 4:43 PM, Jesse Gross wrote:
> OK, here's the second half:
>
> On Wed, Jun 5, 2013 at 10:46 PM, Andy Zhou wrote:
> > diff --git a/datapath/flow.c b/datapath/flow.c
> > index 7f897bd..fc8fb86 10064
Sehr geehrter Herr,
Investition für Ihre Projekte
Ich bin ein Finanzberater hier und ich habe einen Investor, dem zu bereit ist
Platzkapitalien in den günstigen Möglichkeiten der Geldanlage available.amount,
Dollar 1.2American billion zu finanzieren
Meine K
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman and Ravi K.
Cc: Ravi K
Cc: Leo Alterman
Cc: Isaku Yamahata
Cc: Joe Stringer
Signed-off-by: Simon Horman
---
This is the r
38 matches
Mail list logo
