On Jun 7, 2013, at 0:02 , ext Ben Pfaff wrote:
> handle_flow_miss_without_facet() previously translated the actions for
> each packet. Now, it translates the actions once (or not at all, if
> there's an xc already). Won't this prevent slow protocols (e.g. CFM,
> LACP, BFD) from working properly
Thanks.
On Thu, Jun 06, 2013 at 11:17:09AM -0700, Ethan Jackson wrote:
> Applied with some minor tweaks to the commit message. Thanks Simon.
>
> Ethan
>
> On Wed, Jun 5, 2013 at 1:50 PM, Ben Pfaff wrote:
> > On Wed, Jun 05, 2013 at 02:28:47PM +0900, Simon Horman wrote:
> >> facet_check_consist
On Jun 7, 2013, at 1:34 , ext Justin Pettit wrote:
> On Jun 5, 2013, at 10:43 PM, Ben Pfaff wrote:
>> I think that struct xout_cache could use a top-level comment
>> explaining its purpose and how it generally fits in with the rest of
>> the system.
>
> /* A cache of xlate_out (xout) translatio
[ CC Pravin B Shelar for GSO at the end of this email ]
On Tue, Jun 04, 2013 at 02:49:37PM -0700, Jesse Gross wrote:
> On Thu, May 23, 2013 at 8:26 PM, Simon Horman wrote:
> > diff --git a/datapath/actions.c b/datapath/actions.c
> > index 0dac658..1704876 100644
> > --- a/datapath/actions.c
> > +
On Wed, Jun 5, 2013 at 10:46 PM, Andy Zhou wrote:
> Add mega flow support in kernel datapath.
>
> Pravin has made significant contributions to this patch. Including
> the mega flow id look up scheme, API clean ups, and bug fixes.
>
> Co-authored-by: Pravin B Shelar
> Signed-off-by: Pravin B Shela
FWIW, I removed the two "megaflow" references in my code and replaced them with
"kernel wildcards".
--Justin
On Jun 6, 2013, at 5:17 PM, Jesse Gross wrote:
> I mostly meant the kernel code since that's what I've been looking at
> but would be good to be consistent throughout the code base. I
Thanks Ben for the answers.
Few more questions.
On Thu, Jun 6, 2013 at 4:27 PM, Ben Pfaff wrote:
> On Thu, Jun 06, 2013 at 09:49:11AM -0700, Alex Wang wrote:
> > The 2/17. 3/17 look good to me.
>
> Thanks.
>
> > For this patch, want to ask few questions:
> >
> > 1. why does the previous impleme
On Thu, Jun 06, 2013 at 12:56:35AM +0300, Lori Jakab wrote:
> The LISP tunneling support as of now is not yet ready for upstreaming,
> for reasons outlined in this message:
>
> http://openvswitch.org/pipermail/dev/2013-February/025459.html
>
> One solution to the above issues is to make OVS less
I mostly meant the kernel code since that's what I've been looking at
but would be good to be consistent throughout the code base. I think
there are just a few instances of the term in the userspace code and
if we think the term in not obvious then it might be better to just
use "wildcard" or some
Thanks, applied to master.
On Thu, Jun 06, 2013 at 01:33:17PM -0700, Andy Zhou wrote:
> Looks good. Thanks.
>
>
> On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff wrote:
>
> > Returning a static data buffer makes code more brittle and definitely
> > not thread-safe, so this commit switches to using
Thanks, I will address this point in V2 patch.
I agree with you to remove it from the other locations, but want to make
sure you meant within the scope of kernel code, right?
Andy
On Thu, Jun 6, 2013 at 4:41 PM, Jesse Gross wrote:
> It looks good - I might also add that if the mask attribute
On Thu, Jun 6, 2013 at 2:29 PM, Pravin B Shelar wrote:
> Flex array is used to allocate hash buckets which is type struct
> hlist_head, but we use `struct hlist_head *` to calculate
> array size. Since hlist_head is of size pointer it works fine.
>
> Following patch use correct type.
>
> Signed-o
It looks good - I might also add that if the mask attribute is not
specified at all then the flow is exact match. I agree that it is
probably clearer to not use the term "mega flow" here but we should
then also remove it from the other locations in the code as well.
On Thu, Jun 6, 2013 at 3:15 PM,
On Thu, Jun 06, 2013 at 09:49:11AM -0700, Alex Wang wrote:
> The 2/17. 3/17 look good to me.
Thanks.
> For this patch, want to ask few questions:
>
> 1. why does the previous implementation cannot guarantee thread safety (An
> example?)? Is this related to the sigchld_ related functions?
A sing
Thanks for all the improvements! They sound good to me.
On Thu, Jun 06, 2013 at 03:34:08PM -0700, Justin Pettit wrote:
> On Jun 5, 2013, at 10:43 PM, Ben Pfaff wrote:
>
> > "git am" says:
> >
> >Applying: ofproto-dpif: Track relevant fields for wildcarding and add
> > xout cache.
> >/
Thanks, applied to master, branch-1.11, branch-1.10.
On Thu, Jun 06, 2013 at 11:34:32AM -0700, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
> On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff wrote:
> > The ports that exist within a dpif have already been translated through
> > netdev_vport_get_dpi
On Jun 5, 2013, at 10:43 PM, Ben Pfaff wrote:
> "git am" says:
>
>Applying: ofproto-dpif: Track relevant fields for wildcarding and add xout
> cache.
>/home/blp/ovs/.git/rebase-apply/patch:1342: trailing whitespace.
>create_xc(const struct flow_wildcards *initial_wc,
>warning:
On Wed, Jun 05, 2013 at 01:46:21PM -0700, Ethan Jackson wrote:
> Conceptually, a subfacet represents a datapath flow key, and
> therefore belongs more to a datapath more than it does to a bridge.
> This patch moves the subfacet hmap from 'struct ofproto_dpif' to
> 'struct dpif_backer', simplifying
How about the following change? I choose not to use the term "mega flow"
here to avoid confusing outside people.
diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
index 6e71b4c..203c7eb 100644
--- a/include/linux/openvswitch.h
+++ b/include/linux/openvswitch.h
@@ -410,9 +410,1
On Wed, Jun 05, 2013 at 01:46:20PM -0700, Ethan Jackson wrote:
> With the signal datapath, it no longer makes sense to have a per
"single" datapath
> ofproto flow eviction threshold. This patch moves the flow
> eviction threshold to the Open_vSwitch table making the setting
> global, though stil
On Wed, Jun 05, 2013 at 01:46:19PM -0700, Ethan Jackson wrote:
> Subfacets being per-datapath entities, their statistics are really
> only interesting at per-datapath granularity. This patch moves
> them to the dpif_backer and makes some related simplifications.
>
> Signed-off-by: Ethan Jackson
Flex array is used to allocate hash buckets which is type struct
hlist_head, but we use `struct hlist_head *` to calculate
array size. Since hlist_head is of size pointer it works fine.
Following patch use correct type.
Signed-off-by: Pravin B Shelar
---
datapath/flow.c |2 +-
1 files chan
More comments.
We maintain stats in lots of places: struct rule, struct facet, struct
subfacet, struct xout_cache. It's not obvious how all these differ
and how we shuffle them all around.
Every caller of lookup_xc() creates a new xc entry on failure. Can
any of this be factored into a helper?
Dear all,
Our OFConfig code and initial development efforts are posted here:
https://github.com/UH-SDN/softconf.d This is a collaboration with Infoblox.
We included a configuration description under /doc. All YANG modules from
OFConfig standard 1.1.1 are in. However, only the controller IP addr
Looks good. Thanks.
On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff wrote:
> Returning a static data buffer makes code more brittle and definitely
> not thread-safe, so this commit switches to using a caller-provided
> buffer instead.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/dpif-linux.c |
Hi Clinton,
I set up a Facebook profile where I can post my pictures, videos and events and
I want to add you as a friend so you can see it. First, you need to join
Facebook! Once you join, you can also create your own profile.
Thanks,
Clinton
To sign up for Facebook, follow the link below:
ht
Acked-by: Ethan Jackson
On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff wrote:
> The ports that exist within a dpif have already been translated through
> netdev_vport_get_dpif_port(), so there is no value to translating them
> again in the interfaces that query or dump ports (and possibly a drawback
Acked-by: Ethan Jackson
On Wed, Jun 5, 2013 at 1:05 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/process.c| 46 --
> lib/process.h|5 +
> ovsdb/ovsdb-server.c |2 +-
> 3 files changed, 6 insertions(+), 47
Applied with some minor tweaks to the commit message. Thanks Simon.
Ethan
On Wed, Jun 5, 2013 at 1:50 PM, Ben Pfaff wrote:
> On Wed, Jun 05, 2013 at 02:28:47PM +0900, Simon Horman wrote:
>> facet_check_consistency() goes to some effort to create informative
>> error messages, protected by a rat
On Wed, Jun 5, 2013 at 10:46 PM, Andy Zhou wrote:
> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> index e890fd8..6e71b4c 100644
> --- a/include/linux/openvswitch.h
> +++ b/include/linux/openvswitch.h
> @@ -410,6 +410,9 @@ struct ovs_key_nd {
> * @OVS_FLOW_ATTR_CLEAR: I
Hey Ben,
The 2/17. 3/17 look good to me.
For this patch, want to ask few questions:
1. why does the previous implementation cannot guarantee thread safety (An
example?)? Is this related to the sigchld_ related functions?
2. For the "process_register()", the comment still talks about blocking
SI
On Thu, Jun 06, 2013 at 09:05:43AM -0700, Justin Pettit wrote:
> On Jun 5, 2013, at 4:50 PM, Ben Pfaff wrote:
>
> > On Wed, Jun 05, 2013 at 03:21:38PM -0700, Justin Pettit wrote:
> >> From: Ethan Jackson
> >>
> >> A future commit will want to know what bits were significant during the
> >> clas
On Thu, Jun 06, 2013 at 08:50:35AM -0700, Justin Pettit wrote:
>
> On Jun 5, 2013, at 4:42 PM, Ben Pfaff wrote:
>
> > On Wed, Jun 05, 2013 at 03:21:37PM -0700, Justin Pettit wrote:
> >> From: Ethan Jackson
> >>
> >> This function will be useful in a future commit.
> >>
> >> Co-authored-by: Ju
On Wed, Jun 5, 2013 at 6:30 PM, Pravin Shelar wrote:
> I am planning on adding iptunnel_pull_header() function to upstream
> kernel, it is in gre-upstream series that I am going to send.
OK, it was somewhat difficult to review the compatibility code because
it's a backport of something that isn't
On Jun 5, 2013, at 4:50 PM, Ben Pfaff wrote:
> On Wed, Jun 05, 2013 at 03:21:38PM -0700, Justin Pettit wrote:
>> From: Ethan Jackson
>>
>> A future commit will want to know what bits were significant during the
>> classifier lookup.
>>
>> Co-authored-by: Justin Pettit
>> Signed-off-by: Justin
On Jun 5, 2013, at 4:42 PM, Ben Pfaff wrote:
> On Wed, Jun 05, 2013 at 03:21:37PM -0700, Justin Pettit wrote:
>> From: Ethan Jackson
>>
>> This function will be useful in a future commit.
>>
>> Co-authored-by: Justin Pettit
>> Signed-off-by: Justin Pettit
>
> The name flow_wildcards_or_min
On Jun 5, 2013, at 3:26 PM, Ben Pfaff wrote:
> On Wed, Jun 05, 2013 at 03:21:36PM -0700, Justin Pettit wrote:
>> An obvious copy/paste error.
>>
>> Signed-off-by: Justin Pettit
>
> The second sentence of the original description still applies (it
> doesn't make sense to set MFF_ARP_SPA for a
On Jun 5, 2013, at 10:43 PM, Ben Pfaff wrote:
> Justin, I know that you're eager for a full review of this patch, but
> it's just not going to happen tonight. I have some initial feedback
> here, and I'll finish it up tomorrow morning.
No problem. I appreciate you continuing to look at it so l
38 matches
Mail list logo
