Re: [ovs-dev] [PATCH] dpif-linux: Use MAX_PORTS instead of hard-coded 65535.

2013-05-01 Thread Justin Pettit
Looks good. --Justin On May 1, 2013, at 5:13 PM, Ben Pfaff wrote: > MAX_PORTS is currently USHRT_MAX (also 65535). I think that's a > coincidence; I don't remember MAX_PORTS being mentioned when the new > dpif_channel code was written. > > Signed-off-by: Ben Pfaff > --- > lib/dpif-linux.c |

Re: [ovs-dev] [PATCH net-next 1/2] net: More fine-grained support for encapsulated GSO features

2013-05-01 Thread Simon Horman
On Wed, May 01, 2013 at 09:53:42PM -0700, Jesse Gross wrote: > On Wed, May 1, 2013 at 3:57 PM, Simon Horman wrote: > > On Wed, May 01, 2013 at 11:16:40AM -0700, Jesse Gross wrote: > >> On Wed, May 1, 2013 at 12:50 AM, Simon Horman wrote: > >> > On Tue, Apr 30, 2013 at 09:19:51AM -0700, Jesse Gros

Re: [ovs-dev] [PATCH net-next 1/2] net: More fine-grained support for encapsulated GSO features

2013-05-01 Thread Jesse Gross
On Wed, May 1, 2013 at 3:57 PM, Simon Horman wrote: > On Wed, May 01, 2013 at 11:16:40AM -0700, Jesse Gross wrote: >> On Wed, May 1, 2013 at 12:50 AM, Simon Horman wrote: >> > On Tue, Apr 30, 2013 at 09:19:51AM -0700, Jesse Gross wrote: >> >> On Mon, Apr 29, 2013 at 8:21 PM, Simon Horman wrote:

Re: [ovs-dev] [PATCH 2/2] Track ethertype changes for learn_parse()

2013-05-01 Thread Simon Horman
On Wed, May 01, 2013 at 09:42:18PM -0700, Jesse Gross wrote: > On Wed, May 1, 2013 at 1:11 AM, Simon Horman wrote: > > learn_parse() needs to know the current ethertype, including any > > updates made by MPLS push and pop actions in order to determine if > > access to fields is valid or not. > > >

Re: [ovs-dev] [PATCH 1/2] Improve dl_type checking in ofpact_check__

2013-05-01 Thread Simon Horman
On Wed, May 01, 2013 at 09:19:46PM -0700, Jesse Gross wrote: > On Wed, May 1, 2013 at 1:11 AM, Simon Horman wrote: > > Some actions require an MPLS dl_type while others require a non-MPLS > > dl_type. Enforce this for actions handled in ofpact_check__(). > > > > Update the following actions to req

Re: [ovs-dev] [PATCH 2/2] Track ethertype changes for learn_parse()

2013-05-01 Thread Jesse Gross
On Wed, May 1, 2013 at 1:11 AM, Simon Horman wrote: > learn_parse() needs to know the current ethertype, including any > updates made by MPLS push and pop actions in order to determine if > access to fields is valid or not. > > Changes made to ethertype my VLAN push and pop actions are excluded >

[ovs-dev] [PATCH v2] Always update ethertype on mpls_pop

2013-05-01 Thread Simon Horman
The ethertype should always be updated on mpls_pop as there may be a transition between MPLS unicast (0x8847) and MPLS multicast (0x8848). Ben Pfaff tells me that this is consistent with the behaviour described in EXT-194 of the JIRA bug tracker. Signed-off-by: Simon Horman --- v2 * Add note a

Re: [ovs-dev] [PATCH 1/2] Improve dl_type checking in ofpact_check__

2013-05-01 Thread Jesse Gross
On Wed, May 1, 2013 at 1:11 AM, Simon Horman wrote: > Some actions require an MPLS dl_type while others require a non-MPLS > dl_type. Enforce this for actions handled in ofpact_check__(). > > Update the following actions to require an non-MPLS dl_type: > > set_ipv4_src > set_ipv4_dst > set_ipv4_ds

Re: [ovs-dev] issue in launching vm on openvswitch bridge

2013-05-01 Thread freak 62
Thanx Ansis for reply. On Wed, May 1, 2013 at 10:26 PM, Ansis Atteka wrote: > > > > On Tue, Apr 30, 2013 at 11:27 PM, freak 62 wrote: > >> Hi all, >> >> >> I am using Ubuntu 12.10. I am trying to launch VM on the bridge of >> OVS. >> Can I do that with virt-manager ? or Is there any o

Re: [ovs-dev] [PATCH] Make it more obvious that OVS_KEY_ATTR_MPLS may be an array

2013-05-01 Thread Jesse Gross
On Wed, May 1, 2013 at 6:49 PM, Simon Horman wrote: > Note that OVS_KEY_ATTR_MPLS may be an array of ovs_key_mpls > and that the acceptable length may be restricted by the implementation. > > Currently the user-space datapath and proposed kernel datapath > implementation restrict the length to a s

Re: [ovs-dev] 802.1ad QinQ

2013-05-01 Thread Jesse Gross
On Wed, May 1, 2013 at 3:30 PM, Thomas F Herbert wrote: > All, > > I would like to introduce once again the subject of stacked vlans. We have > implemented a network edge device using 802.1ad. It is currently implemented > on Linux with iproute2 and a patched kernel but we would like to > re-impl

Re: [ovs-dev] [PATCH v3 4/4] dapapath: Kill VPORT_F_TUN_ID vport flag.

2013-05-01 Thread Pravin Shelar
On Wed, May 1, 2013 at 6:31 PM, Jesse Gross wrote: > On Wed, May 1, 2013 at 4:02 PM, Pravin B Shelar wrote: >> VPORT_F_TUN_ID is last remaining flag, once we remove it, flags >> field from vport-ops can be removed. Since it does not complicate >> much code, we decided to remove this flag and for

[ovs-dev] [PATCH] Make it more obvious that OVS_KEY_ATTR_MPLS may be an array

2013-05-01 Thread Simon Horman
Note that OVS_KEY_ATTR_MPLS may be an array of ovs_key_mpls and that the acceptable length may be restricted by the implementation. Currently the user-space datapath and proposed kernel datapath implementation restrict the length to a single element. Also update the mpls_top_lse name of the eleme

Re: [ovs-dev] [PATCH v3 4/4] dapapath: Kill VPORT_F_TUN_ID vport flag.

2013-05-01 Thread Jesse Gross
On Wed, May 1, 2013 at 4:02 PM, Pravin B Shelar wrote: > VPORT_F_TUN_ID is last remaining flag, once we remove it, flags > field from vport-ops can be removed. Since it does not complicate > much code, we decided to remove this flag and force vport modules > assign correct tun_key. > > Signed-off

Re: [ovs-dev] [PATCH v3 3/4] datapath: Move vport init to First port create.

2013-05-01 Thread Jesse Gross
On Wed, May 1, 2013 at 4:02 PM, Pravin B Shelar wrote: > vport->init and exit() functios are defined by gre and netdev vport > only and both can be moved to first port create. > > Following patch does same, it moves vport init to respectve vport > create and get rid of vport->init() and vport->exi

Re: [ovs-dev] [PATCH v3 2/4] datapath: Unify vport error stats handling.

2013-05-01 Thread Jesse Gross
On Wed, May 1, 2013 at 4:02 PM, Pravin B Shelar wrote: > Following patch changes vport->send return type so that vport > layer can do error accounting. > > Signed-off-by: Pravin B Shelar This is definitely an improvement: Acked-by: Jesse Gross Just one question: > diff --git a/datapath/vport.

Re: [ovs-dev] [PATCH v3 1/4] tunneling: Remove struct tnl_vport and tnl_ops.

2013-05-01 Thread Jesse Gross
On Wed, May 1, 2013 at 4:02 PM, Pravin B Shelar wrote: > After flow based tunneling, kernel tunneling is greatly simplified. > There is no need to have extra tunning layer between vport and > perticular protocol. > Following patch removes tunneling struct which make code easy to read. > > Signed-o

[ovs-dev] [fd leak 4/4] dpif-linux: Fix fd leak for vports that disappear from the datapath.

2013-05-01 Thread Ben Pfaff
When ovs-vswitchd deletes a port with dpif_linux_port_del(), that function uses del_channel() to delete the corresponding channel, including closing its Netlink socket fd. However, if the vport gets removed by some other process (e.g. "ip link delete" for veths) then this function never gets calle

[ovs-dev] [fd leak 0/4] Fix fd leak in dpif-linux

2013-05-01 Thread Ben Pfaff
This series fixes a fd leak in the dpif-linux implementation. The first patch is a simple partial fix suitable for backporting. The remaining patches are a complete solution. Ben Pfaff (4): dpif-linux: Close channel Netlink sockets when a port number gets recycled. dpif-linux: Factor out p

[ovs-dev] [fd leak 3/4] dpif-linux: Generalize dpif_linux_recv_set() to synchronize channels.

2013-05-01 Thread Ben Pfaff
Until now, the code in dpif_linux_recv_set() has assumed it is starting from a clean slate with no channels at all. This commit generalizes it to compare the existing set of channels against the ones that should exist given the vports that the kernel has, adding any new ones that are missing and r

[ovs-dev] [fd leak 2/4] dpif-linux: Factor out port dumping helper functions.

2013-05-01 Thread Ben Pfaff
These helpers simplify new code to be added in an upcoming commit. Signed-off-by: Ben Pfaff --- lib/dpif-linux.c | 46 +- 1 files changed, 33 insertions(+), 13 deletions(-) diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c index 933aabe..b80c27a 1006

[ovs-dev] [fd leak 1/4] dpif-linux: Close channel Netlink sockets when a port number gets recycled.

2013-05-01 Thread Ben Pfaff
When ovs-vswitchd deletes a port with dpif_linux_port_del(), that function uses del_channel() to delete the corresponding channel, including closing its Netlink socket fd. However, if the vport gets removed by some other process (e.g. "ip link delete" for veths) then this function never gets calle

[ovs-dev] [PATCH] dpif-linux: Use MAX_PORTS instead of hard-coded 65535.

2013-05-01 Thread Ben Pfaff
MAX_PORTS is currently USHRT_MAX (also 65535). I think that's a coincidence; I don't remember MAX_PORTS being mentioned when the new dpif_channel code was written. Signed-off-by: Ben Pfaff --- lib/dpif-linux.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/dpif-li

Re: [ovs-dev] [PATCH] Always update ethertype on mpls_pop

2013-05-01 Thread Ben Pfaff
On Thu, May 02, 2013 at 08:27:48AM +0900, Simon Horman wrote: > On Wed, May 01, 2013 at 03:53:37PM -0700, Ben Pfaff wrote: > > On Thu, May 02, 2013 at 07:40:53AM +0900, Simon Horman wrote: > > > On Wed, May 01, 2013 at 09:54:03AM -0700, Ben Pfaff wrote: > > > > On Wed, May 01, 2013 at 05:06:02PM +0

Re: [ovs-dev] [PATCH] Always update ethertype on mpls_pop

2013-05-01 Thread Simon Horman
On Wed, May 01, 2013 at 03:53:37PM -0700, Ben Pfaff wrote: > On Thu, May 02, 2013 at 07:40:53AM +0900, Simon Horman wrote: > > On Wed, May 01, 2013 at 09:54:03AM -0700, Ben Pfaff wrote: > > > On Wed, May 01, 2013 at 05:06:02PM +0900, Simon Horman wrote: > > > > The ethertype should always be update

[ovs-dev] [PATCH v3 4/4] dapapath: Kill VPORT_F_TUN_ID vport flag.

2013-05-01 Thread Pravin B Shelar
VPORT_F_TUN_ID is last remaining flag, once we remove it, flags field from vport-ops can be removed. Since it does not complicate much code, we decided to remove this flag and force vport modules assign correct tun_key. Signed-off-by: Pravin B Shelar --- v1-v3: New patch. --- datapath/vport-gre

[ovs-dev] [PATCH v3 3/4] datapath: Move vport init to First port create.

2013-05-01 Thread Pravin B Shelar
vport->init and exit() functios are defined by gre and netdev vport only and both can be moved to first port create. Following patch does same, it moves vport init to respectve vport create and get rid of vport->init() and vport->exit() fnctions. Signed-off-by: Pravin B Shelar --- v2-v3: - Fix

[ovs-dev] [PATCH v3 2/4] datapath: Unify vport error stats handling.

2013-05-01 Thread Pravin B Shelar
Following patch changes vport->send return type so that vport layer can do error accounting. Signed-off-by: Pravin B Shelar --- v1-v3: New patch. --- datapath/tunnel.c | 33 ++--- datapath/vport-gre.c| 14 -- datapath/vport-lisp.c | 13 ++

[ovs-dev] [PATCH v3 1/4] tunneling: Remove struct tnl_vport and tnl_ops.

2013-05-01 Thread Pravin B Shelar
After flow based tunneling, kernel tunneling is greatly simplified. There is no need to have extra tunning layer between vport and perticular protocol. Following patch removes tunneling struct which make code easy to read. Signed-off-by: Pravin B Shelar --- v2-v3: - Fixed error handling in ovs_t

Re: [ovs-dev] [PATCH net-next 1/2] net: More fine-grained support for encapsulated GSO features

2013-05-01 Thread Simon Horman
On Wed, May 01, 2013 at 11:16:40AM -0700, Jesse Gross wrote: > On Wed, May 1, 2013 at 12:50 AM, Simon Horman wrote: > > On Tue, Apr 30, 2013 at 09:19:51AM -0700, Jesse Gross wrote: > >> On Mon, Apr 29, 2013 at 8:21 PM, Simon Horman wrote: > >> > On Fri, Apr 26, 2013 at 04:03:21PM -0700, Jesse Gro

Re: [ovs-dev] [PATCH] Always update ethertype on mpls_pop

2013-05-01 Thread Ben Pfaff
On Thu, May 02, 2013 at 07:40:53AM +0900, Simon Horman wrote: > On Wed, May 01, 2013 at 09:54:03AM -0700, Ben Pfaff wrote: > > On Wed, May 01, 2013 at 05:06:02PM +0900, Simon Horman wrote: > > > The ethertype should always be updated on mpls_pop > > > as there may be a transition between MPLS unica

Re: [ovs-dev] [PATCH] Always update ethertype on mpls_pop

2013-05-01 Thread Simon Horman
On Wed, May 01, 2013 at 09:54:03AM -0700, Ben Pfaff wrote: > On Wed, May 01, 2013 at 05:06:02PM +0900, Simon Horman wrote: > > The ethertype should always be updated on mpls_pop > > as there may be a transition between MPLS unicast (0x8847) and > > MPLS multicast (0x8848). > > > > Signed-off-by: S

[ovs-dev] 802.1ad QinQ

2013-05-01 Thread Thomas F Herbert
All, I would like to introduce once again the subject of stacked vlans. We have implemented a network edge device using 802.1ad. It is currently implemented on Linux with iproute2 and a patched kernel but we would like to re-implement it with openvswitch. I have read earlier discussion in t

Re: [ovs-dev] [PATCH] Set release date for 1.10.0.

2013-05-01 Thread Justin Pettit
On May 1, 2013, at 2:33 PM, Ben Pfaff wrote: > On Wed, May 01, 2013 at 02:31:31PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Looks good, thanks. Thanks. I pushed this to master, branch-1.11, and branch-1.10. --Justin ___ dev

Re: [ovs-dev] [PATCH] Revert "Prepare for post-1.11.0 (1.11.90)."

2013-05-01 Thread Justin Pettit
On May 1, 2013, at 2:45 PM, Ben Pfaff wrote: > On Wed, May 01, 2013 at 02:42:07PM -0700, Justin Pettit wrote: >> This reverts commit 9f31efc731090e8d33236c55a4adbf461f3acbd1. >> >> This is the 1.11.0 release, so this patch doesn't belong. >> --- >> This only applies to "branch-1.11". > > Looks

Re: [ovs-dev] [PATCH] Revert "Prepare for post-1.11.0 (1.11.90)."

2013-05-01 Thread Ben Pfaff
On Wed, May 01, 2013 at 02:42:07PM -0700, Justin Pettit wrote: > This reverts commit 9f31efc731090e8d33236c55a4adbf461f3acbd1. > > This is the 1.11.0 release, so this patch doesn't belong. > --- > This only applies to "branch-1.11". Looks good. ___ dev

[ovs-dev] [PATCH] Revert "Prepare for post-1.11.0 (1.11.90)."

2013-05-01 Thread Justin Pettit
This reverts commit 9f31efc731090e8d33236c55a4adbf461f3acbd1. This is the 1.11.0 release, so this patch doesn't belong. --- This only applies to "branch-1.11". --- NEWS |4 configure.ac |2 +- debian/changelog |7 --- 3 files changed, 1 insertions(+), 12 delet

Re: [ovs-dev] [PATCH] Set release date for 1.10.0.

2013-05-01 Thread Ben Pfaff
On Wed, May 01, 2013 at 02:31:31PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Looks good, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] Set release date for 1.10.0.

2013-05-01 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS |2 +- debian/changelog |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 2c57d9b..3a7123b 100644 --- a/NEWS +++ b/NEWS @@ -24,7 +24,7 @@ v1.11.0 - xx xxx will have to manually configure it

Re: [ovs-dev] [PATCH] AUTHORS: added myself to the AUTHORS file

2013-05-01 Thread Ben Pfaff
On Wed, May 01, 2013 at 01:21:54PM -0700, Duffie Cooley wrote: > Forgot to add myself to the AUTHORS file. I already did this (I folded it into the previous patch). ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] AUTHORS: added myself to the AUTHORS file

2013-05-01 Thread Duffie Cooley
Forgot to add myself to the AUTHORS file. Signed-off-by: Duffie Cooley --- AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index b314ce6..8dd06b5 100644 --- a/AUTHORS +++ b/AUTHORS @@ -27,6 +27,7 @@ David Erickson deric...@stanford.edu David S. Miller

Re: [ovs-dev] [PATCH] ovs-sandbox: use the $schema var for creating the db.

2013-05-01 Thread Ben Pfaff
I couldn't apply this from the email for some reason (whitespace damage?) but since it was a one-liner I fixed it up. Thanks a lot! Applied to master and branch-1.11. On Wed, May 01, 2013 at 11:50:08AM -0700, Duffie Cooley wrote: > Found a bug in the ovs-sandbox script. We should use the well >

[ovs-dev] [PATCH] ovs-sandbox: use the $schema var for creating the db.

2013-05-01 Thread Duffie Cooley
Found a bug in the ovs-sandbox script. We should use the well defined $schema var to create the db. Not the $srcdir/dir stuff. Thanks, Duffie Signed-off-by: Duffie Cooley --- tutorial/ovs-sandbox | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tutorial/ovs-sandbox b/tut

[ovs-dev] [PATCH] Use pthread_sigmask() in place of sigprocmask(), for thread safety.

2013-05-01 Thread Ben Pfaff
POSIX says that multithreaded programs must not use sigprocmask() but must use pthread_sigmask() instead. This commit makes that replacement. The actual use of signals in Open vSwitch is still not thread safe following this commit, but this change is a necessary prerequisite for fixing the other

[ovs-dev] [PATCH] socket-util: Use getaddrinfo() instead of gethostbyname() for thread safety.

2013-05-01 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/socket-util.c | 47 +-- 1 files changed, 37 insertions(+), 10 deletions(-) diff --git a/lib/socket-util.c b/lib/socket-util.c index 4f9b5b8..4b559cb 100644 --- a/lib/socket-util.c +++ b/lib/socket-util.c @@ -185,23 +1

[ovs-dev] [PATCH] system-stats: Use getmntent_r() for thread-safety.

2013-05-01 Thread Ben Pfaff
getmntent_r() is a GNU extension so we test for its existence and just disable this feature of system stats if it is not present, because this feature is not very important. Signed-off-by: Ben Pfaff --- configure.ac|2 +- vswitchd/system-stats.c |8 +--- 2 files changed,

[ovs-dev] [PATCH] Use gmtime_r() and localtime_r() instead of non-thread-safe versions.

2013-05-01 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/dynamic-string.c | 12 ++-- lib/table.c |5 +++-- ovsdb/ovsdb-tool.c|3 ++- utilities/ovs-ofctl.c |4 +++- 4 files changed, 14 insertions(+), 10 deletions(-) diff --git a/lib/dynamic-string.c b/lib/dynamic-string.c index bd1cf

[ovs-dev] [PATCH 1/2] signals: Use sys_siglist[] instead of strsignal() for thread-safety.

2013-05-01 Thread Ben Pfaff
strsignal() isn't thread-safety but sys_siglist[] is. Also, according to the glibc manual, BSD has sys_siglist[] but not strsignal(). Signed-off-by: Ben Pfaff --- configure.ac |3 ++- lib/signals.c |8 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/configure.ac

[ovs-dev] [PATCH 2/2] signals: Make signal_name() thread-safe.

2013-05-01 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/fatal-signal.c |4 +++- lib/process.c | 10 -- lib/signals.c | 29 +++-- lib/signals.h |4 +++- 4 files changed, 29 insertions(+), 18 deletions(-) diff --git a/lib/fatal-signal.c b/lib/fatal-signal.c inde

[ovs-dev] [const 3/9] hmap: Make HMAP_INITIALIZER a valid initializer for a const hmap.

2013-05-01 Thread Ben Pfaff
Without this change, an initialization such as const struct hmap map = HMAP_INITIALIZER(&map); yields a compiler warning "initialization discards qualifiers from pointer target type". Signed-off-by: Ben Pfaff --- lib/hmap.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff -

[ovs-dev] [const 5/9] netdev: Make 'smap' variable const in netdev_set_qos().

2013-05-01 Thread Ben Pfaff
This makes this code more obviously thread-safe. Signed-off-by: Ben Pfaff --- lib/netdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/netdev.c b/lib/netdev.c index 156984a..434e257 100644 --- a/lib/netdev.c +++ b/lib/netdev.c @@ -1115,7 +1115,7 @@ netdev_set_qo

[ovs-dev] [const 8/9] ofp-util: Make names[] in ofputil_action_code_from_name() const-ier.

2013-05-01 Thread Ben Pfaff
This changes allows the compiler to put 'names' in a read-only section. Signed-off-by: Ben Pfaff --- lib/ofp-util.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 42c3613..4d3fe9e 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c

[ovs-dev] [const 9/9] vconn: Mark class structures as const.

2013-05-01 Thread Ben Pfaff
These data structures are never modified so it seems logical for them to be const. Signed-off-by: Ben Pfaff --- lib/vconn-provider.h | 20 ++-- lib/vconn-stream.c | 20 ++-- lib/vconn.c | 30 +++--- 3 files changed, 35 inse

[ovs-dev] [const 7/9] vlog: Mark more static data const.

2013-05-01 Thread Ben Pfaff
These data structures are never modified so this seems like a logical change. Signed-off-by: Ben Pfaff --- lib/vlog.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/vlog.c b/lib/vlog.c index 8bc9938..275d02a 100644 --- a/lib/vlog.c +++ b/lib/vlog.c @@ -49,14 +4

[ovs-dev] [const 0/9] Mark many static data structures as const.

2013-05-01 Thread Ben Pfaff
In preparation for multithreading OVS, it makes sense to mark any static data that we can "const", because read-only access to data is obviously thread-safe. Ben Pfaff (9): dpif-linux: Make dummy_action const in dpif_linux_init_flow_put(). Make most "struct option" instances "const". hmap: M

[ovs-dev] [const 4/9] netdev-linux: Mark more static data as "const".

2013-05-01 Thread Ben Pfaff
This makes this code more obviously thread-safe. Signed-off-by: Ben Pfaff --- lib/netdev-linux.c | 30 ++ 1 files changed, 14 insertions(+), 16 deletions(-) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index c0e0c40..722b88b 100644 --- a/lib/netdev-linux.c

[ovs-dev] [const 6/9] stream-fd: Mark 'fd_pstream_class' const.

2013-05-01 Thread Ben Pfaff
These data structures are never modified so this seems like a logical change. Signed-off-by: Ben Pfaff --- lib/stream-fd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/stream-fd.c b/lib/stream-fd.c index 1b16f3e..90d328a 100644 --- a/lib/stream-fd.c +++ b/lib/s

[ovs-dev] [const 1/9] dpif-linux: Make dummy_action const in dpif_linux_init_flow_put().

2013-05-01 Thread Ben Pfaff
This makes this code more obviously thread-safe. Signed-off-by: Ben Pfaff --- lib/dpif-linux.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c index b863a2e..2aa09ff 100644 --- a/lib/dpif-linux.c +++ b/lib/dpif-linux.c @@ -794,7 +

[ovs-dev] [const 2/9] Make most "struct option" instances "const".

2013-05-01 Thread Ben Pfaff
Reducing non-const static data makes code more obviously thread-safe. Although option parsing does not normally need to be thread-safe, I don't know of a drawback to making its data const. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-client.c |4 ++-- ovsdb/ovsdb-server.c |2 +-

Re: [ovs-dev] [PATCH net-next 1/2] net: More fine-grained support for encapsulated GSO features

2013-05-01 Thread Jesse Gross
On Wed, May 1, 2013 at 12:50 AM, Simon Horman wrote: > On Tue, Apr 30, 2013 at 09:19:51AM -0700, Jesse Gross wrote: >> On Mon, Apr 29, 2013 at 8:21 PM, Simon Horman wrote: >> > On Fri, Apr 26, 2013 at 04:03:21PM -0700, Jesse Gross wrote: >> >> On Thu, Apr 25, 2013 at 12:36 AM, Simon Horman wrote

[ovs-dev] [PATCH 1/3] dpif-netdev: Don't run port names through netdev_vport_get_dpif_port().

2013-05-01 Thread Ben Pfaff
The ports that exist within a dpif have already been translated through netdev_vport_get_dpif_port(), so there is no value to translating them again in the interfaces that query or dump ports (and possibly a drawback if somehow the translation could change). After this change, dpif-netdev translat

[ovs-dev] [PATCH 3/3] netdev-vport: Don't return static data in netdev_vport_get_dpif_port().

2013-05-01 Thread Ben Pfaff
Returning a static data buffer makes code more brittle and definitely not thread-safe, so this commit switches to using a caller-provided buffer instead. Signed-off-by: Ben Pfaff --- lib/dpif-linux.c |4 +++- lib/dpif-netdev.c |9 ++--- lib/netdev-vport.c | 18 ++

[ovs-dev] [PATCH 2/3] netdev-vport: Make netdev_vport_get_dpif_port() code less confusing.

2013-05-01 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/netdev-vport.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c index 08169a1..a9911d3 100644 --- a/lib/netdev-vport.c +++ b/lib/netdev-vport.c @@ -126,7 +126,6 @@ netdev_vport_get_dpif_p

Re: [ovs-dev] issue in launching vm on openvswitch bridge

2013-05-01 Thread Ansis Atteka
On Tue, Apr 30, 2013 at 11:27 PM, freak 62 wrote: > Hi all, > > > I am using Ubuntu 12.10. I am trying to launch VM on the bridge of > OVS. > Can I do that with virt-manager ? or Is there any other way?? > Virt-manager is one of the UI applications that use libvirt. If I recall correctly

Re: [ovs-dev] [PATCH v2] ofproto-dpif: Fix memory leak sending packets to controller.

2013-05-01 Thread Justin Pettit
The code's tricky, but I looked over it a couple of times, and it looks reasonable to me. Thanks, --Justin On Apr 25, 2013, at 11:23 AM, Ben Pfaff wrote: > In the case where execute_controller_action() returned true to > handle_flow_miss(), indicating that the packet had been sent to the > c

Re: [ovs-dev] [PATCH] Always update ethertype on mpls_pop

2013-05-01 Thread Ben Pfaff
On Wed, May 01, 2013 at 05:06:02PM +0900, Simon Horman wrote: > The ethertype should always be updated on mpls_pop > as there may be a transition between MPLS unicast (0x8847) and > MPLS multicast (0x8848). > > Signed-off-by: Simon Horman The comment on pop_mpls() needs an update. EXT-194 in th

Re: [ovs-dev] [PATCH] Remove spurious IPv4 data from MPLS packet test

2013-05-01 Thread Ben Pfaff
On Wed, May 01, 2013 at 05:05:26PM +0900, Simon Horman wrote: > Supplying this data is somewhat misleading as it > is completely ignored and is not included in > the synthesised packet. > > Signed-off-by: Simon Horman Applied to master, thanks! ___ dev

Re: [ovs-dev] issue in launching vm on openvswitch bridge

2013-05-01 Thread Gurucharan Shetty
On Tue, Apr 30, 2013 at 11:27 PM, freak 62 wrote: > Hi all, > > > I am using Ubuntu 12.10. I am trying to launch VM on the bridge of > OVS. > Can I do that with virt-manager ? or Is there any other way?? > Can I run the existing VM's to my openvswitch bridge ? > I tried to edit e

[ovs-dev] [PATCH v7 1/5] Add execute_actions

2013-05-01 Thread Simon Horman
This moves generic action execution code out of lib/dpif-netedev.c and into a new file, lib/execute-actions.c. This is in preparation for using execute_set_action() in lib/odp-util.c to handle recirculation/ Signed-off-by: Simon Horman --- v7 * No change v6 * As suggested by Jesse Gross - C

[ovs-dev] [PATCH v7 0/5] Add packet recirculation

2013-05-01 Thread Simon Horman
Recirculation is a technique to allow a frame to re-enter frame processing. This is intended to be used after actions have been applied to the frame with modify the frame in some way that makes it possible for richer processing to occur. An example is and indeed targeted use case is MPLS. If an MP

[ovs-dev] [PATCH v7 2/5] Add set skb_mark support to execute_set_action

2013-05-01 Thread Simon Horman
Add set skb_mark support to execute_set_action. This also adds support for the user-space datapath to honour such actions if they occur before recirculation, which will be added by a subsequent patch. This is in preparation for using execute_set_action() to handle recirculation. Signed-off-by: Si

[ovs-dev] [PATCH v7 3/5] Add set skb_priority support to execute_set_action

2013-05-01 Thread Simon Horman
Add set skb_priority support to execute_set_action. This also adds support for the user-space datapath to honour such actions if they occur before recirculation, which will be added by a subsequent patch. This is in preparation for using execute_set_action() to handle recirculation. Signed-off-by

[ovs-dev] [PATCH v7 4/5] Add set tunnel support to execute_set_action

2013-05-01 Thread Simon Horman
Add set tunnel support to execute_set_action. This also adds support for the user-space datapath to honour such actions if they occur before recirculation, which will be added by a subsequent patch. This is in preparation for using execute_set_action() to handle recirculation. Signed-off-by: Simo

[ovs-dev] [PATCH 0/2] Enhancements to dl_type pre-requisite checking

2013-05-01 Thread Simon Horman
Hi, this short series enhances the checking of dl_type pre-requisites. All of the cases arise from the addition of MPLS. The second patch is dependent on the first patch, but other than that this series is not dependent on any patches. I would like it considered for merging. Simon Horman (2):

[ovs-dev] [PATCH 1/2] Improve dl_type checking in ofpact_check__

2013-05-01 Thread Simon Horman
Some actions require an MPLS dl_type while others require a non-MPLS dl_type. Enforce this for actions handled in ofpact_check__(). Update the following actions to require an non-MPLS dl_type: set_ipv4_src set_ipv4_dst set_ipv4_dscp set_l4_src_port set_l4_dst_port dec_ttl Update the following ac

[ovs-dev] [PATCH 2/2] Track ethertype changes for learn_parse()

2013-05-01 Thread Simon Horman
learn_parse() needs to know the current ethertype, including any updates made by MPLS push and pop actions in order to determine if access to fields is valid or not. Changes made to ethertype my VLAN push and pop actions are excluded from this logic as they do not effect the behaviour of learn_par

[ovs-dev] [PATCH] Always update ethertype on mpls_pop

2013-05-01 Thread Simon Horman
The ethertype should always be updated on mpls_pop as there may be a transition between MPLS unicast (0x8847) and MPLS multicast (0x8848). Signed-off-by: Simon Horman --- lib/packets.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/packets.c b/lib/packets.c index 77aa7

[ovs-dev] [PATCH] Remove spurious IPv4 data from MPLS packet test

2013-05-01 Thread Simon Horman
Supplying this data is somewhat misleading as it is completely ignored and is not included in the synthesised packet. Signed-off-by: Simon Horman --- This patch is independent of other MPLS patches and I would like it considered for merging. --- tests/ofproto-dpif.at | 2 +- 1 file changed, 1

Re: [ovs-dev] [PATCH net-next 1/2] net: More fine-grained support for encapsulated GSO features

2013-05-01 Thread Simon Horman
On Tue, Apr 30, 2013 at 09:19:51AM -0700, Jesse Gross wrote: > On Mon, Apr 29, 2013 at 8:21 PM, Simon Horman wrote: > > On Fri, Apr 26, 2013 at 04:03:21PM -0700, Jesse Gross wrote: > >> On Thu, Apr 25, 2013 at 12:36 AM, Simon Horman wrote: > >> > On Tue, Apr 23, 2013 at 02:00:19PM -0700, Joseph G

Re: [ovs-dev] dev Dige.st, Vol 45, Iss,,ue 173

2013-05-01 Thread jayce lee
*, On May 1, 2013 8:49 AM, wrote: > Send dev mailing list submissions to > dev@openvswitch.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://openvswitch.org/mailman/listinfo/dev > or, via email, send a message with subject or body 'help' to > dev-r