On Apr 29, 2013, at 20:49 , ext Jesse Gross wrote:
> On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo)
> wrote:
>>
>> Another thing that I came to think only when reading Ben's new tutorial:
>> Output to the input port is skipped. This would be a problem if you only
>> have on
From: Thomas Graf
Date: Tue, 30 Apr 2013 01:06:41 +0200
> The only user is get_dpifindex(), no need to redirect via the port
> operations.
>
> Signed-off-by: Thomas Graf
> ---
> V2 - Fix stylistic issue
Applied, thanks Thomas.
___
dev mailing list
de
OK, got it.
At some point we'll want to look up the tunnel meta-data for all sampled
packets so we can fill in the sFlow tunnel annotations too
(http://sflow.org/sflow_tunnels.txt) but that is a separable step. In the mean
time it seems OK that the conjured "packet-out" actions might not popu
On Fri, Apr 26, 2013 at 04:03:21PM -0700, Jesse Gross wrote:
> On Thu, Apr 25, 2013 at 12:36 AM, Simon Horman wrote:
> > On Tue, Apr 23, 2013 at 02:00:19PM -0700, Joseph Gasparakis wrote:
> >> Any particular reason to introduce skb->encapsulation_features instead of
> >> using the existing skb->en
On Mon, Apr 29, 2013 at 01:01:44PM -0700, Jesse Gross wrote:
> On Thu, Apr 25, 2013 at 12:26 AM, Simon Horman wrote:
> > On Tue, Apr 23, 2013 at 04:43:58PM -0700, Jesse Gross wrote:
> >> On Mon, Apr 22, 2013 at 7:19 PM, Simon Horman wrote:
> >> > In the case where a non-MPLS GSO skb becomes an MP
Looks good.
--Justin
On Apr 29, 2013, at 5:49 PM, Ben Pfaff wrote:
> Um, I mean, remove useless code.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/dpif-netdev.c |4
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 6838800.
Um, I mean, remove useless code.
Signed-off-by: Ben Pfaff
---
lib/dpif-netdev.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 6838800..632a1de 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -493,7 +493,6 @@ stat
On Mon, Apr 29, 2013 at 3:25 PM, Ben Pfaff wrote:
> On Mon, Apr 29, 2013 at 01:34:55PM -0700, Gurucharan Shetty wrote:
> > Currently we are creating the worker process after creation of the
> pidfile.
> > This means that the the responsibility of deleting the pidfile after
> process
> > terminati
The only user is get_dpifindex(), no need to redirect via the port
operations.
Signed-off-by: Thomas Graf
---
V2 - Fix stylistic issue
net/openvswitch/datapath.c | 3 ++-
net/openvswitch/vport-internal_dev.c | 1 -
net/openvswitch/vport-netdev.c | 7 ---
net/openvswitch/vpor
On Mon, Apr 29, 2013 at 2:53 PM, Neil Mckee wrote:
> but I'm not sure I understand the one in tunnel.c. I assume you mean this
> comment:
>
> /* XXX:
> *
> * Ability to generate metadata for packet-outs
> * Disallow netdevs with names like "gre64_system" to prevent collisions. */
>
> Is this
On Mon, Apr 29, 2013 at 01:34:55PM -0700, Gurucharan Shetty wrote:
> Currently we are creating the worker process after creation of the pidfile.
> This means that the the responsibility of deleting the pidfile after process
> termination rests with the worker process.
>
> When we restart openvswit
I don't see any reason for this variable to be static.
CC: Ethan Jackson
Signed-off-by: Ben Pfaff
---
lib/rtnetlink-link.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/rtnetlink-link.c b/lib/rtnetlink-link.c
index 0b3710f..459e485 100644
--- a/lib/rtnetlink-li
I don't see any reason for this to be static.
Signed-off-by: Ben Pfaff
---
lib/netdev-vport.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
index 08169a1..4021eda 100644
--- a/lib/netdev-vport.c
+++ b/lib/netdev-vport.c
@@ -214,
I don't see any reason for these to be static.
CC: Ethan Jackson
Signed-off-by: Ben Pfaff
---
lib/route-table.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/route-table.c b/lib/route-table.c
index 5bdcfb0..5891ae8 100644
--- a/lib/route-table.c
+++ b/lib/r
Thanks, applied to master.
On Mon, Apr 29, 2013 at 03:04:06PM -0700, Justin Pettit wrote:
> Both look good to me.
>
> --Justin
>
>
> On Apr 29, 2013, at 3:00 PM, Ben Pfaff wrote:
>
> > This was the only obvious use of bare malloc() in the tree, other
> > than in the implementation of wrapper
These calls are not necessary because F_SETLK does not block.
Signed-off-by: Ben Pfaff
---
lib/lockfile.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/lib/lockfile.c b/lib/lockfile.c
index 3708aec..c37f332 100644
--- a/lib/lockfile.c
+++ b/lib/lockfile.c
@@ -251,9 +2
These functions will not have the same useful effect when Open vSwitch
becomes multithreaded, because time_disable_restart() will disable time
advancing for every thread, not just for the thread that calls it.
These functions are no longer used, so this commit removes them.
Signed-off-by: Ben Pfa
Both look good to me.
--Justin
On Apr 29, 2013, at 3:00 PM, Ben Pfaff wrote:
> This was the only obvious use of bare malloc() in the tree, other
> than in the implementation of wrapper functions.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/netlink-socket.c |5 +
> 1 files changed, 1 inse
Thanks, applied to master.
On Mon, Apr 29, 2013 at 03:00:55PM -0700, Justin Pettit wrote:
> Looks good.
>
> --Justin
>
>
> On Apr 29, 2013, at 2:57 PM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/timeval.h |1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
Looks good.
--Justin
On Apr 29, 2013, at 2:57 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/timeval.h |1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/lib/timeval.h b/lib/timeval.h
> index 72cf498..b74fe12 100644
> --- a/lib/timeval.h
> +++ b/lib/tim
This was the only obvious use of bare malloc() in the tree, other
than in the implementation of wrapper functions.
Signed-off-by: Ben Pfaff
---
lib/netlink-socket.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index a9e6
Signed-off-by: Ben Pfaff
---
lib/netlink-socket.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index 392bcf5..a9e68fa 100644
--- a/lib/netlink-socket.c
+++ b/lib/netlink-socket.c
@@ -59,8 +59,7 @@ static void log_nlmsg(cons
On Apr 29, 2013, at 2:55 PM, Ben Pfaff wrote:
> On Mon, Apr 29, 2013 at 02:49:42PM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Looks good, thanks.
Thanks. I pushed this to master.
--Justin
___
dev mailing list
dev@openvswitch.
On Apr 29, 2013, at 2:55 PM, Ben Pfaff wrote:
> On Mon, Apr 29, 2013 at 02:49:14PM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>> ---
>> The previous commit had a bad commit date and the version number wasn't
>> updated for the Debian changelog.
>
> Looks good, thanks.
Thanks.
Signed-off-by: Ben Pfaff
---
lib/timeval.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/lib/timeval.h b/lib/timeval.h
index 72cf498..b74fe12 100644
--- a/lib/timeval.h
+++ b/lib/timeval.h
@@ -70,7 +70,6 @@ void time_wall_timespec(struct timespec *);
void time_alarm(un
The database documentation says:
If an interface does not support a given statistic, then that pair is
omitted.
but in fact the implementation included the key-value pair for an
unsupported statistic with -1 as the value.
Found by inspection.
Signed-off-by: Ben Pfaff
---
vswitchd/brid
On Mon, Apr 29, 2013 at 02:49:42PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Looks good, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Apr 29, 2013 at 02:49:14PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
> ---
> The previous commit had a bad commit date and the version number wasn't
> updated for the Debian changelog.
Looks good, thanks.
___
dev mailing list
de
OK, I can resubmit the patch with something like this in
ofproto/ofproto-dpif.c:port_construct():
if (netdev_vport_is_patch(netdev)) {
/* By bailing out here, we don't submit the port to the sFlow module
* to be consi
On Mon, Apr 29, 2013 at 2:08 PM, Jesse Gross wrote:
> On Thu, Apr 18, 2013 at 4:51 PM, Pravin B Shelar wrote:
>> vport->init and exit() functios are defined by gre and netdev vport
>> only and both can be moved to first port create.
>>
>> Following patch does same, it moves vport init to respectv
On Mon, Apr 29, 2013 at 1:14 PM, Jesse Gross wrote:
> On Thu, Apr 18, 2013 at 4:51 PM, Pravin B Shelar wrote:
>> Rather than defining ovs specific stats struct (vport_percpu_stats),
>> we can use existing pcpu_tstats to achieve exactly same functionality.
>>
>> Signed-off-by: Pravin B Shelar
>
>
Signed-off-by: Justin Pettit
---
NEWS |4
configure.ac |2 +-
debian/changelog |7 +++
3 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index 042810a..2c57d9b 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
+post-v1.11.0
+--
On Mon, Apr 29, 2013 at 02:42:56PM -0700, Andy Zhou wrote:
> Add fflush() to the 'rate' command of 'ovs-benchmark'. On a tty console
> the output is line-buffered. However, piped output by default has a
> deeper (usually 4KB) buffer, the output won't appear to the other end of
> the pipe until thi
Signed-off-by: Justin Pettit
---
The previous commit had a bad commit date and the version number wasn't
updated for the Debian changelog.
---
NEWS |2 +-
configure.ac |2 +-
debian/changelog | 24 +---
3 files changed, 23 insertions(+), 5 deletions(-
Add fflush() to the 'rate' command of 'ovs-benchmark'. On a tty console
the output is line-buffered. However, piped output by default has a
deeper (usually 4KB) buffer, the output won't appear to the other end of
the pipe until this buffer is full.
This patch makes the piped output of the 'rate'
Signed-off-by: Justin Pettit
---
NEWS |2 +-
configure.ac |2 +-
debian/changelog | 22 --
3 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/NEWS b/NEWS
index 98d300b..042810a 100644
--- a/NEWS
+++ b/NEWS
@@ -1,4 +1,4 @@
-post-v1.10.0
+v
Thanks, applied to master.
On Fri, Apr 26, 2013 at 03:50:26PM -0700, Justin Pettit wrote:
> Looks good.
>
> --Justin
>
>
> On Apr 26, 2013, at 11:37 AM, Ben Pfaff wrote:
>
> > What a dumb bug.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/dpif-netdev.c |2 +-
> > 1 files changed, 1 in
On Thu, Apr 18, 2013 at 4:51 PM, Pravin B Shelar wrote:
> vport->init and exit() functios are defined by gre and netdev vport
> only and both can be moved to first port create.
>
> Following patch does same, it moves vport init to respectve vport
> create and get rid of vport->init() and vport->ex
On Thu, Apr 18, 2013 at 4:51 PM, Pravin B Shelar wrote:
> diff --git a/datapath/vport-vxlan.c b/datapath/vport-vxlan.c
> index 1850fc2..a5ad3fc 100644
> --- a/datapath/vport-vxlan.c
> +++ b/datapath/vport-vxlan.c
> @@ -62,22 +57,28 @@ static inline int vxlan_hdr_len(const struct
> ovs_key_ipv4_tu
Currently we are creating the worker process after creation of the pidfile.
This means that the the responsibility of deleting the pidfile after process
termination rests with the worker process.
When we restart openvswitch using the startup scripts, we SIGTERM the main
process and once it is clea
On Mon, Apr 29, 2013 at 12:47:43PM -0700, Ethan Jackson wrote:
> Signed-off-by: Ethan Jackson
Looks good, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Apr 29, 2013 at 11:27:27AM -0700, Gurucharan Shetty wrote:
> On Mon, Apr 29, 2013 at 10:04 AM, Ben Pfaff wrote:
> > I think that it is best to try to create the pidfile as early as we can.
> > If there is a conflicting pidfile, then it is best to recognize this
> > early on and avoid doing
On Thu, Apr 18, 2013 at 4:51 PM, Pravin B Shelar wrote:
> Rather than defining ovs specific stats struct (vport_percpu_stats),
> we can use existing pcpu_tstats to achieve exactly same functionality.
>
> Signed-off-by: Pravin B Shelar
Acked-by: Jesse Gross
__
On Thu, Apr 25, 2013 at 12:26 AM, Simon Horman wrote:
> On Tue, Apr 23, 2013 at 04:43:58PM -0700, Jesse Gross wrote:
>> On Mon, Apr 22, 2013 at 7:19 PM, Simon Horman wrote:
>> > In the case where a non-MPLS GSO skb becomes an MPLS GSO skb, via
>> > Open vSwitch's push MPLS action it is desirable
Signed-off-by: Ethan Jackson
---
ofproto/.gitignore |1 +
1 file changed, 1 insertion(+)
diff --git a/ofproto/.gitignore b/ofproto/.gitignore
index b336cc7..cd10be1 100644
--- a/ofproto/.gitignore
+++ b/ofproto/.gitignore
@@ -1,2 +1,3 @@
/Makefile
/Makefile.in
+/ipfix-entities.def
--
1.7.
Acked-by: Ethan Jackson
On Wed, Mar 13, 2013 at 10:03 AM, Ben Pfaff wrote:
> This series still needs review. It should be easy to review.
> ___
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
__
OK, that sounds reasonable to me. Can you update the comments to
reflect that sFlow should be OK now - assuming that you think it is. I
see two: ofproto/ofproto-dpif.c:port_construct() and the one in
ofproto/tunnel.c about metadata for packet outs, which was intended to
be for sFlow.
On Thu, Apr 2
On Mon, Apr 29, 2013 at 10:04 AM, Ben Pfaff wrote:
> Thank you for figuring this out! It is a subtle problem. More
> commentary below.
>
> On Mon, Apr 29, 2013 at 08:16:36AM -0700, Gurucharan Shetty wrote:
> > Currently we are creating the worker after creation of the pidfile.
> > This means tw
From: Thomas Graf
Date: Fri, 26 Apr 2013 14:40:55 +0200
> The only user is get_dpifindex(), no need to redirect via the port
> operations.
>
> Signed-off-by: Thomas Graf
Please follow-up with the stylistic feedback given to you if you
haven't already, thanks.
__
On Fri, Apr 26, 2013 at 5:40 AM, Thomas Graf wrote:
> The only user is get_dpifindex(), no need to redirect via the port
> operations.
>
> Signed-off-by: Thomas Graf
I'll let David take this one directly since my tree is otherwise empty
and the merge window is coming up.
Acked-by: Jesse Gross
On Sun, Apr 28, 2013 at 11:01 PM, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
> Note to self: It might be prudent to consider carrying and decrementing
> the tunnel ttl from a tunnel input to tunnel output to cut out possible loops,
> at least in this case of forwarding back to flow-based tunnel inpu
On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo)
wrote:
> On Apr 27, 2013, at 0:43 , ext Jesse Gross wrote:
>> On Thu, Apr 18, 2013 at 8:07 AM, Jarno Rajahalme
>> wrote:
>>> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
>>> index 33b09c6..b88a2d4 100644
>>> --- a
On Fri, Apr 26, 2013 at 3:03 AM, Thomas Graf wrote:
> Due to the missing register rx_handler API in the kernel RHEL6 is
> based on, the datapath currently falls back to using the bridging
> hook with the consequence that bridging and OVS cannot be used in
> parallel on any RHEL6 release.
>
> For t
Thank you for figuring this out! It is a subtle problem. More
commentary below.
On Mon, Apr 29, 2013 at 08:16:36AM -0700, Gurucharan Shetty wrote:
> Currently we are creating the worker after creation of the pidfile.
> This means two things for ovs-vswitchd. One, the pidfile's file descriptor
>
On Fri, Apr 26, 2013 at 11:42 AM, Kyle Mestery (kmestery)
wrote:
> On Apr 26, 2013, at 1:40 PM, Jesse Gross wrote:
>> On Fri, Apr 26, 2013 at 11:30 AM, Kyle Mestery wrote:
>>> VXLAN was recently assigned UDP port 4789 by IANA. This
>>> comit updates the OVS VXLAN implementation to reflect the ne
On Mon, Apr 29, 2013 at 08:16:35AM -0700, Gurucharan Shetty wrote:
> There are very rare cases (ex: ovs-vswitchd.pid is inadvertantly deleted),
> when multiple ovs-vswitchd daemons can end up running at the same time.
> In a situation like that one of the daemons can wait on the poll()
> with a 0 m
There are very rare cases (ex: ovs-vswitchd.pid is inadvertantly deleted),
when multiple ovs-vswitchd daemons can end up running at the same time.
In a situation like that one of the daemons can wait on the poll()
with a 0 ms wait time as it would be expecting system stats to be collected.
But sys
Currently we are creating the worker after creation of the pidfile.
This means two things for ovs-vswitchd. One, the pidfile's file descriptor
is open in both main process and the worker process and closing of the file
descriptor in either of the process means we will loose the lock on the
pidfile.
58 matches
Mail list logo
